Github messages for voidlinux
 help / color / mirror / Atom feed
From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: [PR PATCH] youtube-dl: add required dependency: phantomjs
Date: Fri, 07 Jun 2019 06:37:17 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-12244@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

There is a new pull request by mustaqimM against master on the void-packages repository

https://github.com/mustaqimM/void-packages update_youtube-dl
https://github.com/void-linux/void-packages/pull/12244

youtube-dl: add required dependency: phantomjs
Some links require `phantomjs` or it will error out with:
```
[ytdl_hook] ERROR: PhantomJS executable not found in PATH, download it from http://phantomjs.org
[ytdl_hook] youtube-dl failed: unexpected error ocurred
Failed to recognize file format.
```

A patch file from https://github.com/void-linux/void-packages/pull/12244.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update_youtube-dl-12244.patch --]
[-- Type: application/text/x-diff, Size: 1056 bytes --]

From ea6e5630fea847d4ed285b4d526d5ccc3d6ffc0c Mon Sep 17 00:00:00 2001
From: mustaqim <mustaqim@pm.me>
Date: Fri, 7 Jun 2019 06:29:08 +0200
Subject: [PATCH] youtube-dl: add required dependency: phantomjs

---
 srcpkgs/youtube-dl/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/youtube-dl/template b/srcpkgs/youtube-dl/template
index 3f19382f819..29cc9383785 100644
--- a/srcpkgs/youtube-dl/template
+++ b/srcpkgs/youtube-dl/template
@@ -7,7 +7,7 @@ wrksrc="$pkgname"
 build_style=python-module
 pycompile_module="youtube_dl"
 hostmakedepends="python python3"
-depends="python"
+depends="python phantomjs"
 short_desc="CLI program to download videos from YouTube and other sites (Python2)"
 maintainer="Juan RP <xtraeme@voidlinux.org>"
 license="Unlicense"
@@ -26,7 +26,7 @@ post_install() {
 
 python3-youtube-dl_package() {
 	archs=noarch
-	depends="python3"
+	depends="python3 phantomjs"
 	pycompile_module="youtube_dl"
 	alternatives="youtube-dl:youtube-dl:/usr/bin/youtube-dl3"
 	short_desc="${short_desc/2/3}"

             reply	other threads:[~2019-06-07  4:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-07  4:37 voidlinux-github [this message]
2019-06-07  8:29 ` voidlinux-github
2019-06-07 14:27 ` voidlinux-github
2019-06-07 14:28 ` voidlinux-github
2019-06-07 14:29 ` voidlinux-github
2019-06-07 15:33 ` voidlinux-github
2019-06-07 15:57 ` [PR PATCH] [Closed]: " voidlinux-github
2019-06-07 15:58 ` voidlinux-github
2019-06-07 16:04 ` voidlinux-github

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-12244@inbox.vuxu.org \
    --to=voidlinux-github@inbox.vuxu.org \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).