Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] obs: add vaapi dependencies.
@ 2019-06-12  0:09 voidlinux-github
  2019-06-12 19:47 ` voidlinux-github
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: voidlinux-github @ 2019-06-12  0:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

There is a new pull request by Valeyard1 against master on the void-packages repository

https://github.com/Valeyard1/void-packages obs
https://github.com/void-linux/void-packages/pull/12414

obs: add vaapi dependencies.
closes void-linux/void-packages#10762

A patch file from https://github.com/void-linux/void-packages/pull/12414.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-obs-12414.patch --]
[-- Type: application/text/x-diff, Size: 1227 bytes --]

From 35e58e2f3bdee5e977e5e9efeed2e8c26754a64a Mon Sep 17 00:00:00 2001
From: Leonardo F <leonardof@tutanota.com>
Date: Tue, 11 Jun 2019 20:56:09 -0300
Subject: [PATCH] obs: add vaapi dependencies.

closes void-linux/void-packages#10762
---
 srcpkgs/obs/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/obs/template b/srcpkgs/obs/template
index 811250b9afa..727801304b9 100644
--- a/srcpkgs/obs/template
+++ b/srcpkgs/obs/template
@@ -1,7 +1,7 @@
 # Template file for 'obs'
 pkgname=obs
 version=23.1.0
-revision=2
+revision=3
 _commit_hash_obs_browser="693498b518cf893876f454ef581e13106e8370ec"
 _commit_hash_obs_vst="fde438f7a8afdf41a7ab386a0aa1a61175fc8427"
 _commit_hash_ftl_sdk="98289f7c2ed754c647d451899b3356850c0c1fa3"
@@ -13,7 +13,7 @@ hostmakedepends="pkg-config swig"
 makedepends="LuaJIT-devel fdk-aac-devel ffmpeg-devel glu-devel jack-devel
  libXcomposite-devel libcurl-devel pulseaudio-devel python3-devel
  qt5-x11extras-devel qt5-svg-devel speexdsp-devel v4l-utils-devel vlc-devel
- x264-devel"
+ x264-devel libva-vdpau-driver libvdpau-va-gl libva-intel-driver"
 short_desc="Open Broadcaster Software"
 maintainer="lemmi <lemmi@nerd2nerd.org>"
 license="GPL-2.0-or-later"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: obs: add vaapi dependencies.
  2019-06-12  0:09 [PR PATCH] obs: add vaapi dependencies voidlinux-github
@ 2019-06-12 19:47 ` voidlinux-github
  2019-06-12 20:06 ` voidlinux-github
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: voidlinux-github @ 2019-06-12 19:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/12414#issuecomment-501428897
Comment:
This seems wrong to me. Hardware-specific drivers should not be in the dependencies of a package unless the package cannot be executed without them. In this case they enable additional functionality so it should be up to the user to install the apropriate driver for his hardware.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: obs: add vaapi dependencies.
  2019-06-12  0:09 [PR PATCH] obs: add vaapi dependencies voidlinux-github
  2019-06-12 19:47 ` voidlinux-github
@ 2019-06-12 20:06 ` voidlinux-github
  2019-06-12 20:10 ` voidlinux-github
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: voidlinux-github @ 2019-06-12 20:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/12414#issuecomment-501435304
Comment:
I suspect the code uses dlopen().

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: obs: add vaapi dependencies.
  2019-06-12  0:09 [PR PATCH] obs: add vaapi dependencies voidlinux-github
  2019-06-12 19:47 ` voidlinux-github
  2019-06-12 20:06 ` voidlinux-github
@ 2019-06-12 20:10 ` voidlinux-github
  2019-06-13  7:01 ` [PR PATCH] [Closed]: " voidlinux-github
  2019-06-13  7:01 ` voidlinux-github
  4 siblings, 0 replies; 6+ messages in thread
From: voidlinux-github @ 2019-06-12 20:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/12414#issuecomment-501436663
Comment:
I agree with @Hoshpak 

It's weird that you added them via `makedepends` but were not added to `depends`.

xbps-src can't detect dlopen()ed dependencies, remember.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: obs: add vaapi dependencies.
  2019-06-12  0:09 [PR PATCH] obs: add vaapi dependencies voidlinux-github
                   ` (3 preceding siblings ...)
  2019-06-13  7:01 ` [PR PATCH] [Closed]: " voidlinux-github
@ 2019-06-13  7:01 ` voidlinux-github
  4 siblings, 0 replies; 6+ messages in thread
From: voidlinux-github @ 2019-06-13  7:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/12414#issuecomment-501576130
Comment:
I think the maximum that would be apropriate here would be an install message that advises the users that the drivers can optionally be installed if the feature is needed. I just tried on a system that already had the drivers installed and it worked fine so they are not needed at compile time. I'm closing this PR, feel free to create a new one if you want to add an install message.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: obs: add vaapi dependencies.
  2019-06-12  0:09 [PR PATCH] obs: add vaapi dependencies voidlinux-github
                   ` (2 preceding siblings ...)
  2019-06-12 20:10 ` voidlinux-github
@ 2019-06-13  7:01 ` voidlinux-github
  2019-06-13  7:01 ` voidlinux-github
  4 siblings, 0 replies; 6+ messages in thread
From: voidlinux-github @ 2019-06-13  7:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

There's a closed pull request on the void-packages repository

obs: add vaapi dependencies.
https://github.com/void-linux/void-packages/pull/12414
Description: closes void-linux/void-packages#10762

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-06-13  7:01 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-12  0:09 [PR PATCH] obs: add vaapi dependencies voidlinux-github
2019-06-12 19:47 ` voidlinux-github
2019-06-12 20:06 ` voidlinux-github
2019-06-12 20:10 ` voidlinux-github
2019-06-13  7:01 ` [PR PATCH] [Closed]: " voidlinux-github
2019-06-13  7:01 ` voidlinux-github

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).