From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: [PR PATCH] rust: add patch to limit internalization
Date: Thu, 13 Jun 2019 18:32:46 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-12444@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
There is a new pull request by jnbr against master on the void-packages repository
https://github.com/jnbr/void-packages rust
https://github.com/void-linux/void-packages/pull/12444
rust: add patch to limit internalization
without this patch, some packages fail to build on i686
A patch file from https://github.com/void-linux/void-packages/pull/12444.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rust-12444.patch --]
[-- Type: application/text/x-diff, Size: 2363 bytes --]
From b5df0917c3e09b88e37f81c594f3e6bbc184dc21 Mon Sep 17 00:00:00 2001
From: Johannes <johannes.brechtmann@gmail.com>
Date: Thu, 13 Jun 2019 18:21:53 +0200
Subject: [PATCH] rust: add patch to limit internalization
without this patch, some packages fail to build on i686
[ci skip]
---
.../rust/patches/limit-internalization.patch | 27 +++++++++++++++++++
srcpkgs/rust/template | 2 +-
2 files changed, 28 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/rust/patches/limit-internalization.patch
diff --git a/srcpkgs/rust/patches/limit-internalization.patch b/srcpkgs/rust/patches/limit-internalization.patch
new file mode 100644
index 00000000000..c876df02cc8
--- /dev/null
+++ b/srcpkgs/rust/patches/limit-internalization.patch
@@ -0,0 +1,27 @@
+From b4131e297e18fde119f6f461b3e622218166b009 Mon Sep 17 00:00:00 2001
+From: Josh Stone <jistone@redhat.com>
+Date: Fri, 26 Apr 2019 08:58:14 -0700
+Subject: [PATCH] Limit internalization in LLVM 8 ThinLTO
+
+---
+ src/rustllvm/PassWrapper.cpp | 5 ++++-
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/src/rustllvm/PassWrapper.cpp b/src/rustllvm/PassWrapper.cpp
+index 319c66a21f17..0ebef82d3768 100644
+--- a/src/rustllvm/PassWrapper.cpp
++++ b/src/rustllvm/PassWrapper.cpp
+@@ -873,8 +873,11 @@ LLVMRustCreateThinLTOData(LLVMRustThinLTOModule *modules,
+ return PrevailingType::Unknown;
+ };
+ #if LLVM_VERSION_GE(8, 0)
++ // We don't have a complete picture in our use of ThinLTO, just our immediate
++ // crate, so we need `ImportEnabled = false` to limit internalization.
++ // Otherwise, we sometimes lose `static` values -- see #60184.
+ computeDeadSymbolsWithConstProp(Ret->Index, Ret->GUIDPreservedSymbols,
+- deadIsPrevailing, /* ImportEnabled = */ true);
++ deadIsPrevailing, /* ImportEnabled = */ false);
+ #else
+ computeDeadSymbols(Ret->Index, Ret->GUIDPreservedSymbols, deadIsPrevailing);
+ #endif
+
diff --git a/srcpkgs/rust/template b/srcpkgs/rust/template
index af7da209e5c..44933d5cfce 100644
--- a/srcpkgs/rust/template
+++ b/srcpkgs/rust/template
@@ -1,7 +1,7 @@
# Template file for 'rust'
pkgname=rust
version=1.35.0
-revision=1
+revision=2
_rust_dist_version=1.35.0
_cargo_dist_version=0.36.0
# Always make sure custom distfiles used for bootstrap are
next reply other threads:[~2019-06-13 16:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 16:32 voidlinux-github [this message]
2019-06-13 22:16 ` [PR PATCH] [Merged]: " voidlinux-github
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-12444@inbox.vuxu.org \
--to=voidlinux-github@inbox.vuxu.org \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).