Github messages for voidlinux
 help / color / mirror / Atom feed
From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes
Date: Thu, 27 Jun 2019 00:51:46 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-12710@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

There is a new pull request by reback00 against master on the void-packages repository

https://github.com/reback00/void-packages ddgtk-v0_1-fix-branch
https://github.com/void-linux/void-packages/pull/12710

ddgtk: fixes for recent vte python bindings + other changes
**Changes:**

1. Added additional dependencies against build warnings [template]
2. Updated for latest meson [patch]
3. Updated for latest python module (instead of deprecated `python3` module, used the new `python` module, according to: [https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types](https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types)) [patch]
4. Fixed breakage of write functionality due to recent changes in Vte python bindings (Explanation here: [https://github.com/Guake/guake/issues/1243#issuecomment-410208659](https://github.com/Guake/guake/issues/1243#issuecomment-410208659)) [patch]

#4 raised an error like this below which has been fixed:

```
Traceback (most recent call last):
  File "/usr/local/share/ddgtk/ddgtk/main.py", line 154, in on_confirm_ok_clicked
    self.dd()
  File "/usr/local/share/ddgtk/ddgtk/main.py", line 125, in dd
    self.terminal.feed_child(clear,-1)
TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)
```


A patch file from https://github.com/void-linux/void-packages/pull/12710.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ddgtk-v0_1-fix-branch-12710.patch --]
[-- Type: application/text/x-diff, Size: 2944 bytes --]

From 7491de760335fa96795539b8e0392b127ec812f5 Mon Sep 17 00:00:00 2001
From: reback00 <reback00@protonmail.com>
Date: Thu, 27 Jun 2019 16:35:39 +0600
Subject: [PATCH] ddgtk: fixes for recent vte python bindings + other changes

---
 .../ddgtk/patches/001-changes-for-v0.1.patch  | 33 +++++++++++++++++++
 srcpkgs/ddgtk/template                        |  5 +--
 2 files changed, 36 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch

diff --git a/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
new file mode 100644
index 00000000000..386b5fe5875
--- /dev/null
+++ b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
@@ -0,0 +1,33 @@
+diff -Naurp0 a/meson.build b/meson.build
+--- a/meson.build	2017-10-15 19:48:45.000000000 +0000
++++ b/meson.build	2019-06-24 12:48:11.436750620 +0000
+@@ -3 +3 @@ project('ddgtk',
+-  meson_version: '>= 0.40.0',
++  meson_version: '>= 0.50.0',
+diff -Naurp0 a/src/main.py b/src/main.py
+--- a/src/main.py	2017-10-15 19:48:45.000000000 +0000
++++ b/src/main.py	2019-06-24 12:50:46.519811815 +0000
+@@ -116 +116 @@ class Application():
+-        #self.terminal.feed_child(self.command,-1)
++        #self.terminal.feed_child_binary(self.command.encode("utf-8"))
+@@ -125,4 +125,4 @@ class Application():
+-        self.terminal.feed_child(clear,-1)
+-        self.terminal.feed_child(wait,-1)
+-        self.terminal.feed_child(self.umount,-1)
+-        #self.terminal.feed_child(cmd,-1)
++        self.terminal.feed_child_binary(clear.encode("utf-8"))
++        self.terminal.feed_child_binary(wait.encode("utf-8"))
++        self.terminal.feed_child_binary(self.umount.encode("utf-8"))
++        #self.terminal.feed_child_binary(cmd.encode("utf-8"))
+@@ -130 +130 @@ class Application():
+-        self.terminal.feed_child(self.command,-1)
++        self.terminal.feed_child_binary(self.command.encode("utf-8"))
+diff -Naurp0 a/src/meson.build b/src/meson.build
+--- a/src/meson.build	2017-10-15 19:48:45.000000000 +0000
++++ b/src/meson.build	2019-06-24 12:48:51.950244132 +0000
+@@ -12 +12 @@ gnome.compile_resources('ddgtk',
+-python3 = import('python3')
++python3 = import('python')
+@@ -15 +15 @@ conf = configuration_data()
+-conf.set('PYTHON', python3.find_python().path())
++conf.set('PYTHON', python3.find_installation().path())
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index f97c362c1c5..84948070877 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -1,9 +1,10 @@
 # Template file for 'ddgtk'
 pkgname=ddgtk
 version=0.1
-revision=1
+revision=2
 build_style=meson
-hostmakedepends="pkg-config glib glib-devel"
+patch_args="-Np1"
+hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
 depends="python3 python3-gobject gtk+3"
 short_desc="GUI frontend for dd to create bootable ISO images for Linux"
 maintainer="reback00 <reback00@protonmail.com>"

             reply	other threads:[~2019-06-26 22:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26 22:51 voidlinux-github [this message]
2019-06-26 23:14 ` [PR PATCH] [Updated] " voidlinux-github
2019-06-26 23:14 ` voidlinux-github
2019-06-27  8:23 ` voidlinux-github
2019-06-27 14:25 ` [PR PATCH] [Updated] " voidlinux-github
2019-06-27 14:25 ` voidlinux-github
2019-06-27 14:30 ` voidlinux-github
2019-06-27 14:32 ` voidlinux-github
2019-06-27 15:24 ` voidlinux-github
2019-06-27 15:26 ` voidlinux-github
2019-06-27 15:26 ` voidlinux-github
2019-06-27 16:55 ` ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name voidlinux-github
2019-06-27 16:56 ` voidlinux-github
2019-06-27 16:58 ` [PR PATCH] [Updated] " voidlinux-github
2019-06-27 16:58 ` voidlinux-github
2019-06-28 16:17 ` voidlinux-github
2019-06-28 21:13 ` [PR PATCH] [Updated] " voidlinux-github
2019-06-28 21:13 ` voidlinux-github
2019-06-28 21:22 ` ddgtk: fixes for vte, latest meson, py module name, additional deps voidlinux-github
2019-06-30 13:35 ` [PR PATCH] [Merged]: " voidlinux-github
2019-06-30 13:39 ` voidlinux-github
2019-06-30 14:46 ` voidlinux-github

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-12710@inbox.vuxu.org \
    --to=voidlinux-github@inbox.vuxu.org \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).