Github messages for voidlinux
 help / Atom feed
* [PR PATCH] audacious: enable Qt interface
@ 2019-09-03  7:35 voidlinux-github
  2019-09-03  9:05 ` voidlinux-github
                   ` (18 more replies)
  0 siblings, 19 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-03  7:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

There is a new pull request by bra1nwave against master on the void-packages repository

https://github.com/bra1nwave/void-packages audacious
https://github.com/void-linux/void-packages/pull/14178

audacious: enable Qt interface
closes  https://github.com/void-linux/void-packages/issues/14171

A patch file from https://github.com/void-linux/void-packages/pull/14178.patch is attached

[-- Attachment #2: github-pr-audacious-14178.patch --]
[-- Type: text/x-diff, Size: 3354 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
@ 2019-09-03  9:05 ` voidlinux-github
  2019-09-03 10:09 ` [PR PATCH] [Updated] " voidlinux-github
                   ` (17 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-03  9:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/14178#issuecomment-527372580

Comment:
I think a built option would be good

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
  2019-09-03  9:05 ` voidlinux-github
@ 2019-09-03 10:09 ` " voidlinux-github
  2019-09-03 10:12 ` voidlinux-github
                   ` (16 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-03 10:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

There is an updated pull request by bra1nwave against master on the void-packages repository

https://github.com/bra1nwave/void-packages audacious
https://github.com/void-linux/void-packages/pull/14178

audacious: enable Qt interface
closes  https://github.com/void-linux/void-packages/issues/14171

Should I add a build option for Qt/GTK?

A patch file from https://github.com/void-linux/void-packages/pull/14178.patch is attached

[-- Attachment #2: github-pr-audacious-14178.patch --]
[-- Type: text/x-diff, Size: 4129 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
  2019-09-03  9:05 ` voidlinux-github
  2019-09-03 10:09 ` [PR PATCH] [Updated] " voidlinux-github
@ 2019-09-03 10:12 ` voidlinux-github
  2019-09-03 10:16 ` voidlinux-github
                   ` (15 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-03 10:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

There is an updated pull request by bra1nwave against master on the void-packages repository

https://github.com/bra1nwave/void-packages audacious
https://github.com/void-linux/void-packages/pull/14178

audacious: enable Qt interface
closes  https://github.com/void-linux/void-packages/issues/14171

Should I add a build option for Qt/GTK?

A patch file from https://github.com/void-linux/void-packages/pull/14178.patch is attached

[-- Attachment #2: github-pr-audacious-14178.patch --]
[-- Type: text/x-diff, Size: 4069 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
                   ` (2 preceding siblings ...)
  2019-09-03 10:12 ` voidlinux-github
@ 2019-09-03 10:16 ` voidlinux-github
  2019-09-03 10:21 ` voidlinux-github
                   ` (14 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-03 10:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

There is an updated pull request by bra1nwave against master on the void-packages repository

https://github.com/bra1nwave/void-packages audacious
https://github.com/void-linux/void-packages/pull/14178

audacious: enable Qt interface
closes  https://github.com/void-linux/void-packages/issues/14171

Should I add a build option for Qt/GTK?

A patch file from https://github.com/void-linux/void-packages/pull/14178.patch is attached

[-- Attachment #2: github-pr-audacious-14178.patch --]
[-- Type: text/x-diff, Size: 4073 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
                   ` (3 preceding siblings ...)
  2019-09-03 10:16 ` voidlinux-github
@ 2019-09-03 10:21 ` voidlinux-github
  2019-09-03 10:25 ` voidlinux-github
                   ` (13 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-03 10:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

There is an updated pull request by bra1nwave against master on the void-packages repository

https://github.com/bra1nwave/void-packages audacious
https://github.com/void-linux/void-packages/pull/14178

audacious: enable Qt interface
closes  https://github.com/void-linux/void-packages/issues/14171

Should I add a build option for Qt/GTK?

A patch file from https://github.com/void-linux/void-packages/pull/14178.patch is attached

[-- Attachment #2: github-pr-audacious-14178.patch --]
[-- Type: text/x-diff, Size: 4063 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
                   ` (4 preceding siblings ...)
  2019-09-03 10:21 ` voidlinux-github
@ 2019-09-03 10:25 ` voidlinux-github
  2019-09-04 16:35 ` voidlinux-github
                   ` (12 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-03 10:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 147 bytes --]

New comment by bra1nwave on void-packages repository

https://github.com/void-linux/void-packages/pull/14178#issuecomment-527400053

Comment:
Done

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
                   ` (5 preceding siblings ...)
  2019-09-03 10:25 ` voidlinux-github
@ 2019-09-04 16:35 ` voidlinux-github
  2019-09-04 16:47 ` voidlinux-github
                   ` (11 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-04 16:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/14178#issuecomment-527982691

Comment:
Default build depends on both qt and gtk now. Can they be split out to subpkgs?

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
                   ` (6 preceding siblings ...)
  2019-09-04 16:35 ` voidlinux-github
@ 2019-09-04 16:47 ` voidlinux-github
  2019-09-04 16:52 ` voidlinux-github
                   ` (10 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-04 16:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/14178#issuecomment-527987181

Comment:
+1

El mié., 4 sept. 2019 18:35, Piotr <notifications@github.com> escribió:

> Default build depends on both qt and gtk now. Can they be split out to
> subpkgs?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/void-linux/void-packages/pull/14178?email_source=notifications&email_token=AAGR7KKXAAKL6ZL2DJEOAXTQH7PU5A5CNFSM4ITC6QH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD54GAYY#issuecomment-527982691>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAGR7KN2N4VY3PRSKOYKTB3QH7PU5ANCNFSM4ITC6QHQ>
> .
>


^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
                   ` (7 preceding siblings ...)
  2019-09-04 16:47 ` voidlinux-github
@ 2019-09-04 16:52 ` voidlinux-github
  2019-09-04 16:56 ` voidlinux-github
                   ` (9 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-04 16:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

New comment by bra1nwave on void-packages repository

https://github.com/void-linux/void-packages/pull/14178#issuecomment-527989071

Comment:
> Default build depends on both qt and gtk now. Can they be split out to subpkgs?

Yeah, I think so. Then the build options are redundant, right?

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
                   ` (8 preceding siblings ...)
  2019-09-04 16:52 ` voidlinux-github
@ 2019-09-04 16:56 ` voidlinux-github
  2019-09-04 17:01 ` voidlinux-github
                   ` (8 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-04 16:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

New comment by bra1nwave on void-packages repository

https://github.com/void-linux/void-packages/pull/14178#issuecomment-527989071

Comment:
> Default build depends on both qt and gtk now. Can they be split out to subpkgs?

Yeah, I think so. Then the build options are (obviously) redundant, right?

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
                   ` (9 preceding siblings ...)
  2019-09-04 16:56 ` voidlinux-github
@ 2019-09-04 17:01 ` voidlinux-github
  2019-09-05  7:24 ` voidlinux-github
                   ` (7 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-04 17:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/14178#issuecomment-527992554

Comment:
Yes, no need for build options.


^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
                   ` (10 preceding siblings ...)
  2019-09-04 17:01 ` voidlinux-github
@ 2019-09-05  7:24 ` voidlinux-github
  2019-09-09 12:12 ` voidlinux-github
                   ` (6 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-05  7:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 789 bytes --]

New comment by bra1nwave on void-packages repository

https://github.com/void-linux/void-packages/pull/14178#issuecomment-528235612

Comment:
It's not easy as I thought it would be. The main culprit here is `audacious-plugins`. It has a lot of various .so plugins which either depend on GTK or QT. Sure, we can hunt down every SO, but this would be a nightmare to maintain. 

There is also the problem that some plugins that were not previously dependent on Qt are now depending on it. Which means I cannot move it into a subpkg.

We have (IMHO) two alternatives:
- Keep the Build options and make GTK the default one. If someone only needs the Qt version, he/she can build it with `-o ~gtk,qt`
- Make separate (`audacious-qt` and `audacious-qt-plugins`) templates with disabled GTK

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
                   ` (11 preceding siblings ...)
  2019-09-05  7:24 ` voidlinux-github
@ 2019-09-09 12:12 ` voidlinux-github
  2019-09-09 12:16 ` voidlinux-github
                   ` (5 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-09 12:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/14178#issuecomment-529443510

Comment:
You could also do two builds in the template (one for each variant toolkit) and split results in corespoinding subpackages, which is not a nice thing either. Also dependency-overwriting if the shared package is possible, but even worse.

I'd say: only support one toolkit and go for a default build option. If demand should arise to provide both versions at the same time, we can still warmup this discussion.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
                   ` (12 preceding siblings ...)
  2019-09-09 12:12 ` voidlinux-github
@ 2019-09-09 12:16 ` voidlinux-github
  2019-09-09 12:25 ` voidlinux-github
                   ` (4 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-09 12:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/14178#issuecomment-529443510

Comment:
I'd say: only support one toolkit and go for a default build option. If demand should arise to provide both versions at the same time, we can still warmup this discussion.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
                   ` (13 preceding siblings ...)
  2019-09-09 12:16 ` voidlinux-github
@ 2019-09-09 12:25 ` voidlinux-github
  2019-09-11 16:03 ` [PR PATCH] [Updated] " voidlinux-github
                   ` (3 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-09 12:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/14178#issuecomment-529443510

Comment:
I'd say: only support one toolkit and go for a default build option. If demand should arise to provide both versions at the same time, we can still warmup this discussion.
@bra1nwave Both build options probably should conflict, can you please account for that with `vopt_conflict`?

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
                   ` (14 preceding siblings ...)
  2019-09-09 12:25 ` voidlinux-github
@ 2019-09-11 16:03 ` " voidlinux-github
  2019-09-11 16:04 ` voidlinux-github
                   ` (2 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-11 16:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

There is an updated pull request by bra1nwave against master on the void-packages repository

https://github.com/bra1nwave/void-packages audacious
https://github.com/void-linux/void-packages/pull/14178

audacious: enable Qt interface
closes  https://github.com/void-linux/void-packages/issues/14171

Should I add a build option for Qt/GTK?

A patch file from https://github.com/void-linux/void-packages/pull/14178.patch is attached

[-- Attachment #2: github-pr-audacious-14178.patch --]
[-- Type: text/x-diff, Size: 4104 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
                   ` (15 preceding siblings ...)
  2019-09-11 16:03 ` [PR PATCH] [Updated] " voidlinux-github
@ 2019-09-11 16:04 ` voidlinux-github
  2019-09-13  8:34 ` [PR PATCH] [Updated] " voidlinux-github
  2019-09-13 22:06 ` [PR PATCH] [Merged]: " voidlinux-github
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-11 16:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New comment by bra1nwave on void-packages repository

https://github.com/void-linux/void-packages/pull/14178#issuecomment-530449231

Comment:
@Piraty Done

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
                   ` (16 preceding siblings ...)
  2019-09-11 16:04 ` voidlinux-github
@ 2019-09-13  8:34 ` " voidlinux-github
  2019-09-13 22:06 ` [PR PATCH] [Merged]: " voidlinux-github
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-13  8:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

There is an updated pull request by bra1nwave against master on the void-packages repository

https://github.com/bra1nwave/void-packages audacious
https://github.com/void-linux/void-packages/pull/14178

audacious: enable Qt interface
closes  https://github.com/void-linux/void-packages/issues/14171

Should I add a build option for Qt/GTK?

A patch file from https://github.com/void-linux/void-packages/pull/14178.patch is attached

[-- Attachment #2: github-pr-audacious-14178.patch --]
[-- Type: text/x-diff, Size: 4101 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Merged]: audacious: enable Qt interface
  2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
                   ` (17 preceding siblings ...)
  2019-09-13  8:34 ` [PR PATCH] [Updated] " voidlinux-github
@ 2019-09-13 22:06 ` " voidlinux-github
  18 siblings, 0 replies; 20+ messages in thread
From: voidlinux-github @ 2019-09-13 22:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

There's a merged pull request on the void-packages repository

audacious: enable Qt interface
https://github.com/void-linux/void-packages/pull/14178

Description:
closes  https://github.com/void-linux/void-packages/issues/14171

Should I add a build option for Qt/GTK?

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, back to index

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-03  7:35 [PR PATCH] audacious: enable Qt interface voidlinux-github
2019-09-03  9:05 ` voidlinux-github
2019-09-03 10:09 ` [PR PATCH] [Updated] " voidlinux-github
2019-09-03 10:12 ` voidlinux-github
2019-09-03 10:16 ` voidlinux-github
2019-09-03 10:21 ` voidlinux-github
2019-09-03 10:25 ` voidlinux-github
2019-09-04 16:35 ` voidlinux-github
2019-09-04 16:47 ` voidlinux-github
2019-09-04 16:52 ` voidlinux-github
2019-09-04 16:56 ` voidlinux-github
2019-09-04 17:01 ` voidlinux-github
2019-09-05  7:24 ` voidlinux-github
2019-09-09 12:12 ` voidlinux-github
2019-09-09 12:16 ` voidlinux-github
2019-09-09 12:25 ` voidlinux-github
2019-09-11 16:03 ` [PR PATCH] [Updated] " voidlinux-github
2019-09-11 16:04 ` voidlinux-github
2019-09-13  8:34 ` [PR PATCH] [Updated] " voidlinux-github
2019-09-13 22:06 ` [PR PATCH] [Merged]: " voidlinux-github

Github messages for voidlinux

Archives are clonable: git clone --mirror http://inbox.vuxu.org/voidlinux-github

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/ public-inbox