Github messages for voidlinux
 help / Atom feed
* [PR PATCH] t
@ 2019-09-06 23:53 voidlinux-github
  2019-09-06 23:55 ` t voidlinux-github
                   ` (13 more replies)
  0 siblings, 14 replies; 15+ messages in thread
From: voidlinux-github @ 2019-09-06 23:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

There is a new pull request by thomas-t-w against master on the void-packages repository

https://github.com/thomas-t-w/void-packages networkmanager
https://github.com/void-linux/void-packages/pull/14277

t
This causes network connections to be properly restarted on
suspend and resume of the system via elogind/desktops.

A patch file from https://github.com/void-linux/void-packages/pull/14277.patch is attached

[-- Attachment #2: github-pr-networkmanager-14277.patch --]
[-- Type: text/x-diff, Size: 1049 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: t
  2019-09-06 23:53 [PR PATCH] t voidlinux-github
@ 2019-09-06 23:55 ` voidlinux-github
  2019-09-08  0:44 ` NetworkManager: Set elogind on by default voidlinux-github
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: voidlinux-github @ 2019-09-06 23:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

New comment by thomas-t-w on void-packages repository

https://github.com/void-linux/void-packages/pull/14277#issuecomment-529049770

Comment:
Sorry about the name of the request. t moves by table with my screen reader and I was trying to move to the table to check the diff. I guess I was accidentally in the title field when I pressed that.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: NetworkManager: Set elogind on by default.
  2019-09-06 23:53 [PR PATCH] t voidlinux-github
  2019-09-06 23:55 ` t voidlinux-github
@ 2019-09-08  0:44 ` voidlinux-github
  2019-09-08  0:59 ` voidlinux-github
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: voidlinux-github @ 2019-09-08  0:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

New comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/14277#issuecomment-529158461

Comment:
I'm not a fan of this. When not using one of the bigger DEs, it's totally feasible to build a system without session management. This change would break that somewhat.

Just my 2 cents though, no bikeshedding intended.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: NetworkManager: Set elogind on by default.
  2019-09-06 23:53 [PR PATCH] t voidlinux-github
  2019-09-06 23:55 ` t voidlinux-github
  2019-09-08  0:44 ` NetworkManager: Set elogind on by default voidlinux-github
@ 2019-09-08  0:59 ` voidlinux-github
  2019-09-08  2:13 ` voidlinux-github
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: voidlinux-github @ 2019-09-08  0:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

New comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/14277#issuecomment-529159033

Comment:
On another note, network connections should be properly resumed regardless.

AFAIK, NM uses the sleep detection for some special cases, not the general reinitialization of connections after sleep.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: NetworkManager: Set elogind on by default.
  2019-09-06 23:53 [PR PATCH] t voidlinux-github
                   ` (2 preceding siblings ...)
  2019-09-08  0:59 ` voidlinux-github
@ 2019-09-08  2:13 ` voidlinux-github
  2019-09-08  2:34 ` voidlinux-github
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: voidlinux-github @ 2019-09-08  2:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

New comment by thomas-t-w on void-packages repository

https://github.com/void-linux/void-packages/pull/14277#issuecomment-529162605

Comment:
Hi,
I really appreciate your concern on this because it is important. I also use command line only systems with Network Manager. This build time option only adds a build time dependency. I tested a system without elogind with this build option on briefly and I was still able to connect to networks. I will admit that my tests were not extensive. If there are regressions for systems without elogind, I agree that we should revert it but from what I could tell, it still runs correctly even if elogind is not on the system. Can you test this with your use case and let me know if things work?

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: NetworkManager: Set elogind on by default.
  2019-09-06 23:53 [PR PATCH] t voidlinux-github
                   ` (3 preceding siblings ...)
  2019-09-08  2:13 ` voidlinux-github
@ 2019-09-08  2:34 ` voidlinux-github
  2019-09-08 13:24 ` voidlinux-github
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: voidlinux-github @ 2019-09-08  2:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

New comment by thomas-t-w on void-packages repository

https://github.com/void-linux/void-packages/pull/14277#issuecomment-529163626

Comment:
I did some more research on this.
You can test this with these.
When sleeping:
dbus-send --print-reply --system --dest=org.freedesktop.NetworkManager /org/freedesktop/NetworkManager org.freedesktop.NetworkManager.Sleep boolean:true
On wake:
dbus-send --print-reply --system --dest=org.freedesktop.NetworkManager /org/freedesktop/NetworkManager org.freedesktop.NetworkManager.Sleep boolean:false

When waking from sleep, an immediate disconnect and rescan  is triggered. This should allow connections to be made slightly quicker when roaming between networks. Still though, as with my last comment, if it breaks things if no elogind exists, we shouldn't apply it.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: NetworkManager: Set elogind on by default.
  2019-09-06 23:53 [PR PATCH] t voidlinux-github
                   ` (4 preceding siblings ...)
  2019-09-08  2:34 ` voidlinux-github
@ 2019-09-08 13:24 ` voidlinux-github
  2019-09-08 15:09 ` voidlinux-github
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: voidlinux-github @ 2019-09-08 13:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

New comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/14277#issuecomment-529202603

Comment:
Indeed, I tested without elogind installed and things just seem to work. I am convinced. :+1: 

With this being the case, I'd wonder if we could get rid of the `elogind` build option completely.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: NetworkManager: Set elogind on by default.
  2019-09-06 23:53 [PR PATCH] t voidlinux-github
                   ` (5 preceding siblings ...)
  2019-09-08 13:24 ` voidlinux-github
@ 2019-09-08 15:09 ` voidlinux-github
  2019-09-09 12:15 ` voidlinux-github
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: voidlinux-github @ 2019-09-08 15:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

New comment by thomas-t-w on void-packages repository

https://github.com/void-linux/void-packages/pull/14277#issuecomment-529211754

Comment:
I think that eventually we could. I was originally going to do that but I am usually pretty conservative when it comes to things like this though. I guess it comes from me needing accessibility software and people making changes to programs that break that all the time. I think that maybe its good to leave it around for a while to make it easier to revert if someone has some obscure issue. Void serves many use cases and I don't want to break someones workflow. My vote would be to leave it around for a while (two weeks or so) and see if someone complains. What do you think about this?

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: NetworkManager: Set elogind on by default.
  2019-09-06 23:53 [PR PATCH] t voidlinux-github
                   ` (6 preceding siblings ...)
  2019-09-08 15:09 ` voidlinux-github
@ 2019-09-09 12:15 ` voidlinux-github
  2019-09-09 12:46 ` voidlinux-github
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: voidlinux-github @ 2019-09-09 12:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/14277#issuecomment-529444419

Comment:
Let's ask @Gottox for an opinion here :)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: NetworkManager: Set elogind on by default.
  2019-09-06 23:53 [PR PATCH] t voidlinux-github
                   ` (7 preceding siblings ...)
  2019-09-09 12:15 ` voidlinux-github
@ 2019-09-09 12:46 ` voidlinux-github
  2019-09-09 13:44 ` voidlinux-github
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: voidlinux-github @ 2019-09-09 12:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New comment by Gottox on void-packages repository

https://github.com/void-linux/void-packages/pull/14277#issuecomment-529456605

Comment:
This would cause NetworkManager to link against libelogind or does it speak to dbus directly?

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: NetworkManager: Set elogind on by default.
  2019-09-06 23:53 [PR PATCH] t voidlinux-github
                   ` (8 preceding siblings ...)
  2019-09-09 12:46 ` voidlinux-github
@ 2019-09-09 13:44 ` voidlinux-github
  2019-09-09 14:07 ` voidlinux-github
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: voidlinux-github @ 2019-09-09 13:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

New comment by thomas-t-w on void-packages repository

https://github.com/void-linux/void-packages/pull/14277#issuecomment-529481783

Comment:
It links against the elogind library. I have continued testing now without elogind to make sure nothing bad happens for the past few days and everything has been fine on a command line system. I tried to perform many of the features in the program.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: NetworkManager: Set elogind on by default.
  2019-09-06 23:53 [PR PATCH] t voidlinux-github
                   ` (9 preceding siblings ...)
  2019-09-09 13:44 ` voidlinux-github
@ 2019-09-09 14:07 ` voidlinux-github
  2019-09-09 14:12 ` voidlinux-github
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: voidlinux-github @ 2019-09-09 14:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New comment by thomas-t-w on void-packages repository

https://github.com/void-linux/void-packages/pull/14277#issuecomment-529492190

Comment:
NetworkManager already depends on libelogind indirectly because it depends on polkit which depends on libelogind

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: NetworkManager: Set elogind on by default.
  2019-09-06 23:53 [PR PATCH] t voidlinux-github
                   ` (10 preceding siblings ...)
  2019-09-09 14:07 ` voidlinux-github
@ 2019-09-09 14:12 ` voidlinux-github
  2019-09-09 14:47 ` voidlinux-github
  2019-09-11 11:42 ` [PR PATCH] [Merged]: " voidlinux-github
  13 siblings, 0 replies; 15+ messages in thread
From: voidlinux-github @ 2019-09-09 14:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

New comment by thomas-t-w on void-packages repository

https://github.com/void-linux/void-packages/pull/14277#issuecomment-529492190

Comment:
NetworkManager already depends on libelogind indirectly because it depends on polkit which depends on libelogind. This is obviously important because we don't want to have a situation where a linked library isn't on the system.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: NetworkManager: Set elogind on by default.
  2019-09-06 23:53 [PR PATCH] t voidlinux-github
                   ` (11 preceding siblings ...)
  2019-09-09 14:12 ` voidlinux-github
@ 2019-09-09 14:47 ` voidlinux-github
  2019-09-11 11:42 ` [PR PATCH] [Merged]: " voidlinux-github
  13 siblings, 0 replies; 15+ messages in thread
From: voidlinux-github @ 2019-09-09 14:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by Gottox on void-packages repository

https://github.com/void-linux/void-packages/pull/14277#issuecomment-529511880

Comment:
You're right. And polkit without a sessionmanager is useless.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Merged]: NetworkManager: Set elogind on by default.
  2019-09-06 23:53 [PR PATCH] t voidlinux-github
                   ` (12 preceding siblings ...)
  2019-09-09 14:47 ` voidlinux-github
@ 2019-09-11 11:42 ` " voidlinux-github
  13 siblings, 0 replies; 15+ messages in thread
From: voidlinux-github @ 2019-09-11 11:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

There's a merged pull request on the void-packages repository

NetworkManager: Set elogind on by default.
https://github.com/void-linux/void-packages/pull/14277

Description:
This causes network connections to be properly restarted on
suspend and resume of the system via elogind/desktops.

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, back to index

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-06 23:53 [PR PATCH] t voidlinux-github
2019-09-06 23:55 ` t voidlinux-github
2019-09-08  0:44 ` NetworkManager: Set elogind on by default voidlinux-github
2019-09-08  0:59 ` voidlinux-github
2019-09-08  2:13 ` voidlinux-github
2019-09-08  2:34 ` voidlinux-github
2019-09-08 13:24 ` voidlinux-github
2019-09-08 15:09 ` voidlinux-github
2019-09-09 12:15 ` voidlinux-github
2019-09-09 12:46 ` voidlinux-github
2019-09-09 13:44 ` voidlinux-github
2019-09-09 14:07 ` voidlinux-github
2019-09-09 14:12 ` voidlinux-github
2019-09-09 14:47 ` voidlinux-github
2019-09-11 11:42 ` [PR PATCH] [Merged]: " voidlinux-github

Github messages for voidlinux

Archives are clonable: git clone --mirror http://inbox.vuxu.org/voidlinux-github

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/ public-inbox