[PR PATCH] elogind: disable utmp for musl

[PR PATCH] elogind: disable utmp for musl

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 769 bytes --]

There is a new pull request by Stantheman against master on the void-packages repository

https://github.com/Stantheman/void-packages elogind-utmp
https://github.com/void-linux/void-packages/pull/15138

elogind: disable utmp for musl
Since musl only stubs out utmp, elogind emits this warning on startup:

    "elogind[1044]: Failed to set utmp path to /dev/null/utmp: Not supported"

This patch silences that warning by building elogind on musl without utmp log handling support.

I'm not sure if this is the best method of checking for musl and updating the configure line. This is my second void contribution. I grepped for other uses of `XBPS_TARGET_LIBC` as a guide.

A patch file from https://github.com/void-linux/void-packages/pull/15138.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-elogind-utmp-15138.patch --]
[-- Type: text/x-diff, Size: 1321 bytes --]

From 4e8c8341cfe3752c401c0a98aba3faeb469218ef Mon Sep 17 00:00:00 2001
From: Stan Schwertly <stan@schwertly.com>
Date: Sat, 5 Oct 2019 13:35:18 -0400
Subject: [PATCH] elogind: disable utmp for musl

This silences the startup warning log:

    "elogind[1044]: Failed to set utmp path to /dev/null/utmp: Not supported"

By disabling utmp usage by elogind for musl targets
---
 srcpkgs/elogind/template | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/elogind/template b/srcpkgs/elogind/template
index 7d03f4e5fc0..3573956c521 100644
--- a/srcpkgs/elogind/template
+++ b/srcpkgs/elogind/template
@@ -1,7 +1,7 @@
 # Template file for 'elogind'
 pkgname=elogind
 version=241.3
-revision=2
+revision=3
 build_style=meson
 configure_args="-Dcgroup-controller=elogind -Dhalt-path=/usr/bin/halt
  -Drootlibexecdir=/usr/libexec/elogind -Dreboot-path=/usr/bin/reboot
@@ -20,6 +20,10 @@ distfiles="https://github.com/${pkgname}/${pkgname}/archive/v${version}.tar.gz"
 checksum=d6a465479c8a629d49ea9374f6199b0c60e7e42eade0fcd8265fc37085386365
 conf_files="/etc/elogind/logind.conf"
 
+if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
+	configure_args+=" -Dutmp=false"
+fi
+
 pre_check() {
 	# test-fs-util checks for /etc/machine-id/foo and expects ENOTDIR
 	# since /etc/machine-id is expected to be a file.

Re: [PR PATCH] [Merged]: elogind: disable utmp for musl

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

There's a merged pull request on the void-packages repository

elogind: disable utmp for musl
https://github.com/void-linux/void-packages/pull/15138

Description:
Since musl only stubs out utmp, elogind emits this warning on startup:

    "elogind[1044]: Failed to set utmp path to /dev/null/utmp: Not supported"

This patch silences that warning by building elogind on musl without utmp log handling support.

I'm not sure if this is the best method of checking for musl and updating the configure line. This is my second void contribution. I grepped for other uses of `XBPS_TARGET_LIBC` as a guide.