Github messages for voidlinux
 help / color / mirror / Atom feed
From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: [PR PATCH] libtool: respect environment variables
Date: Mon, 28 Oct 2019 20:45:38 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-15867@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]

There is a new pull request by jnbr against master on the void-packages repository

https://github.com/jnbr/void-packages libtool
https://github.com/void-linux/void-packages/pull/15867

libtool: respect environment variables
The /usr/bin/libtool script used to use cross tool-chains, when it was cross compiled.
This broke cross-built libtool for native builds and was changed in
653f4339274d162109af27c93a741264460f2da4 to native tool-chains.
Setting native tool-chains in libtools causes cross-builds which use libtool to fail.

Thus, change /usr/bin/libtool to use environment variables when defined and fall back to the native tool-chain otherwise.

A patch file from https://github.com/void-linux/void-packages/pull/15867.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libtool-15867.patch --]
[-- Type: text/x-diff, Size: 1631 bytes --]

From 7af8add8edd9bd377c465739ca3e418b1e18bab1 Mon Sep 17 00:00:00 2001
From: Johannes <johannes.brechtmann@gmail.com>
Date: Mon, 28 Oct 2019 20:33:14 +0100
Subject: [PATCH] libtool: respect environment variables

The /usr/bin/libtool script used to use cross tool-chains,
when it was cross compiled.
This broke cross-built libtool for native builds and was changed in
653f4339274d162109af27c93a741264460f2da4 to native tool-chains.
Setting native tool-chains in libtools causes cross-builds which use
libtool to fail.

Thus, change /usr/bin/libtool to use environment variables when defined
and fall back to the native tool-chain otherwise.
---
 srcpkgs/libtool/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/libtool/template b/srcpkgs/libtool/template
index 0624dd875de..a3c30d9bd5f 100644
--- a/srcpkgs/libtool/template
+++ b/srcpkgs/libtool/template
@@ -1,7 +1,7 @@
 # Template file for 'libtool'
 pkgname=libtool
 version=2.4.6
-revision=3
+revision=4
 build_style=gnu-configure
 hostmakedepends="perl automake help2man"
 depends="tar sed"
@@ -28,8 +28,8 @@ post_install() {
 	# things that need to go; the target libtool script is meant to be used
 	# in native environments, not in cross environments, so patch the script
 	if [ "$CROSS_BUILD" ]; then
-		# e.g. AR="armv7l-linux-gnueabihf-ar" becomes AR="ar"
-		vsed -i -e "s,=\"${XBPS_CROSS_TRIPLET}\-,=\",g" \
+		# e.g. AR="armv7l-linux-gnueabihf-ar" becomes AR="${AR:=ar}"
+		vsed -i -e "s,\([A-Z]\+\)=\"${XBPS_CROSS_TRIPLET}\-\(.*\)\",\1=\$\{\1:=\2\},g" \
 		 ${PKGDESTDIR}/usr/bin/libtool
 
 		# clear out any sysroot present

             reply	other threads:[~2019-10-28 19:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 19:45 voidlinux-github [this message]
2019-10-28 19:45 ` voidlinux-github
2019-10-28 20:46 ` [PR PATCH] [Updated] " voidlinux-github
2019-10-28 20:46 ` voidlinux-github
2019-11-02  9:36 ` [PR PATCH] [Merged]: " voidlinux-github

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-15867@inbox.vuxu.org \
    --to=voidlinux-github@inbox.vuxu.org \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).