[PR PATCH] xf86-video-vmware: add libstdc++ to depends

[PR PATCH] xf86-video-vmware: add libstdc++ to depends

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

There is a new pull request by flexibeast against master on the void-packages repository

https://github.com/flexibeast/void-packages modify-xf86-video-vmware
https://github.com/void-linux/void-packages/pull/16139

xf86-video-vmware: add libstdc++ to depends
A Reddit user [found](https://www.reddit.com/r/voidlinux/comments/drqni6/need_help_about_xorg/) that X using `xf86-video-vmware` wouldn't start without manually installing the `libstdc++` package. This PR adds that package to `xf86-video-vmware`'s 'depends'.

A patch file from https://github.com/void-linux/void-packages/pull/16139.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-modify-xf86-video-vmware-16139.patch --]
[-- Type: text/x-diff, Size: 1353 bytes --]

From 0ede9905864ca250ac2b64e7cf648688722e15ab Mon Sep 17 00:00:00 2001
From: Alexis <flexibeast@gmail.com>
Date: Tue, 5 Nov 2019 21:29:13 +1100
Subject: [PATCH] xf86-video-vmware: add libstdc++ to depends

---
 srcpkgs/xf86-video-vmware/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/xf86-video-vmware/template b/srcpkgs/xf86-video-vmware/template
index 441bcdb58e9..98e4bc898e9 100644
--- a/srcpkgs/xf86-video-vmware/template
+++ b/srcpkgs/xf86-video-vmware/template
@@ -1,20 +1,20 @@
-# Template build file for 'xf86-video-vmware'
+# Template file for 'xf86-video-vmware'
 pkgname=xf86-video-vmware
 version=13.3.0
-revision=1
-lib32disabled=yes
+revision=2
 archs="i686* x86_64*"
 build_style=gnu-configure
 configure_args="--enable-vmwarectrl-client"
 hostmakedepends="pkg-config"
 makedepends="libdrm-devel MesaLib-devel xorg-server-devel"
-depends="virtual?xserver-abi-video-24_1 mesa-vmwgfx-dri"
+depends="virtual?xserver-abi-video-24_1 mesa-vmwgfx-dri libstdc++"
 short_desc="Modular Xorg VMware virtual video driver"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"
 homepage="http://xorg.freedesktop.org"
 distfiles="${XORG_SITE}/driver/$pkgname-$version.tar.bz2"
 checksum=47971924659e51666a757269ad941a059ef5afe7a47b5101c174a6022ac4066c
+lib32disabled=yes
 
 LDFLAGS="-Wl,-z,lazy"
 

Re: xf86-video-vmware: add libstdc++ to depends

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/16139#issuecomment-549783189

Comment:
The screenshot looks more like libllvm9 should depend on libstc++ than the driver package itself or what do you think @q66 ?

Re: xf86-video-vmware: add libstdc++ to depends

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/16139#issuecomment-549783189

Comment:
The screenshot looks more like libllvm9 should depend on libstc++ rather than the driver package itself or what do you think @q66 ?

Re: xf86-video-vmware: add libstdc++ to depends

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/16139#issuecomment-549783189

Comment:
The screenshot looks more like libllvm9 should depend on libstdc++ rather than the driver package itself or what do you think @q66 ?

Re: xf86-video-vmware: add libstdc++ to depends

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/16139#issuecomment-549788003

Comment:
`libllvm9` already `shlib-requires` it, so the user just has a broken system

Re: xf86-video-vmware: add libstdc++ to depends

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/16139#issuecomment-549788003

Comment:
`libllvm9` already `shlib-requires` it, so the user just has a broken system

```
q66@rimi: /home/q66$ xbps-query libllvm9
architecture: ppc64le
automatic-install: yes
build-date: 2019-10-05 22:14 CEST
filename-sha256: c525f9332dbd805394cc2e5360c080fc12bc7baa9c4a2e121679ef7b2b5f40e1
filename-size: 19MB
homepage: https://www.llvm.org
install-date: 2019-10-19 19:23 CEST
installed_size: 87MB
license: NCSA
maintainer: q66 <daniel@octaforge.org>
metafile-sha256: 8b5f270ecb5a3ad7f64c46a415a8c3820d9a7a581dcdf2c7ad109320444edab2
pkgver: libllvm9-9.0.0_2
repository: /media/hostdir/binpkgs
shlib-provides:
	libLLVM-9.so
shlib-requires:
	libffi.so.6
	libedit.so.0
	libz.so.1
	libdl.so.2
	libncursesw.so.6
	libpthread.so.0
	libxml2.so.2
	libstdc++.so.6
	libm.so.6
	libgcc_s.so.1
	libc.so.6
	ld64.so.2
short_desc: Low Level Virtual Machine - runtime library
state: installed
```

Re: xf86-video-vmware: add libstdc++ to depends

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/16139#issuecomment-549789004

Comment:
Alright then, let's close.

Re: [PR PATCH] [Closed]: xf86-video-vmware: add libstdc++ to depends

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

There's a closed pull request on the void-packages repository

xf86-video-vmware: add libstdc++ to depends
https://github.com/void-linux/void-packages/pull/16139

Description:
A Reddit user [found](https://www.reddit.com/r/voidlinux/comments/drqni6/need_help_about_xorg/) that X using `xf86-video-vmware` wouldn't start without manually installing the `libstdc++` package. This PR adds that package to `xf86-video-vmware`'s 'depends'.