Github messages for voidlinux
 help / color / mirror / Atom feed
From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: [PR PATCH] build-style/go: use glob instead of find
Date: Mon, 11 Nov 2019 08:01:02 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-16354@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

There is a new pull request by zdtcd against master on the void-packages repository

https://github.com/zdtcd/void-packages build-style-go
https://github.com/void-linux/void-packages/pull/16354

build-style/go: use glob instead of find
Close #12442 

A patch file from https://github.com/void-linux/void-packages/pull/16354.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-build-style-go-16354.patch --]
[-- Type: text/x-diff, Size: 1837 bytes --]

From 302432dcdfac352d45a3fbd475bd3a83d40e3eb4 Mon Sep 17 00:00:00 2001
From: Doan Tran Cong Danh <congdanhqx@gmail.com>
Date: Mon, 11 Nov 2019 13:49:02 +0700
Subject: [PATCH 1/2] build-style/go: use glob instead of find

---
 common/build-style/go.sh | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index 97412843b20..d19598cf3a9 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -41,8 +41,9 @@ do_build() {
 }
 
 do_install() {
-	find "${GOPATH}/bin" -type f -executable | while read line
-	do
-		vbin "${line}"
+	for f in ${GOPATH}/bin/*; do
+		if [ -x "$f" ]; then
+			vbin "$f"
+		fi
 	done
 }

From 323032bd7844d20a8b28102ceea0c8f83b67d081 Mon Sep 17 00:00:00 2001
From: Doan Tran Cong Danh <congdanhqx@gmail.com>
Date: Mon, 11 Nov 2019 13:59:12 +0700
Subject: [PATCH 2/2] doctl: don't use go get

---
 srcpkgs/doctl/template | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/doctl/template b/srcpkgs/doctl/template
index 1ed77fc2a35..733ea20e279 100644
--- a/srcpkgs/doctl/template
+++ b/srcpkgs/doctl/template
@@ -1,17 +1,14 @@
 # Template file for 'doctl'
 pkgname=doctl
 version=1.21.1
-revision=1
+revision=2
 build_style=go
 go_import_path="github.com/digitalocean/doctl/cmd/doctl"
 go_build_tags="v${version}"
-go_get="yes"
-hostmakedepends="git"
+go_get="no"
 short_desc="Command line tool for DigitalOcean services"
 maintainer="Noah Huppert <contact@noahh.io>"
 license="Apache-2.0"
 homepage="https://github.com/digitalocean/doctl"
-
-post_install() {
-	       vlicense "$GOPATH/src/github.com/digitalocean/doctl/LICENSE.txt"
-}
+distfiles="https://github.com/digitalocean/doctl/archive/v${version}.tar.gz"
+checksum=8c1e60930e913ace562511b6a7ee8f0d3f4d08d4ba48148f26e12b6d2eb95f2b

             reply	other threads:[~2019-11-11  7:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11  7:01 voidlinux-github [this message]
2019-11-11  7:49 ` [PR PATCH] [Updated] " voidlinux-github

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-16354@inbox.vuxu.org \
    --to=voidlinux-github@inbox.vuxu.org \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).