Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] [RFC] SDL2: unify build options on all archs, don't enable rpi for arm*
@ 2020-01-14  3:50 voidlinux-github
  2020-01-14  3:53 ` voidlinux-github
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-14  3:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]

There is a new pull request by Johnnynator against master on the void-packages repository

https://github.com/Johnnynator/void-packages SDL2
https://github.com/void-linux/void-packages/pull/18298

[RFC] SDL2: unify build options on all archs, don't enable rpi for arm*
Currently `rpi-userland-devel` provides the some `pkgconfig` files as `libglvnd-devel`
```
/usr/lib/pkgconfig/glesv2.pc
/usr/lib/pkgconfig/egl.pc
```

Which makes it impossible to build something that depends on `SDL2-devel` and `libglvnd-devel`/`MesaLib-devel` since `rpi-userland-devel` will be pulled in.

Also if I'm not mistaken, the rpi build option is currently nevertheless broken. SDL2 only searches for `libGLESv2.so.2` if `--enable-video-rpi` is not set, and `rpi-userland` is only providing `libGLESv2.so`. The code of SDL does runtime checks whether it is a rpi so enabling it shouldn't break non rpi's. But everything should be less broken as the current state. So if anyone wanna fix the rpi build option feel free to do so.

A patch file from https://github.com/void-linux/void-packages/pull/18298.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-SDL2-18298.patch --]
[-- Type: text/x-diff, Size: 1321 bytes --]

From e2c9accce07cacb5028b494c8cd3d62338f29121 Mon Sep 17 00:00:00 2001
From: John <johnz@posteo.net>
Date: Tue, 14 Jan 2020 04:07:23 +0100
Subject: [PATCH] SDL2: unify build options on all archs, don't enable rpi for
 arm*

---
 srcpkgs/SDL2/template | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/SDL2/template b/srcpkgs/SDL2/template
index 8d9aa05cfd6..34158dd8da2 100644
--- a/srcpkgs/SDL2/template
+++ b/srcpkgs/SDL2/template
@@ -1,7 +1,7 @@
 # Template file for 'SDL2'
 pkgname=SDL2
 version=2.0.10
-revision=2
+revision=3
 build_style=gnu-configure
 configure_args="--enable-alsa --disable-esd --disable-rpath --enable-libudev
  --enable-clock_gettime --disable-nas --disable-arts --disable-x11-shared
@@ -18,17 +18,11 @@ checksum=b4656c13a1f0d0023ae2f4a9cf08ec92fffb464e0f24238337784159b8b91d57
 
 # Package build options
 build_options="gles opengl pulseaudio sndio vulkan wayland x11"
+build_options_default="gles opengl pulseaudio sndio vulkan wayland x11"
 
 case "$XBPS_TARGET_MACHINE" in
-	i686*|x86_64*|ppc*)
-		build_options_default="gles opengl pulseaudio sndio vulkan wayland x11"
-		;;
-	aarch64*)
-		build_options_default="gles opengl pulseaudio sndio x11"
-		;;
 	arm*)
 		build_options+=" rpi"
-		build_options_default="rpi pulseaudio sndio x11"
 		;;
 esac
 

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-01-25 23:27 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-14  3:50 [PR PATCH] [RFC] SDL2: unify build options on all archs, don't enable rpi for arm* voidlinux-github
2020-01-14  3:53 ` voidlinux-github
2020-01-17 14:58 ` voidlinux-github
2020-01-17 15:15 ` voidlinux-github
2020-01-19 21:23 ` voidlinux-github
2020-01-19 21:25 ` [PR PATCH] [Updated] " voidlinux-github
2020-01-22 18:17 ` [PR PATCH] [Merged]: " voidlinux-github
2020-01-25 23:27 ` voidlinux-github

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).