Github messages for voidlinux
 help / color / mirror / Atom feed
From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: [PR PATCH] inetutils: fix the missing port number for whois
Date: Thu, 23 Jan 2020 22:53:13 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18520@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

There is a new pull request by shahab-vahedi against master on the void-packages repository

https://github.com/shahab-vahedi/void-packages inetutils-fix-missing-whois-service-in-iana
https://github.com/void-linux/void-packages/pull/18520

inetutils: fix the missing port number for whois
Fixes issue 18445:
https://github.com/void-linux/void-packages/issues/18445

inetutils-whois consults the /etc/services provided by IANA to
determine the port number for the "whois" service. However, the
"whois" service is not listed in that file and when you run whois
you will end up with the following error:

> whois 4.2.2.4
  getaddrinfo: Servname not supported for ai_socktype

This patch makes use of "nicname" port which is the same number
(43) as a "whois" port and is listed in /etc/services. Moreover,
I have added "help2man" as the "hostmakedepends". Usually, you
don't need to have it running, but if you touch the whois.c file,
then the build process needs it.

A patch file from https://github.com/void-linux/void-packages/pull/18520.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-inetutils-fix-missing-whois-service-in-iana-18520.patch --]
[-- Type: text/x-diff, Size: 1958 bytes --]

From eacf1ff5e44a584012a775a179b41c1451234537 Mon Sep 17 00:00:00 2001
From: Shahab Vahedi <shahab.vahedi@gmail.com>
Date: Thu, 23 Jan 2020 22:39:42 +0100
Subject: [PATCH] inetutils: fix the missing port number for whois

Fixes issue 18445:
https://github.com/void-linux/void-packages/issues/18445

inetutils-whois consults the /etc/services provided by IANA to
determine the port number for the "whois" service. However, the
"whois" service is not listed in that file and when you run whois
you will end up with the following error:

> whois 4.2.2.4
  getaddrinfo: Servname not supported for ai_socktype

This patch makes use of "nicname" port which is the same number
(43) as a "whois" port and is listed in /etc/services. Moreover,
I have added "help2man" as the "hostmakedepends". Usually, you
don't need to have it running, but if you touch the whois.c file,
then the build process needs it.
---
 srcpkgs/inetutils/template | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/inetutils/template b/srcpkgs/inetutils/template
index 9ef3f2b3d0e..7e9a009e72c 100644
--- a/srcpkgs/inetutils/template
+++ b/srcpkgs/inetutils/template
@@ -1,9 +1,10 @@
 # Template file for 'inetutils'
 pkgname=inetutils
 version=1.9.4
-revision=10
+revision=11
 build_style=gnu-configure
 configure_args="--without-wrap --with-pam"
+hostmakedepends="help2man"
 makedepends="pam-devel readline-devel"
 short_desc="GNU network utilities"
 maintainer="Orphaned <orphan@voidlinux.org>"
@@ -32,6 +33,8 @@ pre_configure() {
 	sed -i 's|_GL_WARN_ON_USE (gets|//_GL_WARN_ON_USE (gets|' lib/stdio.in.h
 	# Create a definition to allow the ifconfig program to build properly
 	echo '#define PATH_PROCNET_DEV "/proc/net/dev"' >> ifconfig/system/linux.h
+	# Since there is no "whois" port in IANA services, use the next best thing.
+	sed -i 's|port : "whois"|port : "nicname"|' whois/whois.c
 }
 post_install() {
 	# Keep just usr/share/info/inetutils.info.gz

             reply	other threads:[~2020-01-23 21:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-23 21:53 voidlinux-github [this message]
2020-01-24 22:43 ` [PR PATCH] [Updated] " voidlinux-github
2020-01-24 22:46 ` voidlinux-github
2020-01-25  7:49 ` [PR PATCH] [Merged]: " voidlinux-github

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18520@inbox.vuxu.org \
    --to=voidlinux-github@inbox.vuxu.org \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).