Github messages for voidlinux
 help / color / mirror / Atom feed
From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: [PR PATCH] avahi: preserve default behavior for disallow-other-stacks
Date: Mon, 03 Feb 2020 17:25:17 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18773@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 811 bytes --]

There is a new pull request by ahesford against master on the void-packages repository

https://github.com/ahesford/void-packages avahi
https://github.com/void-linux/void-packages/pull/18773

avahi: preserve default behavior for disallow-other-stacks
The void package for avahi overrides the default configuration for disallow-other-stacks, which causes avahi-daemon to bind port 5353. This is "recommended" practice by the Avahi maintainers, but is disabled by default to "not annoy people". In particular, setting this to true breaks the hpaio SANE driver, which attempts to use its own mDNS stack to search for network-connected scanners.

To be consistent with default avahi behavior, this PR undoes the override.

A patch file from https://github.com/void-linux/void-packages/pull/18773.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-avahi-18773.patch --]
[-- Type: text/x-diff, Size: 1176 bytes --]

From 9b7a4373a37b5285d6a22d34e6d43b853f6f878a Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Mon, 3 Feb 2020 11:19:43 -0500
Subject: [PATCH] avahi: preserve default behavior for disallow-other-stacks in
 avahi-daemon.conf

---
 srcpkgs/avahi/template | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/srcpkgs/avahi/template b/srcpkgs/avahi/template
index 572075be35a..199cbd4e057 100644
--- a/srcpkgs/avahi/template
+++ b/srcpkgs/avahi/template
@@ -1,7 +1,7 @@
 # Template file for 'avahi'
 pkgname=avahi
 version=0.7
-revision=8
+revision=9
 build_style=gnu-configure
 configure_args="--disable-qt3 --disable-qt4 --disable-mono --disable-monodoc
  --disable-doxygen-doc --enable-compat-libdns_sd --enable-compat-howl
@@ -42,8 +42,6 @@ post_extract() {
 }
 post_install() {
 	rm -rf ${DESTDIR}/usr/lib/python*
-	# Enable 'disallow_other_stacks' option by default.
-	sed -e 's,\#\(disallow-other-stacks\).*,\1=yes,' -i ${DESTDIR}/etc/avahi/avahi-daemon.conf
 	# Set 'enable-dbus=warn' option by default to not require dbus.
 	sed -e 's,\#\(enable-dbus\).*,\1=warn,' -i ${DESTDIR}/etc/avahi/avahi-daemon.conf
 	vsv avahi-daemon

             reply	other threads:[~2020-02-03 16:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03 16:25 voidlinux-github [this message]
2020-02-14 15:19 ` [PR PATCH] [Merged]: " xtraeme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18773@inbox.vuxu.org \
    --to=voidlinux-github@inbox.vuxu.org \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).