Github messages for voidlinux
 help / color / mirror / Atom feed
From: sirikid <sirikid@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines
Date: Fri, 24 Apr 2020 02:26:08 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-21288@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

There is a new pull request by sirikid against master on the void-packages repository

https://github.com/sirikid/void-packages don't-strip-unknown-binaries
https://github.com/void-linux/void-packages/pull/21288

06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines
Because most likely these files are not executables, but some kind of bytecode. And strip doesn't know how to strip them anyway.

A patch file from https://github.com/void-linux/void-packages/pull/21288.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-don't-strip-unknown-binaries-21288.patch --]
[-- Type: text/x-diff, Size: 920 bytes --]

From 0c9e4688447228e7d6434870893b8eb5b3ab1e54 Mon Sep 17 00:00:00 2001
From: a <a@a.a>
Date: Fri, 24 Apr 2020 03:16:18 +0300
Subject: [PATCH] 06-strip-and-debug-pkgs.sh: ignore binaries for unknown
 machines

Because most likely these files are not executables, but some kind of
bytecode. And strip doesn't know how to strip them anyway.
---
 common/hooks/post-install/06-strip-and-debug-pkgs.sh | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/common/hooks/post-install/06-strip-and-debug-pkgs.sh b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
index a15dd1a96c3..44d8a51fe93 100644
--- a/common/hooks/post-install/06-strip-and-debug-pkgs.sh
+++ b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
@@ -70,6 +70,10 @@ hook() {
 			continue
 		fi
 
+		if [[ $(file -b "$f") =~ "no machine" ]]; then
+			continue
+		fi
+
 		fname=${f##*/}
 		for x in ${nostrip_files}; do
 			if [ "$x" = "$fname" ]; then

             reply	other threads:[~2020-04-24  0:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24  0:26 sirikid [this message]
2020-04-24  0:29 ` Vaelatern
2020-04-24  0:35 ` sirikid
2020-04-24  0:42 ` Vaelatern
2020-04-24  0:53 ` sirikid
2020-04-24  1:22 ` sirikid
2020-04-24  3:00 ` Vaelatern
2020-04-24  3:01 ` [PR PATCH] [Merged]: " Vaelatern
2020-04-25  0:06 ` sirikid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-21288@inbox.vuxu.org \
    --to=sirikid@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).