Github messages for voidlinux
 help / color / Atom feed
* [PR PATCH] iwd: fix output sent to tty1
@ 2020-04-26 16:47 NeelChotai
  2020-04-27 15:00 ` sgn
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: NeelChotai @ 2020-04-26 16:47 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

There is a new pull request by NeelChotai against master on the void-packages repository

https://github.com/NeelChotai/void-packages iwd-fix
https://github.com/void-linux/void-packages/pull/21353

iwd: fix output sent to tty1


A patch file from https://github.com/void-linux/void-packages/pull/21353.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-iwd-fix-21353.patch --]
[-- Type: text/x-diff, Size: 590 bytes --]

From 679b21198547077e57ca9c7575a473e49ebeb6fa Mon Sep 17 00:00:00 2001
From: Neel Chotai <neel@chot.ai>
Date: Sun, 26 Apr 2020 17:47:26 +0100
Subject: [PATCH] iwd: fix output sent to tty1

---
 srcpkgs/iwd/files/iwd/run | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/srcpkgs/iwd/files/iwd/run b/srcpkgs/iwd/files/iwd/run
index b7d22b7f9e4..311df3d708d 100755
--- a/srcpkgs/iwd/files/iwd/run
+++ b/srcpkgs/iwd/files/iwd/run
@@ -1,4 +1,3 @@
 #!/bin/sh
 [ -r ./conf ] && . ./conf
-exec 2>&1
-exec /usr/libexec/iwd ${OPTS}
+exec /usr/libexec/iwd ${OPTS} > /dev/null 2>&1

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: iwd: fix output sent to tty1
  2020-04-26 16:47 [PR PATCH] iwd: fix output sent to tty1 NeelChotai
@ 2020-04-27 15:00 ` sgn
  2020-04-27 23:49 ` [PR PATCH] [Updated] " NeelChotai
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: sgn @ 2020-04-27 15:00 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/21353#issuecomment-620041497

Comment:
Does it retains log?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] iwd: fix output sent to tty1
  2020-04-26 16:47 [PR PATCH] iwd: fix output sent to tty1 NeelChotai
  2020-04-27 15:00 ` sgn
@ 2020-04-27 23:49 ` NeelChotai
  2020-04-28  0:07 ` NeelChotai
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: NeelChotai @ 2020-04-27 23:49 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

There is an updated pull request by NeelChotai against master on the void-packages repository

https://github.com/NeelChotai/void-packages iwd-fix
https://github.com/void-linux/void-packages/pull/21353

iwd: fix output sent to tty1
Closes #20912.

A patch file from https://github.com/void-linux/void-packages/pull/21353.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-iwd-fix-21353.patch --]
[-- Type: text/x-diff, Size: 523 bytes --]

From d18fd3ebef8d27e5cf342834cf4177c1fa0e9d73 Mon Sep 17 00:00:00 2001
From: Neel Chotai <neel@chot.ai>
Date: Sun, 26 Apr 2020 17:47:26 +0100
Subject: [PATCH] iwd: fix output sent to tty1

---
 srcpkgs/iwd/files/iwd/run | 1 -
 1 file changed, 1 deletion(-)

diff --git a/srcpkgs/iwd/files/iwd/run b/srcpkgs/iwd/files/iwd/run
index b7d22b7f9e4..de3d5201036 100755
--- a/srcpkgs/iwd/files/iwd/run
+++ b/srcpkgs/iwd/files/iwd/run
@@ -1,4 +1,3 @@
 #!/bin/sh
 [ -r ./conf ] && . ./conf
-exec 2>&1
 exec /usr/libexec/iwd ${OPTS}

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: iwd: fix output sent to tty1
  2020-04-26 16:47 [PR PATCH] iwd: fix output sent to tty1 NeelChotai
  2020-04-27 15:00 ` sgn
  2020-04-27 23:49 ` [PR PATCH] [Updated] " NeelChotai
@ 2020-04-28  0:07 ` NeelChotai
  2020-04-29  0:44 ` ericonr
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: NeelChotai @ 2020-04-28  0:07 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 575 bytes --]

New comment by NeelChotai on void-packages repository

https://github.com/void-linux/void-packages/pull/21353#issuecomment-620299780

Comment:
> Does it retains log?

I've tested it a little more and it appears as through simply removing the redirection from stderr to stdout is enough to prevent the spam on tty1. This should retain any log output.

Something of note - the NetworkManager run file uses the approach I originally used, perhaps its output doesn't need to be redirected to /dev/null either? I don't use NetworkManager personally so I'm unable to test it. 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: iwd: fix output sent to tty1
  2020-04-26 16:47 [PR PATCH] iwd: fix output sent to tty1 NeelChotai
                   ` (2 preceding siblings ...)
  2020-04-28  0:07 ` NeelChotai
@ 2020-04-29  0:44 ` ericonr
  2020-04-29  1:10 ` travankor
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2020-04-29  0:44 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/21353#issuecomment-620927709

Comment:
Seems to have worked fine for me too!

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: iwd: fix output sent to tty1
  2020-04-26 16:47 [PR PATCH] iwd: fix output sent to tty1 NeelChotai
                   ` (3 preceding siblings ...)
  2020-04-29  0:44 ` ericonr
@ 2020-04-29  1:10 ` travankor
  2020-04-29  1:25 ` [PR PATCH] [Updated] " NeelChotai
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: travankor @ 2020-04-29  1:10 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New comment by travankor on void-packages repository

https://github.com/void-linux/void-packages/pull/21353#issuecomment-620935054

Comment:
Yeah +1 to merging, I've had this as a private change for ~6months

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] iwd: fix output sent to tty1
  2020-04-26 16:47 [PR PATCH] iwd: fix output sent to tty1 NeelChotai
                   ` (4 preceding siblings ...)
  2020-04-29  1:10 ` travankor
@ 2020-04-29  1:25 ` NeelChotai
  2020-05-26  8:23 ` travankor
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: NeelChotai @ 2020-04-29  1:25 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

There is an updated pull request by NeelChotai against master on the void-packages repository

https://github.com/NeelChotai/void-packages iwd-fix
https://github.com/void-linux/void-packages/pull/21353

iwd: fix output sent to tty1
Closes #20912.

A patch file from https://github.com/void-linux/void-packages/pull/21353.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-iwd-fix-21353.patch --]
[-- Type: text/x-diff, Size: 961 bytes --]

From d0e7b5d96667be7a0019c49100480ad0d2f28e6d Mon Sep 17 00:00:00 2001
From: Neel Chotai <neel@chot.ai>
Date: Sun, 26 Apr 2020 17:47:26 +0100
Subject: [PATCH] iwd: fix output sent to tty1

---
 srcpkgs/iwd/files/iwd/run | 1 -
 srcpkgs/iwd/template      | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/srcpkgs/iwd/files/iwd/run b/srcpkgs/iwd/files/iwd/run
index b7d22b7f9e4..de3d5201036 100755
--- a/srcpkgs/iwd/files/iwd/run
+++ b/srcpkgs/iwd/files/iwd/run
@@ -1,4 +1,3 @@
 #!/bin/sh
 [ -r ./conf ] && . ./conf
-exec 2>&1
 exec /usr/libexec/iwd ${OPTS}
diff --git a/srcpkgs/iwd/template b/srcpkgs/iwd/template
index 881093a9970..06d87c64c37 100644
--- a/srcpkgs/iwd/template
+++ b/srcpkgs/iwd/template
@@ -1,7 +1,7 @@
 # Template file for 'iwd'
 pkgname=iwd
 version=1.7
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--disable-systemd-service --enable-pie
  --enable-external-ell --enable-dbus-policy --enable-wired"

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: iwd: fix output sent to tty1
  2020-04-26 16:47 [PR PATCH] iwd: fix output sent to tty1 NeelChotai
                   ` (5 preceding siblings ...)
  2020-04-29  1:25 ` [PR PATCH] [Updated] " NeelChotai
@ 2020-05-26  8:23 ` travankor
  2020-05-26 11:41 ` sgn
  2020-06-01 21:41 ` NeelChotai
  8 siblings, 0 replies; 10+ messages in thread
From: travankor @ 2020-05-26  8:23 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New comment by travankor on void-packages repository

https://github.com/void-linux/void-packages/pull/21353#issuecomment-633882607

Comment:
@sgn Anything else?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: iwd: fix output sent to tty1
  2020-04-26 16:47 [PR PATCH] iwd: fix output sent to tty1 NeelChotai
                   ` (6 preceding siblings ...)
  2020-05-26  8:23 ` travankor
@ 2020-05-26 11:41 ` sgn
  2020-06-01 21:41 ` NeelChotai
  8 siblings, 0 replies; 10+ messages in thread
From: sgn @ 2020-05-26 11:41 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/21353#issuecomment-633972654

Comment:
On 2020-05-26 01:23:41-0700, travankor <notifications@github.com> wrote:
> @sgn Anything else?

I forgot about this.

Gimme sometime, maybe this weekend. Please ping me if this PR isn't
merged or commented that time.

I'm also iwd's user but I don't have time to try this for now.

-- 
Danh


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: iwd: fix output sent to tty1
  2020-04-26 16:47 [PR PATCH] iwd: fix output sent to tty1 NeelChotai
                   ` (7 preceding siblings ...)
  2020-05-26 11:41 ` sgn
@ 2020-06-01 21:41 ` NeelChotai
  8 siblings, 0 replies; 10+ messages in thread
From: NeelChotai @ 2020-06-01 21:41 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 149 bytes --]

New comment by NeelChotai on void-packages repository

https://github.com/void-linux/void-packages/pull/21353#issuecomment-637128514

Comment:
@sgn 

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, back to index

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-26 16:47 [PR PATCH] iwd: fix output sent to tty1 NeelChotai
2020-04-27 15:00 ` sgn
2020-04-27 23:49 ` [PR PATCH] [Updated] " NeelChotai
2020-04-28  0:07 ` NeelChotai
2020-04-29  0:44 ` ericonr
2020-04-29  1:10 ` travankor
2020-04-29  1:25 ` [PR PATCH] [Updated] " NeelChotai
2020-05-26  8:23 ` travankor
2020-05-26 11:41 ` sgn
2020-06-01 21:41 ` NeelChotai

Github messages for voidlinux

Archives are clonable: git clone --mirror http://inbox.vuxu.org/voidlinux-github

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git