Github messages for voidlinux
 help / color / mirror / Atom feed
From: haemka <haemka@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [ISSUE] xdotool reports wrong version
Date: Sat, 16 May 2020 10:09:04 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-22006@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 2129 bytes --]

New issue by haemka on void-packages repository

https://github.com/void-linux/void-packages/issues/22006

Description:
# System

* xuname:
   `Void 5.6.11_1 x86_64 AuthenticAMD uptodate rrrmFFFF`
* package:  
  xdotool 3.20160805.1_2

### Expected behavior
`xdotool -v` should report correct version (currently `3.20160805.1`)

### Actual behavior
`xdotool -v` reports `xdotool version 3.20191225.1`

### Steps to reproduce the behavior
Run `xdotool -v`

### Explanation
The upstream repository of xdotool contains multiple release archives which differ slightly ([1](https://github.com/jordansissel/xdotool/releases/download/v3.20160805.1/xdotool-3.20160805.1.tar.gz) and [2](https://github.com/jordansissel/xdotool/archive/v3.20160805.1.tar.gz))

The link for archive 2 is used in the srcpkgs template, but this archive is missing the `VERSION` file, which is read by `version.sh` called from ` Makefile`. By changing the archive download link in the packages template and rebuilding the package xdotool shows the correct version.

```diff
diff --git a/srcpkgs/xdotool/template b/srcpkgs/xdotool/template
index 7734b38845..a3366c7844 100644
--- a/srcpkgs/xdotool/template
+++ b/srcpkgs/xdotool/template
@@ -1,7 +1,7 @@
 # Template file for 'xdotool'
 pkgname=xdotool
 version=3.20160805.1
-revision=2
+revision=3
 build_style=gnu-makefile
 make_build_target="all"
 make_install_args="INSTALLMAN=$DESTDIR/usr/share/man"
@@ -11,8 +11,8 @@ short_desc="Command-line X11 automation tool"
 maintainer="Leah Neukirchen <leah@vuxu.org>"
 license="BSD-3-Clause"
 homepage="https://github.com/jordansissel/xdotool"
-distfiles="https://github.com/jordansissel/${pkgname}/archive/v${version}.tar.gz"
-checksum=ddafca1239075c203769c17a5a184587731e56fbe0438c09d08f8af1704e117a
+distfiles="https://github.com/jordansissel/${pkgname}/releases/download/v${version}/xdotool-${version}.tar.gz"
+checksum=35be5ff6edf0c620a0e16f09ea5e101d5173280161772fca18657d83f20fcca8
 CFLAGS="-std=c99"
 
 xdotool-devel_package() {
```

Leads to a package where `xdotool -v` shows `xdotool version 3.20160805.1`

             reply	other threads:[~2020-05-16  8:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-16  8:09 haemka [this message]
2020-05-18 22:34 ` [ISSUE] [CLOSED] " leahneukirchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-22006@inbox.vuxu.org \
    --to=haemka@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).