Github messages for voidlinux
 help / color / Atom feed
* [PR PATCH] python3-pyscard: rename from python3-scard
@ 2020-05-27 13:16 sgn
  2020-05-31  2:09 ` [PR PATCH] [Merged]: " sgn
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: sgn @ 2020-05-27 13:16 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

There is a new pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages python3-pyscard-rename
https://github.com/void-linux/void-packages/pull/22353

python3-pyscard: rename from python3-scard
Make a PR because I'm not sure if this will have any impacts.

A patch file from https://github.com/void-linux/void-packages/pull/22353.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-pyscard-rename-22353.patch --]
[-- Type: text/x-diff, Size: 3860 bytes --]

From fb1bad69a3a7a87e5c18d1af09434400030fc40f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Wed, 27 May 2020 20:14:13 +0700
Subject: [PATCH] python3-pyscard: rename from python3-scard

---
 srcpkgs/python3-fido2/template                      |  7 ++++---
 srcpkgs/{python3-scard => python3-pyscard}/template | 10 ++++++----
 srcpkgs/{python3-scard => python3-pyscard}/update   |  0
 srcpkgs/yubikey-manager/template                    |  6 +++---
 4 files changed, 13 insertions(+), 10 deletions(-)
 rename srcpkgs/{python3-scard => python3-pyscard}/template (71%)
 rename srcpkgs/{python3-scard => python3-pyscard}/update (100%)

diff --git a/srcpkgs/python3-fido2/template b/srcpkgs/python3-fido2/template
index 2c7977d65a7..fcf8a219ca2 100644
--- a/srcpkgs/python3-fido2/template
+++ b/srcpkgs/python3-fido2/template
@@ -2,13 +2,14 @@
 pkgname=python3-fido2
 _pkgname=fido2
 version=0.8.1
-revision=1
+revision=2
 archs=noarch
 wrksrc="${_pkgname}-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-six python3-cryptography python3-scard"
-checkdepends="$depends"
+depends="python3-six python3-cryptography python3-pyscard"
+# Missing fakefs will be pulled from pypi
+checkdepends="$depends python3-mock"
 short_desc="Library for FIDO2 functionality"
 maintainer="Đoàn Trần Công Danh <congdanhqx@gmail.com>"
 license="BSD-2-Clause"
diff --git a/srcpkgs/python3-scard/template b/srcpkgs/python3-pyscard/template
similarity index 71%
rename from srcpkgs/python3-scard/template
rename to srcpkgs/python3-pyscard/template
index f11e703f7d6..f9d7ef130ec 100644
--- a/srcpkgs/python3-scard/template
+++ b/srcpkgs/python3-pyscard/template
@@ -1,18 +1,20 @@
-# Template file for 'python3-scard'
-pkgname=python3-scard
+# Template file for 'python3-pyscard'
+pkgname=python3-pyscard
 _pkgname=pyscard
 version=1.9.9
-revision=1
+revision=2
 wrksrc="${_pkgname}-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools swig"
 makedepends="python3-devel pcsclite-devel"
 depends="python3 pcsclite"
 short_desc="Python library for smartcard"
-maintainer="Doan Tran Cong Danh <congdanhqx@gmail.com>"
+maintainer="Đoàn Trần Công Danh <congdanhqx@gmail.com>"
 license="LGPL-2.1-or-later"
 homepage="https://pyscard.sourceforge.io/index.html"
 distfiles="${PYPI_SITE}/p/${_pkgname}/${_pkgname}-${version}.tar.gz"
 checksum=e6bde541990183858740793806b1c7f4e798670519ae4c96145f35d5d7944c20
+provides="python3-scard-${version}_$revision"
+replaces="python3-scard>=0"
 
 CPPFLAGS="-I${XBPS_CROSS_BASE}/usr/include/PCSC"
diff --git a/srcpkgs/python3-scard/update b/srcpkgs/python3-pyscard/update
similarity index 100%
rename from srcpkgs/python3-scard/update
rename to srcpkgs/python3-pyscard/update
diff --git a/srcpkgs/yubikey-manager/template b/srcpkgs/yubikey-manager/template
index b8601ea1e15..75886e00e81 100644
--- a/srcpkgs/yubikey-manager/template
+++ b/srcpkgs/yubikey-manager/template
@@ -1,16 +1,16 @@
 # Template file for 'yubikey-manager'
 pkgname=yubikey-manager
 version=3.1.1
-revision=1
+revision=2
 archs=noarch
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="libu2f-host python3-fido2 python3-openssl python3-usb python3-scard
+depends="libu2f-host python3-fido2 python3-openssl python3-usb python3-pyscard
  python3-click python3-cryptography python3-six pcsc-ccid python3-setuptools
  libykpers"
 checkdepends="$depends python3-pytest"
 short_desc="Library and CLI tools to configure YubiKey"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Đoàn Trần Công Danh <congdanhqx@gmail.com>"
 license="BSD-2-Clause"
 homepage="https://developers.yubico.com/yubikey-manager/"
 distfiles="https://developers.yubico.com/${pkgname}/Releases/${pkgname}-${version}.tar.gz"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Merged]: python3-pyscard: rename from python3-scard
  2020-05-27 13:16 [PR PATCH] python3-pyscard: rename from python3-scard sgn
@ 2020-05-31  2:09 ` sgn
  2020-06-01 20:40 ` Chocimier
  2020-06-02  0:26 ` sgn
  2 siblings, 0 replies; 4+ messages in thread
From: sgn @ 2020-05-31  2:09 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

There's a merged pull request on the void-packages repository

python3-pyscard: rename from python3-scard
https://github.com/void-linux/void-packages/pull/22353

Description:
Make a PR because I'm not sure if this will have any impacts.

---
Merging in 1 week.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: python3-pyscard: rename from python3-scard
  2020-05-27 13:16 [PR PATCH] python3-pyscard: rename from python3-scard sgn
  2020-05-31  2:09 ` [PR PATCH] [Merged]: " sgn
@ 2020-06-01 20:40 ` Chocimier
  2020-06-02  0:26 ` sgn
  2 siblings, 0 replies; 4+ messages in thread
From: Chocimier @ 2020-06-01 20:40 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/22353#issuecomment-637090504

Comment:
Aah, I'm late, but still.

Renaming package break build of out-of tree packages; invalidates `hold`, `repolock`, `ignores` and similar custom settings.
If package was installed manually, transitional package is required, because `replaces=` causes package to be [uninstalled](https://github.com/void-linux/void-packages/issues/11816#issuecomment-493770733), and there is no safe enough period after which transitional package could be removed without breaking [otherwise working updates](https://www.michaelwashere.net/post/2017-09-24-upgrading-the-ancient/).

If gain is purely aestethic, I would like to ask to not rename.

You could point me merging similar renames. Please do not repeat my mistakes.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: python3-pyscard: rename from python3-scard
  2020-05-27 13:16 [PR PATCH] python3-pyscard: rename from python3-scard sgn
  2020-05-31  2:09 ` [PR PATCH] [Merged]: " sgn
  2020-06-01 20:40 ` Chocimier
@ 2020-06-02  0:26 ` sgn
  2 siblings, 0 replies; 4+ messages in thread
From: sgn @ 2020-06-02  0:26 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/22353#issuecomment-637196278

Comment:
On 2020-06-01 13:41:07-0700, Piotr <notifications@github.com> wrote:
> Aah, I'm late, but still.
> 
> Renaming package break build of out-of tree packages; invalidates
> `hold`, `repolock`, `ignores` and similar custom settings.
> If package was installed manually, transitional package is required,
> because `replaces=` causes package to be
> [uninstalled](https://github.com/void-linux/void-packages/issues/11816#issuecomment-493770733),
> and there is no safe enough period after which transitional package
> could be removed without breaking [otherwise working
> updates](https://www.michaelwashere.net/post/2017-09-24-upgrading-the-ancient/).

I agree with this point.
I /thought/ python3-scard was pulled by yubikey-manager for most of
users, hence I /thought/ it's safe enough.

> If gain is purely aestethic, I would like to ask to not rename.

I fear that a day will come and there is a Python package named scard.
Looking at other packages, I think it's 100% possible.

> You could point me merging similar renames. Please do not repeat my mistakes.

OK.
Does it make sense to create a transitional package now?

-- 
Danh


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-27 13:16 [PR PATCH] python3-pyscard: rename from python3-scard sgn
2020-05-31  2:09 ` [PR PATCH] [Merged]: " sgn
2020-06-01 20:40 ` Chocimier
2020-06-02  0:26 ` sgn

Github messages for voidlinux

Archives are clonable: git clone --mirror http://inbox.vuxu.org/voidlinux-github

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git