Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[RFC] Update gcompat to 0.9.0, add spotify to musl, use dynamic musl-obstack #23432
+32
−81
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ericonr commentedJul 6, 2020
Okay, so this is a biggie PR, and I do need help for making some decisions.
gcompatcan do Spotify now, on Adélie. I am working on debugging it on Void, because it isn't working completely yet.obstackingcompat, by enabling the dynamic lib inmusl-obstack. This completely fixes #22616, which needed obstack and_strftime_lsymbols (the latter was fixed by gcompat itself).musl-obstack-devel.musl-obstack-devel, but they ended up depending on the dynamic version of obstack. Is this bad? Is there some way to solve this? Perhaps two devel sub packages, one for dynamic and one for static linking?