[PR PATCH] sylpheed: patch to use SNI

[PR PATCH] sylpheed: patch to use SNI

[Gorggg]

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

There is a new pull request by Gorggg against master on the void-packages repository

https://github.com/Gorggg/void-packages master
https://github.com/void-linux/void-packages/pull/23487

sylpheed: patch to use SNI
Prior to this patch, sylpheed built against newer versions of LibreSSL could
not connect to IMAP server such as gmail's because it did not use SNI. This
patch from OpenBSD is a simple fix to implement it.

This fix is documented in the upstream bug tracker here: [https://sylpheed.sraoss.jp/redmine/issues/306](https://sylpheed.sraoss.jp/redmine/issues/306) and in the OpenBSD CVS here: [https://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/mail/sylpheed/patches/patch-libsylph_ssl_c](https://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/mail/sylpheed/patches/patch-libsylph_ssl_c)

If there is anything I missed or anything I could have done better while contributing, please let me know. Thanks for any reply.

A patch file from https://github.com/void-linux/void-packages/pull/23487.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-23487.patch --]
[-- Type: text/x-diff, Size: 1824 bytes --]

From b0db2dd96396cc11bc30edc45138916c248139ef Mon Sep 17 00:00:00 2001
From: George Matsumura <gmmatsumura01@bvsd.org>
Date: Wed, 8 Jul 2020 21:16:47 -0600
Subject: [PATCH] sylpheed: patch to use SNI

Prior to this patch, sylpheed built against newer versions of LibreSSL could
not connect to IMAP server such as gmail's because it did not use SNI. This
patch from OpenBSD is a simple fix to implement it.
---
 srcpkgs/sylpheed/patches/libsylph_ssl_c.patch | 16 ++++++++++++++++
 srcpkgs/sylpheed/template                     |  2 +-
 2 files changed, 17 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/sylpheed/patches/libsylph_ssl_c.patch

diff --git a/srcpkgs/sylpheed/patches/libsylph_ssl_c.patch b/srcpkgs/sylpheed/patches/libsylph_ssl_c.patch
new file mode 100644
index 00000000000..6d760ea11d1
--- /dev/null
+++ b/srcpkgs/sylpheed/patches/libsylph_ssl_c.patch
@@ -0,0 +1,16 @@
+--- libsylph/ssl.c.orig
++++ libsylph/ssl.c
+@@ -258,6 +258,13 @@ gboolean ssl_init_socket_with_method(SockInfo *sockinf
+ 		return FALSE;
+ 	}
+ 
++#ifdef SSL_CTRL_SET_TLSEXT_HOSTNAME
++	if (!SSL_set_tlsext_host_name(sockinfo->ssl, sockinfo->hostname)) {
++		g_warning("Error setting servername extension\n");
++		return FALSE;
++	}
++#endif
++
+ 	SSL_set_fd(sockinfo->ssl, sockinfo->sock);
+ 	while ((ret = SSL_connect(sockinfo->ssl)) != 1) {
+ 		err = SSL_get_error(sockinfo->ssl, ret);
diff --git a/srcpkgs/sylpheed/template b/srcpkgs/sylpheed/template
index be188c4e2db..af4410ac0fa 100644
--- a/srcpkgs/sylpheed/template
+++ b/srcpkgs/sylpheed/template
@@ -1,7 +1,7 @@
 # Template build file for 'sylpheed'.
 pkgname=sylpheed
 version=3.7.0
-revision=5
+revision=6
 lib32disabled=yes
 build_style=gnu-configure
 configure_args="--disable-compface --disable-gtkspell --enable-ldap --with-gpgme-prefix=${XBPS_CROSS_BASE}/usr"

Re: sylpheed: patch to use SNI

[ddevcc]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by ddevcc on void-packages repository

https://github.com/void-linux/void-packages/pull/23487#issuecomment-691711311

Comment:
I can confirm this works for me and now allows me to connect to gmail.  Thank you!

Re: [PR PATCH] [Closed]: sylpheed: patch to use SNI

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

There's a closed pull request on the void-packages repository

sylpheed: patch to use SNI
https://github.com/void-linux/void-packages/pull/23487

Description:
Prior to this patch, sylpheed built against newer versions of LibreSSL could
not connect to IMAP server such as gmail's because it did not use SNI. This
patch from OpenBSD is a simple fix to implement it.

This fix is documented in the upstream bug tracker here: [https://sylpheed.sraoss.jp/redmine/issues/306](https://sylpheed.sraoss.jp/redmine/issues/306) and in the OpenBSD CVS here: [https://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/mail/sylpheed/patches/patch-libsylph_ssl_c](https://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/mail/sylpheed/patches/patch-libsylph_ssl_c)

If there is anything I missed or anything I could have done better while contributing, please let me know. Thanks for any reply.

Re: sylpheed: patch to use SNI

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23487#issuecomment-769534545

Comment:
I fixed some things which were wrong with the commit message and you had an extra revbump.