Github messages for voidlinux
 help / color / mirror / Atom feed
From: Johnnynator <Johnnynator@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] qt5-webkit: add musl stacksize patch from webkit2gtk
Date: Sat, 11 Jul 2020 19:31:15 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23524@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

There is a new pull request by Johnnynator against master on the void-packages repository

https://github.com/Johnnynator/void-packages qt5-webkit
https://github.com/void-linux/void-packages/pull/23524

qt5-webkit: add musl stacksize patch from webkit2gtk
jsc on musl regulary fails without this patch:
> Fatal error compiling builtin function 'apply'

[ci skip]

A patch file from https://github.com/void-linux/void-packages/pull/23524.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qt5-webkit-23524.patch --]
[-- Type: text/x-diff, Size: 2575 bytes --]

From 86e90b673717d81e1b8334e3ce5ecf6f72b801c6 Mon Sep 17 00:00:00 2001
From: John <me@johnnynator.dev>
Date: Sat, 11 Jul 2020 19:28:32 +0200
Subject: [PATCH] qt5-webkit: add musl stacksize patch from webkit2gtk

jsc on musl regulary fails without this patch:
> Fatal error compiling builtin function 'apply'

[ci skip]
---
 srcpkgs/qt5-webkit/patches/jsc-musl.patch | 32 +++++++++++++++++++++++
 srcpkgs/qt5-webkit/template               |  2 +-
 2 files changed, 33 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/qt5-webkit/patches/jsc-musl.patch

diff --git a/srcpkgs/qt5-webkit/patches/jsc-musl.patch b/srcpkgs/qt5-webkit/patches/jsc-musl.patch
new file mode 100644
index 00000000000..b8b77523196
--- /dev/null
+++ b/srcpkgs/qt5-webkit/patches/jsc-musl.patch
@@ -0,0 +1,32 @@
+--- Source/JavaScriptCore/runtime/Options.h	2020-04-14 00:51:51.000000000 +0200
++++ -	2020-07-11 18:53:50.372744315 +0200
+@@ -40,6 +40,16 @@
+ 
+ namespace JSC {
+ 
++#if defined(__GLIBC__)
++constexpr unsigned jscMaxPerThreadStack = 4 * MB;
++constexpr unsigned jscSoftReservedZoneSize = 128 * KB;
++constexpr unsigned jscReservedZoneSize = 64 * KB;
++#else
++constexpr unsigned jscMaxPerThreadStack = 80 * KB;
++constexpr unsigned jscSoftReservedZoneSize = 32 * KB;
++constexpr unsigned jscReservedZoneSize = 16 * KB;
++#endif
++
+ // How do JSC VM options work?
+ // ===========================
+ // The JSC_OPTIONS() macro below defines a list of all JSC options in use,
+@@ -112,9 +122,9 @@
+     \
+     v(bool, reportMustSucceedExecutableAllocations, false, nullptr) \
+     \
+-    v(unsigned, maxPerThreadStackUsage, 4 * MB, nullptr) \
+-    v(unsigned, reservedZoneSize, 128 * KB, nullptr) \
+-    v(unsigned, errorModeReservedZoneSize, 64 * KB, nullptr) \
++    v(unsigned, maxPerThreadStackUsage, jscMaxPerThreadStack, nullptr) \
++    v(unsigned, reservedZoneSize, jscSoftReservedZoneSize, nullptr) \
++    v(unsigned, errorModeReservedZoneSize, jscReservedZoneSize, nullptr) \
+     \
+     v(bool, crashIfCantAllocateJITMemory, false, nullptr) \
+     v(unsigned, jitMemoryReservationSize, 0, "Set this number to change the executable allocation size in ExecutableAllocatorFixedVMPool. (In bytes.)") \
diff --git a/srcpkgs/qt5-webkit/template b/srcpkgs/qt5-webkit/template
index b86b746d252..03abdc4115d 100644
--- a/srcpkgs/qt5-webkit/template
+++ b/srcpkgs/qt5-webkit/template
@@ -1,7 +1,7 @@
 # Template file for 'qt5-webkit'
 pkgname=qt5-webkit
 version=5.212.0
-revision=10
+revision=11
 _snap=1586819898
 _v=${version%.*}
 wrksrc="qtwebkit-opensource-src-${_v}"

             reply	other threads:[~2020-07-11 17:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-11 17:31 Johnnynator [this message]
2020-07-11 18:17 ` [PR PATCH] [Merged]: " Johnnynator

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23524@inbox.vuxu.org \
    --to=johnnynator@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).