Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: rust-analyzer-2020.07.13
@ 2020-07-17 18:54 gbrlsnchs
  2020-07-17 21:07 ` [PR PATCH] [Updated] " gbrlsnchs
                   ` (14 more replies)
  0 siblings, 15 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-07-17 18:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

There is a new pull request by gbrlsnchs against master on the void-packages repository

https://github.com/gbrlsnchs/void-packages rust-analyzer
https://github.com/void-linux/void-packages/pull/23623

New package: rust-analyzer-2020.07.13


A patch file from https://github.com/void-linux/void-packages/pull/23623.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rust-analyzer-23623.patch --]
[-- Type: text/x-diff, Size: 1204 bytes --]

From 6d0660a1211b10cdb555279031bda04c3b730c58 Mon Sep 17 00:00:00 2001
From: Gabriel Sanches <gabriel@gsr.dev>
Date: Fri, 17 Jul 2020 15:50:57 -0300
Subject: [PATCH] New package: rust-analyzer-2020.07.13

---
 srcpkgs/rust-analyzer/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/rust-analyzer/template

diff --git a/srcpkgs/rust-analyzer/template b/srcpkgs/rust-analyzer/template
new file mode 100644
index 00000000000..e43b87e3269
--- /dev/null
+++ b/srcpkgs/rust-analyzer/template
@@ -0,0 +1,21 @@
+# Template file for 'rust-analyzer'
+pkgname=rust-analyzer
+version=2020.07.13
+_ver=${version//./-}
+revision=1
+build_style=cargo
+make_install_args="--path=crates/${pkgname}"
+hostmakedepends="rust"
+short_desc="An experimental Rust compiler front-end for IDEs"
+maintainer="Gabriel Sanches <gabriel@gsr.dev>"
+license="Apache-2.0, MIT"
+homepage="https://${pkgname}.github.io/"
+distfiles="https://github.com/${pkgname}/${pkgname}/archive/${_ver}.tar.gz"
+checksum=e4176167bba26eeb7bc7bbf5be45d261e05e231331135dfbc6f12f927ac6eb60
+wrksrc="${pkgname}-${_ver}"
+
+post_install() {
+	vlicense LICENSE-APACHE
+	vlicense LICENSE-MIT
+	vdoc README.md
+}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] New package: rust-analyzer-2020.07.13
  2020-07-17 18:54 [PR PATCH] New package: rust-analyzer-2020.07.13 gbrlsnchs
@ 2020-07-17 21:07 ` gbrlsnchs
  2020-08-09  9:37 ` [PR REVIEW] " jnbr
                   ` (13 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-07-17 21:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

There is an updated pull request by gbrlsnchs against master on the void-packages repository

https://github.com/gbrlsnchs/void-packages rust-analyzer
https://github.com/void-linux/void-packages/pull/23623

New package: rust-analyzer-2020.07.13


A patch file from https://github.com/void-linux/void-packages/pull/23623.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rust-analyzer-23623.patch --]
[-- Type: text/x-diff, Size: 1191 bytes --]

From 6459e90b98c5a2b24c27f59490c685926ced355f Mon Sep 17 00:00:00 2001
From: Gabriel Sanches <gabriel@gsr.dev>
Date: Fri, 17 Jul 2020 15:50:57 -0300
Subject: [PATCH] New package: rust-analyzer-2020.07.13

---
 srcpkgs/rust-analyzer/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/rust-analyzer/template

diff --git a/srcpkgs/rust-analyzer/template b/srcpkgs/rust-analyzer/template
new file mode 100644
index 00000000000..237475e6c4f
--- /dev/null
+++ b/srcpkgs/rust-analyzer/template
@@ -0,0 +1,21 @@
+# Template file for 'rust-analyzer'
+pkgname=rust-analyzer
+version=2020.07.13
+revision=1
+_ver=${version//./-}
+wrksrc="${pkgname}-${_ver}"
+build_style=cargo
+make_install_args="--path=crates/${pkgname}"
+hostmakedepends="rust"
+short_desc="Rust compiler front-end for IDEs"
+maintainer="Gabriel Sanches <gabriel@gsr.dev>"
+license="Apache-2.0, MIT"
+homepage="https://rust-analyzer.github.io/"
+distfiles="https://github.com/${pkgname}/${pkgname}/archive/${_ver}.tar.gz"
+checksum=e4176167bba26eeb7bc7bbf5be45d261e05e231331135dfbc6f12f927ac6eb60
+
+post_install() {
+	vlicense LICENSE-APACHE
+	vlicense LICENSE-MIT
+	vdoc README.md
+}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] New package: rust-analyzer-2020.07.13
  2020-07-17 18:54 [PR PATCH] New package: rust-analyzer-2020.07.13 gbrlsnchs
  2020-07-17 21:07 ` [PR PATCH] [Updated] " gbrlsnchs
@ 2020-08-09  9:37 ` jnbr
  2020-08-09  9:40 ` jnbr
                   ` (12 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: jnbr @ 2020-08-09  9:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New review comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/23623#discussion_r467560723

Comment:
this can be removed, it's implied by the build_style

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] New package: rust-analyzer-2020.07.13
  2020-07-17 18:54 [PR PATCH] New package: rust-analyzer-2020.07.13 gbrlsnchs
  2020-07-17 21:07 ` [PR PATCH] [Updated] " gbrlsnchs
  2020-08-09  9:37 ` [PR REVIEW] " jnbr
@ 2020-08-09  9:40 ` jnbr
  2020-08-09 19:44 ` ericonr
                   ` (11 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: jnbr @ 2020-08-09  9:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New review comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/23623#discussion_r467561052

Comment:
can you explain why this is needed?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: rust-analyzer-2020.07.13
  2020-07-17 18:54 [PR PATCH] New package: rust-analyzer-2020.07.13 gbrlsnchs
                   ` (2 preceding siblings ...)
  2020-08-09  9:40 ` jnbr
@ 2020-08-09 19:44 ` ericonr
  2020-08-11  2:18 ` [PR REVIEW] " gbrlsnchs
                   ` (10 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2020-08-09 19:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23623#issuecomment-671093133

Comment:
Does it make sense to have this as a system package? It goes hand in hand with rust development, for which someone would likely be using `rustup`. And it gets releases like crazy: https://github.com/rust-analyzer/rust-analyzer/releases

This installation step seems to indicate it depends on `rustup`, unless it can download sources without rustup: https://rust-analyzer.github.io/manual.html#installation ?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] New package: rust-analyzer-2020.07.13
  2020-07-17 18:54 [PR PATCH] New package: rust-analyzer-2020.07.13 gbrlsnchs
                   ` (3 preceding siblings ...)
  2020-08-09 19:44 ` ericonr
@ 2020-08-11  2:18 ` gbrlsnchs
  2020-08-11  2:23 ` gbrlsnchs
                   ` (9 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-08-11  2:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

New review comment by gbrlsnchs on void-packages repository

https://github.com/void-linux/void-packages/pull/23623#discussion_r468287563

Comment:
Because the Cargo build style [sets it when nothing is set](https://github.com/void-linux/void-packages/blob/5474e8770623edc15f2c552e2beae77f86e729d8/common/build-style/cargo.sh#L20). If it the build style didn't set it, it would just work, but since it sets it to `.`, I have to override it, otherwise the package won't compile.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: rust-analyzer-2020.07.13
  2020-07-17 18:54 [PR PATCH] New package: rust-analyzer-2020.07.13 gbrlsnchs
                   ` (4 preceding siblings ...)
  2020-08-11  2:18 ` [PR REVIEW] " gbrlsnchs
@ 2020-08-11  2:23 ` gbrlsnchs
  2020-08-11  2:37 ` ericonr
                   ` (8 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-08-11  2:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

New comment by gbrlsnchs on void-packages repository

https://github.com/void-linux/void-packages/pull/23623#issuecomment-671685931

Comment:
> Does it make sense to have this as a system package? It goes hand in hand with rust development, for which someone would likely be using `rustup`. And it gets releases like crazy: https://github.com/rust-analyzer/rust-analyzer/releases

Currently, `rust-analyzer` is distributed as binary only, not via rustup, so I think it makes sense to distribute it for now via XBPS. There was a discussion about whether it should be distributed via rustup, but nothing has changed since then.

> This installation step seems to indicate it depends on `rustup`, unless it can download sources without rustup: https://rust-analyzer.github.io/manual.html#installation ?

It's not a hard dependency, it simply needs `rust-src` in order for autocompletion and stuff to work properly.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: rust-analyzer-2020.07.13
  2020-07-17 18:54 [PR PATCH] New package: rust-analyzer-2020.07.13 gbrlsnchs
                   ` (5 preceding siblings ...)
  2020-08-11  2:23 ` gbrlsnchs
@ 2020-08-11  2:37 ` ericonr
  2020-09-15 18:56 ` [PR PATCH] [Updated] " gbrlsnchs
                   ` (7 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2020-08-11  2:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23623#issuecomment-671690016

Comment:
I must have understood https://github.com/rust-analyzer/rust-analyzer/issues/4224 wrong, it says that it's packaged with rustup already. But yeah, I couldn't download it with `rustup` :/

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] New package: rust-analyzer-2020.07.13
  2020-07-17 18:54 [PR PATCH] New package: rust-analyzer-2020.07.13 gbrlsnchs
                   ` (6 preceding siblings ...)
  2020-08-11  2:37 ` ericonr
@ 2020-09-15 18:56 ` gbrlsnchs
  2020-09-15 18:58 ` New package: rust-analyzer-2020.09.14 gbrlsnchs
                   ` (6 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-15 18:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

There is an updated pull request by gbrlsnchs against master on the void-packages repository

https://github.com/gbrlsnchs/void-packages rust-analyzer
https://github.com/void-linux/void-packages/pull/23623

New package: rust-analyzer-2020.07.13


A patch file from https://github.com/void-linux/void-packages/pull/23623.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rust-analyzer-23623.patch --]
[-- Type: text/x-diff, Size: 1166 bytes --]

From 7f93316969f668e4dfc9e747fb5df090e116c0a3 Mon Sep 17 00:00:00 2001
From: Gabriel Sanches <gabriel@gsr.dev>
Date: Fri, 17 Jul 2020 15:50:57 -0300
Subject: [PATCH] New package: rust-analyzer-2020.09.14

---
 srcpkgs/rust-analyzer/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/rust-analyzer/template

diff --git a/srcpkgs/rust-analyzer/template b/srcpkgs/rust-analyzer/template
new file mode 100644
index 00000000000..1361ce39766
--- /dev/null
+++ b/srcpkgs/rust-analyzer/template
@@ -0,0 +1,20 @@
+# Template file for 'rust-analyzer'
+pkgname=rust-analyzer
+version=2020.09.14
+revision=1
+_ver=${version//./-}
+wrksrc="${pkgname}-${_ver}"
+build_style=cargo
+make_install_args="--path=crates/${pkgname}"
+short_desc="Rust compiler front-end for IDEs"
+maintainer="Gabriel Sanches <gabriel@gsr.dev>"
+license="Apache-2.0, MIT"
+homepage="https://rust-analyzer.github.io/"
+distfiles="https://github.com/${pkgname}/${pkgname}/archive/${_ver}.tar.gz"
+checksum=162c0acac4c025e287deab7974340bf6147343495697ac72101cb8d56caab01e
+
+post_install() {
+	vlicense LICENSE-APACHE
+	vlicense LICENSE-MIT
+	vdoc README.md
+}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: rust-analyzer-2020.09.14
  2020-07-17 18:54 [PR PATCH] New package: rust-analyzer-2020.07.13 gbrlsnchs
                   ` (7 preceding siblings ...)
  2020-09-15 18:56 ` [PR PATCH] [Updated] " gbrlsnchs
@ 2020-09-15 18:58 ` gbrlsnchs
  2020-09-15 19:05 ` [PR REVIEW] " gbrlsnchs
                   ` (5 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-15 18:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by gbrlsnchs on void-packages repository

https://github.com/void-linux/void-packages/pull/23623#issuecomment-692910079

Comment:
I updated the package to the latest version.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] New package: rust-analyzer-2020.09.14
  2020-07-17 18:54 [PR PATCH] New package: rust-analyzer-2020.07.13 gbrlsnchs
                   ` (8 preceding siblings ...)
  2020-09-15 18:58 ` New package: rust-analyzer-2020.09.14 gbrlsnchs
@ 2020-09-15 19:05 ` gbrlsnchs
  2020-09-21 14:58 ` [PR PATCH] [Closed]: " gbrlsnchs
                   ` (4 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-15 19:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

New review comment by gbrlsnchs on void-packages repository

https://github.com/void-linux/void-packages/pull/23623#discussion_r468287563

Comment:
Because the Cargo build style [sets it when nothing is set](https://github.com/void-linux/void-packages/blob/5474e8770623edc15f2c552e2beae77f86e729d8/common/build-style/cargo.sh#L20). If the build style didn't set it, it would just work, but since it sets it to `.`, I have to override it, otherwise the package won't compile.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Closed]: New package: rust-analyzer-2020.09.14
  2020-07-17 18:54 [PR PATCH] New package: rust-analyzer-2020.07.13 gbrlsnchs
                   ` (9 preceding siblings ...)
  2020-09-15 19:05 ` [PR REVIEW] " gbrlsnchs
@ 2020-09-21 14:58 ` gbrlsnchs
  2020-09-21 23:23 ` gbrlsnchs
                   ` (3 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-21 14:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

There's a closed pull request on the void-packages repository

New package: rust-analyzer-2020.09.14
https://github.com/void-linux/void-packages/pull/23623

Description:


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: rust-analyzer-2020.09.14
  2020-07-17 18:54 [PR PATCH] New package: rust-analyzer-2020.07.13 gbrlsnchs
                   ` (10 preceding siblings ...)
  2020-09-21 14:58 ` [PR PATCH] [Closed]: " gbrlsnchs
@ 2020-09-21 23:23 ` gbrlsnchs
  2020-09-21 23:35 ` [PR PATCH] [Merged]: " jnbr
                   ` (2 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-21 23:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

New comment by gbrlsnchs on void-packages repository

https://github.com/void-linux/void-packages/pull/23623#issuecomment-696431720

Comment:
> Looks good to me.
> Sorry for the long delay.
> 
> I will merge it when CI passed.

Thanks. Do you want me to update it to the latest version? It just came out today...

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Merged]: New package: rust-analyzer-2020.09.14
  2020-07-17 18:54 [PR PATCH] New package: rust-analyzer-2020.07.13 gbrlsnchs
                   ` (11 preceding siblings ...)
  2020-09-21 23:23 ` gbrlsnchs
@ 2020-09-21 23:35 ` jnbr
  2020-09-21 23:36 ` jnbr
  2020-09-22  2:08 ` gbrlsnchs
  14 siblings, 0 replies; 16+ messages in thread
From: jnbr @ 2020-09-21 23:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

There's a merged pull request on the void-packages repository

New package: rust-analyzer-2020.09.14
https://github.com/void-linux/void-packages/pull/23623

Description:


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: rust-analyzer-2020.09.14
  2020-07-17 18:54 [PR PATCH] New package: rust-analyzer-2020.07.13 gbrlsnchs
                   ` (12 preceding siblings ...)
  2020-09-21 23:35 ` [PR PATCH] [Merged]: " jnbr
@ 2020-09-21 23:36 ` jnbr
  2020-09-22  2:08 ` gbrlsnchs
  14 siblings, 0 replies; 16+ messages in thread
From: jnbr @ 2020-09-21 23:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/23623#issuecomment-696435829

Comment:
I've seen you comment too late. Feel free to do the update in a new pull request.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: rust-analyzer-2020.09.14
  2020-07-17 18:54 [PR PATCH] New package: rust-analyzer-2020.07.13 gbrlsnchs
                   ` (13 preceding siblings ...)
  2020-09-21 23:36 ` jnbr
@ 2020-09-22  2:08 ` gbrlsnchs
  14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-22  2:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New comment by gbrlsnchs on void-packages repository

https://github.com/void-linux/void-packages/pull/23623#issuecomment-696473101

Comment:
No problem! Thanks!

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2020-09-22  2:08 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-17 18:54 [PR PATCH] New package: rust-analyzer-2020.07.13 gbrlsnchs
2020-07-17 21:07 ` [PR PATCH] [Updated] " gbrlsnchs
2020-08-09  9:37 ` [PR REVIEW] " jnbr
2020-08-09  9:40 ` jnbr
2020-08-09 19:44 ` ericonr
2020-08-11  2:18 ` [PR REVIEW] " gbrlsnchs
2020-08-11  2:23 ` gbrlsnchs
2020-08-11  2:37 ` ericonr
2020-09-15 18:56 ` [PR PATCH] [Updated] " gbrlsnchs
2020-09-15 18:58 ` New package: rust-analyzer-2020.09.14 gbrlsnchs
2020-09-15 19:05 ` [PR REVIEW] " gbrlsnchs
2020-09-21 14:58 ` [PR PATCH] [Closed]: " gbrlsnchs
2020-09-21 23:23 ` gbrlsnchs
2020-09-21 23:35 ` [PR PATCH] [Merged]: " jnbr
2020-09-21 23:36 ` jnbr
2020-09-22  2:08 ` gbrlsnchs

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git