[PR PATCH] qemu : fixed firmware path

[PR PATCH] qemu : fixed firmware path

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

There is a new pull request by pandom79 against master on the void-packages repository

https://github.com/pandom79/void-packages qemu
https://github.com/void-linux/void-packages/pull/23651

qemu : fixed firmware path
Hi,
the actual qemu version is built wrong. 
When libvirt start, it searchs firmware in **/usr/share/qemu/firmware** but the firmwares are installed in /usr/lib/qemu/firmware beacuse it has been set **--data-lib=/usr/lib**.
Deleting this setting , now libvirt works correctly and i can choice uefi firmware.
Before this was not possible.
Regards




A patch file from https://github.com/void-linux/void-packages/pull/23651.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qemu-23651.patch --]
[-- Type: text/x-diff, Size: 1132 bytes --]

From a59ada6905a44cbfe73eb70a812d95236835bb22 Mon Sep 17 00:00:00 2001
From: Domenico Panella <pandom79@gmail.com>
Date: Sun, 19 Jul 2020 11:19:22 +0200
Subject: [PATCH] qemu : fixed firmware path

---
 srcpkgs/qemu/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/qemu/template b/srcpkgs/qemu/template
index 5a32c5c1dd3..e1635cf560b 100644
--- a/srcpkgs/qemu/template
+++ b/srcpkgs/qemu/template
@@ -1,7 +1,7 @@
 # Template file for 'qemu'
 pkgname=qemu
 version=5.0.0
-revision=2
+revision=3
 short_desc="Open Source Processor Emulator"
 maintainer="Helmut Pozimski <helmut@pozimski.eu>"
 license="GPL-2.0-or-later, LGPL-2.1-or-later"
@@ -62,7 +62,7 @@ do_configure() {
 		--disable-xen --enable-tpm \
 		--enable-vhost-net --enable-vnc-png --enable-virtfs \
 		--enable-libusb --disable-glusterfs --enable-snappy --enable-usb-redir \
-		--enable-pie --localstatedir=/var --datadir=/usr/lib --enable-docs \
+		--enable-pie --localstatedir=/var --enable-docs \
 		$(vopt_enable virgl virglrenderer) $(vopt_enable opengl) $(vopt_enable spice) \
 		${want_sdl} \
 		$(vopt_enable smartcard) \

Re: qemu : fixed firmware path

[sgn]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23651#issuecomment-660618583

Comment:
Blocked by #23601 

Re: qemu : fixed firmware path

[sgn]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23651#issuecomment-660618583

Comment:
Blocked by #23601, supersedes #23597, fixes #23495 

Re: qemu : fixed firmware path

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by pandom79 on void-packages repository

https://github.com/void-linux/void-packages/pull/23651#issuecomment-660622697

Comment:
I spoke with phrdina via email a few days ago.
I did't know that he already create a pull request.
We can close this pr.

Re: [PR PATCH] [Closed]: qemu : fixed firmware path

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

There's a closed pull request on the void-packages repository

qemu : fixed firmware path
https://github.com/void-linux/void-packages/pull/23651

Description:
Hi,
the actual qemu version is built wrong. 
When libvirt start, it searchs firmware in **/usr/share/qemu/firmware** but the firmwares are installed in **/usr/lib/qemu/firmware** because it has been set **--data-lib=/usr/lib**.
Deleting this setting , now libvirt works correctly and i can choice uefi firmware.
Before this was not possible.
Regards

Re: [PR PATCH] [Updated] qemu : fixed firmware path

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

There is an updated pull request by pandom79 against master on the void-packages repository

https://github.com/pandom79/void-packages qemu
https://github.com/void-linux/void-packages/pull/23651

qemu : fixed firmware path
Hi,
the actual qemu version is built wrong. 
When libvirt start, it searchs firmware in **/usr/share/qemu/firmware** but the firmwares are installed in **/usr/lib/qemu/firmware** because it has been set **--data-lib=/usr/lib**.
Deleting this setting , now libvirt works correctly and i can choice uefi firmware.
Before this was not possible.
Regards




A patch file from https://github.com/void-linux/void-packages/pull/23651.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qemu-23651.patch --]
[-- Type: text/x-diff, Size: 1132 bytes --]

From a59ada6905a44cbfe73eb70a812d95236835bb22 Mon Sep 17 00:00:00 2001
From: Domenico Panella <pandom79@gmail.com>
Date: Sun, 19 Jul 2020 11:19:22 +0200
Subject: [PATCH] qemu : fixed firmware path

---
 srcpkgs/qemu/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/qemu/template b/srcpkgs/qemu/template
index 5a32c5c1dd3..e1635cf560b 100644
--- a/srcpkgs/qemu/template
+++ b/srcpkgs/qemu/template
@@ -1,7 +1,7 @@
 # Template file for 'qemu'
 pkgname=qemu
 version=5.0.0
-revision=2
+revision=3
 short_desc="Open Source Processor Emulator"
 maintainer="Helmut Pozimski <helmut@pozimski.eu>"
 license="GPL-2.0-or-later, LGPL-2.1-or-later"
@@ -62,7 +62,7 @@ do_configure() {
 		--disable-xen --enable-tpm \
 		--enable-vhost-net --enable-vnc-png --enable-virtfs \
 		--enable-libusb --disable-glusterfs --enable-snappy --enable-usb-redir \
-		--enable-pie --localstatedir=/var --datadir=/usr/lib --enable-docs \
+		--enable-pie --localstatedir=/var --enable-docs \
 		$(vopt_enable virgl virglrenderer) $(vopt_enable opengl) $(vopt_enable spice) \
 		${want_sdl} \
 		$(vopt_enable smartcard) \

Re: [PR PATCH] [Updated] qemu : fixed firmware path

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

There is an updated pull request by pandom79 against master on the void-packages repository

https://github.com/pandom79/void-packages qemu
https://github.com/void-linux/void-packages/pull/23651

qemu : fixed firmware path
Hi,
the actual qemu version is built wrong. 
When libvirt start, it searchs firmware in **/usr/share/qemu/firmware** but the firmwares are installed in **/usr/lib/qemu/firmware** because it has been set **--data-lib=/usr/lib**.
Deleting this setting , now libvirt works correctly and i can choice uefi firmware.
Before this was not possible.
Regards




A patch file from https://github.com/void-linux/void-packages/pull/23651.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qemu-23651.patch --]
[-- Type: text/x-diff, Size: 1132 bytes --]

From a59ada6905a44cbfe73eb70a812d95236835bb22 Mon Sep 17 00:00:00 2001
From: Domenico Panella <pandom79@gmail.com>
Date: Sun, 19 Jul 2020 11:19:22 +0200
Subject: [PATCH] qemu : fixed firmware path

---
 srcpkgs/qemu/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/qemu/template b/srcpkgs/qemu/template
index 5a32c5c1dd3..e1635cf560b 100644
--- a/srcpkgs/qemu/template
+++ b/srcpkgs/qemu/template
@@ -1,7 +1,7 @@
 # Template file for 'qemu'
 pkgname=qemu
 version=5.0.0
-revision=2
+revision=3
 short_desc="Open Source Processor Emulator"
 maintainer="Helmut Pozimski <helmut@pozimski.eu>"
 license="GPL-2.0-or-later, LGPL-2.1-or-later"
@@ -62,7 +62,7 @@ do_configure() {
 		--disable-xen --enable-tpm \
 		--enable-vhost-net --enable-vnc-png --enable-virtfs \
 		--enable-libusb --disable-glusterfs --enable-snappy --enable-usb-redir \
-		--enable-pie --localstatedir=/var --datadir=/usr/lib --enable-docs \
+		--enable-pie --localstatedir=/var --enable-docs \
 		$(vopt_enable virgl virglrenderer) $(vopt_enable opengl) $(vopt_enable spice) \
 		${want_sdl} \
 		$(vopt_enable smartcard) \

Re: [PR PATCH] [Updated] qemu : fixed firmware path

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

There is an updated pull request by pandom79 against master on the void-packages repository

https://github.com/pandom79/void-packages qemu
https://github.com/void-linux/void-packages/pull/23651

qemu : fixed firmware path
Hi,
the actual qemu version is built wrong. 
When libvirt start, it searchs firmware in **/usr/share/qemu/firmware** but the firmwares are installed in **/usr/lib/qemu/firmware** because it has been set **--data-lib=/usr/lib**.
Deleting this setting , now libvirt works correctly and i can choice uefi firmware.
Before this was not possible.
Regards




A patch file from https://github.com/void-linux/void-packages/pull/23651.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qemu-23651.patch --]
[-- Type: text/x-diff, Size: 3378 bytes --]

From a59ada6905a44cbfe73eb70a812d95236835bb22 Mon Sep 17 00:00:00 2001
From: Domenico Panella <pandom79@gmail.com>
Date: Sun, 19 Jul 2020 11:19:22 +0200
Subject: [PATCH 1/3] qemu : fixed firmware path

---
 srcpkgs/qemu/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/qemu/template b/srcpkgs/qemu/template
index 5a32c5c1dd3..e1635cf560b 100644
--- a/srcpkgs/qemu/template
+++ b/srcpkgs/qemu/template
@@ -1,7 +1,7 @@
 # Template file for 'qemu'
 pkgname=qemu
 version=5.0.0
-revision=2
+revision=3
 short_desc="Open Source Processor Emulator"
 maintainer="Helmut Pozimski <helmut@pozimski.eu>"
 license="GPL-2.0-or-later, LGPL-2.1-or-later"
@@ -62,7 +62,7 @@ do_configure() {
 		--disable-xen --enable-tpm \
 		--enable-vhost-net --enable-vnc-png --enable-virtfs \
 		--enable-libusb --disable-glusterfs --enable-snappy --enable-usb-redir \
-		--enable-pie --localstatedir=/var --datadir=/usr/lib --enable-docs \
+		--enable-pie --localstatedir=/var --enable-docs \
 		$(vopt_enable virgl virglrenderer) $(vopt_enable opengl) $(vopt_enable spice) \
 		${want_sdl} \
 		$(vopt_enable smartcard) \

From d64600e30744c327debdf52f92c5ad913a3f9998 Mon Sep 17 00:00:00 2001
From: Domenico Panella <pandom79@gmail.com>
Date: Mon, 20 Jul 2020 13:50:49 +0200
Subject: [PATCH 2/3] qemu : fixed firmware path

---
 srcpkgs/qemu/template | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/qemu/template b/srcpkgs/qemu/template
index e1635cf560b..caa2348fcfd 100644
--- a/srcpkgs/qemu/template
+++ b/srcpkgs/qemu/template
@@ -1,7 +1,7 @@
 # Template file for 'qemu'
 pkgname=qemu
 version=5.0.0
-revision=3
+revision=2
 short_desc="Open Source Processor Emulator"
 maintainer="Helmut Pozimski <helmut@pozimski.eu>"
 license="GPL-2.0-or-later, LGPL-2.1-or-later"
@@ -62,7 +62,7 @@ do_configure() {
 		--disable-xen --enable-tpm \
 		--enable-vhost-net --enable-vnc-png --enable-virtfs \
 		--enable-libusb --disable-glusterfs --enable-snappy --enable-usb-redir \
-		--enable-pie --localstatedir=/var --enable-docs \
+		--enable-pie --localstatedir=/var --datadir=/usr/lib --enable-docs \
 		$(vopt_enable virgl virglrenderer) $(vopt_enable opengl) $(vopt_enable spice) \
 		${want_sdl} \
 		$(vopt_enable smartcard) \
@@ -75,6 +75,7 @@ do_build() {
 	make ${makejobs}
 }
 do_install() {
+	
 	# Remove our strip(1) wrapper... E2BIG.
 	rm -f ${XBPS_WRAPPERDIR}/strip
 
@@ -82,6 +83,11 @@ do_install() {
 	# qemu-bridge-helper must be setuid for non privileged users.
 	chmod u+s ${DESTDIR}/usr/libexec/qemu-bridge-helper
 
+	#Symbolic link /usr/share/qemu/firmware -> /usr/lib/qemu/firmware
+	#to permit libvirtd to find the firmwares
+	vmkdir usr/share/qemu
+	ln -s /usr/lib/qemu/firmware ${DESTDIR}/usr/share/qemu/firmware 
+	
 	vsv qemu-ga
 }
 

From 31a7abc5407780b5ec821caf4379b65420ebcd6e Mon Sep 17 00:00:00 2001
From: Domenico Panella <pandom79@gmail.com>
Date: Mon, 20 Jul 2020 13:52:44 +0200
Subject: [PATCH 3/3] qemu : fixed firmware path

---
 srcpkgs/qemu/template | 1 -
 1 file changed, 1 deletion(-)

diff --git a/srcpkgs/qemu/template b/srcpkgs/qemu/template
index caa2348fcfd..eb90aa1b12e 100644
--- a/srcpkgs/qemu/template
+++ b/srcpkgs/qemu/template
@@ -75,7 +75,6 @@ do_build() {
 	make ${makejobs}
 }
 do_install() {
-	
 	# Remove our strip(1) wrapper... E2BIG.
 	rm -f ${XBPS_WRAPPERDIR}/strip
 

Re: [PR PATCH] [Updated] qemu : fixed firmware path

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

There is an updated pull request by pandom79 against master on the void-packages repository

https://github.com/pandom79/void-packages qemu
https://github.com/void-linux/void-packages/pull/23651

qemu : fixed firmware path
Hi,
the actual qemu version is built wrong. 
When libvirt start, it searchs firmware in **/usr/share/qemu/firmware** but the firmwares are installed in **/usr/lib/qemu/firmware** because it has been set **--data-lib=/usr/lib**.
Deleting this setting , now libvirt works correctly and i can choice uefi firmware.
Before this was not possible.
Regards




A patch file from https://github.com/void-linux/void-packages/pull/23651.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qemu-23651.patch --]
[-- Type: text/x-diff, Size: 801 bytes --]

From 67c51912613a50f3607468e83b42fc935f7ae216 Mon Sep 17 00:00:00 2001
From: Domenico Panella <pandom79@gmail.com>
Date: Sun, 19 Jul 2020 11:19:22 +0200
Subject: [PATCH] qemu : fixed firmware path

---
 srcpkgs/qemu/template | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/srcpkgs/qemu/template b/srcpkgs/qemu/template
index 5a32c5c1dd3..eb90aa1b12e 100644
--- a/srcpkgs/qemu/template
+++ b/srcpkgs/qemu/template
@@ -82,6 +82,11 @@ do_install() {
 	# qemu-bridge-helper must be setuid for non privileged users.
 	chmod u+s ${DESTDIR}/usr/libexec/qemu-bridge-helper
 
+	#Symbolic link /usr/share/qemu/firmware -> /usr/lib/qemu/firmware
+	#to permit libvirtd to find the firmwares
+	vmkdir usr/share/qemu
+	ln -s /usr/lib/qemu/firmware ${DESTDIR}/usr/share/qemu/firmware 
+	
 	vsv qemu-ga
 }
 

Re: qemu : fixed firmware path

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New comment by pandom79 on void-packages repository

https://github.com/void-linux/void-packages/pull/23651#issuecomment-660982036

Comment:
the symbolic link works for me.

Re: [PR PATCH] [Updated] qemu : fixed firmware path

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

There is an updated pull request by pandom79 against master on the void-packages repository

https://github.com/pandom79/void-packages qemu
https://github.com/void-linux/void-packages/pull/23651

qemu : fixed firmware path
Hi,
the actual qemu version is built wrong. 
When libvirt start, it searchs firmware in **/usr/share/qemu/firmware** but the firmwares are installed in **/usr/lib/qemu/firmware** because it has been set **--data-lib=/usr/lib**.
Deleting this setting , now libvirt works correctly and i can choice uefi firmware.
Before this was not possible.
Regards




A patch file from https://github.com/void-linux/void-packages/pull/23651.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qemu-23651.patch --]
[-- Type: text/x-diff, Size: 799 bytes --]

From fc54d2a8c6494ba3b6a1e8017cee03ebc1c9863a Mon Sep 17 00:00:00 2001
From: Domenico Panella <pandom79@gmail.com>
Date: Sun, 19 Jul 2020 11:19:22 +0200
Subject: [PATCH] qemu : fixed firmware path

---
 srcpkgs/qemu/template | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/srcpkgs/qemu/template b/srcpkgs/qemu/template
index 5a32c5c1dd3..c7d5f856816 100644
--- a/srcpkgs/qemu/template
+++ b/srcpkgs/qemu/template
@@ -82,6 +82,11 @@ do_install() {
 	# qemu-bridge-helper must be setuid for non privileged users.
 	chmod u+s ${DESTDIR}/usr/libexec/qemu-bridge-helper
 
+	#Symbolic link /usr/share/qemu/firmware -> /usr/lib/qemu/firmware
+	#to permit libvirtd to find the firmwares
+	vmkdir usr/share/qemu
+	ln -s /usr/lib/qemu/firmware ${DESTDIR}/usr/share/qemu/firmware
+
 	vsv qemu-ga
 }
 

Re: qemu : fixed firmware path

[sgn]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23651#issuecomment-661060275

Comment:
@pandom79 We'll use your old change instead.

Re: qemu : fixed firmware path

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by pandom79 on void-packages repository

https://github.com/void-linux/void-packages/pull/23651#issuecomment-661066587

Comment:
in fact, it seem more clean as workaround, however with a symlink it works.

Re: qemu : fixed firmware path

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by pandom79 on void-packages repository

https://github.com/void-linux/void-packages/pull/23651#issuecomment-661066587

Comment:
in fact, it seems more clean as workaround, however with a symlink it works.

Re: qemu : fixed firmware path

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New comment by pandom79 on void-packages repository

https://github.com/void-linux/void-packages/pull/23651#issuecomment-691908298

Comment:
Close this pr. It has been resolved by [24884](https://github.com/void-linux/void-packages/pull/24884)

Re: [PR PATCH] [Closed]: qemu : fixed firmware path

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

There's a closed pull request on the void-packages repository

qemu : fixed firmware path
https://github.com/void-linux/void-packages/pull/23651

Description:
Hi,
the actual qemu version is built wrong. 
When libvirt start, it searchs firmware in **/usr/share/qemu/firmware** but the firmwares are installed in **/usr/lib/qemu/firmware** because it has been set **--data-lib=/usr/lib**.
Deleting this setting , now libvirt works correctly and i can choice uefi firmware.
Before this was not possible.
Regards