Github messages for voidlinux
 help / color / mirror / Atom feed
From: ashpooljh <ashpooljh@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] New package: mattermost-desktop-4.5.2
Date: Sat, 25 Jul 2020 12:43:05 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23827@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

There is a new pull request by ashpooljh against master on the void-packages repository

https://github.com/ashpooljh/void-packages mattermost-desktop
https://github.com/void-linux/void-packages/pull/23827

New package: mattermost-desktop-4.5.2
OK, I know this is yet another Electron monstrosity [nobody ever asked for](https://github.com/void-linux/void-packages/issues?q=mattermost), but there are actually people out there using it. Believe it or not, I personally find it slightly less annoying than Slack. Even Stallman [recommends](https://stallman.org/slack.html) it!

By the way, this is my first attempt both at creating a Void package AND at building and packaging an Electron application, so it's probably a mess. I'm looking forward to receiving comments and remarks.

A patch file from https://github.com/void-linux/void-packages/pull/23827.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mattermost-desktop-23827.patch --]
[-- Type: text/x-diff, Size: 3810 bytes --]

From c2dd47e9e892731161fd900eaf3204a82fb6781a Mon Sep 17 00:00:00 2001
From: Artem Zhurikhin <ashpool@xecut.net>
Date: Sat, 25 Jul 2020 13:32:25 +0300
Subject: [PATCH] New package: mattermost-desktop-4.5.2

---
 .../patches/10-only-build-unpacked.patch      |  7 +++
 .../patches/20-create-desktop-file.patch      | 17 +++++++
 srcpkgs/mattermost-desktop/template           | 50 +++++++++++++++++++
 3 files changed, 74 insertions(+)
 create mode 100644 srcpkgs/mattermost-desktop/patches/10-only-build-unpacked.patch
 create mode 100644 srcpkgs/mattermost-desktop/patches/20-create-desktop-file.patch
 create mode 100644 srcpkgs/mattermost-desktop/template

diff --git a/srcpkgs/mattermost-desktop/patches/10-only-build-unpacked.patch b/srcpkgs/mattermost-desktop/patches/10-only-build-unpacked.patch
new file mode 100644
index 00000000000..7cbf34356a3
--- /dev/null
+++ b/srcpkgs/mattermost-desktop/patches/10-only-build-unpacked.patch
@@ -0,0 +1,7 @@
+--- electron-builder.json.orig	2020-07-25 12:41:25.091865817 +0300
++++ electron-builder.json	2020-07-25 12:41:41.889843654 +0300
+@@ -38,3 +38 @@
+-      "deb",
+-      "tar.gz",
+-      "appimage"
++      "dir"
diff --git a/srcpkgs/mattermost-desktop/patches/20-create-desktop-file.patch b/srcpkgs/mattermost-desktop/patches/20-create-desktop-file.patch
new file mode 100644
index 00000000000..8cb468d77b9
--- /dev/null
+++ b/srcpkgs/mattermost-desktop/patches/20-create-desktop-file.patch
@@ -0,0 +1,17 @@
+--- electron-builder.json.orig	2020-07-25 12:46:12.470489136 +0300
++++ electron-builder.json	2020-07-25 12:47:22.490397616 +0300
+@@ -52 +52,2 @@
+-          "README.md"
++          "README.md",
++          "Mattermost.desktop"
+--- resources/linux/Mattermost.desktop.orig	1970-01-01 03:00:00.000000000 +0300
++++ resources/linux/Mattermost.desktop		2020-07-25 12:49:12.938253258 +0300
+@@ -0,0 +1,8 @@
++[Desktop Entry]
++Name=Mattermost
++Comment=Mattermost Desktop application for Linux
++Exec=/usr/bin/mattermost-desktop/mattermost-desktop
++Terminal=false
++Type=Application
++Icon=/usr/libexec/mattermost-desktop/icon.svg
++Categories=Network;InstantMessaging;
diff --git a/srcpkgs/mattermost-desktop/template b/srcpkgs/mattermost-desktop/template
new file mode 100644
index 00000000000..81a4332e2e6
--- /dev/null
+++ b/srcpkgs/mattermost-desktop/template
@@ -0,0 +1,50 @@
+# Template file for 'mattermost-desktop'
+pkgname=mattermost-desktop
+version=4.5.2
+revision=1
+archs="x86_64"  # no musl due to electron
+wrksrc="mattermost-desktop-${version}"
+# electron-builder needs GNU tar
+hostmakedepends="git wget nodejs-lts-10 python libicns GraphicsMagick xz tar"
+short_desc="Team messaging app, an open source Slack alternative"
+maintainer="Artem Zhurikhin <ashpool@xecut.net>"
+license="Apache-2.0"
+homepage="https://mattermost.com/"
+checksum=17e32346592d175f091a4f12068e0cfc5cfd20ed7894f88bb5b54b2eb6eac74a
+
+# In the source archive the top-level dir is named "desktop-${version}/"
+# It does not contain the name of the package, so we need custom fetch & extract
+
+_disturl="https://github.com/mattermost/desktop/archive/v${version}.tar.gz"
+_distfile="mattermost-desktop-${version}.tar.gz"
+
+do_fetch() {
+	wget -O "${_distfile}" "${_disturl}"
+}
+
+do_extract() {
+	pwd
+	bsdtar -C ${wrksrc} \
+		-xzf "${XBPS_BUILDDIR}/${_distfile}" \
+		--strip-components=1 \
+		desktop-${version}
+}
+
+pre_build() {
+	rm package-lock.json ||:  # Is it even OK to leave this in the distribution?
+	npm install
+}
+
+do_build() {
+	npm run build
+	npm run package:linux
+}
+
+do_install() {
+	cd release/linux-unpacked
+	vmkdir usr/libexec/${pkgname}
+	vcopy . usr/libexec/${pkgname}
+	vinstall Mattermost.desktop 644 usr/share/applications
+	vmkdir usr/bin
+	ln -s ../libexec/mattermost-desktop ${DESTDIR}/usr/bin/mattermost-desktop
+}

             reply	other threads:[~2020-07-25 10:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-25 10:43 ashpooljh [this message]
2020-07-25 10:55 ` [PR REVIEW] " pullmoll
2020-07-25 10:58 ` pullmoll
2020-07-25 11:04 ` ashpooljh
2020-07-25 11:07 ` ashpooljh
2020-07-25 11:08 ` pullmoll
2020-07-25 11:09 ` pullmoll
2020-07-25 11:09 ` ashpooljh
2020-07-25 11:56 ` [PR PATCH] [Updated] " ashpooljh
2020-07-25 12:14 ` ashpooljh
2020-07-25 16:23 ` [PR PATCH] [Updated] " ashpooljh
2020-07-25 16:32 ` ashpooljh
2020-07-25 16:46 ` ashpooljh
2020-07-25 17:01 ` [PR PATCH] [Updated] " ashpooljh
2020-07-25 17:02 ` ashpooljh
2020-07-26 11:24 ` [PR REVIEW] " pullmoll
2020-07-26 11:25 ` pullmoll
2020-07-26 11:38 ` [PR PATCH] [Updated] " ashpooljh
2020-07-26 12:07 ` [PR REVIEW] " ashpooljh
2020-07-26 13:49 ` [PR PATCH] [Merged]: " pullmoll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23827@inbox.vuxu.org \
    --to=ashpooljh@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).