Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] new package: onedrive-2.4.3
@ 2020-07-28 15:01 selfisekai
  2020-07-28 15:17 ` [PR REVIEW] " ericonr
                   ` (22 more replies)
  0 siblings, 23 replies; 24+ messages in thread
From: selfisekai @ 2020-07-28 15:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

There is a new pull request by selfisekai against master on the void-packages repository

https://github.com/selfisekai/void-packages onedrive-service
https://github.com/void-linux/void-packages/pull/23898

new package: onedrive-2.4.3
https://github.com/abraunegg/onedrive

A patch file from https://github.com/void-linux/void-packages/pull/23898.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-onedrive-service-23898.patch --]
[-- Type: text/x-diff, Size: 1713 bytes --]

From 005e96f1b857c6c367af19c24006e6ef14d76b8c Mon Sep 17 00:00:00 2001
From: selfisekai <laura@selfisekai.rocks>
Date: Tue, 28 Jul 2020 16:42:18 +0200
Subject: [PATCH] new package: onedrive-2.4.3

---
 srcpkgs/onedrive/files/onedrive/run |  2 ++
 srcpkgs/onedrive/template           | 22 ++++++++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100644 srcpkgs/onedrive/files/onedrive/run
 create mode 100644 srcpkgs/onedrive/template

diff --git a/srcpkgs/onedrive/files/onedrive/run b/srcpkgs/onedrive/files/onedrive/run
new file mode 100644
index 00000000000..2d3e5d51c79
--- /dev/null
+++ b/srcpkgs/onedrive/files/onedrive/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec onedrive --monitor
\ No newline at end of file
diff --git a/srcpkgs/onedrive/template b/srcpkgs/onedrive/template
new file mode 100644
index 00000000000..0d300960b65
--- /dev/null
+++ b/srcpkgs/onedrive/template
@@ -0,0 +1,22 @@
+# Template file for 'onedrive'
+pkgname=onedrive
+version=2.4.3
+revision=1
+wrksrc="onedrive-${version}"
+build_style=gnu-configure
+configure_args="DC=ldc2 --bindir=/usr/bin"
+depends="curl"
+hostmakedepends="ldc pkg-config"
+makedepends="libcurl-devel sqlite-devel libnotify-devel"
+short_desc="Maintained client for Microsoft OneDrive"
+maintainer="selfisekai <laura@selfisekai.rocks>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/abraunegg/onedrive"
+changelog="https://raw.githubusercontent.com/abraunegg/onedrive/v${version}/CHANGELOG.md"
+distfiles="https://github.com/abraunegg/onedrive/archive/v${version}.tar.gz"
+checksum=4236f436b3658e360164d945a8bc5c9620539c1339ef9182e3d060d2e3b90b9b
+
+post_install() {
+	vinstall config 644 usr/share/onedrive config.default
+	vsv onedrive
+}

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
@ 2020-07-28 15:17 ` ericonr
  2020-07-28 15:17 ` ericonr
                   ` (21 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2020-07-28 15:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461662396

Comment:
You can use their About from GH: "OneDrive Client for Linux"

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
  2020-07-28 15:17 ` [PR REVIEW] " ericonr
  2020-07-28 15:17 ` ericonr
@ 2020-07-28 15:17 ` ericonr
  2020-07-28 15:17 ` ericonr
                   ` (19 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2020-07-28 15:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461662617

Comment:
This should be the default wrksrc

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
  2020-07-28 15:17 ` [PR REVIEW] " ericonr
@ 2020-07-28 15:17 ` ericonr
  2020-07-28 15:17 ` ericonr
                   ` (20 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2020-07-28 15:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461663899

Comment:
Should this service be run as root?

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (2 preceding siblings ...)
  2020-07-28 15:17 ` ericonr
@ 2020-07-28 15:17 ` ericonr
  2020-07-28 15:17 ` ericonr
                   ` (18 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2020-07-28 15:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461662990

Comment:
The build style has `bindir` set up.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (3 preceding siblings ...)
  2020-07-28 15:17 ` ericonr
@ 2020-07-28 15:17 ` ericonr
  2020-07-28 15:17 ` ericonr
                   ` (17 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2020-07-28 15:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461662617

Comment:
This is he default wrksrc

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (4 preceding siblings ...)
  2020-07-28 15:17 ` ericonr
@ 2020-07-28 15:17 ` ericonr
  2020-07-28 15:18 ` ericonr
                   ` (16 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2020-07-28 15:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461662617

Comment:
This is the default wrksrc

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (5 preceding siblings ...)
  2020-07-28 15:17 ` ericonr
@ 2020-07-28 15:18 ` ericonr
  2020-07-28 15:30 ` daniel-eys
                   ` (15 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2020-07-28 15:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461662990

Comment:
The build style already has `bindir` set up.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (6 preceding siblings ...)
  2020-07-28 15:18 ` ericonr
@ 2020-07-28 15:30 ` daniel-eys
  2020-07-28 15:31 ` [PR REVIEW] " selfisekai
                   ` (14 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: daniel-eys @ 2020-07-28 15:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#issuecomment-665109598

Comment:
There's already `onedrive-d` with the former upstream where this fork originated from.
I'd suggest to update `onedrive-d` instead of introducing a new template, so users with `onedrive-d` already installed get this update as well with their next system upgrade.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (7 preceding siblings ...)
  2020-07-28 15:30 ` daniel-eys
@ 2020-07-28 15:31 ` selfisekai
  2020-07-28 15:33 ` daniel-eys
                   ` (13 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: selfisekai @ 2020-07-28 15:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

New review comment by selfisekai on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461674592

Comment:
that's what maintaners seem to encourage here: https://github.com/abraunegg/onedrive/blob/master/docs/USAGE.md#running-onedrive-as-a-system-service, but I can change that

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (8 preceding siblings ...)
  2020-07-28 15:31 ` [PR REVIEW] " selfisekai
@ 2020-07-28 15:33 ` daniel-eys
  2020-07-28 15:38 ` ericonr
                   ` (12 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: daniel-eys @ 2020-07-28 15:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New review comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461675651

Comment:
Does this really need `/usr/bin/curl` at runtime?


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (9 preceding siblings ...)
  2020-07-28 15:33 ` daniel-eys
@ 2020-07-28 15:38 ` ericonr
  2020-07-28 15:39 ` selfisekai
                   ` (11 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2020-07-28 15:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461679568

Comment:
They have instructions for running as user, which is the bet way, IMO. https://github.com/abraunegg/onedrive/blob/master/docs/USAGE.md#onedrive-service-running-as-a-non-root-user-via-systemd-with-notifications-enabled-arch-ubuntu-debian-opensuse-fedora

Running something like this as root isn't great practice. I don't think we should include the service.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (10 preceding siblings ...)
  2020-07-28 15:38 ` ericonr
@ 2020-07-28 15:39 ` selfisekai
  2020-07-28 15:42 ` ericonr
                   ` (10 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: selfisekai @ 2020-07-28 15:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by selfisekai on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461680471

Comment:
I don't really know

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (11 preceding siblings ...)
  2020-07-28 15:39 ` selfisekai
@ 2020-07-28 15:42 ` ericonr
  2020-07-28 15:47 ` ahesford
                   ` (9 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2020-07-28 15:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461682294

Comment:
I don't think so, since it uses libcurl directly.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (12 preceding siblings ...)
  2020-07-28 15:42 ` ericonr
@ 2020-07-28 15:47 ` ahesford
  2020-07-28 15:47 ` ahesford
                   ` (8 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ahesford @ 2020-07-28 15:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461675002

Comment:
Move `depends` after `hostmakedepends` and `depends`.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (13 preceding siblings ...)
  2020-07-28 15:47 ` ahesford
@ 2020-07-28 15:47 ` ahesford
  2020-07-28 15:47 ` ahesford
                   ` (7 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ahesford @ 2020-07-28 15:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461677212

Comment:
If this is not intended to be run as root (and I suspect it isn't), the service should be removed. You can define a [per-user service](https://docs.voidlinux.org/config/services/user-services.html) to manage this locally, but there is no mechanism to support per-user services in XBPS packages.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (14 preceding siblings ...)
  2020-07-28 15:47 ` ahesford
@ 2020-07-28 15:47 ` ahesford
  2020-07-28 15:56 ` ahesford
                   ` (6 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ahesford @ 2020-07-28 15:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461674615

Comment:
Add `nocross="uses host flags for cross compilations"` because this will not cross build.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (15 preceding siblings ...)
  2020-07-28 15:47 ` ahesford
@ 2020-07-28 15:56 ` ahesford
  2020-07-28 15:56 ` ahesford
                   ` (5 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ahesford @ 2020-07-28 15:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461692503

Comment:
The "run as root" directions actually include `systemctl --user`, which is *not* a system-level service and will *not* run as root. It will run as the user that invokes `systemctl`. Down the page, there are instructions that load a system-level service as root, but that seems like a terrible idea to sync user-level files.

My suspicion is that the authors of this package don't thoroughly understand `systemd` task management.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (16 preceding siblings ...)
  2020-07-28 15:56 ` ahesford
@ 2020-07-28 15:56 ` ahesford
  2020-07-28 15:58 ` ahesford
                   ` (4 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ahesford @ 2020-07-28 15:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461692503

Comment:
The "run as root" directions actually include `systemctl --user`, which is *not* a system-level service and will *not* run as root. It will run as the user that invokes `systemctl`. Down the page, there are instructions that load a system-level service as root, but that seems like a terrible idea to sync user-level files.

My suspicion is that the authors of this upstream package don't thoroughly understand `systemd` task management.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (17 preceding siblings ...)
  2020-07-28 15:56 ` ahesford
@ 2020-07-28 15:58 ` ahesford
  2020-07-28 16:11 ` [PR REVIEW] " selfisekai
                   ` (3 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ahesford @ 2020-07-28 15:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#issuecomment-665125177

Comment:
> There's already `onedrive-d` with the former upstream where this fork originated from.
> I'd suggest to update `onedrive-d` instead of introducing a new template, so users with `onedrive-d` already installed get this update as well with their next system upgrade.

The `onedrive-d` package is already misnamed, so we can take this opportunity to transition to a properly named package and make `onedrive-d` a meta that pulls in the new one.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (18 preceding siblings ...)
  2020-07-28 15:58 ` ahesford
@ 2020-07-28 16:11 ` selfisekai
  2020-07-28 16:15 ` [PR PATCH] [Updated] " selfisekai
                   ` (2 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: selfisekai @ 2020-07-28 16:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New review comment by selfisekai on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461702689

Comment:
removing `depends` at all as it's invalid: https://github.com/void-linux/void-packages/pull/23898#discussion_r461682294

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (19 preceding siblings ...)
  2020-07-28 16:11 ` [PR REVIEW] " selfisekai
@ 2020-07-28 16:15 ` selfisekai
  2020-07-28 16:18 ` [PR REVIEW] " selfisekai
  2020-07-28 16:38 ` [PR PATCH] [Merged]: " ahesford
  22 siblings, 0 replies; 24+ messages in thread
From: selfisekai @ 2020-07-28 16:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

There is an updated pull request by selfisekai against master on the void-packages repository

https://github.com/selfisekai/void-packages onedrive-service
https://github.com/void-linux/void-packages/pull/23898

new package: onedrive-2.4.3
https://github.com/abraunegg/onedrive

A patch file from https://github.com/void-linux/void-packages/pull/23898.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-onedrive-service-23898.patch --]
[-- Type: text/x-diff, Size: 3039 bytes --]

From 8fc008f97e797bcaa1ab308c724e641d5116e0bc Mon Sep 17 00:00:00 2001
From: selfisekai <laura@selfisekai.rocks>
Date: Tue, 28 Jul 2020 16:42:18 +0200
Subject: [PATCH] new package: onedrive-2.4.3

---
 srcpkgs/onedrive-d          |  1 +
 srcpkgs/onedrive-d/template | 28 ----------------------------
 srcpkgs/onedrive/template   | 26 ++++++++++++++++++++++++++
 3 files changed, 27 insertions(+), 28 deletions(-)
 create mode 120000 srcpkgs/onedrive-d
 delete mode 100644 srcpkgs/onedrive-d/template
 create mode 100644 srcpkgs/onedrive/template

diff --git a/srcpkgs/onedrive-d b/srcpkgs/onedrive-d
new file mode 120000
index 00000000000..fee711d1d52
--- /dev/null
+++ b/srcpkgs/onedrive-d
@@ -0,0 +1 @@
+onedrive
\ No newline at end of file
diff --git a/srcpkgs/onedrive-d/template b/srcpkgs/onedrive-d/template
deleted file mode 100644
index 7d744fbf38c..00000000000
--- a/srcpkgs/onedrive-d/template
+++ /dev/null
@@ -1,28 +0,0 @@
-# Template file for 'onedrive-d'
-pkgname=onedrive-d
-version=1.1.3
-revision=1
-wrksrc="onedrive-${version}"
-build_style=gnu-makefile
-hostmakedepends="dmd"
-makedepends="libcurl-devel sqlite-devel"
-short_desc="Free Client for OneDrive on Linux"
-maintainer="ibrokemypie <ibrokemypie@bastardi.net>"
-license="GPL-3.0-or-later"
-homepage="https://github.com/skilion/onedrive"
-changelog="https://raw.githubusercontent.com/skilion/onedrive/master/CHANGELOG.md"
-distfiles="https://github.com/skilion/onedrive/archive/v${version}.tar.gz"
-checksum=fb12235a73919b3374b8f27785b834a690fba1c6e70c6e6f1f5da3e51eb471a0
-nocross="https://build.voidlinux.org/builders/armv7l_builder/builds/3910/steps/shell_3/logs/stdio"
-
-pre_build() {
-	printf 'v%s\n' "$pkgver" > version
-	sed -i '/^onedrive:/ s/version //' Makefile
-	sed -i 's/std\.c\./core.stdc./g' src/sqlite.d
-}
-
-post_install() {
-	vinstall config 644 usr/share/onedrive config.default
-	# We don't care about the systemd service installed here.
-	rm -rf ${DESTDIR}/usr/lib/systemd
-}
diff --git a/srcpkgs/onedrive/template b/srcpkgs/onedrive/template
new file mode 100644
index 00000000000..85923b540c3
--- /dev/null
+++ b/srcpkgs/onedrive/template
@@ -0,0 +1,26 @@
+# Template file for 'onedrive'
+pkgname=onedrive
+version=2.4.3
+revision=1
+build_style=gnu-configure
+configure_args="DC=ldc2"
+hostmakedepends="ldc pkg-config"
+makedepends="libcurl-devel sqlite-devel libnotify-devel"
+short_desc="OneDrive Client for Linux"
+maintainer="selfisekai <laura@selfisekai.rocks>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/abraunegg/onedrive"
+changelog="https://raw.githubusercontent.com/abraunegg/onedrive/v${version}/CHANGELOG.md"
+distfiles="https://github.com/abraunegg/onedrive/archive/v${version}.tar.gz"
+checksum=4236f436b3658e360164d945a8bc5c9620539c1339ef9182e3d060d2e3b90b9b
+nocross="uses host flags for cross compilations"
+
+post_install() {
+	vinstall config 644 usr/share/onedrive config.default
+}
+
+onedrive-d_package() {
+	build_style=meta
+	depends="${sourcepkg}"
+	short_desc+=" (transitional dummy package)"
+}

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (20 preceding siblings ...)
  2020-07-28 16:15 ` [PR PATCH] [Updated] " selfisekai
@ 2020-07-28 16:18 ` selfisekai
  2020-07-28 16:38 ` [PR PATCH] [Merged]: " ahesford
  22 siblings, 0 replies; 24+ messages in thread
From: selfisekai @ 2020-07-28 16:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by selfisekai on void-packages repository

https://github.com/void-linux/void-packages/pull/23898#discussion_r461707226

Comment:
the service is removed now

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Merged]: new package: onedrive-2.4.3
  2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
                   ` (21 preceding siblings ...)
  2020-07-28 16:18 ` [PR REVIEW] " selfisekai
@ 2020-07-28 16:38 ` ahesford
  22 siblings, 0 replies; 24+ messages in thread
From: ahesford @ 2020-07-28 16:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

There's a merged pull request on the void-packages repository

new package: onedrive-2.4.3
https://github.com/void-linux/void-packages/pull/23898

Description:
https://github.com/abraunegg/onedrive

^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2020-07-28 16:38 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 15:01 [PR PATCH] new package: onedrive-2.4.3 selfisekai
2020-07-28 15:17 ` [PR REVIEW] " ericonr
2020-07-28 15:17 ` ericonr
2020-07-28 15:17 ` ericonr
2020-07-28 15:17 ` ericonr
2020-07-28 15:17 ` ericonr
2020-07-28 15:17 ` ericonr
2020-07-28 15:18 ` ericonr
2020-07-28 15:30 ` daniel-eys
2020-07-28 15:31 ` [PR REVIEW] " selfisekai
2020-07-28 15:33 ` daniel-eys
2020-07-28 15:38 ` ericonr
2020-07-28 15:39 ` selfisekai
2020-07-28 15:42 ` ericonr
2020-07-28 15:47 ` ahesford
2020-07-28 15:47 ` ahesford
2020-07-28 15:47 ` ahesford
2020-07-28 15:56 ` ahesford
2020-07-28 15:56 ` ahesford
2020-07-28 15:58 ` ahesford
2020-07-28 16:11 ` [PR REVIEW] " selfisekai
2020-07-28 16:15 ` [PR PATCH] [Updated] " selfisekai
2020-07-28 16:18 ` [PR REVIEW] " selfisekai
2020-07-28 16:38 ` [PR PATCH] [Merged]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).