* [PR PATCH] kdegraphics-thumbnailers: Add ffmpeg dependency
@ 2020-07-30 0:50 cinerea0
2020-07-30 2:37 ` cinerea0
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: cinerea0 @ 2020-07-30 0:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
There is a new pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages kdegraphics
https://github.com/void-linux/void-packages/pull/23936
kdegraphics-thumbnailers: Add ffmpeg dependency
This commit adds `ffmpegthumbnailer` as a dependency; this eases the process of enabling thumbnails in Dolphin.
A patch file from https://github.com/void-linux/void-packages/pull/23936.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kdegraphics-23936.patch --]
[-- Type: text/x-diff, Size: 1062 bytes --]
From 8e52951d6f22e991c69bed6212f9e2b4c5f37a10 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Wed, 29 Jul 2020 20:47:29 -0400
Subject: [PATCH] kdegraphics-thumbnailers: Add ffmpeg dependency
---
srcpkgs/kdegraphics-thumbnailers/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/kdegraphics-thumbnailers/template b/srcpkgs/kdegraphics-thumbnailers/template
index 194005ad9d5..327a8664bd4 100644
--- a/srcpkgs/kdegraphics-thumbnailers/template
+++ b/srcpkgs/kdegraphics-thumbnailers/template
@@ -1,11 +1,11 @@
# Template file for 'kdegraphics-thumbnailers'
pkgname=kdegraphics-thumbnailers
version=20.04.3
-revision=1
+revision=2
build_style=cmake
hostmakedepends="extra-cmake-modules kcoreaddons kconfig-devel pkg-config gettext"
makedepends="qt5-devel kio-devel libkexiv25-devel"
-depends="ghostscript"
+depends="ffmpegthumbnailer ghostscript"
short_desc="KDE Plasma 5 Thumbnailers for various graphics file formats"
maintainer="1is7ac3 <isaac.qa13@gmail.com>"
license="GPL-2.0-or-later"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: kdegraphics-thumbnailers: Add ffmpeg dependency
2020-07-30 0:50 [PR PATCH] kdegraphics-thumbnailers: Add ffmpeg dependency cinerea0
@ 2020-07-30 2:37 ` cinerea0
2020-07-31 10:09 ` Johnnynator
2020-07-31 10:09 ` [PR PATCH] [Closed]: " Johnnynator
2 siblings, 0 replies; 4+ messages in thread
From: cinerea0 @ 2020-07-30 2:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 219 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/23936#issuecomment-666050823
Comment:
It was suggested that I ping @1is7ac3 and @Johnnynator for review on this PR.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: kdegraphics-thumbnailers: Add ffmpeg dependency
2020-07-30 0:50 [PR PATCH] kdegraphics-thumbnailers: Add ffmpeg dependency cinerea0
2020-07-30 2:37 ` cinerea0
@ 2020-07-31 10:09 ` Johnnynator
2020-07-31 10:09 ` [PR PATCH] [Closed]: " Johnnynator
2 siblings, 0 replies; 4+ messages in thread
From: Johnnynator @ 2020-07-31 10:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
New comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/23936#issuecomment-667045905
Comment:
Nope, kdegraphics-thumbnailers does not use ffmpegthumbnailer anywhere. So adding it as a dep is wrong. Also the correct way to get video thumbnails would be `ffmpegthumbs` not `ffmpegthumbnailer`. But `ffmpegthumbs` and ` kdegraphics-thumbnailers` work independently of each other
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PR PATCH] [Closed]: kdegraphics-thumbnailers: Add ffmpeg dependency
2020-07-30 0:50 [PR PATCH] kdegraphics-thumbnailers: Add ffmpeg dependency cinerea0
2020-07-30 2:37 ` cinerea0
2020-07-31 10:09 ` Johnnynator
@ 2020-07-31 10:09 ` Johnnynator
2 siblings, 0 replies; 4+ messages in thread
From: Johnnynator @ 2020-07-31 10:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 292 bytes --]
There's a closed pull request on the void-packages repository
kdegraphics-thumbnailers: Add ffmpeg dependency
https://github.com/void-linux/void-packages/pull/23936
Description:
This commit adds `ffmpegthumbnailer` as a dependency; this eases the process of enabling thumbnails in Dolphin.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-31 10:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30 0:50 [PR PATCH] kdegraphics-thumbnailers: Add ffmpeg dependency cinerea0
2020-07-30 2:37 ` cinerea0
2020-07-31 10:09 ` Johnnynator
2020-07-31 10:09 ` [PR PATCH] [Closed]: " Johnnynator
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).