Github messages for voidlinux
 help / color / Atom feed
* [PR PATCH] perl-module: add perl to build depends
@ 2020-07-30  4:02 zdykstra
  2020-07-30  4:27 ` ericonr
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: zdykstra @ 2020-07-30  4:02 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

There is a new pull request by zdykstra against master on the void-packages repository

https://github.com/zdykstra/void-packages perl-module
https://github.com/void-linux/void-packages/pull/23942

perl-module: add perl to build depends
There are 456 packages with a build style of `perl-module`. Of those 455 have `perl` explicitly set for `$hostmakedepends` and 425 have `perl` set for `$makedepends`. 

I'm not sure it's reasonable to retroactively fix all of the templates using the `perl-module` build style, but future updates of templates can be cleaned up.

A patch file from https://github.com/void-linux/void-packages/pull/23942.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-perl-module-23942.patch --]
[-- Type: text/x-diff, Size: 635 bytes --]

From 023f6f75086cd8564001affc64744d54a072a300 Mon Sep 17 00:00:00 2001
From: Zach Dykstra <dykstra.zachary@gmail.com>
Date: Wed, 29 Jul 2020 22:58:23 -0500
Subject: [PATCH] perl-module: add perl to build depends

---
 common/environment/build-style/perl-module.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/environment/build-style/perl-module.sh b/common/environment/build-style/perl-module.sh
index 2444d3d104f..60d67713147 100644
--- a/common/environment/build-style/perl-module.sh
+++ b/common/environment/build-style/perl-module.sh
@@ -1 +1,3 @@
+hostmakedepends+=" perl"
+makedepends+=" perl"
 lib32disabled=yes

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: perl-module: add perl to build depends
  2020-07-30  4:02 [PR PATCH] perl-module: add perl to build depends zdykstra
@ 2020-07-30  4:27 ` ericonr
  2020-07-30  4:27 ` ericonr
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2020-07-30  4:27 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23942#issuecomment-666096695

Comment:
I've made some changes to templates in how dependencies are pulled in, and didn't revbump those, only the packages that would actually change, so you wouldn't need to trigger a rebuild of 455 packages. I think it makes more sense to make this change for all templates in this PR, otherwise you will need to add an xlint for it or most packages won't be cleaned up...

Might be nice to add a note in the manual that the `perl-module` build style pulls in perl by itself too.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: perl-module: add perl to build depends
  2020-07-30  4:02 [PR PATCH] perl-module: add perl to build depends zdykstra
  2020-07-30  4:27 ` ericonr
@ 2020-07-30  4:27 ` ericonr
  2020-07-30  4:35 ` zdykstra
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2020-07-30  4:27 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23942#issuecomment-666097023

Comment:
Might make sense to wait for an ok for this change before going to all the trouble, of course. And perhaps have the change as a single commit? "tree-wide: ..."

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: perl-module: add perl to build depends
  2020-07-30  4:02 [PR PATCH] perl-module: add perl to build depends zdykstra
  2020-07-30  4:27 ` ericonr
  2020-07-30  4:27 ` ericonr
@ 2020-07-30  4:35 ` zdykstra
  2020-07-30  4:38 ` zdykstra
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: zdykstra @ 2020-07-30  4:35 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/23942#issuecomment-666100003

Comment:
> I've made some changes to templates in how dependencies are pulled in, and didn't revbump those, only the packages that would actually change, so you wouldn't need to trigger a rebuild of 455 packages. I think it makes more sense to make this change for all templates in this PR, otherwise you will need to add an xlint for it or most packages won't be cleaned up...
> 
> Might be nice to add a note in the manual that the `perl-module` build style pulls in perl by itself too.

That's a good point about `xlint`. I can look at adding a rule there to warn about perl being explicitly set in makedepends/hostmakedepends.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: perl-module: add perl to build depends
  2020-07-30  4:02 [PR PATCH] perl-module: add perl to build depends zdykstra
                   ` (2 preceding siblings ...)
  2020-07-30  4:35 ` zdykstra
@ 2020-07-30  4:38 ` zdykstra
  2020-07-30  4:40 ` [PR PATCH] [Updated] " zdykstra
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: zdykstra @ 2020-07-30  4:38 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/23942#issuecomment-666101199

Comment:
> I like the idea. It could also add `perl` to `depends`.

That seems reasonable - there are three other build styles that do it as well. 

```
$ grep "^depends+" *
gem.sh:depends+=" ruby"
R-cran.sh:depends+=" R"
raku-dist.sh:depends+=" rakudo"
```


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] perl-module: add perl to build depends
  2020-07-30  4:02 [PR PATCH] perl-module: add perl to build depends zdykstra
                   ` (3 preceding siblings ...)
  2020-07-30  4:38 ` zdykstra
@ 2020-07-30  4:40 ` zdykstra
  2020-07-30  4:51 ` zdykstra
  2020-08-04 13:10 ` [PR PATCH] [Merged]: " leahneukirchen
  6 siblings, 0 replies; 8+ messages in thread
From: zdykstra @ 2020-07-30  4:40 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

There is an updated pull request by zdykstra against master on the void-packages repository

https://github.com/zdykstra/void-packages perl-module
https://github.com/void-linux/void-packages/pull/23942

perl-module: add perl to build depends
There are 456 packages with a build style of `perl-module`. Of those 455 have `perl` explicitly set for `$hostmakedepends` and 425 have `perl` set for `$makedepends`. 

I'm not sure it's reasonable to retroactively fix all of the templates using the `perl-module` build style, but future updates of templates can be cleaned up.

A patch file from https://github.com/void-linux/void-packages/pull/23942.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-perl-module-23942.patch --]
[-- Type: text/x-diff, Size: 654 bytes --]

From 6b4ed02fdd23c061f0cf78eb20b6fa8109146e8d Mon Sep 17 00:00:00 2001
From: Zach Dykstra <dykstra.zachary@gmail.com>
Date: Wed, 29 Jul 2020 22:58:23 -0500
Subject: [PATCH] perl-module: add perl to build depends

---
 common/environment/build-style/perl-module.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/common/environment/build-style/perl-module.sh b/common/environment/build-style/perl-module.sh
index 2444d3d104f..300ed9b5db6 100644
--- a/common/environment/build-style/perl-module.sh
+++ b/common/environment/build-style/perl-module.sh
@@ -1 +1,4 @@
+hostmakedepends+=" perl"
+makedepends+=" perl"
+depends+=" perl"
 lib32disabled=yes

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: perl-module: add perl to build depends
  2020-07-30  4:02 [PR PATCH] perl-module: add perl to build depends zdykstra
                   ` (4 preceding siblings ...)
  2020-07-30  4:40 ` [PR PATCH] [Updated] " zdykstra
@ 2020-07-30  4:51 ` zdykstra
  2020-08-04 13:10 ` [PR PATCH] [Merged]: " leahneukirchen
  6 siblings, 0 replies; 8+ messages in thread
From: zdykstra @ 2020-07-30  4:51 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/23942#issuecomment-666101199

Comment:
> I like the idea. It could also add `perl` to `depends`.

That seems reasonable - there are three other build styles that do it as well. 

```
$ grep "^depends+" *
gem.sh:depends+=" ruby"
R-cran.sh:depends+=" R"
raku-dist.sh:depends+=" rakudo"
```

I've added it in to `perl-module.sh` as well.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Merged]: perl-module: add perl to build depends
  2020-07-30  4:02 [PR PATCH] perl-module: add perl to build depends zdykstra
                   ` (5 preceding siblings ...)
  2020-07-30  4:51 ` zdykstra
@ 2020-08-04 13:10 ` leahneukirchen
  6 siblings, 0 replies; 8+ messages in thread
From: leahneukirchen @ 2020-08-04 13:10 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

There's a merged pull request on the void-packages repository

perl-module: add perl to build depends
https://github.com/void-linux/void-packages/pull/23942

Description:
There are 456 packages with a build style of `perl-module`. Of those, 455 have `perl` explicitly set for `$hostmakedepends` and 425 have `perl` set for `$makedepends`. 

I'm not sure it's reasonable to retroactively fix all of the templates using the `perl-module` build style, but future updates of templates can be cleaned up.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30  4:02 [PR PATCH] perl-module: add perl to build depends zdykstra
2020-07-30  4:27 ` ericonr
2020-07-30  4:27 ` ericonr
2020-07-30  4:35 ` zdykstra
2020-07-30  4:38 ` zdykstra
2020-07-30  4:40 ` [PR PATCH] [Updated] " zdykstra
2020-07-30  4:51 ` zdykstra
2020-08-04 13:10 ` [PR PATCH] [Merged]: " leahneukirchen

Github messages for voidlinux

Archives are clonable: git clone --mirror http://inbox.vuxu.org/voidlinux-github

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git