[PR PATCH] [WIP] New package: ly-0.5.2

[PR PATCH] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 1805 bytes --]

There is a new pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages ly
https://github.com/void-linux/void-packages/pull/24038

[WIP] New package: ly-0.5.2
[ly](https://github.com/nullgemm/ly) is a simple TUI display manager. It recently had a new tagged release, and I thought this would be a good time to try to package it. ly has been requested multiple times (https://github.com/void-linux/void-packages/issues/1577, https://github.com/void-linux/void-packages/issues/13583), and there have been multiple attempts to package it (https://github.com/void-linux/void-packages/pull/1702, https://github.com/void-linux/void-packages/pull/13649, https://github.com/void-linux/void-packages/pull/20496). The template is based almost entirely on [this template](https://github.com/ericonr/void-packages/commit/eadabab675acaff062d138a2607d5920b125bfde) by @ericonr, and the service files were taken from [a fork of ly made to work with Void](https://github.com/drozdowsky/ly-void/commit/b972fe48a143e709dc695ac8e2c83dc57cee279f). The patches make minor adjustments to make ly display on the standard TTY 7 and remove the systemD service.

ly is able to build properly on my machine; I'll soon see if it build properly through travis. The problem with this package is that it doesn't seem to work quite right after it starts running. I get PAM errors when attempting to log in using ly; you can see those errors in [this issue in the ly repository](https://github.com/nullgemm/ly/issues/216). My hunch is that the problem lies in [ly's PAM file](https://github.com/nullgemm/ly/blob/master/res/pam.d/ly). Does anyone know how to patch this to work properly?

A patch file from https://github.com/void-linux/void-packages/pull/24038.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ly-24038.patch --]
[-- Type: text/x-diff, Size: 7751 bytes --]

From e51c0ae763b1aaa477d45d41806df79e5a759907 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Tue, 4 Aug 2020 00:41:29 -0400
Subject: [PATCH] New package: ly-0.5.2

---
 srcpkgs/ly/INSTALL.msg              |  1 +
 srcpkgs/ly/files/ly/conf            | 14 +++++++
 srcpkgs/ly/files/ly/finish          |  4 ++
 srcpkgs/ly/files/ly/run             | 15 +++++++
 srcpkgs/ly/patches/config.c.patch   | 12 ++++++
 srcpkgs/ly/patches/config.ini.patch | 12 ++++++
 srcpkgs/ly/patches/makefile.patch   | 27 ++++++++++++
 srcpkgs/ly/template                 | 64 +++++++++++++++++++++++++++++
 8 files changed, 149 insertions(+)
 create mode 100644 srcpkgs/ly/INSTALL.msg
 create mode 100644 srcpkgs/ly/files/ly/conf
 create mode 100755 srcpkgs/ly/files/ly/finish
 create mode 100755 srcpkgs/ly/files/ly/run
 create mode 100644 srcpkgs/ly/patches/config.c.patch
 create mode 100644 srcpkgs/ly/patches/config.ini.patch
 create mode 100644 srcpkgs/ly/patches/makefile.patch
 create mode 100644 srcpkgs/ly/template

diff --git a/srcpkgs/ly/INSTALL.msg b/srcpkgs/ly/INSTALL.msg
new file mode 100644
index 00000000000..32e01462159
--- /dev/null
+++ b/srcpkgs/ly/INSTALL.msg
@@ -0,0 +1 @@
+ly requires either xinit or sx to be available.
diff --git a/srcpkgs/ly/files/ly/conf b/srcpkgs/ly/files/ly/conf
new file mode 100644
index 00000000000..1fea45318e6
--- /dev/null
+++ b/srcpkgs/ly/files/ly/conf
@@ -0,0 +1,14 @@
+if [ -x /sbin/agetty -o -x /bin/agetty ]; then
+	# util-linux specific settings
+	if [ "${tty}" = "tty1" ]; then
+		GETTY_ARGS="--noclear"
+	fi
+fi
+
+BAUD_RATE=38400
+TERM_NAME=linux
+
+StandardInput=tty
+TTYPath=/dev/tty7
+TTYReset=yes
+TTYVHangup=yes 
diff --git a/srcpkgs/ly/files/ly/finish b/srcpkgs/ly/files/ly/finish
new file mode 100755
index 00000000000..e758d36fe52
--- /dev/null
+++ b/srcpkgs/ly/files/ly/finish
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+tty=${PWD##*-}
+exec utmpset -w $tty
diff --git a/srcpkgs/ly/files/ly/run b/srcpkgs/ly/files/ly/run
new file mode 100755
index 00000000000..74f5613ca03
--- /dev/null
+++ b/srcpkgs/ly/files/ly/run
@@ -0,0 +1,15 @@
+#!/bin/sh
+
+tty=${PWD##*-}
+
+[ -r conf ] && . ./conf
+
+if [ -x /sbin/getty -o -x /bin/getty ]; then
+	# busybox
+	GETTY=getty
+elif [ -x /sbin/agetty -o -x /bin/agetty ]; then
+	# util-linux
+	GETTY=agetty
+fi
+
+exec setsid ${GETTY} ${GETTY_ARGS} -nl /usr/bin/ly tty7 "${BAUD_RATE}" "${TERM_NAME}"
diff --git a/srcpkgs/ly/patches/config.c.patch b/srcpkgs/ly/patches/config.c.patch
new file mode 100644
index 00000000000..ddc60056cac
--- /dev/null
+++ b/srcpkgs/ly/patches/config.c.patch
@@ -0,0 +1,12 @@
+Change default tty to 7
+--- src/config.c	2020-07-28 11:35:08.000000000 -0400
++++ "src/config copy.c"	2020-08-02 21:36:05.334018482 -0400
+@@ -288,7 +288,7 @@
+ 	config.service_name = strdup("ly");
+ 	config.shutdown_cmd = strdup("/sbin/shutdown -a now");
+ 	config.term_reset_cmd = strdup("/usr/bin/tput reset");
+-	config.tty = 2;
++	config.tty = 7;
+ 	config.wayland_cmd = strdup(DATADIR "/wsetup.sh");
+ 	config.wayland_specifier = false;
+ 	config.waylandsessions = strdup("/usr/share/wayland-sessions");
diff --git a/srcpkgs/ly/patches/config.ini.patch b/srcpkgs/ly/patches/config.ini.patch
new file mode 100644
index 00000000000..aec293c5f3b
--- /dev/null
+++ b/srcpkgs/ly/patches/config.ini.patch
@@ -0,0 +1,12 @@
+Change default tty to 7
+--- res/config.ini	2020-07-28 11:35:08.000000000 -0400
++++ "res/config copy.ini"	2020-08-02 21:37:52.572343702 -0400
+@@ -79,7 +79,7 @@
+ #term_reset_cmd = /usr/bin/tput reset
+ 
+ # tty in use
+-#tty = 2
++#tty = 7
+ 
+ # wayland setup command
+ #wayland_cmd = /etc/ly/wsetup.sh
diff --git a/srcpkgs/ly/patches/makefile.patch b/srcpkgs/ly/patches/makefile.patch
new file mode 100644
index 00000000000..8c56843ac28
--- /dev/null
+++ b/srcpkgs/ly/patches/makefile.patch
@@ -0,0 +1,27 @@
+Remove systemd service from install and uninstall targets
+--- makefile	2020-07-28 11:35:08.000000000 -0400
++++ "makefile copy"	2020-08-02 21:40:10.283778154 -0400
+@@ -78,7 +78,6 @@
+ 	@install -DZ $(RESD)/wsetup.sh -t $(DATADIR)
+ 	@install -dZ $(DATADIR)/lang
+ 	@install -DZ $(RESD)/lang/* -t $(DATADIR)/lang
+-	@install -DZ $(RESD)/ly.service -m 644 -t ${DESTDIR}/usr/lib/systemd/system
+ 	@install -DZ $(RESD)/pam.d/ly -m 644 -t ${DESTDIR}/etc/pam.d
+ 
+ installnoconf: $(BIND)/$(NAME)
+@@ -89,7 +88,6 @@
+ 	@install -DZ $(RESD)/wsetup.sh -t $(DATADIR)
+ 	@install -dZ $(DATADIR)/lang
+ 	@install -DZ $(RESD)/lang/* -t $(DATADIR)/lang
+-	@install -DZ $(RESD)/ly.service -m 644 -t ${DESTDIR}/usr/lib/systemd/system
+ 	@install -DZ $(RESD)/pam.d/ly -m 644 -t ${DESTDIR}/etc/pam.d
+ 
+ uninstall:
+@@ -97,7 +95,6 @@
+ 	@rm -rf ${DESTDIR}/etc/ly
+ 	@rm -rf $(DATADIR)
+ 	@rm -f ${DESTDIR}/usr/bin/ly
+-	@rm -f ${DESTDIR}/usr/lib/systemd/system/ly.service
+ 	@rm -f ${DESTDIR}/etc/pam.d/ly
+ 
+ clean:
diff --git a/srcpkgs/ly/template b/srcpkgs/ly/template
new file mode 100644
index 00000000000..6a47efc9784
--- /dev/null
+++ b/srcpkgs/ly/template
@@ -0,0 +1,64 @@
+# Template file for 'ly'
+pkgname=ly
+version=0.5.2
+revision=1
+_argoat_githash=0eb7afae7a001094c9166a8959e021375707522c
+_testoasterror_githash=ee7c9d031d4632a6f381a6c174a38539bac04068
+_configator_githash=8cec1786196ae6f6a8b35e66181277457f2a2bb2
+_ctypes_githash=eb4b36559de8d17015f9416861ed085d06f5f5ed
+_dragonfail_githash=0a2492c6aab3ff64e182db894ce4d40b26799fbd
+_termbox_githash=23fff64470b0730959b39c70aa31fbddd776d9bc
+build_style=gnu-makefile
+make_build_args="FLAGS=\"$CFLAGS\""
+conf_files="/etc/ly/config.ini"
+hostmakedepends="git"
+makedepends="ncurses-devel pam-devel xcb-util-devel libX11-devel"
+depends="pam util-linux xauth"
+short_desc="TUI (ncurses-like) display manager"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
+license="WTFPL"
+homepage="https://github.com/nullgemm/ly"
+distfiles="https://github.com/nullgemm/ly/archive/v${version}.tar.gz
+ https://github.com/nullgemm/argoat/archive/${_argoat_githash}.tar.gz>argoat-${_argoat_githash}.tar.gz
+ https://github.com/nullgemm/testoasterror/archive/${_testoasterror_githash}.tar.gz>testoasterror-${_testoasterror_githash}.tar.gz
+ https://github.com/nullgemm/configator/archive/${_configator_githash}.tar.gz>configator-${_configator_githash}.tar.gz
+ https://raw.githubusercontent.com/nullgemm/ctypes/${_ctypes_githash}/ctypes.h>ctypes-${_ctypes_githash}.h
+ https://github.com/nullgemm/dragonfail/archive/${_dragonfail_githash}.tar.gz>dragonfail-${_dragonfail_githash}.tar.gz
+ https://github.com/nullgemm/termbox_next/archive/${_termbox_githash}.tar.gz>termbox_next-${_termbox_githash}.tar.gz"
+checksum="3460c2c8015add2946f9ff5d3e4bf051d7c07005698fe61279cedacd1283e010
+ 65b0b5d688f8538513f335795156441365b9cb319a28d2defbb29d81ea43a188
+ d627845bcece46499801bbef5b2ccf3e0bfe39493b52a16ae34478e54ab11bd6
+ 2067100f9779eceb5abefa9402ed56546314ca5ad6b3d5156d3e1eb46c853679
+ ef169974c68b548dc8ac83bd4714622775b024fab07dc2b7fe96e8e8f102dbab
+ d5cdd6d528a43c35d08e7fcac849370c07d949671ef592cfecb02b23ad3c4dad
+ 76d73183d2191e9e37285f39f2b1bd51f1dc2d991637902ff3c1aa35111b288d"
+skip_extraction="ctypes-${_ctypes_githash}.h"
+
+post_extract() {
+	cp -rv ../argoat-${_argoat_githash}/* sub/argoat/
+	cp -rv ../testoasterror-${_testoasterror_githash}/* sub/argoat/sub/testoasterror/
+	cp -rv ../configator-${_configator_githash}/* sub/configator/
+	cp -rv $XBPS_SRCDISTDIR/$pkgname-$version/ctypes-${_ctypes_githash}.h sub/ctypes/ctypes.h
+	cp -rv ../dragonfail-${_dragonfail_githash}/* sub/dragonfail/
+	cp -rv ../termbox_next-${_termbox_githash}/* sub/termbox_next/
+}
+
+_make() {
+	make CC="$CC" FLAGS="$CFLAGS"
+}
+
+pre_build() {
+	exit
+	cd sub/argoat/sub/testoasterror
+	_make
+	cd ../../
+	_make
+}
+
+do_build() {
+	_make
+}
+
+post_install() {
+	vsv ly
+}

Re: [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-668386569

Comment:
Could anyone who's familiar with C explain the error occuring on the ARM builds:
```
src/login.c:13:10: fatal error: security/pam_appl.h: No such file or directory

   13 | #include <security/pam_appl.h>

      |          ^~~~~~~~~~~~~~~~~~~~~

compilation terminated.
```
I think it means that there's a library that's not installed, but this error doesn't exist on any of the other architectures.

Re: [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-668389106

Comment:
If you `vsed` away the `@`s in the Makefile, you can see what commands it's trying to run and try to debug from there. That looks like a cross compilation issue, though.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r464809747

Comment:
Why default to 7?

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r464809915

Comment:
tty7 shouldn't be hardcoded.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r464810195

Comment:
It doesn't, it can launch a shell or wayland session.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r464810326

Comment:
Does it still need `git`?

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r464809687

Comment:
Easier to just remove these in `post_install` instead of patching the makefile.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r464810083

Comment:
Are these being used anywhere?

Re: [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-668605397

Comment:
Try to add this patch as a commit https://github.com/nullgemm/ly/commit/8493c5a8ada16d3da56b23ff28791068c542d1eb for the PAM issue.

Re: [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-668605397

Comment:
Try to add this commit as a patch https://github.com/nullgemm/ly/commit/8493c5a8ada16d3da56b23ff28791068c542d1eb for the PAM issue.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465067873

Comment:
Why is this here?

Re: [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-668605397

Comment:
~~Try to add this commit as a patch https://github.com/nullgemm/ly/commit/8493c5a8ada16d3da56b23ff28791068c542d1eb for the PAM issue.~~

Hmm this should be in the release you pulled.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465142465

Comment:
7 is the tty that all (as far as I know) desktop environments launch on. With the previous default tty of 2, users would run into a scenario where they would log in via `ly` and receive no feedback that it had succeeded; they would need to manually switch to tty7 after logging in.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465144888

Comment:
What would be the correct way to set it? Subsitute `tty7` with `${tty}`?

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465145489

Comment:
No, but adding it shuts up the "git not found" output that pops up without it. Granted, you still get the "fatal, not a git repository" error with it installed, so I guess it doesn't matter. I'll remove it.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465146155

Comment:
No idea, I inherited it from a previous version of the template. I'll remove it and see what happens.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465152661

Comment:
no, because the service is being installed as `ly`. It would need to be installed as `ly-tty7` for the `tty=${PWD##*-}` trick to work.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 667 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465156095

Comment:
BAUD_RATE and TERM_NAME are used in the `run` file. The others are inherited from the systemD service file. They don't appear to be used anywhere, but they do correspond to commands that should probably be added to the `run` file. In this case, the commands would be changing the virtual terminal to whichever one is specified there and issuing `reset` to clear the screen. At least, that's what I got from [this article](https://alan-mushi.github.io/2014/10/26/execute-an-interactive-script-at-boot-with-systemd.html).

Re: [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 2347 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-668681620

Comment:
After using `vsed` to get rid of the `@`s at the start of lines, removing `git`, and removing that `exit`, I'm running into a compilation error I wasn't before:
```
building object obj/src/config.o
mkdir -p obj/src
cc -Isrc -Isub/ctypes -Isub/argoat/src -Isub/configator/src -Isub/dragonfail/src -Isub/termbox_next/src -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe    -c -o obj/src/config.o src/config.c
src/config.c: In function 'lang_load':
src/config.c:12:19: error: 'DATADIR' undeclared (first use in this function)
   12 |  #define INI_LANG DATADIR "/lang/%s.ini"
      |                   ^~~~~~~
src/config.c:141:22: note: in expansion of macro 'INI_LANG'
  141 |  snprintf(file, 256, INI_LANG, config.lang);
      |                      ^~~~~~~~
src/config.c:12:19: note: each undeclared identifier is reported only once for each function it appears in
   12 |  #define INI_LANG DATADIR "/lang/%s.ini"
      |                   ^~~~~~~
src/config.c:141:22: note: in expansion of macro 'INI_LANG'
  141 |  snprintf(file, 256, INI_LANG, config.lang);
      |                      ^~~~~~~~
src/config.c:12:27: error: expected ')' before string constant
   12 |  #define INI_LANG DATADIR "/lang/%s.ini"
      |                           ^~~~~~~~~~~~~~
src/config.c:141:22: note: in expansion of macro 'INI_LANG'
  141 |  snprintf(file, 256, INI_LANG, config.lang);
      |                      ^~~~~~~~
src/config.c: In function 'config_defaults':
src/config.c:292:30: error: 'DATADIR' undeclared (first use in this function)
  292 |  config.wayland_cmd = strdup(DATADIR "/wsetup.sh");
      |                              ^~~~~~~
src/config.c:292:37: error: expected ')' before string constant
  292 |  config.wayland_cmd = strdup(DATADIR "/wsetup.sh");
      |                                     ^~~~~~~~~~~~~
      |                                     )
src/config.c:296:37: error: expected ')' before string constant
  296 |  config.x_cmd_setup = strdup(DATADIR "/xsetup.sh");
      |                                     ^~~~~~~~~~~~~
      |                                     )
make: *** [makefile:52: obj/src/config.o] Error 1
```

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465208057

Comment:
I see. Could we simply uncomment this from the config file, to avoid patching the source as well? We should open an issue/PR with upstream about making it a build time option, as well.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465208602

Comment:
Ok, so perhaps add a `reset` command before launching ly. Not sure what `hangup` gives us.

Re: [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-668726545

Comment:
You are overwriting the compiler flags, which includes a define for `DATADIR`.  If you want to fix this, commenting out this line https://github.com/nullgemm/ly/blob/master/makefile#L3 from the makefile and adding `export FLAGS="$CFLAGS"` to `pre_build` should be enough. 

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465399075

Comment:
Yes, I can change the config file to avoid patching the source. Would the issue simply contain a request to add setting tty7 as the default as a build time option?

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465400883

Comment:
It's hardcoded to tty2 in the original run file. I'm starting to think that I'm going to need to scrap a lot of the work done in the void fork on the service files.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465404118

Comment:
Actually, now that I think about it, is it possible to read in data from another file in the conf file?

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465420490

Comment:
Ideally no, the conf file should be reasonably simple

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465420546

Comment:
What are you thinking of doing?

Re: [PR PATCH] [Updated] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

There is an updated pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages ly
https://github.com/void-linux/void-packages/pull/24038

[WIP] New package: ly-0.5.2
[ly](https://github.com/nullgemm/ly) is a simple TUI display manager. It recently had a new tagged release, and I thought this would be a good time to try to package it. ly has been requested multiple times (https://github.com/void-linux/void-packages/issues/1577, https://github.com/void-linux/void-packages/issues/13583), and there have been multiple attempts to package it (https://github.com/void-linux/void-packages/pull/1702, https://github.com/void-linux/void-packages/pull/13649, https://github.com/void-linux/void-packages/pull/20496). The template is based almost entirely on [this template](https://github.com/ericonr/void-packages/commit/eadabab675acaff062d138a2607d5920b125bfde) by @ericonr, and the service files were taken from [a fork of ly made to work with Void](https://github.com/drozdowsky/ly-void/commit/b972fe48a143e709dc695ac8e2c83dc57cee279f). The patches make minor adjustments to make ly display on the standard TTY 7 and remove the systemD service.

ly is able to build properly on my machine; I'll soon see if it build properly through travis. The problem with this package is that it doesn't seem to work quite right after it starts running. I get PAM errors when attempting to log in using ly; you can see those errors in [this issue in the ly repository](https://github.com/nullgemm/ly/issues/216). My hunch is that the problem lies in [ly's PAM file](https://github.com/nullgemm/ly/blob/master/res/pam.d/ly). Does anyone know how to patch this to work properly?

A patch file from https://github.com/void-linux/void-packages/pull/24038.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ly-24038.patch --]
[-- Type: text/x-diff, Size: 4855 bytes --]

From 2d136dfd34ee26eaf6656a74e2b4f4d0e2f799e2 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Tue, 4 Aug 2020 21:41:56 -0400
Subject: [PATCH] New package: ly-0.5.2

---
 srcpkgs/ly/files/ly/conf            |  9 +++++
 srcpkgs/ly/files/ly/run             | 15 ++++++++
 srcpkgs/ly/patches/config.ini.patch | 12 +++++++
 srcpkgs/ly/template                 | 56 +++++++++++++++++++++++++++++
 4 files changed, 92 insertions(+)
 create mode 100644 srcpkgs/ly/files/ly/conf
 create mode 100755 srcpkgs/ly/files/ly/run
 create mode 100644 srcpkgs/ly/patches/config.ini.patch
 create mode 100644 srcpkgs/ly/template

diff --git a/srcpkgs/ly/files/ly/conf b/srcpkgs/ly/files/ly/conf
new file mode 100644
index 00000000000..b9b33c268cf
--- /dev/null
+++ b/srcpkgs/ly/files/ly/conf
@@ -0,0 +1,9 @@
+if [ -x /sbin/agetty -o -x /bin/agetty ]; then
+	# util-linux specific settings
+	if [ "${tty}" = "tty1" ]; then
+		GETTY_ARGS="--noclear"
+	fi
+fi
+
+BAUD_RATE=38400
+TERM_NAME=linux
diff --git a/srcpkgs/ly/files/ly/run b/srcpkgs/ly/files/ly/run
new file mode 100755
index 00000000000..cb9c3453573
--- /dev/null
+++ b/srcpkgs/ly/files/ly/run
@@ -0,0 +1,15 @@
+#!/bin/sh
+
+[ -r conf ] && . ./conf
+
+if [ -x /sbin/getty -o -x /bin/getty ]; then
+	# busybox
+	GETTY=getty
+elif [ -x /sbin/agetty -o -x /bin/agetty ]; then
+	# util-linux
+	GETTY=agetty
+fi
+
+chvt 7
+reset
+exec setsid ${GETTY} ${GETTY_ARGS} -nl /usr/bin/ly tty7 "${BAUD_RATE}" "${TERM_NAME}"
diff --git a/srcpkgs/ly/patches/config.ini.patch b/srcpkgs/ly/patches/config.ini.patch
new file mode 100644
index 00000000000..37f74b0bbbe
--- /dev/null
+++ b/srcpkgs/ly/patches/config.ini.patch
@@ -0,0 +1,12 @@
+Change default tty to 7
+--- res/config.ini	2020-07-28 11:35:08.000000000 -0400
++++ "res/config copy.ini"	2020-08-02 21:37:52.572343702 -0400
+@@ -79,7 +79,7 @@
+ #term_reset_cmd = /usr/bin/tput reset
+ 
+ # tty in use
+-#tty = 2
++tty = 7
+ 
+ # wayland setup command
+ #wayland_cmd = /etc/ly/wsetup.sh
diff --git a/srcpkgs/ly/template b/srcpkgs/ly/template
new file mode 100644
index 00000000000..f3467fc6a56
--- /dev/null
+++ b/srcpkgs/ly/template
@@ -0,0 +1,56 @@
+# Template file for 'ly'
+pkgname=ly
+version=0.5.2
+revision=1
+_argoat_githash=0eb7afae7a001094c9166a8959e021375707522c
+_testoasterror_githash=ee7c9d031d4632a6f381a6c174a38539bac04068
+_configator_githash=8cec1786196ae6f6a8b35e66181277457f2a2bb2
+_ctypes_githash=eb4b36559de8d17015f9416861ed085d06f5f5ed
+_dragonfail_githash=0a2492c6aab3ff64e182db894ce4d40b26799fbd
+_termbox_githash=23fff64470b0730959b39c70aa31fbddd776d9bc
+build_style=gnu-makefile
+conf_files="/etc/ly/config.ini"
+makedepends="ncurses-devel pam-devel xcb-util-devel libX11-devel"
+depends="pam util-linux xauth"
+short_desc="TUI (ncurses-like) display manager"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
+license="WTFPL"
+homepage="https://github.com/nullgemm/ly"
+distfiles="https://github.com/nullgemm/ly/archive/v${version}.tar.gz
+ https://github.com/nullgemm/argoat/archive/${_argoat_githash}.tar.gz>argoat-${_argoat_githash}.tar.gz
+ https://github.com/nullgemm/testoasterror/archive/${_testoasterror_githash}.tar.gz>testoasterror-${_testoasterror_githash}.tar.gz
+ https://github.com/nullgemm/configator/archive/${_configator_githash}.tar.gz>configator-${_configator_githash}.tar.gz
+ https://raw.githubusercontent.com/nullgemm/ctypes/${_ctypes_githash}/ctypes.h>ctypes-${_ctypes_githash}.h
+ https://github.com/nullgemm/dragonfail/archive/${_dragonfail_githash}.tar.gz>dragonfail-${_dragonfail_githash}.tar.gz
+ https://github.com/nullgemm/termbox_next/archive/${_termbox_githash}.tar.gz>termbox_next-${_termbox_githash}.tar.gz"
+checksum="3460c2c8015add2946f9ff5d3e4bf051d7c07005698fe61279cedacd1283e010
+ 65b0b5d688f8538513f335795156441365b9cb319a28d2defbb29d81ea43a188
+ d627845bcece46499801bbef5b2ccf3e0bfe39493b52a16ae34478e54ab11bd6
+ 2067100f9779eceb5abefa9402ed56546314ca5ad6b3d5156d3e1eb46c853679
+ ef169974c68b548dc8ac83bd4714622775b024fab07dc2b7fe96e8e8f102dbab
+ d5cdd6d528a43c35d08e7fcac849370c07d949671ef592cfecb02b23ad3c4dad
+ 76d73183d2191e9e37285f39f2b1bd51f1dc2d991637902ff3c1aa35111b288d"
+skip_extraction="ctypes-${_ctypes_githash}.h"
+
+post_extract() {
+	cp -rv ../argoat-${_argoat_githash}/* sub/argoat/
+	cp -rv ../testoasterror-${_testoasterror_githash}/* sub/argoat/sub/testoasterror/
+	cp -rv ../configator-${_configator_githash}/* sub/configator/
+	cp -rv $XBPS_SRCDISTDIR/$pkgname-$version/ctypes-${_ctypes_githash}.h sub/ctypes/ctypes.h
+	cp -rv ../dragonfail-${_dragonfail_githash}/* sub/dragonfail/
+	cp -rv ../termbox_next-${_termbox_githash}/* sub/termbox_next/
+}
+
+pre_build() {
+	cd sub/argoat/sub/testoasterror
+	make
+	cd ../../
+	make
+	cd ../../
+	vsed -i makefile -e "s/^\t@/\t/g"
+}
+
+post_install() {
+	rm -f $DESTDIR/usr/lib/systemd/system/ly.service
+	vsv ly
+}

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465425866

Comment:
I'm considering `grep`ing the `/etc/ly/config.ini` file for the tty number and using that in the arguments passed to `/usr/bin/ly`.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465426486

Comment:
As a side note, can I move the getty vs agetty thing in the run file into the conf file?

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465439317

Comment:
I would make it generic, so any tty can be chosen as default.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465439916

Comment:
Honestly, I don't have any issue with making this package depend on `util-linux` directly, so imo you can just use `agetty`.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465439916

Comment:
Honestly, I don't have any issue with making this package depend on `util-linux` directly, so imo you can just use `agetty`. No need to check for anything.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465440328

Comment:
> I'm considering greping the /etc/ly/config.ini file for the tty number and using that in the arguments passed to /usr/bin/ly.

I prefer the user configuring this manually, with you leaving sensible defaults. Otherwise it becomes a little too magical.

Re: [PR PATCH] [Updated] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

There is an updated pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages ly
https://github.com/void-linux/void-packages/pull/24038

[WIP] New package: ly-0.5.2
[ly](https://github.com/nullgemm/ly) is a simple TUI display manager. It recently had a new tagged release, and I thought this would be a good time to try to package it. ly has been requested multiple times (https://github.com/void-linux/void-packages/issues/1577, https://github.com/void-linux/void-packages/issues/13583), and there have been multiple attempts to package it (https://github.com/void-linux/void-packages/pull/1702, https://github.com/void-linux/void-packages/pull/13649, https://github.com/void-linux/void-packages/pull/20496). The template is based almost entirely on [this template](https://github.com/ericonr/void-packages/commit/eadabab675acaff062d138a2607d5920b125bfde) by @ericonr, and the service files were taken from [a fork of ly made to work with Void](https://github.com/drozdowsky/ly-void/commit/b972fe48a143e709dc695ac8e2c83dc57cee279f). The patches make minor adjustments to make ly display on the standard TTY 7 and remove the systemD service.

ly is able to build properly on my machine; I'll soon see if it build properly through travis. The problem with this package is that it doesn't seem to work quite right after it starts running. I get PAM errors when attempting to log in using ly; you can see those errors in [this issue in the ly repository](https://github.com/nullgemm/ly/issues/216). My hunch is that the problem lies in [ly's PAM file](https://github.com/nullgemm/ly/blob/master/res/pam.d/ly). Does anyone know how to patch this to work properly?

A patch file from https://github.com/void-linux/void-packages/pull/24038.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ly-24038.patch --]
[-- Type: text/x-diff, Size: 4680 bytes --]

From f71c2a4dd83d592514d4a54a421c3d978cdc47e4 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Wed, 5 Aug 2020 00:07:37 -0400
Subject: [PATCH] New package: ly-0.5.2

---
 srcpkgs/ly/files/ly/conf            |  7 ++++
 srcpkgs/ly/files/ly/run             |  7 ++++
 srcpkgs/ly/patches/config.ini.patch | 12 +++++++
 srcpkgs/ly/template                 | 56 +++++++++++++++++++++++++++++
 4 files changed, 82 insertions(+)
 create mode 100644 srcpkgs/ly/files/ly/conf
 create mode 100755 srcpkgs/ly/files/ly/run
 create mode 100644 srcpkgs/ly/patches/config.ini.patch
 create mode 100644 srcpkgs/ly/template

diff --git a/srcpkgs/ly/files/ly/conf b/srcpkgs/ly/files/ly/conf
new file mode 100644
index 00000000000..120c6425b45
--- /dev/null
+++ b/srcpkgs/ly/files/ly/conf
@@ -0,0 +1,7 @@
+BAUD_RATE=38400
+TERM_NAME=linux
+TTY=7
+
+if [ "${TTY}" = "1" ]; then
+	GETTY_ARGS="--noclear"
+fi
diff --git a/srcpkgs/ly/files/ly/run b/srcpkgs/ly/files/ly/run
new file mode 100755
index 00000000000..06b984c1f7b
--- /dev/null
+++ b/srcpkgs/ly/files/ly/run
@@ -0,0 +1,7 @@
+#!/bin/sh
+
+[ -r conf ] && . ./conf
+
+chvt "${TTY}"
+reset
+exec setsid agetty ${GETTY_ARGS} -nl /usr/bin/ly "tty${TTY}" "${BAUD_RATE}" "${TERM_NAME}"
diff --git a/srcpkgs/ly/patches/config.ini.patch b/srcpkgs/ly/patches/config.ini.patch
new file mode 100644
index 00000000000..0adeb3bc93a
--- /dev/null
+++ b/srcpkgs/ly/patches/config.ini.patch
@@ -0,0 +1,12 @@
+--- res/config.ini	2020-07-28 11:35:08.000000000 -0400
++++ "res/config copy.ini"	2020-08-05 00:00:19.044893166 -0400
+@@ -79,7 +79,8 @@
+ #term_reset_cmd = /usr/bin/tput reset
+ 
+ # tty in use
+-#tty = 2
++# if you change this value, you must also change the "TTY" value in /etc/sv/ly/conf
++tty = 7
+ 
+ # wayland setup command
+ #wayland_cmd = /etc/ly/wsetup.sh
diff --git a/srcpkgs/ly/template b/srcpkgs/ly/template
new file mode 100644
index 00000000000..f3467fc6a56
--- /dev/null
+++ b/srcpkgs/ly/template
@@ -0,0 +1,56 @@
+# Template file for 'ly'
+pkgname=ly
+version=0.5.2
+revision=1
+_argoat_githash=0eb7afae7a001094c9166a8959e021375707522c
+_testoasterror_githash=ee7c9d031d4632a6f381a6c174a38539bac04068
+_configator_githash=8cec1786196ae6f6a8b35e66181277457f2a2bb2
+_ctypes_githash=eb4b36559de8d17015f9416861ed085d06f5f5ed
+_dragonfail_githash=0a2492c6aab3ff64e182db894ce4d40b26799fbd
+_termbox_githash=23fff64470b0730959b39c70aa31fbddd776d9bc
+build_style=gnu-makefile
+conf_files="/etc/ly/config.ini"
+makedepends="ncurses-devel pam-devel xcb-util-devel libX11-devel"
+depends="pam util-linux xauth"
+short_desc="TUI (ncurses-like) display manager"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
+license="WTFPL"
+homepage="https://github.com/nullgemm/ly"
+distfiles="https://github.com/nullgemm/ly/archive/v${version}.tar.gz
+ https://github.com/nullgemm/argoat/archive/${_argoat_githash}.tar.gz>argoat-${_argoat_githash}.tar.gz
+ https://github.com/nullgemm/testoasterror/archive/${_testoasterror_githash}.tar.gz>testoasterror-${_testoasterror_githash}.tar.gz
+ https://github.com/nullgemm/configator/archive/${_configator_githash}.tar.gz>configator-${_configator_githash}.tar.gz
+ https://raw.githubusercontent.com/nullgemm/ctypes/${_ctypes_githash}/ctypes.h>ctypes-${_ctypes_githash}.h
+ https://github.com/nullgemm/dragonfail/archive/${_dragonfail_githash}.tar.gz>dragonfail-${_dragonfail_githash}.tar.gz
+ https://github.com/nullgemm/termbox_next/archive/${_termbox_githash}.tar.gz>termbox_next-${_termbox_githash}.tar.gz"
+checksum="3460c2c8015add2946f9ff5d3e4bf051d7c07005698fe61279cedacd1283e010
+ 65b0b5d688f8538513f335795156441365b9cb319a28d2defbb29d81ea43a188
+ d627845bcece46499801bbef5b2ccf3e0bfe39493b52a16ae34478e54ab11bd6
+ 2067100f9779eceb5abefa9402ed56546314ca5ad6b3d5156d3e1eb46c853679
+ ef169974c68b548dc8ac83bd4714622775b024fab07dc2b7fe96e8e8f102dbab
+ d5cdd6d528a43c35d08e7fcac849370c07d949671ef592cfecb02b23ad3c4dad
+ 76d73183d2191e9e37285f39f2b1bd51f1dc2d991637902ff3c1aa35111b288d"
+skip_extraction="ctypes-${_ctypes_githash}.h"
+
+post_extract() {
+	cp -rv ../argoat-${_argoat_githash}/* sub/argoat/
+	cp -rv ../testoasterror-${_testoasterror_githash}/* sub/argoat/sub/testoasterror/
+	cp -rv ../configator-${_configator_githash}/* sub/configator/
+	cp -rv $XBPS_SRCDISTDIR/$pkgname-$version/ctypes-${_ctypes_githash}.h sub/ctypes/ctypes.h
+	cp -rv ../dragonfail-${_dragonfail_githash}/* sub/dragonfail/
+	cp -rv ../termbox_next-${_termbox_githash}/* sub/termbox_next/
+}
+
+pre_build() {
+	cd sub/argoat/sub/testoasterror
+	make
+	cd ../../
+	make
+	cd ../../
+	vsed -i makefile -e "s/^\t@/\t/g"
+}
+
+post_install() {
+	rm -f $DESTDIR/usr/lib/systemd/system/ly.service
+	vsv ly
+}

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465460427

Comment:
Just changed it. Could you take a look at the conf, run, and config.ini.patch files to see if that's sufficient to allow users to understand what they need to do?

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465462152

Comment:
I don't love the idea of running `chvt`, but fair enough.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465462386

Comment:
Perhaps leave a comment here pointing to the service conf?

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465467733

Comment:
Issue opened: https://github.com/nullgemm/ly/issues/225

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465468155

Comment:
I tested it without `chvt`, and unfortunately `ly` doesn't switch to its TTY on its own.

Re: [PR PATCH] [Updated] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

There is an updated pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages ly
https://github.com/void-linux/void-packages/pull/24038

[WIP] New package: ly-0.5.2
[ly](https://github.com/nullgemm/ly) is a simple TUI display manager. It recently had a new tagged release, and I thought this would be a good time to try to package it. ly has been requested multiple times (https://github.com/void-linux/void-packages/issues/1577, https://github.com/void-linux/void-packages/issues/13583), and there have been multiple attempts to package it (https://github.com/void-linux/void-packages/pull/1702, https://github.com/void-linux/void-packages/pull/13649, https://github.com/void-linux/void-packages/pull/20496). The template is based almost entirely on [this template](https://github.com/ericonr/void-packages/commit/eadabab675acaff062d138a2607d5920b125bfde) by @ericonr, and the service files were taken from [a fork of ly made to work with Void](https://github.com/drozdowsky/ly-void/commit/b972fe48a143e709dc695ac8e2c83dc57cee279f). The patches make minor adjustments to make ly display on the standard TTY 7 and remove the systemD service.

ly is able to build properly on my machine; I'll soon see if it build properly through travis. The problem with this package is that it doesn't seem to work quite right after it starts running. I get PAM errors when attempting to log in using ly; you can see those errors in [this issue in the ly repository](https://github.com/nullgemm/ly/issues/216). My hunch is that the problem lies in [ly's PAM file](https://github.com/nullgemm/ly/blob/master/res/pam.d/ly). Does anyone know how to patch this to work properly?

A patch file from https://github.com/void-linux/void-packages/pull/24038.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ly-24038.patch --]
[-- Type: text/x-diff, Size: 4777 bytes --]

From c77c892c43c8bcdc3297183985d80585041dbbea Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Wed, 5 Aug 2020 00:46:05 -0400
Subject: [PATCH] New package: ly-0.5.2

---
 srcpkgs/ly/files/ly/conf            |  8 +++++
 srcpkgs/ly/files/ly/run             |  7 ++++
 srcpkgs/ly/patches/config.ini.patch | 12 +++++++
 srcpkgs/ly/template                 | 56 +++++++++++++++++++++++++++++
 4 files changed, 83 insertions(+)
 create mode 100644 srcpkgs/ly/files/ly/conf
 create mode 100755 srcpkgs/ly/files/ly/run
 create mode 100644 srcpkgs/ly/patches/config.ini.patch
 create mode 100644 srcpkgs/ly/template

diff --git a/srcpkgs/ly/files/ly/conf b/srcpkgs/ly/files/ly/conf
new file mode 100644
index 00000000000..31223b16bfb
--- /dev/null
+++ b/srcpkgs/ly/files/ly/conf
@@ -0,0 +1,8 @@
+BAUD_RATE=38400
+TERM_NAME=linux
+# don't change the following value without also changing the "tty" value in /etc/ly/config.ini
+TTY=7
+
+if [ "${TTY}" = "1" ]; then
+	GETTY_ARGS="--noclear"
+fi
diff --git a/srcpkgs/ly/files/ly/run b/srcpkgs/ly/files/ly/run
new file mode 100755
index 00000000000..06b984c1f7b
--- /dev/null
+++ b/srcpkgs/ly/files/ly/run
@@ -0,0 +1,7 @@
+#!/bin/sh
+
+[ -r conf ] && . ./conf
+
+chvt "${TTY}"
+reset
+exec setsid agetty ${GETTY_ARGS} -nl /usr/bin/ly "tty${TTY}" "${BAUD_RATE}" "${TERM_NAME}"
diff --git a/srcpkgs/ly/patches/config.ini.patch b/srcpkgs/ly/patches/config.ini.patch
new file mode 100644
index 00000000000..0adeb3bc93a
--- /dev/null
+++ b/srcpkgs/ly/patches/config.ini.patch
@@ -0,0 +1,12 @@
+--- res/config.ini	2020-07-28 11:35:08.000000000 -0400
++++ "res/config copy.ini"	2020-08-05 00:00:19.044893166 -0400
+@@ -79,7 +79,8 @@
+ #term_reset_cmd = /usr/bin/tput reset
+ 
+ # tty in use
+-#tty = 2
++# if you change this value, you must also change the "TTY" value in /etc/sv/ly/conf
++tty = 7
+ 
+ # wayland setup command
+ #wayland_cmd = /etc/ly/wsetup.sh
diff --git a/srcpkgs/ly/template b/srcpkgs/ly/template
new file mode 100644
index 00000000000..f3467fc6a56
--- /dev/null
+++ b/srcpkgs/ly/template
@@ -0,0 +1,56 @@
+# Template file for 'ly'
+pkgname=ly
+version=0.5.2
+revision=1
+_argoat_githash=0eb7afae7a001094c9166a8959e021375707522c
+_testoasterror_githash=ee7c9d031d4632a6f381a6c174a38539bac04068
+_configator_githash=8cec1786196ae6f6a8b35e66181277457f2a2bb2
+_ctypes_githash=eb4b36559de8d17015f9416861ed085d06f5f5ed
+_dragonfail_githash=0a2492c6aab3ff64e182db894ce4d40b26799fbd
+_termbox_githash=23fff64470b0730959b39c70aa31fbddd776d9bc
+build_style=gnu-makefile
+conf_files="/etc/ly/config.ini"
+makedepends="ncurses-devel pam-devel xcb-util-devel libX11-devel"
+depends="pam util-linux xauth"
+short_desc="TUI (ncurses-like) display manager"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
+license="WTFPL"
+homepage="https://github.com/nullgemm/ly"
+distfiles="https://github.com/nullgemm/ly/archive/v${version}.tar.gz
+ https://github.com/nullgemm/argoat/archive/${_argoat_githash}.tar.gz>argoat-${_argoat_githash}.tar.gz
+ https://github.com/nullgemm/testoasterror/archive/${_testoasterror_githash}.tar.gz>testoasterror-${_testoasterror_githash}.tar.gz
+ https://github.com/nullgemm/configator/archive/${_configator_githash}.tar.gz>configator-${_configator_githash}.tar.gz
+ https://raw.githubusercontent.com/nullgemm/ctypes/${_ctypes_githash}/ctypes.h>ctypes-${_ctypes_githash}.h
+ https://github.com/nullgemm/dragonfail/archive/${_dragonfail_githash}.tar.gz>dragonfail-${_dragonfail_githash}.tar.gz
+ https://github.com/nullgemm/termbox_next/archive/${_termbox_githash}.tar.gz>termbox_next-${_termbox_githash}.tar.gz"
+checksum="3460c2c8015add2946f9ff5d3e4bf051d7c07005698fe61279cedacd1283e010
+ 65b0b5d688f8538513f335795156441365b9cb319a28d2defbb29d81ea43a188
+ d627845bcece46499801bbef5b2ccf3e0bfe39493b52a16ae34478e54ab11bd6
+ 2067100f9779eceb5abefa9402ed56546314ca5ad6b3d5156d3e1eb46c853679
+ ef169974c68b548dc8ac83bd4714622775b024fab07dc2b7fe96e8e8f102dbab
+ d5cdd6d528a43c35d08e7fcac849370c07d949671ef592cfecb02b23ad3c4dad
+ 76d73183d2191e9e37285f39f2b1bd51f1dc2d991637902ff3c1aa35111b288d"
+skip_extraction="ctypes-${_ctypes_githash}.h"
+
+post_extract() {
+	cp -rv ../argoat-${_argoat_githash}/* sub/argoat/
+	cp -rv ../testoasterror-${_testoasterror_githash}/* sub/argoat/sub/testoasterror/
+	cp -rv ../configator-${_configator_githash}/* sub/configator/
+	cp -rv $XBPS_SRCDISTDIR/$pkgname-$version/ctypes-${_ctypes_githash}.h sub/ctypes/ctypes.h
+	cp -rv ../dragonfail-${_dragonfail_githash}/* sub/dragonfail/
+	cp -rv ../termbox_next-${_termbox_githash}/* sub/termbox_next/
+}
+
+pre_build() {
+	cd sub/argoat/sub/testoasterror
+	make
+	cd ../../
+	make
+	cd ../../
+	vsed -i makefile -e "s/^\t@/\t/g"
+}
+
+post_install() {
+	rm -f $DESTDIR/usr/lib/systemd/system/ly.service
+	vsv ly
+}

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r465470385

Comment:
Changed!

Re: [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-668978527

Comment:
Good news: The package now compiles fine on ARM architectures after simplifying the template.
Bad news: The PAM problem still exists.

Re: [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-669367919

Comment:
I will try building this locally later to see if I can track anything down.

Re: [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-669614083

Comment:
@cinerea0 does this service segfault for you as well? Whenever I log into it I get a segfault in my dmesg.

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r466086237

Comment:
This is terrible. If the service is constantly dying for some reason, you can't fix it at all, because it will always run `chvt` again.

Re: [PR PATCH] [Updated] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

There is an updated pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages ly
https://github.com/void-linux/void-packages/pull/24038

[WIP] New package: ly-0.5.2
[ly](https://github.com/nullgemm/ly) is a simple TUI display manager. It recently had a new tagged release, and I thought this would be a good time to try to package it. ly has been requested multiple times (https://github.com/void-linux/void-packages/issues/1577, https://github.com/void-linux/void-packages/issues/13583), and there have been multiple attempts to package it (https://github.com/void-linux/void-packages/pull/1702, https://github.com/void-linux/void-packages/pull/13649, https://github.com/void-linux/void-packages/pull/20496). The template is based almost entirely on [this template](https://github.com/ericonr/void-packages/commit/eadabab675acaff062d138a2607d5920b125bfde) by @ericonr, and the service files were taken from [a fork of ly made to work with Void](https://github.com/drozdowsky/ly-void/commit/b972fe48a143e709dc695ac8e2c83dc57cee279f). The patches make minor adjustments to make ly display on the standard TTY 7 and remove the systemD service.

ly is able to build properly on my machine; I'll soon see if it build properly through travis. The problem with this package is that it doesn't seem to work quite right after it starts running. I get PAM errors when attempting to log in using ly; you can see those errors in [this issue in the ly repository](https://github.com/nullgemm/ly/issues/216). My hunch is that the problem lies in [ly's PAM file](https://github.com/nullgemm/ly/blob/master/res/pam.d/ly). Does anyone know how to patch this to work properly?

A patch file from https://github.com/void-linux/void-packages/pull/24038.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ly-24038.patch --]
[-- Type: text/x-diff, Size: 4754 bytes --]

From ea6663a4e561ae6be2b89a92ab139eff672b0c94 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Wed, 5 Aug 2020 22:00:00 -0400
Subject: [PATCH] New package: ly-0.5.2

---
 srcpkgs/ly/files/ly/conf            |  8 +++++
 srcpkgs/ly/files/ly/run             |  5 +++
 srcpkgs/ly/patches/config.ini.patch | 12 +++++++
 srcpkgs/ly/template                 | 56 +++++++++++++++++++++++++++++
 4 files changed, 81 insertions(+)
 create mode 100644 srcpkgs/ly/files/ly/conf
 create mode 100755 srcpkgs/ly/files/ly/run
 create mode 100644 srcpkgs/ly/patches/config.ini.patch
 create mode 100644 srcpkgs/ly/template

diff --git a/srcpkgs/ly/files/ly/conf b/srcpkgs/ly/files/ly/conf
new file mode 100644
index 00000000000..31223b16bfb
--- /dev/null
+++ b/srcpkgs/ly/files/ly/conf
@@ -0,0 +1,8 @@
+BAUD_RATE=38400
+TERM_NAME=linux
+# don't change the following value without also changing the "tty" value in /etc/ly/config.ini
+TTY=7
+
+if [ "${TTY}" = "1" ]; then
+	GETTY_ARGS="--noclear"
+fi
diff --git a/srcpkgs/ly/files/ly/run b/srcpkgs/ly/files/ly/run
new file mode 100755
index 00000000000..3b66be6142c
--- /dev/null
+++ b/srcpkgs/ly/files/ly/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+[ -r conf ] && . ./conf
+
+exec setsid agetty ${GETTY_ARGS} -nl /usr/bin/ly "tty${TTY}" "${BAUD_RATE}" "${TERM_NAME}"
diff --git a/srcpkgs/ly/patches/config.ini.patch b/srcpkgs/ly/patches/config.ini.patch
new file mode 100644
index 00000000000..0adeb3bc93a
--- /dev/null
+++ b/srcpkgs/ly/patches/config.ini.patch
@@ -0,0 +1,12 @@
+--- res/config.ini	2020-07-28 11:35:08.000000000 -0400
++++ "res/config copy.ini"	2020-08-05 00:00:19.044893166 -0400
+@@ -79,7 +79,8 @@
+ #term_reset_cmd = /usr/bin/tput reset
+ 
+ # tty in use
+-#tty = 2
++# if you change this value, you must also change the "TTY" value in /etc/sv/ly/conf
++tty = 7
+ 
+ # wayland setup command
+ #wayland_cmd = /etc/ly/wsetup.sh
diff --git a/srcpkgs/ly/template b/srcpkgs/ly/template
new file mode 100644
index 00000000000..f3467fc6a56
--- /dev/null
+++ b/srcpkgs/ly/template
@@ -0,0 +1,56 @@
+# Template file for 'ly'
+pkgname=ly
+version=0.5.2
+revision=1
+_argoat_githash=0eb7afae7a001094c9166a8959e021375707522c
+_testoasterror_githash=ee7c9d031d4632a6f381a6c174a38539bac04068
+_configator_githash=8cec1786196ae6f6a8b35e66181277457f2a2bb2
+_ctypes_githash=eb4b36559de8d17015f9416861ed085d06f5f5ed
+_dragonfail_githash=0a2492c6aab3ff64e182db894ce4d40b26799fbd
+_termbox_githash=23fff64470b0730959b39c70aa31fbddd776d9bc
+build_style=gnu-makefile
+conf_files="/etc/ly/config.ini"
+makedepends="ncurses-devel pam-devel xcb-util-devel libX11-devel"
+depends="pam util-linux xauth"
+short_desc="TUI (ncurses-like) display manager"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
+license="WTFPL"
+homepage="https://github.com/nullgemm/ly"
+distfiles="https://github.com/nullgemm/ly/archive/v${version}.tar.gz
+ https://github.com/nullgemm/argoat/archive/${_argoat_githash}.tar.gz>argoat-${_argoat_githash}.tar.gz
+ https://github.com/nullgemm/testoasterror/archive/${_testoasterror_githash}.tar.gz>testoasterror-${_testoasterror_githash}.tar.gz
+ https://github.com/nullgemm/configator/archive/${_configator_githash}.tar.gz>configator-${_configator_githash}.tar.gz
+ https://raw.githubusercontent.com/nullgemm/ctypes/${_ctypes_githash}/ctypes.h>ctypes-${_ctypes_githash}.h
+ https://github.com/nullgemm/dragonfail/archive/${_dragonfail_githash}.tar.gz>dragonfail-${_dragonfail_githash}.tar.gz
+ https://github.com/nullgemm/termbox_next/archive/${_termbox_githash}.tar.gz>termbox_next-${_termbox_githash}.tar.gz"
+checksum="3460c2c8015add2946f9ff5d3e4bf051d7c07005698fe61279cedacd1283e010
+ 65b0b5d688f8538513f335795156441365b9cb319a28d2defbb29d81ea43a188
+ d627845bcece46499801bbef5b2ccf3e0bfe39493b52a16ae34478e54ab11bd6
+ 2067100f9779eceb5abefa9402ed56546314ca5ad6b3d5156d3e1eb46c853679
+ ef169974c68b548dc8ac83bd4714622775b024fab07dc2b7fe96e8e8f102dbab
+ d5cdd6d528a43c35d08e7fcac849370c07d949671ef592cfecb02b23ad3c4dad
+ 76d73183d2191e9e37285f39f2b1bd51f1dc2d991637902ff3c1aa35111b288d"
+skip_extraction="ctypes-${_ctypes_githash}.h"
+
+post_extract() {
+	cp -rv ../argoat-${_argoat_githash}/* sub/argoat/
+	cp -rv ../testoasterror-${_testoasterror_githash}/* sub/argoat/sub/testoasterror/
+	cp -rv ../configator-${_configator_githash}/* sub/configator/
+	cp -rv $XBPS_SRCDISTDIR/$pkgname-$version/ctypes-${_ctypes_githash}.h sub/ctypes/ctypes.h
+	cp -rv ../dragonfail-${_dragonfail_githash}/* sub/dragonfail/
+	cp -rv ../termbox_next-${_termbox_githash}/* sub/termbox_next/
+}
+
+pre_build() {
+	cd sub/argoat/sub/testoasterror
+	make
+	cd ../../
+	make
+	cd ../../
+	vsed -i makefile -e "s/^\t@/\t/g"
+}
+
+post_install() {
+	rm -f $DESTDIR/usr/lib/systemd/system/ly.service
+	vsv ly
+}

Re: [PR REVIEW] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r466102315

Comment:
I just tested it again without the `chvt` and it works just fine; I think I might have also changed something else last time. I've removed the `chvt` and `reset` because they're no longer needed.

Re: [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 860 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-669646361

Comment:
@ericonr I didn't think to check my dmesg logs before, but it's segfaulting for me as well. Here's what I believe to be the relevant portion of the logs:
```
[17802.088814] elogind-daemon[1786]: New session 3 of user erebus.
[17802.118293] ly[22191]: segfault at 0 ip 00007f8a457453e1 sp 00007ffc0c1a7248 error 4 in libc-2.30.so[7f8a4560c000+149000]
[17802.118304] Code: 84 00 00 00 00 00 0f 1f 00 31 c0 c5 f8 77 c3 66 2e 0f 1f 84 00 00 00 00 00 89 f9 48 89 fa c5 f9 ef c0 83 e1 3f 83 f9 20 77 1f <c5> fd 74 0f c5 fd d7 c1 85 c0 0f 85 df 00 00 00 48 83 c7 20 83 e1
[17822.337659] elogind-daemon[1786]: Removed session 3.
```
This means that it's not actually a PAM problem but a full-on crashing problem, right?

Re: [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-669648310

Comment:
> This means that it's not actually a PAM problem but a full-on crashing problem, right?

It's still potentially a PAM problem, I really don't know. I'm trying to debug it to see if I can catch the error. What seems to happen is that `ly` forks itself to do something, and then that segfaults.

Re: [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-669648310

Comment:
> This means that it's not actually a PAM problem but a full-on crashing problem, right?

It's still potentially a PAM problem, I really don't know. I'm trying to debug it to see if I can catch the error. What seems to happen is that `ly` forks itself to do something, and then that segfaults. The main process is still alive/

Re: [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-669663661

Comment:
Found it! In ly's `env_init` function, it tries to get the contents of the environment variable `LANG`, which might not be set (it isn't, on my system). `getenv` returns a NULL pointer in this case, and when it tries to access that pointer it segfaults. Basically what you need to do is set `LANG` to something, so it doesn't seg fault. I can report this upstream later.

You can do something like this for the service, to solve this:

```
LANG="$LANG" exec setsid ...
```

Re: [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-669666141

Comment:
Haven't tested the login service there, but the cross compiled version seems to work fine on armv6l-musl.

Re: [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-669669526

Comment:
If you could make a patch / vsed command in `sub/termbox_next/makefile` to use `$(AR)` instead of `ar`, that would be great too. This should also be upstreamed, if possible.

Re: [PR PATCH] [Updated] [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

There is an updated pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages ly
https://github.com/void-linux/void-packages/pull/24038

[WIP] New package: ly-0.5.2
[ly](https://github.com/nullgemm/ly) is a simple TUI display manager. It recently had a new tagged release, and I thought this would be a good time to try to package it. ly has been requested multiple times (https://github.com/void-linux/void-packages/issues/1577, https://github.com/void-linux/void-packages/issues/13583), and there have been multiple attempts to package it (https://github.com/void-linux/void-packages/pull/1702, https://github.com/void-linux/void-packages/pull/13649, https://github.com/void-linux/void-packages/pull/20496). The template is based almost entirely on [this template](https://github.com/ericonr/void-packages/commit/eadabab675acaff062d138a2607d5920b125bfde) by @ericonr, and the service files were taken from [a fork of ly made to work with Void](https://github.com/drozdowsky/ly-void/commit/b972fe48a143e709dc695ac8e2c83dc57cee279f). The patches make minor adjustments to make ly display on the standard TTY 7 and remove the systemD service.

ly is able to build properly on my machine; I'll soon see if it build properly through travis. The problem with this package is that it doesn't seem to work quite right after it starts running. I get PAM errors when attempting to log in using ly; you can see those errors in [this issue in the ly repository](https://github.com/nullgemm/ly/issues/216). My hunch is that the problem lies in [ly's PAM file](https://github.com/nullgemm/ly/blob/master/res/pam.d/ly). Does anyone know how to patch this to work properly?

A patch file from https://github.com/void-linux/void-packages/pull/24038.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ly-24038.patch --]
[-- Type: text/x-diff, Size: 4827 bytes --]

From dd46b0a07ef31575889dd974e1cba50aabed62c9 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Thu, 6 Aug 2020 00:50:05 -0400
Subject: [PATCH] New package: ly-0.5.2

---
 srcpkgs/ly/files/ly/conf            |  8 ++++
 srcpkgs/ly/files/ly/run             |  5 +++
 srcpkgs/ly/patches/config.ini.patch | 12 ++++++
 srcpkgs/ly/template                 | 57 +++++++++++++++++++++++++++++
 4 files changed, 82 insertions(+)
 create mode 100644 srcpkgs/ly/files/ly/conf
 create mode 100755 srcpkgs/ly/files/ly/run
 create mode 100644 srcpkgs/ly/patches/config.ini.patch
 create mode 100644 srcpkgs/ly/template

diff --git a/srcpkgs/ly/files/ly/conf b/srcpkgs/ly/files/ly/conf
new file mode 100644
index 00000000000..31223b16bfb
--- /dev/null
+++ b/srcpkgs/ly/files/ly/conf
@@ -0,0 +1,8 @@
+BAUD_RATE=38400
+TERM_NAME=linux
+# don't change the following value without also changing the "tty" value in /etc/ly/config.ini
+TTY=7
+
+if [ "${TTY}" = "1" ]; then
+	GETTY_ARGS="--noclear"
+fi
diff --git a/srcpkgs/ly/files/ly/run b/srcpkgs/ly/files/ly/run
new file mode 100755
index 00000000000..8585549abbc
--- /dev/null
+++ b/srcpkgs/ly/files/ly/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+[ -r conf ] && . ./conf
+
+LANG="$LANG" exec setsid agetty ${GETTY_ARGS} -nl /usr/bin/ly "tty${TTY}" "${BAUD_RATE}" "${TERM_NAME}"
diff --git a/srcpkgs/ly/patches/config.ini.patch b/srcpkgs/ly/patches/config.ini.patch
new file mode 100644
index 00000000000..0adeb3bc93a
--- /dev/null
+++ b/srcpkgs/ly/patches/config.ini.patch
@@ -0,0 +1,12 @@
+--- res/config.ini	2020-07-28 11:35:08.000000000 -0400
++++ "res/config copy.ini"	2020-08-05 00:00:19.044893166 -0400
+@@ -79,7 +79,8 @@
+ #term_reset_cmd = /usr/bin/tput reset
+ 
+ # tty in use
+-#tty = 2
++# if you change this value, you must also change the "TTY" value in /etc/sv/ly/conf
++tty = 7
+ 
+ # wayland setup command
+ #wayland_cmd = /etc/ly/wsetup.sh
diff --git a/srcpkgs/ly/template b/srcpkgs/ly/template
new file mode 100644
index 00000000000..443b1b2f972
--- /dev/null
+++ b/srcpkgs/ly/template
@@ -0,0 +1,57 @@
+# Template file for 'ly'
+pkgname=ly
+version=0.5.2
+revision=1
+_argoat_githash=0eb7afae7a001094c9166a8959e021375707522c
+_testoasterror_githash=ee7c9d031d4632a6f381a6c174a38539bac04068
+_configator_githash=8cec1786196ae6f6a8b35e66181277457f2a2bb2
+_ctypes_githash=eb4b36559de8d17015f9416861ed085d06f5f5ed
+_dragonfail_githash=0a2492c6aab3ff64e182db894ce4d40b26799fbd
+_termbox_githash=23fff64470b0730959b39c70aa31fbddd776d9bc
+build_style=gnu-makefile
+conf_files="/etc/ly/config.ini"
+makedepends="ncurses-devel pam-devel xcb-util-devel libX11-devel"
+depends="pam util-linux xauth"
+short_desc="TUI (ncurses-like) display manager"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
+license="WTFPL"
+homepage="https://github.com/nullgemm/ly"
+distfiles="https://github.com/nullgemm/ly/archive/v${version}.tar.gz
+ https://github.com/nullgemm/argoat/archive/${_argoat_githash}.tar.gz>argoat-${_argoat_githash}.tar.gz
+ https://github.com/nullgemm/testoasterror/archive/${_testoasterror_githash}.tar.gz>testoasterror-${_testoasterror_githash}.tar.gz
+ https://github.com/nullgemm/configator/archive/${_configator_githash}.tar.gz>configator-${_configator_githash}.tar.gz
+ https://raw.githubusercontent.com/nullgemm/ctypes/${_ctypes_githash}/ctypes.h>ctypes-${_ctypes_githash}.h
+ https://github.com/nullgemm/dragonfail/archive/${_dragonfail_githash}.tar.gz>dragonfail-${_dragonfail_githash}.tar.gz
+ https://github.com/nullgemm/termbox_next/archive/${_termbox_githash}.tar.gz>termbox_next-${_termbox_githash}.tar.gz"
+checksum="3460c2c8015add2946f9ff5d3e4bf051d7c07005698fe61279cedacd1283e010
+ 65b0b5d688f8538513f335795156441365b9cb319a28d2defbb29d81ea43a188
+ d627845bcece46499801bbef5b2ccf3e0bfe39493b52a16ae34478e54ab11bd6
+ 2067100f9779eceb5abefa9402ed56546314ca5ad6b3d5156d3e1eb46c853679
+ ef169974c68b548dc8ac83bd4714622775b024fab07dc2b7fe96e8e8f102dbab
+ d5cdd6d528a43c35d08e7fcac849370c07d949671ef592cfecb02b23ad3c4dad
+ 76d73183d2191e9e37285f39f2b1bd51f1dc2d991637902ff3c1aa35111b288d"
+skip_extraction="ctypes-${_ctypes_githash}.h"
+
+post_extract() {
+	cp -rv ../argoat-${_argoat_githash}/* sub/argoat/
+	cp -rv ../testoasterror-${_testoasterror_githash}/* sub/argoat/sub/testoasterror/
+	cp -rv ../configator-${_configator_githash}/* sub/configator/
+	cp -rv $XBPS_SRCDISTDIR/$pkgname-$version/ctypes-${_ctypes_githash}.h sub/ctypes/ctypes.h
+	cp -rv ../dragonfail-${_dragonfail_githash}/* sub/dragonfail/
+	cp -rv ../termbox_next-${_termbox_githash}/* sub/termbox_next/
+}
+
+pre_build() {
+	cd sub/argoat/sub/testoasterror
+	make
+	cd ../../
+	make
+	cd ../../
+	vsed -i makefile -e "s/^\t@/\t/g"
+	vsed -i sub/termbox_next/makefile -e "s/^\t@ar/\t@\$(AR)/g"
+}
+
+post_install() {
+	rm -f $DESTDIR/usr/lib/systemd/system/ly.service
+	vsv ly
+}

Re: [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-669691640

Comment:
> If you could make a patch / vsed command in `sub/termbox_next/makefile` to use `$(AR)` instead of `ar`, that would be great too. This should also be upstreamed, if possible.

I added a `vsed` to do this in the template. I also opened a pull request here: https://github.com/nullgemm/termbox_next/pull/5

> LANG="$LANG" exec setsid ...

I added this to the `run` file, and it now works perfectly! Thank you so much! Do you think the `LANG="$LANG"` part could be moved to the `conf` file, or does it have to directly precede the `exec` command?

Re: [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-669702767

Comment:
> Do you think the LANG="$LANG" part could be moved to the conf file, or does it have to directly precede the exec command?

It needs to be in the `run` file to be sure it's exported to the application, since the application crashes without it. The user can do whatever they want to it in the `conf` file, and the final value is what ly will see.

Re: New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-669932461

Comment:
In that case, I think this is fine to to merged, right?

Re: New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-669968297

Comment:
My builddir is dirty after the build:

```
argoat-0eb7afae7a001094c9166a8959e021375707522c
configator-8cec1786196ae6f6a8b35e66181277457f2a2bb2
dragonfail-0a2492c6aab3ff64e182db894ce4d40b26799fbd
termbox_next-23fff64470b0730959b39c70aa31fbddd776d9bc
testoasterror-ee7c9d031d4632a6f381a6c174a38539bac04068
```

You can try to use `create_wrksrc` + `build_wrksrc` to make it so this doesn't happen. The `Waybar` template does a similar trick.

Re: [PR REVIEW] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r466468704

Comment:
What do you think about adding an option to source `/etc/locale.conf` ? Having `LANG` set can be nice for your session.

Re: [PR REVIEW] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r466485567

Comment:
When you say "option", do you mean putting it in an `if` block like the `GETTY_ARGS`, or having it be commented out by default in the `conf` file with an explanation of what it will do if un-commented?

Re: [PR REVIEW] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r466492556

Comment:
"option" is a bad word. You can just check if it exists, and if so, source it. Kinda like it's done for the `conf` file itself.

Re: [PR PATCH] [Updated] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 1804 bytes --]

There is an updated pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages ly
https://github.com/void-linux/void-packages/pull/24038

New package: ly-0.5.2
[ly](https://github.com/nullgemm/ly) is a simple TUI display manager. It recently had a new tagged release, and I thought this would be a good time to try to package it. ly has been requested multiple times (https://github.com/void-linux/void-packages/issues/1577, https://github.com/void-linux/void-packages/issues/13583), and there have been multiple attempts to package it (https://github.com/void-linux/void-packages/pull/1702, https://github.com/void-linux/void-packages/pull/13649, https://github.com/void-linux/void-packages/pull/20496). The template is based almost entirely on [this template](https://github.com/ericonr/void-packages/commit/eadabab675acaff062d138a2607d5920b125bfde) by @ericonr, and the service files were taken from [a fork of ly made to work with Void](https://github.com/drozdowsky/ly-void/commit/b972fe48a143e709dc695ac8e2c83dc57cee279f). The patches make minor adjustments to make ly display on the standard TTY 7 and remove the systemD service.

ly is able to build properly on my machine; I'll soon see if it build properly through travis. The problem with this package is that it doesn't seem to work quite right after it starts running. I get PAM errors when attempting to log in using ly; you can see those errors in [this issue in the ly repository](https://github.com/nullgemm/ly/issues/216). My hunch is that the problem lies in [ly's PAM file](https://github.com/nullgemm/ly/blob/master/res/pam.d/ly). Does anyone know how to patch this to work properly?

A patch file from https://github.com/void-linux/void-packages/pull/24038.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ly-24038.patch --]
[-- Type: text/x-diff, Size: 5382 bytes --]

From 65697a869e1e65c10c9f986fbfc680c8e65fd41c Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Thu, 6 Aug 2020 15:31:58 -0400
Subject: [PATCH] New package: ly-0.5.2

---
 srcpkgs/ly/files/ly/conf            | 10 +++++
 srcpkgs/ly/files/ly/finish          |  5 +++
 srcpkgs/ly/files/ly/run             |  5 +++
 srcpkgs/ly/patches/config.ini.patch | 13 +++++++
 srcpkgs/ly/template                 | 59 +++++++++++++++++++++++++++++
 5 files changed, 92 insertions(+)
 create mode 100644 srcpkgs/ly/files/ly/conf
 create mode 100755 srcpkgs/ly/files/ly/finish
 create mode 100755 srcpkgs/ly/files/ly/run
 create mode 100644 srcpkgs/ly/patches/config.ini.patch
 create mode 100644 srcpkgs/ly/template

diff --git a/srcpkgs/ly/files/ly/conf b/srcpkgs/ly/files/ly/conf
new file mode 100644
index 00000000000..aaf30562b81
--- /dev/null
+++ b/srcpkgs/ly/files/ly/conf
@@ -0,0 +1,10 @@
+BAUD_RATE=38400
+TERM_NAME=linux
+# don't change the following value without also changing the "tty" value in /etc/ly/config.ini
+TTY=7
+
+if [ "${TTY}" = "1" ]; then
+	GETTY_ARGS="--noclear"
+fi
+
+[ -r /etc/locale.conf ] && . /etc/locale.conf
diff --git a/srcpkgs/ly/files/ly/finish b/srcpkgs/ly/files/ly/finish
new file mode 100755
index 00000000000..2c107a46656
--- /dev/null
+++ b/srcpkgs/ly/files/ly/finish
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+[ -r conf ] && . ./conf 
+
+exec utmpset -w "tty${TTY}"
diff --git a/srcpkgs/ly/files/ly/run b/srcpkgs/ly/files/ly/run
new file mode 100755
index 00000000000..8585549abbc
--- /dev/null
+++ b/srcpkgs/ly/files/ly/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+[ -r conf ] && . ./conf
+
+LANG="$LANG" exec setsid agetty ${GETTY_ARGS} -nl /usr/bin/ly "tty${TTY}" "${BAUD_RATE}" "${TERM_NAME}"
diff --git a/srcpkgs/ly/patches/config.ini.patch b/srcpkgs/ly/patches/config.ini.patch
new file mode 100644
index 00000000000..b3098e1a48f
--- /dev/null
+++ b/srcpkgs/ly/patches/config.ini.patch
@@ -0,0 +1,13 @@
+Changes default TTY to 7
+--- ly-0.5.2/res/config.ini	2020-07-28 11:35:08.000000000 -0400
++++ "ly-0.5.2/res/config copy.ini"	2020-08-06 14:20:41.677126155 -0400
+@@ -79,7 +79,8 @@
+ #term_reset_cmd = /usr/bin/tput reset
+ 
+ # tty in use
+-#tty = 2
++# if you change this value, you must also change the "TTY" value in /etc/sv/ly/conf
++tty = 7
+ 
+ # wayland setup command
+ #wayland_cmd = /etc/ly/wsetup.sh
diff --git a/srcpkgs/ly/template b/srcpkgs/ly/template
new file mode 100644
index 00000000000..eaf0ed7c5a3
--- /dev/null
+++ b/srcpkgs/ly/template
@@ -0,0 +1,59 @@
+# Template file for 'ly'
+pkgname=ly
+version=0.5.2
+revision=1
+create_wrksrc=yes
+build_wrksrc=${pkgname}-${version}
+_argoat_githash=0eb7afae7a001094c9166a8959e021375707522c
+_testoasterror_githash=ee7c9d031d4632a6f381a6c174a38539bac04068
+_configator_githash=8cec1786196ae6f6a8b35e66181277457f2a2bb2
+_ctypes_githash=eb4b36559de8d17015f9416861ed085d06f5f5ed
+_dragonfail_githash=0a2492c6aab3ff64e182db894ce4d40b26799fbd
+_termbox_githash=23fff64470b0730959b39c70aa31fbddd776d9bc
+build_style=gnu-makefile
+conf_files="/etc/ly/config.ini"
+makedepends="ncurses-devel pam-devel xcb-util-devel libX11-devel"
+depends="pam util-linux xauth"
+short_desc="TUI (ncurses-like) display manager"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
+license="WTFPL"
+homepage="https://github.com/nullgemm/ly"
+distfiles="https://github.com/nullgemm/ly/archive/v${version}.tar.gz
+ https://github.com/nullgemm/argoat/archive/${_argoat_githash}.tar.gz>argoat-${_argoat_githash}.tar.gz
+ https://github.com/nullgemm/testoasterror/archive/${_testoasterror_githash}.tar.gz>testoasterror-${_testoasterror_githash}.tar.gz
+ https://github.com/nullgemm/configator/archive/${_configator_githash}.tar.gz>configator-${_configator_githash}.tar.gz
+ https://raw.githubusercontent.com/nullgemm/ctypes/${_ctypes_githash}/ctypes.h>ctypes-${_ctypes_githash}.h
+ https://github.com/nullgemm/dragonfail/archive/${_dragonfail_githash}.tar.gz>dragonfail-${_dragonfail_githash}.tar.gz
+ https://github.com/nullgemm/termbox_next/archive/${_termbox_githash}.tar.gz>termbox_next-${_termbox_githash}.tar.gz"
+checksum="3460c2c8015add2946f9ff5d3e4bf051d7c07005698fe61279cedacd1283e010
+ 65b0b5d688f8538513f335795156441365b9cb319a28d2defbb29d81ea43a188
+ d627845bcece46499801bbef5b2ccf3e0bfe39493b52a16ae34478e54ab11bd6
+ 2067100f9779eceb5abefa9402ed56546314ca5ad6b3d5156d3e1eb46c853679
+ ef169974c68b548dc8ac83bd4714622775b024fab07dc2b7fe96e8e8f102dbab
+ d5cdd6d528a43c35d08e7fcac849370c07d949671ef592cfecb02b23ad3c4dad
+ 76d73183d2191e9e37285f39f2b1bd51f1dc2d991637902ff3c1aa35111b288d"
+skip_extraction="ctypes-${_ctypes_githash}.h"
+
+post_extract() {
+	mv argoat-${_argoat_githash}/* ${build_wrksrc}/sub/argoat/
+	mv testoasterror-${_testoasterror_githash}/* ${build_wrksrc}/sub/argoat/sub/testoasterror/
+	mv configator-${_configator_githash}/* ${build_wrksrc}/sub/configator/
+	mv $XBPS_SRCDISTDIR/$pkgname-$version/ctypes-${_ctypes_githash}.h ${build_wrksrc}/sub/ctypes/ctypes.h
+	mv dragonfail-${_dragonfail_githash}/* ${build_wrksrc}/sub/dragonfail/
+	mv termbox_next-${_termbox_githash}/* ${build_wrksrc}/sub/termbox_next/
+}
+
+pre_build() {
+	cd sub/argoat/sub/testoasterror
+	make
+	cd ../../
+	make
+	cd ../../
+	vsed -i makefile -e "s/^\t@/\t/g"
+	vsed -i sub/termbox_next/makefile -e "s/^\t@ar/\t@\$(AR)/g"
+}
+
+post_install() {
+	rm -f $DESTDIR/usr/lib/systemd/system/ly.service
+	vsv ly
+}

Re: [PR REVIEW] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#discussion_r466639909

Comment:
I've added that in the most recent push.

Re: [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-670153394

Comment:
> My builddir is dirty after the build

I've fixed this in the most recent version of the template. However, while testing`ly`, I ran into a problem that might need fixing (that's why this PR is a draft again). Upon logging in using `ly`, switching to another TTY, and then disabling the `ly` service, the computer freezes. This doesn't happen when using my current DM (`sddm`),so I assume it's unintended behavior. I attempted to fix this by including the `finish` file, but it didn't help. Since the computer freezes, I'm not sure how to check `dmesg` logs from the event, or if those are even the correct logs to check.

Re: [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-670155284

Comment:
Does it completely freeze? Is not even `ssh` working?

Re: [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-670170657

Comment:
> Is not even ssh working?

Do you mean is it possible to ssh into my machine after it freezes? I haven't tried it yet. Might be difficult to do since I'm testing this on my laptop and I don't really have any other devices.

Re: [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-670178421

Comment:
There are SSH clients for smartphones, if you have that. Otherwise, can you try listing the steps here? Which session did you log into? I haven't managed to reproduce it.

Re: [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-670196801

Comment:
I was able to access it through ssh and was able to access `dmesg` logs, but I didn't see anything out of the ordinary. If you can't reproduce it, then it might just be a me problem (and even then, the actions I took aren't likely to occur often enough to be a problem). Assuming that's the case, would it be alright to mark this as ready for review?

Re: [WIP] New package: ly-0.5.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-670207059

Comment:
I think so, it is quite unusual.

Regarding your issue, which session did you start, X or Wayland? When it seems to be locked, could you try pressing `Alt+SysRq+R` and then checking if you can interact with the system? (The SysRq key is usually the Print Screen one - PrtScr)

Re: [WIP] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-670243711

Comment:
I started X. Pressing `Alt+SysRq+R` didn't do anything. Since this problem is likely limited to me, I'll be marking this as ready for review momentarily. If anyone files an issue about it here, asks about it on IRC, or makes a post on the subreddit I'll take another look at it.

Off-topic, but once this gets merged, would you mind taking a look at two other PR's I have open? Travis doesn't report any problems with the most recent version of the templates, so it should be quick: #23924 #23972 

Re: New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-671548343

Comment:
I've edited the opening comment so that merging this PR will automatically close the open issue that's a package request for ly. I would appreciate a maintainer closing the PR I linked in the opening comment after merging this as well. Is there anything remaining that is keeping this from being merged? This (and a couple of my other PRs linked above) have been sitting open for a few days without additional feedback.

Re: New package: ly-0.5.2

[PaperMountainStudio]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

New comment by PaperMountainStudio on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-671990323

Comment:
@cinerea0 Hi, I noticed version number is not built in the binary. ly uses git to determine which version it is running, that's why during build there are warnings `/bin/sh: git: command not found`. Adding git into `hostmakedepends` will not solve this, because in the extracted tarball, is not a git repository.

Re: New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-672223831

Comment:
@PaperMountainStudio In that case, the git errors in that part of the build process can be completely ignored, right?

Re: New package: ly-0.5.2

[PaperMountainStudio]

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

New comment by PaperMountainStudio on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-672228726

Comment:
You could, but then printing version wouldn't work (not a big issue, I think). Or you could patch one line in the makefile. ---- On Tue, 11 Aug 2020 21:39:04 +0200  notifications@github.com  wrote ----
@PaperMountainStudio In that case, the git errors in that part of the build process can be completely ignored, right?

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

Re: [PR PATCH] [Updated] New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 1495 bytes --]

There is an updated pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages ly
https://github.com/void-linux/void-packages/pull/24038

New package: ly-0.5.2
[ly](https://github.com/nullgemm/ly) is a simple TUI display manager. It recently had a new tagged release, and I thought this would be a good time to try to package it. This PR would resolve #13583 and would allow #13649 to be closed. The template is based almost entirely on [this template](https://github.com/ericonr/void-packages/commit/eadabab675acaff062d138a2607d5920b125bfde) by @ericonr, and the service files were taken from [a fork of ly made to work with Void](https://github.com/drozdowsky/ly-void/commit/b972fe48a143e709dc695ac8e2c83dc57cee279f). The patches make minor adjustments to make ly display on the standard TTY 7 and remove the systemD service.

ly is able to build properly on my machine; I'll soon see if it build properly through travis. The problem with this package is that it doesn't seem to work quite right after it starts running. I get PAM errors when attempting to log in using ly; you can see those errors in [this issue in the ly repository](https://github.com/nullgemm/ly/issues/216). My hunch is that the problem lies in [ly's PAM file](https://github.com/nullgemm/ly/blob/master/res/pam.d/ly). Does anyone know how to patch this to work properly?

A patch file from https://github.com/void-linux/void-packages/pull/24038.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ly-24038.patch --]
[-- Type: text/x-diff, Size: 5496 bytes --]

From 92f994ad74cf72b804ea980c43a0103afb1bffbd Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Tue, 11 Aug 2020 21:58:37 -0400
Subject: [PATCH] New package: ly-0.5.2

---
 srcpkgs/ly/files/ly/conf            | 10 +++++
 srcpkgs/ly/files/ly/finish          |  5 +++
 srcpkgs/ly/files/ly/run             |  5 +++
 srcpkgs/ly/patches/config.ini.patch | 13 +++++++
 srcpkgs/ly/template                 | 60 +++++++++++++++++++++++++++++
 5 files changed, 93 insertions(+)
 create mode 100644 srcpkgs/ly/files/ly/conf
 create mode 100755 srcpkgs/ly/files/ly/finish
 create mode 100755 srcpkgs/ly/files/ly/run
 create mode 100644 srcpkgs/ly/patches/config.ini.patch
 create mode 100644 srcpkgs/ly/template

diff --git a/srcpkgs/ly/files/ly/conf b/srcpkgs/ly/files/ly/conf
new file mode 100644
index 00000000000..aaf30562b81
--- /dev/null
+++ b/srcpkgs/ly/files/ly/conf
@@ -0,0 +1,10 @@
+BAUD_RATE=38400
+TERM_NAME=linux
+# don't change the following value without also changing the "tty" value in /etc/ly/config.ini
+TTY=7
+
+if [ "${TTY}" = "1" ]; then
+	GETTY_ARGS="--noclear"
+fi
+
+[ -r /etc/locale.conf ] && . /etc/locale.conf
diff --git a/srcpkgs/ly/files/ly/finish b/srcpkgs/ly/files/ly/finish
new file mode 100755
index 00000000000..2c107a46656
--- /dev/null
+++ b/srcpkgs/ly/files/ly/finish
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+[ -r conf ] && . ./conf 
+
+exec utmpset -w "tty${TTY}"
diff --git a/srcpkgs/ly/files/ly/run b/srcpkgs/ly/files/ly/run
new file mode 100755
index 00000000000..8585549abbc
--- /dev/null
+++ b/srcpkgs/ly/files/ly/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+[ -r conf ] && . ./conf
+
+LANG="$LANG" exec setsid agetty ${GETTY_ARGS} -nl /usr/bin/ly "tty${TTY}" "${BAUD_RATE}" "${TERM_NAME}"
diff --git a/srcpkgs/ly/patches/config.ini.patch b/srcpkgs/ly/patches/config.ini.patch
new file mode 100644
index 00000000000..b3098e1a48f
--- /dev/null
+++ b/srcpkgs/ly/patches/config.ini.patch
@@ -0,0 +1,13 @@
+Changes default TTY to 7
+--- ly-0.5.2/res/config.ini	2020-07-28 11:35:08.000000000 -0400
++++ "ly-0.5.2/res/config copy.ini"	2020-08-06 14:20:41.677126155 -0400
+@@ -79,7 +79,8 @@
+ #term_reset_cmd = /usr/bin/tput reset
+ 
+ # tty in use
+-#tty = 2
++# if you change this value, you must also change the "TTY" value in /etc/sv/ly/conf
++tty = 7
+ 
+ # wayland setup command
+ #wayland_cmd = /etc/ly/wsetup.sh
diff --git a/srcpkgs/ly/template b/srcpkgs/ly/template
new file mode 100644
index 00000000000..605915794ad
--- /dev/null
+++ b/srcpkgs/ly/template
@@ -0,0 +1,60 @@
+# Template file for 'ly'
+pkgname=ly
+version=0.5.2
+revision=1
+create_wrksrc=yes
+build_wrksrc=${pkgname}-${version}
+_argoat_githash=0eb7afae7a001094c9166a8959e021375707522c
+_testoasterror_githash=ee7c9d031d4632a6f381a6c174a38539bac04068
+_configator_githash=8cec1786196ae6f6a8b35e66181277457f2a2bb2
+_ctypes_githash=eb4b36559de8d17015f9416861ed085d06f5f5ed
+_dragonfail_githash=0a2492c6aab3ff64e182db894ce4d40b26799fbd
+_termbox_githash=23fff64470b0730959b39c70aa31fbddd776d9bc
+build_style=gnu-makefile
+conf_files="/etc/ly/config.ini"
+makedepends="ncurses-devel pam-devel xcb-util-devel libX11-devel"
+depends="pam util-linux xauth"
+short_desc="TUI (ncurses-like) display manager"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
+license="WTFPL"
+homepage="https://github.com/nullgemm/ly"
+distfiles="https://github.com/nullgemm/ly/archive/v${version}.tar.gz
+ https://github.com/nullgemm/argoat/archive/${_argoat_githash}.tar.gz>argoat-${_argoat_githash}.tar.gz
+ https://github.com/nullgemm/testoasterror/archive/${_testoasterror_githash}.tar.gz>testoasterror-${_testoasterror_githash}.tar.gz
+ https://github.com/nullgemm/configator/archive/${_configator_githash}.tar.gz>configator-${_configator_githash}.tar.gz
+ https://raw.githubusercontent.com/nullgemm/ctypes/${_ctypes_githash}/ctypes.h>ctypes-${_ctypes_githash}.h
+ https://github.com/nullgemm/dragonfail/archive/${_dragonfail_githash}.tar.gz>dragonfail-${_dragonfail_githash}.tar.gz
+ https://github.com/nullgemm/termbox_next/archive/${_termbox_githash}.tar.gz>termbox_next-${_termbox_githash}.tar.gz"
+checksum="3460c2c8015add2946f9ff5d3e4bf051d7c07005698fe61279cedacd1283e010
+ 65b0b5d688f8538513f335795156441365b9cb319a28d2defbb29d81ea43a188
+ d627845bcece46499801bbef5b2ccf3e0bfe39493b52a16ae34478e54ab11bd6
+ 2067100f9779eceb5abefa9402ed56546314ca5ad6b3d5156d3e1eb46c853679
+ ef169974c68b548dc8ac83bd4714622775b024fab07dc2b7fe96e8e8f102dbab
+ d5cdd6d528a43c35d08e7fcac849370c07d949671ef592cfecb02b23ad3c4dad
+ 76d73183d2191e9e37285f39f2b1bd51f1dc2d991637902ff3c1aa35111b288d"
+skip_extraction="ctypes-${_ctypes_githash}.h"
+
+post_extract() {
+	mv argoat-${_argoat_githash}/* ${build_wrksrc}/sub/argoat/
+	mv testoasterror-${_testoasterror_githash}/* ${build_wrksrc}/sub/argoat/sub/testoasterror/
+	mv configator-${_configator_githash}/* ${build_wrksrc}/sub/configator/
+	mv $XBPS_SRCDISTDIR/$pkgname-$version/ctypes-${_ctypes_githash}.h ${build_wrksrc}/sub/ctypes/ctypes.h
+	mv dragonfail-${_dragonfail_githash}/* ${build_wrksrc}/sub/dragonfail/
+	mv termbox_next-${_termbox_githash}/* ${build_wrksrc}/sub/termbox_next/
+}
+
+pre_build() {
+	cd sub/argoat/sub/testoasterror
+	make
+	cd ../../
+	make
+	cd ../../
+	vsed -i makefile -e "s/^FLAGS+= -DGIT_VERSION_STRING=.*/FLAGS+= -DGIT_VERSION_STRING=\\\\\"${version}\\\\\"/g"
+	vsed -i makefile -e "s/^\t@/\t/g"
+	vsed -i sub/termbox_next/makefile -e "s/^\t@ar/\t@\$(AR)/g"
+}
+
+post_install() {
+	rm -f $DESTDIR/usr/lib/systemd/system/ly.service
+	vsv ly
+}

Re: New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-672489255

Comment:
@PaperMountainStudio I've added a `vsed` line to the template in the most recent push that sets the version number correctly.

Re: New package: ly-0.5.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-673519247

Comment:
After discussion on IRC last night, a verdict was reached that this package is extremely unlikely to be merged in its current state because of all the unversioned dependencies that need to be downloaded and the necessary patching of the configuration file. As such, this PR is currently blocking on https://github.com/nullgemm/ly/issues/225 and https://github.com/nullgemm/ly/issues/226.

Re: [PR PATCH] [Closed]: [WIP] New package: ly-0.5.2

[abenson]

[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]

There's a closed pull request on the void-packages repository

[WIP] New package: ly-0.5.2
https://github.com/void-linux/void-packages/pull/24038

Description:
[ly](https://github.com/nullgemm/ly) is a simple TUI display manager. It recently had a new tagged release, and I thought this would be a good time to try to package it. This PR would resolve #13583 and would allow #13649 to be closed. The template is based almost entirely on [this template](https://github.com/ericonr/void-packages/commit/eadabab675acaff062d138a2607d5920b125bfde) by @ericonr, and the service files were taken from [a fork of ly made to work with Void](https://github.com/drozdowsky/ly-void/commit/b972fe48a143e709dc695ac8e2c83dc57cee279f). The patches make minor adjustments to make ly display on the standard TTY 7 and remove the systemD service.

ly is able to build properly on my machine; I'll soon see if it build properly through travis. The problem with this package is that it doesn't seem to work quite right after it starts running. I get PAM errors when attempting to log in using ly; you can see those errors in [this issue in the ly repository](https://github.com/nullgemm/ly/issues/216). My hunch is that the problem lies in [ly's PAM file](https://github.com/nullgemm/ly/blob/master/res/pam.d/ly). Does anyone know how to patch this to work properly?

Re: [WIP] New package: ly-0.5.2

[abenson]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/24038#issuecomment-962518894

Comment:
Seemingly abandoned.