Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] screenkey: update to 1.2.
@ 2020-08-30 12:38 not-chicken
  2020-09-02 17:58 ` Chocimier
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: not-chicken @ 2020-08-30 12:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

There is a new pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages skey
https://github.com/void-linux/void-packages/pull/24548

screenkey: update to 1.2.


A patch file from https://github.com/void-linux/void-packages/pull/24548.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-skey-24548.patch --]
[-- Type: text/x-diff, Size: 979 bytes --]

From de2766756795d607c5d49ba1709411eed65db767 Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Sun, 30 Aug 2020 18:01:13 +0530
Subject: [PATCH] screenkey: update to 1.2.

---
 srcpkgs/screenkey/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/screenkey/template b/srcpkgs/screenkey/template
index b4feb736b89..2ddff8201cb 100644
--- a/srcpkgs/screenkey/template
+++ b/srcpkgs/screenkey/template
@@ -1,6 +1,6 @@
 # Template file for 'screenkey'
 pkgname=screenkey
-version=1.1
+version=1.2
 revision=1
 archs=noarch
 build_style=python3-module
@@ -11,4 +11,4 @@ maintainer="Steve Prybylski <sa.prybylx@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="http://www.thregr.org/~wavexx/software/screenkey"
 distfiles="${homepage}/releases/screenkey-${version}.tar.gz"
-checksum=0f382e485bf185d9f4f549eab9cfe1a48c53d66dc9c362e6ab433e51c6842ed7
+checksum=6ef4dd759724bd498c9b193099e5650375810e209638e5f0d778dfb746ac5b73

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: screenkey: update to 1.2.
  2020-08-30 12:38 [PR PATCH] screenkey: update to 1.2 not-chicken
@ 2020-09-02 17:58 ` Chocimier
  2020-09-14 19:27 ` Chocimier
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Chocimier @ 2020-09-02 17:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/24548#issuecomment-685901525

Comment:
There are more mandatory dependencies. Tests fail.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: screenkey: update to 1.2.
  2020-08-30 12:38 [PR PATCH] screenkey: update to 1.2 not-chicken
  2020-09-02 17:58 ` Chocimier
@ 2020-09-14 19:27 ` Chocimier
  2020-09-15  2:58 ` not-chicken
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Chocimier @ 2020-09-14 19:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/24548#issuecomment-692264639

Comment:
Tests still fail. Add python3-cairo to depends and checkdepends="${depends} libXtst"

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: screenkey: update to 1.2.
  2020-08-30 12:38 [PR PATCH] screenkey: update to 1.2 not-chicken
  2020-09-02 17:58 ` Chocimier
  2020-09-14 19:27 ` Chocimier
@ 2020-09-15  2:58 ` not-chicken
  2020-09-15 21:23 ` Chocimier
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: not-chicken @ 2020-09-15  2:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/24548#issuecomment-692432321

Comment:
>Tests still fail

Idk if I'm doing something wrong, but `./xbps-src check` always gives `Ran 0 tests in 0.000s. OK` for me, even after proposed changes. Lacks a test suite?
 Or are you referring to something else?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: screenkey: update to 1.2.
  2020-08-30 12:38 [PR PATCH] screenkey: update to 1.2 not-chicken
                   ` (2 preceding siblings ...)
  2020-09-15  2:58 ` not-chicken
@ 2020-09-15 21:23 ` Chocimier
  2020-09-16  1:50 ` [PR PATCH] [Updated] " not-chicken
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Chocimier @ 2020-09-15 21:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2874 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/24548#issuecomment-692987314

Comment:
If you look at any dependencies list (webpage, setup.py, requires.txt, script itself), pycairo is there.

Yes, `./xbps-src check`. "Ran 0 tests in 0.000s" is good, it means tests were run but not counted, or at least module was imported.

Interesting that it passes for you, here it is

```
=> screenkey-1.2_1: running do_check ...
running test
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
WARNING: The pip package is not available, falling back to EasyInstall for handling setup_requires/test_requires; this is deprecated and will be removed in a future version.
Searching for pycairo
Reading https://pypi.org/simple/pycairo/
Downloading https://files.pythonhosted.org/packages/e8/9d/c8be300fc6b1298559d37a071c3833b0b251e0fff334d2e4c408d5789162/pycairo-1.19.1.tar.gz#sha256=2c143183280feb67f5beb4e543fd49990c28e7df427301ede04fc550d3562e84
Best match: pycairo 1.19.1
Processing pycairo-1.19.1.tar.gz
Writing /tmp/easy_install-1tkis69f/pycairo-1.19.1/setup.cfg
Running pycairo-1.19.1/setup.py -q bdist_egg --dist-dir /tmp/easy_install-1tkis69f/pycairo-1.19.1/egg-dist-tmp-qk9enuph
no previously-included directories found matching 'docs/_build'
warning: no files found matching 'README' under directory 'tests'
warning: no files found matching 'README' under directory 'examples'
error: Setup script exited with 'pkg-config' not found.
Command ['pkg-config', '--print-errors', '--exists', 'cairo >= 1.13.1']
=> ERROR: screenkey-1.2_1: do_check: 'python3 setup.py ${make_check_target} ${make_check_args}' exited with 1
=> ERROR:   in do_check() at common/build-style/python3-module.sh:35
```
first, then 
```
=> screenkey-1.2_1: running do_check ...
running test
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
running egg_info
writing screenkey.egg-info/PKG-INFO
writing dependency_links to screenkey.egg-info/dependency_links.txt
writing requirements to screenkey.egg-info/requires.txt
writing top-level names to screenkey.egg-info/top_level.txt
reading manifest file 'screenkey.egg-info/SOURCES.txt'
writing manifest file 'screenkey.egg-info/SOURCES.txt'
running build_ext
Unable to init server: Could not connect: Connection refused
Unable to init server: Could not connect: Connection refused

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
```
what means tests skipped, but dependencies are present.

Maybe you run it in some equipped masterdir?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] screenkey: update to 1.2.
  2020-08-30 12:38 [PR PATCH] screenkey: update to 1.2 not-chicken
                   ` (3 preceding siblings ...)
  2020-09-15 21:23 ` Chocimier
@ 2020-09-16  1:50 ` not-chicken
  2020-09-16  1:50 ` not-chicken
  2020-09-16 19:32 ` [PR PATCH] [Merged]: " Chocimier
  6 siblings, 0 replies; 8+ messages in thread
From: not-chicken @ 2020-09-16  1:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

There is an updated pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages skey
https://github.com/void-linux/void-packages/pull/24548

screenkey: update to 1.2.


A patch file from https://github.com/void-linux/void-packages/pull/24548.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-skey-24548.patch --]
[-- Type: text/x-diff, Size: 1192 bytes --]

From a11b7c346198e31bb63f3a37da9f66f9b25cccc9 Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Sun, 30 Aug 2020 18:01:13 +0530
Subject: [PATCH] screenkey: update to 1.2.

---
 srcpkgs/screenkey/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/screenkey/template b/srcpkgs/screenkey/template
index b4feb736b89..4608f9c9f15 100644
--- a/srcpkgs/screenkey/template
+++ b/srcpkgs/screenkey/template
@@ -1,14 +1,14 @@
 # Template file for 'screenkey'
 pkgname=screenkey
-version=1.1
+version=1.2
 revision=1
-archs=noarch
 build_style=python3-module
 hostmakedepends="intltool python3-setuptools python3-distutils-extra"
-depends="python3-gobject"
+depends="gtk+3 libX11 python3-gobject"
+checkdepends="${depends} libXtst"
 short_desc="Screencast tool to display your keys"
 maintainer="Steve Prybylski <sa.prybylx@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="http://www.thregr.org/~wavexx/software/screenkey"
 distfiles="${homepage}/releases/screenkey-${version}.tar.gz"
-checksum=0f382e485bf185d9f4f549eab9cfe1a48c53d66dc9c362e6ab433e51c6842ed7
+checksum=6ef4dd759724bd498c9b193099e5650375810e209638e5f0d778dfb746ac5b73

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: screenkey: update to 1.2.
  2020-08-30 12:38 [PR PATCH] screenkey: update to 1.2 not-chicken
                   ` (4 preceding siblings ...)
  2020-09-16  1:50 ` [PR PATCH] [Updated] " not-chicken
@ 2020-09-16  1:50 ` not-chicken
  2020-09-16 19:32 ` [PR PATCH] [Merged]: " Chocimier
  6 siblings, 0 replies; 8+ messages in thread
From: not-chicken @ 2020-09-16  1:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/24548#issuecomment-693121263

Comment:
> Maybe you run it in some equipped masterdir?

Indeed, I had a package installed there from some previous testing. My bad.

> If you look at any dependencies list (webpage, setup.py, requires.txt, script itself), pycairo is there.

Yes, but since it was implicitly pulled in via `python3-gobject`, it was left out. 
I haven't added it in recent push, let me know if there's any drawback in this approach.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Merged]: screenkey: update to 1.2.
  2020-08-30 12:38 [PR PATCH] screenkey: update to 1.2 not-chicken
                   ` (5 preceding siblings ...)
  2020-09-16  1:50 ` not-chicken
@ 2020-09-16 19:32 ` Chocimier
  6 siblings, 0 replies; 8+ messages in thread
From: Chocimier @ 2020-09-16 19:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

There's a merged pull request on the void-packages repository

screenkey: update to 1.2.
https://github.com/void-linux/void-packages/pull/24548

Description:


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-09-16 19:32 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-30 12:38 [PR PATCH] screenkey: update to 1.2 not-chicken
2020-09-02 17:58 ` Chocimier
2020-09-14 19:27 ` Chocimier
2020-09-15  2:58 ` not-chicken
2020-09-15 21:23 ` Chocimier
2020-09-16  1:50 ` [PR PATCH] [Updated] " not-chicken
2020-09-16  1:50 ` not-chicken
2020-09-16 19:32 ` [PR PATCH] [Merged]: " Chocimier

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git