Github messages for voidlinux
 help / color / mirror / Atom feed
From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] OpenXcom: rebuild against yaml-cpp
Date: Fri, 04 Sep 2020 01:46:26 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24650@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

There is a new pull request by ahesford against master on the void-packages repository

https://github.com/ahesford/void-packages openxcom
https://github.com/void-linux/void-packages/pull/24650

OpenXcom: rebuild against yaml-cpp
Apparently yaml-cpp breaks ABI without bumping the soname.

A patch file from https://github.com/void-linux/void-packages/pull/24650.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-openxcom-24650.patch --]
[-- Type: text/x-diff, Size: 1454 bytes --]

From cef3de1a0b1750bfbcb9474a4c6e2460193e3e7c Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Thu, 3 Sep 2020 19:43:41 -0400
Subject: [PATCH 1/2] yaml-cpp: Note possibility of ABI breakage without soname
 bumps

---
 srcpkgs/yaml-cpp/template | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/srcpkgs/yaml-cpp/template b/srcpkgs/yaml-cpp/template
index fbb9fdc093c..4f0339ee980 100644
--- a/srcpkgs/yaml-cpp/template
+++ b/srcpkgs/yaml-cpp/template
@@ -1,5 +1,7 @@
 # Template file for 'yaml-cpp'
 pkgname=yaml-cpp
+# yaml-cpp may break ABI even without changing the soname; when
+# updating, test dependants to determine if revbumps are needed
 version=0.6.3
 revision=1
 wrksrc="${pkgname}-${pkgname}-${version}"

From 27fd820928827dc4bd31821d2631566e6ae64662 Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Thu, 3 Sep 2020 19:44:03 -0400
Subject: [PATCH 2/2] OpenXcom: rebuild against current yaml-cpp

---
 srcpkgs/OpenXcom/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/OpenXcom/template b/srcpkgs/OpenXcom/template
index 7ae26fb5081..57629dd3242 100644
--- a/srcpkgs/OpenXcom/template
+++ b/srcpkgs/OpenXcom/template
@@ -1,7 +1,7 @@
 # Template file for 'OpenXcom'
 pkgname=OpenXcom
 version=1.0
-revision=3
+revision=4
 build_style=gnu-configure
 configure_args="--disable-silent-rules --disable-werror"
 hostmakedepends="automake pkg-config xmlto"

             reply	other threads:[~2020-09-03 23:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 23:46 ahesford [this message]
2020-09-04 13:57 ` [PR PATCH] [Closed]: " ahesford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24650@inbox.vuxu.org \
    --to=ahesford@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).