Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] gtk+: add reminder to revbump gtk-layer-shell.
@ 2020-09-06 15:55 ericonr
  2020-09-06 15:56 ` ericonr
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: ericonr @ 2020-09-06 15:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages gtk
https://github.com/void-linux/void-packages/pull/24717

gtk+: add reminder to revbump gtk-layer-shell.
If gtk-layer-shell isn't revbumped, it has warning messages like:

  ** (waybar:449): WARNING **: 12:44:32.403: gtk-layer-shell was not
  compiled with support for GTK v3.24.22, program may crash

A patch file from https://github.com/void-linux/void-packages/pull/24717.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gtk-24717.patch --]
[-- Type: text/x-diff, Size: 816 bytes --]

From 48f6ea6f2714a2d62760dbb399baa1a1a72574f3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 6 Sep 2020 12:52:53 -0300
Subject: [PATCH] gtk+: add reminder to revbump gtk-layer-shell.

If gtk-layer-shell isn't revbumped, it has warning messages like:

  ** (waybar:449): WARNING **: 12:44:32.403: gtk-layer-shell was not
  compiled with support for GTK v3.24.22, program may crash
---
 srcpkgs/gtk+/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/gtk+/template b/srcpkgs/gtk+/template
index 39883068d06..07bc8bf9196 100644
--- a/srcpkgs/gtk+/template
+++ b/srcpkgs/gtk+/template
@@ -1,4 +1,5 @@
 # Template file for 'gtk+'
+# Revbump gtk-layer-shell when updating, otherwise it presents a warning message
 pkgname=gtk+
 version=2.24.32
 revision=3

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: gtk+: add reminder to revbump gtk-layer-shell.
  2020-09-06 15:55 [PR PATCH] gtk+: add reminder to revbump gtk-layer-shell ericonr
@ 2020-09-06 15:56 ` ericonr
  2020-09-10 13:49 ` sgn
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-09-06 15:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24717#issuecomment-687826717

Comment:
I'm not revbumping it here because #24259 is updating it.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: gtk+: add reminder to revbump gtk-layer-shell.
  2020-09-06 15:55 [PR PATCH] gtk+: add reminder to revbump gtk-layer-shell ericonr
  2020-09-06 15:56 ` ericonr
@ 2020-09-10 13:49 ` sgn
  2020-09-10 13:53 ` ericonr
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: sgn @ 2020-09-10 13:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24717#issuecomment-690301704

Comment:
Is the commit message correct? Note that it says `3.24.22` instead of `2.24.22`, anyway we should set
```
depends="gtk+>=2.24.22"
```
in `gtk-layer-shell`?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: gtk+: add reminder to revbump gtk-layer-shell.
  2020-09-06 15:55 [PR PATCH] gtk+: add reminder to revbump gtk-layer-shell ericonr
  2020-09-06 15:56 ` ericonr
  2020-09-10 13:49 ` sgn
@ 2020-09-10 13:53 ` ericonr
  2020-09-10 13:54 ` [PR PATCH] [Updated] " ericonr
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-09-10 13:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24717#issuecomment-690303824

Comment:
I'm making the change in the wrong template 🤦

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] gtk+: add reminder to revbump gtk-layer-shell.
  2020-09-06 15:55 [PR PATCH] gtk+: add reminder to revbump gtk-layer-shell ericonr
                   ` (2 preceding siblings ...)
  2020-09-10 13:53 ` ericonr
@ 2020-09-10 13:54 ` ericonr
  2020-09-10 13:54 ` ericonr
  2020-09-17 15:56 ` [PR PATCH] [Merged]: " sgn
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-09-10 13:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages gtk
https://github.com/void-linux/void-packages/pull/24717

gtk+: add reminder to revbump gtk-layer-shell.
If gtk-layer-shell isn't revbumped, it has warning messages like:

  ** (waybar:449): WARNING **: 12:44:32.403: gtk-layer-shell was not
  compiled with support for GTK v3.24.22, program may crash

A patch file from https://github.com/void-linux/void-packages/pull/24717.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gtk-24717.patch --]
[-- Type: text/x-diff, Size: 824 bytes --]

From e03930195625e495551f363f9aa481e1133ecd54 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 6 Sep 2020 12:52:53 -0300
Subject: [PATCH] gtk+3: add reminder to revbump gtk-layer-shell.

If gtk-layer-shell isn't revbumped, it has warning messages like:

  ** (waybar:449): WARNING **: 12:44:32.403: gtk-layer-shell was not
  compiled with support for GTK v3.24.22, program may crash
---
 srcpkgs/gtk+3/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/gtk+3/template b/srcpkgs/gtk+3/template
index bbc37e644d1..f87019d93ed 100644
--- a/srcpkgs/gtk+3/template
+++ b/srcpkgs/gtk+3/template
@@ -1,4 +1,5 @@
 # Template file for 'gtk+3'
+# Revbump gtk-layer-shell when updating, otherwise it presents a warning message
 pkgname=gtk+3
 version=3.24.22
 revision=1

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: gtk+: add reminder to revbump gtk-layer-shell.
  2020-09-06 15:55 [PR PATCH] gtk+: add reminder to revbump gtk-layer-shell ericonr
                   ` (3 preceding siblings ...)
  2020-09-10 13:54 ` [PR PATCH] [Updated] " ericonr
@ 2020-09-10 13:54 ` ericonr
  2020-09-17 15:56 ` [PR PATCH] [Merged]: " sgn
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-09-10 13:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24717#issuecomment-690304617

Comment:
Should be good now.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Merged]: gtk+: add reminder to revbump gtk-layer-shell.
  2020-09-06 15:55 [PR PATCH] gtk+: add reminder to revbump gtk-layer-shell ericonr
                   ` (4 preceding siblings ...)
  2020-09-10 13:54 ` ericonr
@ 2020-09-17 15:56 ` sgn
  5 siblings, 0 replies; 7+ messages in thread
From: sgn @ 2020-09-17 15:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

There's a merged pull request on the void-packages repository

gtk+: add reminder to revbump gtk-layer-shell.
https://github.com/void-linux/void-packages/pull/24717

Description:
If gtk-layer-shell isn't revbumped, it has warning messages like:

  ** (waybar:449): WARNING **: 12:44:32.403: gtk-layer-shell was not
  compiled with support for GTK v3.24.22, program may crash

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-09-17 15:56 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-06 15:55 [PR PATCH] gtk+: add reminder to revbump gtk-layer-shell ericonr
2020-09-06 15:56 ` ericonr
2020-09-10 13:49 ` sgn
2020-09-10 13:53 ` ericonr
2020-09-10 13:54 ` [PR PATCH] [Updated] " ericonr
2020-09-10 13:54 ` ericonr
2020-09-17 15:56 ` [PR PATCH] [Merged]: " sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).