Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] dhcpcd: make privsep a build option
@ 2020-09-12 18:40 CameronNemo
  2020-09-13  0:54 ` [PR REVIEW] " sgn
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: CameronNemo @ 2020-09-12 18:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

There is a new pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages dhcpcd-privsep-option
https://github.com/void-linux/void-packages/pull/24867

dhcpcd: make privsep a build option
Still forks away from the supervisor :/
But there is no huge process tree, just a launcher and master.

A patch file from https://github.com/void-linux/void-packages/pull/24867.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dhcpcd-privsep-option-24867.patch --]
[-- Type: text/x-diff, Size: 1467 bytes --]

From 93517a69ff0b5eae472086fd8718a326a0082e68 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Sat, 12 Sep 2020 11:38:57 -0700
Subject: [PATCH] dhcpcd: make privsep a build option

---
 srcpkgs/dhcpcd/template | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/dhcpcd/template b/srcpkgs/dhcpcd/template
index 89da9d503bf..4bedf20ab84 100644
--- a/srcpkgs/dhcpcd/template
+++ b/srcpkgs/dhcpcd/template
@@ -1,10 +1,10 @@
 # Template file for 'dhcpcd'
 pkgname=dhcpcd
 version=9.2.0
-revision=1
+revision=2
 build_style=configure
 make_check_target=test
-configure_args="--prefix=/usr --sbindir=/usr/bin --sysconfdir=/etc --rundir=/run/dhcpcd --privsepuser=_dhcpcd"
+configure_args="--prefix=/usr --sbindir=/usr/bin --sysconfdir=/etc --rundir=/run/dhcpcd"
 hostmakedepends="ntp pkg-config"
 makedepends="eudev-libudev-devel"
 short_desc="RFC2131 compliant DHCP client"
@@ -15,9 +15,15 @@ distfiles="https://roy.marples.name/downloads/dhcpcd/dhcpcd-${version}.tar.xz"
 checksum=fcb2d19672d445bbfd38678fdee4f556ef967a3ea6bd81092d10545df2cb9666
 lib32disabled=yes
 conf_files=/etc/dhcpcd.conf
-# privsep
-system_accounts="_dhcpcd"
-_dhcpcd_homedir="/var/db/dhcpcd"
+
+build_options="privsep"
+build_options_default="privsep"
+
+if [ "$build_option_privsep" ]; then
+	configure_args+=" --privsepuser=_dhcpcd"
+	system_accounts="_dhcpcd"
+	_dhcpcd_homedir="/var/db/dhcpcd"
+fi
 
 post_install() {
 	vsv dhcpcd

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] dhcpcd: make privsep a build option
  2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
@ 2020-09-13  0:54 ` sgn
  2020-09-13 10:48 ` sgn
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: sgn @ 2020-09-13  0:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24867#discussion_r487465132

Comment:
I prefer to keep them for no reason.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] dhcpcd: make privsep a build option
  2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
  2020-09-13  0:54 ` [PR REVIEW] " sgn
@ 2020-09-13 10:48 ` sgn
  2020-09-15 16:11 ` [PR PATCH] [Updated] " CameronNemo
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: sgn @ 2020-09-13 10:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24867#discussion_r487465132

Comment:
I prefer to keep them (for no reason).

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] dhcpcd: make privsep a build option
  2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
  2020-09-13  0:54 ` [PR REVIEW] " sgn
  2020-09-13 10:48 ` sgn
@ 2020-09-15 16:11 ` CameronNemo
  2020-09-15 18:46 ` [PR REVIEW] " Piraty
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: CameronNemo @ 2020-09-15 16:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

There is an updated pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages dhcpcd-privsep-option
https://github.com/void-linux/void-packages/pull/24867

dhcpcd: make privsep a build option
Still forks away from the supervisor :/
But there is no huge process tree, just a launcher and master.

A patch file from https://github.com/void-linux/void-packages/pull/24867.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dhcpcd-privsep-option-24867.patch --]
[-- Type: text/x-diff, Size: 1422 bytes --]

From 3a41ab6ca12a79100dfed6fe2f41f2379e9499fa Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Sat, 12 Sep 2020 11:38:57 -0700
Subject: [PATCH] dhcpcd: make privsep a build option

---
 srcpkgs/dhcpcd/template | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/dhcpcd/template b/srcpkgs/dhcpcd/template
index 89da9d503bf..f01d260a1d6 100644
--- a/srcpkgs/dhcpcd/template
+++ b/srcpkgs/dhcpcd/template
@@ -1,10 +1,10 @@
 # Template file for 'dhcpcd'
 pkgname=dhcpcd
 version=9.2.0
-revision=1
+revision=2
 build_style=configure
 make_check_target=test
-configure_args="--prefix=/usr --sbindir=/usr/bin --sysconfdir=/etc --rundir=/run/dhcpcd --privsepuser=_dhcpcd"
+configure_args="--prefix=/usr --sbindir=/usr/bin --sysconfdir=/etc --rundir=/run/dhcpcd"
 hostmakedepends="ntp pkg-config"
 makedepends="eudev-libudev-devel"
 short_desc="RFC2131 compliant DHCP client"
@@ -15,10 +15,17 @@ distfiles="https://roy.marples.name/downloads/dhcpcd/dhcpcd-${version}.tar.xz"
 checksum=fcb2d19672d445bbfd38678fdee4f556ef967a3ea6bd81092d10545df2cb9666
 lib32disabled=yes
 conf_files=/etc/dhcpcd.conf
-# privsep
+
 system_accounts="_dhcpcd"
 _dhcpcd_homedir="/var/db/dhcpcd"
 
+build_options="privsep"
+build_options_default="privsep"
+
+if [ "$build_option_privsep" ]; then
+	configure_args+=" --privsepuser=_dhcpcd"
+fi
+
 post_install() {
 	vsv dhcpcd
 	vsv dhcpcd-eth0

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] dhcpcd: make privsep a build option
  2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
                   ` (2 preceding siblings ...)
  2020-09-15 16:11 ` [PR PATCH] [Updated] " CameronNemo
@ 2020-09-15 18:46 ` Piraty
  2020-09-21  0:34 ` CameronNemo
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Piraty @ 2020-09-15 18:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/24867#discussion_r488886569

Comment:
`vopt_if`?

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] dhcpcd: make privsep a build option
  2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
                   ` (3 preceding siblings ...)
  2020-09-15 18:46 ` [PR REVIEW] " Piraty
@ 2020-09-21  0:34 ` CameronNemo
  2020-09-21  0:35 ` [PR PATCH] [Updated] " CameronNemo
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: CameronNemo @ 2020-09-21  0:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New review comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/24867#discussion_r491754563

Comment:
kept

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] dhcpcd: make privsep a build option
  2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
                   ` (4 preceding siblings ...)
  2020-09-21  0:34 ` CameronNemo
@ 2020-09-21  0:35 ` CameronNemo
  2020-09-21  0:35 ` [PR REVIEW] " CameronNemo
  2020-09-23  9:54 ` the-maldridge
  7 siblings, 0 replies; 9+ messages in thread
From: CameronNemo @ 2020-09-21  0:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

There is an updated pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages dhcpcd-privsep-option
https://github.com/void-linux/void-packages/pull/24867

dhcpcd: make privsep a build option
Still forks away from the supervisor :/
But there is no huge process tree, just a launcher and master.

A patch file from https://github.com/void-linux/void-packages/pull/24867.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dhcpcd-privsep-option-24867.patch --]
[-- Type: text/x-diff, Size: 1378 bytes --]

From a6901b09b77cfc2c7328540fbccc271756bb1b8e Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Sat, 12 Sep 2020 11:38:57 -0700
Subject: [PATCH] dhcpcd: make privsep a build option

---
 srcpkgs/dhcpcd/template | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/dhcpcd/template b/srcpkgs/dhcpcd/template
index 89da9d503bf..6f015e19514 100644
--- a/srcpkgs/dhcpcd/template
+++ b/srcpkgs/dhcpcd/template
@@ -1,10 +1,12 @@
 # Template file for 'dhcpcd'
 pkgname=dhcpcd
 version=9.2.0
-revision=1
+revision=2
 build_style=configure
 make_check_target=test
-configure_args="--prefix=/usr --sbindir=/usr/bin --sysconfdir=/etc --rundir=/run/dhcpcd --privsepuser=_dhcpcd"
+configure_args="
+ --prefix=/usr --sbindir=/usr/bin --sysconfdir=/etc --rundir=/run/dhcpcd
+ $(vopt_if privsep --privsepuser=_dhcpcd)"
 hostmakedepends="ntp pkg-config"
 makedepends="eudev-libudev-devel"
 short_desc="RFC2131 compliant DHCP client"
@@ -15,10 +17,13 @@ distfiles="https://roy.marples.name/downloads/dhcpcd/dhcpcd-${version}.tar.xz"
 checksum=fcb2d19672d445bbfd38678fdee4f556ef967a3ea6bd81092d10545df2cb9666
 lib32disabled=yes
 conf_files=/etc/dhcpcd.conf
-# privsep
+
 system_accounts="_dhcpcd"
 _dhcpcd_homedir="/var/db/dhcpcd"
 
+build_options="privsep"
+build_options_default="privsep"
+
 post_install() {
 	vsv dhcpcd
 	vsv dhcpcd-eth0

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] dhcpcd: make privsep a build option
  2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
                   ` (5 preceding siblings ...)
  2020-09-21  0:35 ` [PR PATCH] [Updated] " CameronNemo
@ 2020-09-21  0:35 ` CameronNemo
  2020-09-23  9:54 ` the-maldridge
  7 siblings, 0 replies; 9+ messages in thread
From: CameronNemo @ 2020-09-21  0:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New review comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/24867#discussion_r491754716

Comment:
used vopt_if

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: dhcpcd: make privsep a build option
  2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
                   ` (6 preceding siblings ...)
  2020-09-21  0:35 ` [PR REVIEW] " CameronNemo
@ 2020-09-23  9:54 ` the-maldridge
  7 siblings, 0 replies; 9+ messages in thread
From: the-maldridge @ 2020-09-23  9:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/24867#issuecomment-697260425

Comment:
This doesn't really solve the original problem though, which is it forking away from the supervisor.   I'm not sure why you'd add this package since it doesn't change the status of the bug that needs to be fixed.

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-09-23  9:54 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
2020-09-13  0:54 ` [PR REVIEW] " sgn
2020-09-13 10:48 ` sgn
2020-09-15 16:11 ` [PR PATCH] [Updated] " CameronNemo
2020-09-15 18:46 ` [PR REVIEW] " Piraty
2020-09-21  0:34 ` CameronNemo
2020-09-21  0:35 ` [PR PATCH] [Updated] " CameronNemo
2020-09-21  0:35 ` [PR REVIEW] " CameronNemo
2020-09-23  9:54 ` the-maldridge

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git