[ISSUE] Package request: Sunflower 0.4 (62)

[ISSUE] Package request: Sunflower 0.4 (62)

[gorkawien]

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

New issue by gorkawien on void-packages repository

https://github.com/void-linux/void-packages/issues/25062

Description:
Sunflower is a small and highly customizable twin-panel file manager for Linux with support for plugins. It is intended to be an easy-to-use and powerful file manager that seamlessly integrates into the GNOME desktop environment (but not limited to).

https://sunflower-fm.org
https://github.com/MeanEYE/Sunflower

Re: Package request: Sunflower 0.4 (62)

[reback00]

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

New comment by reback00 on void-packages repository

https://github.com/void-linux/void-packages/issues/25062#issuecomment-703140980

Comment:
I have prepared a template for Sunflower, but unfortunately it keeps hanging, nothing shows up. Maybe I did some silly mistake. To be on the safe side, I submitted an issue [here](https://github.com/MeanEYE/Sunflower/issues/453).

Have you faced this issue on Void Linux before? Have you tried to build it manually, without XBPS?

Re: Package request: Sunflower 0.4 (62)

[gorkawien]

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

New comment by gorkawien on void-packages repository

https://github.com/void-linux/void-packages/issues/25062#issuecomment-703163665

Comment:
My first try was to use xdeb, after that i spoke with a mate in a Telegram channel, and we made some advance, but not to the end.
There is an open thread on the mailing list:
https://groups.google.com/g/sunflower-fm/c/aRfN-MkW72s
I put there our progess.
Maybe if we unite our effort, we can finally get a working template!!
I will take a look at you template.
Thanks in advance!!

Re: Package request: Sunflower 0.4 (62)

[gorkawien]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New comment by gorkawien on void-packages repository

https://github.com/void-linux/void-packages/issues/25062#issuecomment-703218973

Comment:
@reback00 I saw a few differences between our templatetes.
Here is ours:
https://imgur.com/a/dUWGemj

Re: Package request: Sunflower 0.4 (62)

[reback00]

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]

New comment by reback00 on void-packages repository

https://github.com/void-linux/void-packages/issues/25062#issuecomment-703534009

Comment:
@gorkawien  OK, good template you got there. Especially, I like the `version` value being set to `0.4.62`. Makes better sense than mine.

But it seems on your template it will need `python3-setuptools` on `hostdepends`. And possibly it will need some more depends after that. I got them solved in mine. I don't have any build errors. But the problem seems to be that some changes are not updated in master yet for it to work in Void Linux.

As [suggested](https://github.com/MeanEYE/Sunflower/issues/453#issuecomment-703146876) by the author, I tried their `develop` branch and it [partially worked](https://github.com/MeanEYE/Sunflower/issues/453#issuecomment-703181779). I think the path error that I got in develop branch, is fixable through a patch to the source code (even if they don't push any changes for that). But can we push a develop branch package to void-packages repo? I don't think it will be accepted. I think this will be a problem if the changes are not merged to master soon.

Re: Package request: Sunflower 0.4 (62)

[gorkawien]

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

New comment by gorkawien on void-packages repository

https://github.com/void-linux/void-packages/issues/25062#issuecomment-703562201

Comment:
@reback00 
Thanks for your feedback!
 My skills are very limited, and your feedback will help me to learn!!
I will share your comments with the person that helped me to build the template, and see if we can do some progress.

Re: Package request: Sunflower 0.4 (62)

[reback00]

[-- Attachment #1: Type: text/plain, Size: 993 bytes --]

New comment by reback00 on void-packages repository

https://github.com/void-linux/void-packages/issues/25062#issuecomment-703576369

Comment:
@gorkawien  Well, there is a good news!

> I think the path error that I got in develop branch, is fixable through a patch to the source code

It seems I was right about this. I tried a [patch](https://notabug.org/reback00/void-goodies/src/master/srcpkgs/sunflower-dev/patches/path-fix.patch) and it works! I have pushed a `sunflower-dev` package [here](https://notabug.org/reback00/void-goodies/src/master/srcpkgs/sunflower-dev) if you want to try. So even if it doesn't work on master or if this package doesn't get accepted, you have a working package template! Be sure to test it before use though. I haven't used it thoroughly.

I haven't tried the patch on `master` yet. If the patch can fix master too, maybe we can hope for a package soon!

I'll also communicate this patch in the issue to see if the author can give us any solution.

Re: Package request: Sunflower 0.4 (62)

[gorkawien]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New comment by gorkawien on void-packages repository

https://github.com/void-linux/void-packages/issues/25062#issuecomment-704403687

Comment:
@rebackOO
Thank you very much!!
I will try it and see if I can use it with my Budgie or Gnome ISO.
I will post here my results.

Re: Package request: Sunflower 0.4 (62)

[gorkawien]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

New comment by gorkawien on void-packages repository

https://github.com/void-linux/void-packages/issues/25062#issuecomment-704403687

Comment:
@rebackOO
Thank you very much!!
I had to change the checksum.
the correct one is:
5f408a35f249eb0a1a544acab5910849a233dd968b160aaa247b3dc21f47ce42

After that i installed on my [driver](https://prnt.sc/uu80cy)
I have to do some more test, but for now is working fine.

Re: Package request: Sunflower 0.4 (62)

[reback00]

[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]

New comment by reback00 on void-packages repository

https://github.com/void-linux/void-packages/issues/25062#issuecomment-705160052

Comment:
> I had to change the checksum.

That's kind of expected. The checksum will change when there is a new commit in `devel`. The distfile url just downloads what's in devel. So whenever there's an update on that branch, it changes checksum with it. I added an `@` as suggested by [Manual.md](https://github.com/void-linux/void-packages/blob/master/Manual.md#optional-variables):
> If a distfile changes its checksum for every download because it is packaged on the fly on the server, like e.g. snapshot tarballs from any of the https://*.googlesource.com/ sites, the checksum of the archive contents can be specified by prepending a commercial at (@). For tarballs you can find the contents checksum by using the command tar xf <tarball.ext> --to-stdout | sha256sum.

I thought it would pass it as being ok even if it changes because I added the @. But I guess it doesn't work that way.

Re: Package request: Sunflower 0.4 (62)

[gorkawien]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

New comment by gorkawien on void-packages repository

https://github.com/void-linux/void-packages/issues/25062#issuecomment-705485411

Comment:
@reback00 
Regarding the patches you included, could this affect the support for certain icon themes??
I included papirus-icon-theme in my l[ast release](https://twitter.com/OsAgarim/status/1313907358632992769/photo/1) of AgarimOS Gnome and I have this feeling that Sunflower doesn't display the folders correctly as it does with other icon-themes.

Re: Package request: Sunflower 0.4 (62)

[reback00]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

New comment by reback00 on void-packages repository

https://github.com/void-linux/void-packages/issues/25062#issuecomment-705973514

Comment:
@gorkawien I am using Qogir icon theme and it's showing the icons fine. Also, I tried papirus icons, and it seems to be working on my end too:

![sunflower06](https://user-images.githubusercontent.com/51861250/95545871-e0b32480-0a20-11eb-8e31-1534c0a808d7.png)

I have changed icon theme with `lxappearance`.

The patch just hardcodes the path to main.css, but the file stays the same. So it should work without problems like the upstream intended. If you still face issues I'm afraid you'll have to post an issue to upstream.

Re: Package request: Sunflower 0.4 (62)

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/issues/25062#issuecomment-856359205

Comment:
> > I had to change the checksum.
> 
> That's kind of expected. The checksum will change when there is a new commit in `devel`. The distfile url just downloads what's in devel. So whenever there's an update on that branch, it changes checksum with it. I added an `@` as suggested by [Manual.md](https://github.com/void-linux/void-packages/blob/master/Manual.md#optional-variables):
> 
> > If a distfile changes its checksum for every download because it is packaged on the fly on the server, like e.g. snapshot tarballs from any of the https://*.googlesource.com/ sites, the checksum of the archive contents can be specified by prepending a commercial at (@). For tarballs you can find the contents checksum by using the command tar xf <tarball.ext> --to-stdout | sha256sum.
> 
> I thought it would pass it as being ok even if it changes because I added the @. But I guess it doesn't work that way.

["But shells parse all the time. Worse, the essence of the shell is parsing: the parser and the runner are intimately interleaved and cannot be clearly separated, thanks to the specification. The shell performs several kinds of expansions, automatic filename globbing, and automatic word splitting, in an unintuitive order, requiring users to memorize numerous arbitrary quoting rules in order to achieve what they want. Pages abound where common mistakes are listed, more often than not leading to security holes. Did you know that "$@" is a special case of double quoting, because it will split the arguments into several words, whereas every other use of double quotes in a shell is meant to prevent splitting?"](https://skarnet.org/software/execline/dieshdiedie.html)

Re: Package request: Sunflower 0.4 (62)

[niels0n]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

New comment by niels0n on void-packages repository

https://github.com/void-linux/void-packages/issues/25062#issuecomment-1542531749

Comment:
Hey there, I was trying to use Sunflower and create a template but I'm struggling and I found this discussion.
Is there any update on this?

Re: Package request: Sunflower 0.4 (62)

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/issues/25062#issuecomment-1542810854

Comment:
> 

Nope!

Re: Package request: Sunflower 0.4 (62)

[niels0n]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

New comment by niels0n on void-packages repository

https://github.com/void-linux/void-packages/issues/25062#issuecomment-1542916778

Comment:
I actually have just seen that the @reback00's [template](https://notabug.org/reback00/void-goodies/src/master/srcpkgs/sunflower-dev) seems to work. Is there something wrong with it?