Github messages for voidlinux
 help / color / mirror / Atom feed
From: shahab-vahedi <shahab-vahedi@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] Add libQtWebkit.so.4 to common/shlibs
Date: Wed, 07 Oct 2020 14:57:13 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25411@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

There is a new pull request by shahab-vahedi against master on the void-packages repository

https://github.com/shahab-vahedi/void-packages libqtwebkit4
https://github.com/void-linux/void-packages/pull/25411

Add libQtWebkit.so.4 to common/shlibs
The commit message follows in the end. One remark that I have to make is that I am not 100% sure the line that I chose to add the entry is the best one.
```
When building a modified version of "goldendict" [1], I ended up
with this error:

  SONAME: libQtWebKit.so.4 <-> UNKNOWN PKG PLEASE FIX!

Here's the package added.

[1] modified "template" of "goldendict"
Because Qt5 webkit does not render right-to-left texts nicely, I
build my "goldendict" against Qt4; i.e. replace "qt5-webkit-devel"
with "qt-webkit-devel".
```

A patch file from https://github.com/void-linux/void-packages/pull/25411.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libqtwebkit4-25411.patch --]
[-- Type: text/x-diff, Size: 1070 bytes --]

From 4e53f774071fce711801c2ddc7d8a919fa8694c2 Mon Sep 17 00:00:00 2001
From: Shahab Vahedi <shahab.vahedi@gmail.com>
Date: Wed, 7 Oct 2020 14:53:17 +0200
Subject: [PATCH] Add libQtWebkit.so.4 to common/shlibs

When building a modified version of "goldendict" [1], I ended up
with this error:

  SONAME: libQtWebKit.so.4 <-> UNKNOWN PKG PLEASE FIX!

Here's the package added.

[1] modified "template" of "goldendict"
Because Qt5 webkit does not render right-to-left texts nicely, I
build my "goldendict" against Qt4; i.e. replace "qt5-webkit-devel"
with "qt-webkit-devel".
---
 common/shlibs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/shlibs b/common/shlibs
index 7dad8c2117d..54eb5ddc78b 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -456,6 +456,7 @@ libQtSql.so.4 qt-4.5.3_1
 libQtDeclarative.so.4 qt-4.5.3_1
 libQtDesignerComponents.so.4 qt-designer-libs-4.7.8_13
 libQtDesigner.so.4 qt-designer-libs-4.7.8_13
+libQtWebKit.so.4 qt-webkit-2.3.4_7
 libsysfs.so.2 libsysfs-2.1.0_1
 libsensors.so.5 libsensors-3.5.0_1
 libcap-ng.so.0 libcap-ng-0.6.2_1

             reply	other threads:[~2020-10-07 12:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07 12:57 shahab-vahedi [this message]
2020-10-07 13:00 ` q66
2020-10-07 13:01 ` q66
2020-10-07 13:01 ` [PR PATCH] [Closed]: " q66
2020-10-07 13:02 ` q66
2020-10-07 13:06 ` shahab-vahedi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25411@inbox.vuxu.org \
    --to=shahab-vahedi@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).