Github messages for voidlinux
 help / color / mirror / Atom feed
From: jnbr <jnbr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] gcc: fix order of postdep_objects_CXX
Date: Wed, 14 Oct 2020 20:31:00 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25605@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 388 bytes --]

There is a new pull request by jnbr against master on the void-packages repository

https://github.com/jnbr/void-packages gcc
https://github.com/void-linux/void-packages/pull/25605

gcc: fix order of postdep_objects_CXX
make sure crt* objects come after anything else

fixes #25535

[ci skip]

A patch file from https://github.com/void-linux/void-packages/pull/25605.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gcc-25605.patch --]
[-- Type: text/x-diff, Size: 1891 bytes --]

From 22e78dc1b001bf26908e1d91ab81d706fe035b60 Mon Sep 17 00:00:00 2001
From: Johannes <johannes.brechtmann@gmail.com>
Date: Wed, 14 Oct 2020 20:26:38 +0200
Subject: [PATCH] gcc: fix order of postdep_objects_CXX

make sure crt* objects come after anything else

fixes #25535

[ci skip]
---
 srcpkgs/gcc/patches/fix-vtv-link-order.patch | 20 ++++++++++++++++++++
 srcpkgs/gcc/template                         |  2 +-
 2 files changed, 21 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/gcc/patches/fix-vtv-link-order.patch

diff --git a/srcpkgs/gcc/patches/fix-vtv-link-order.patch b/srcpkgs/gcc/patches/fix-vtv-link-order.patch
new file mode 100644
index 00000000000..3315c3e990b
--- /dev/null
+++ b/srcpkgs/gcc/patches/fix-vtv-link-order.patch
@@ -0,0 +1,20 @@
+put vtv_end.o in front of postdep_objects_CXX
+having it after crtendS.o leads to missing zero termination in eh_frame section
+
+This is in line with comment in libgcc/vtv_end.c:
+
+   When the GCC driver inserts vtv_start.o into the link line (just
+   after crtbegin.o) it also inserts vtv_end.o into the link line,
+   just before crtend.o.
+
+--- libstdc++-v3/configure
++++ libstdc++-v3/configure
+@@ -15443,7 +15443,7 @@
+ 
+ if test "$enable_vtable_verify" = yes; then
+   predep_objects_CXX="${predep_objects_CXX} ${glibcxx_builddir}/../libgcc/vtv_start.o"
+-  postdep_objects_CXX="${postdep_objects_CXX} ${glibcxx_builddir}/../libgcc/vtv_end.o"
++  postdep_objects_CXX="${glibcxx_builddir}/../libgcc/vtv_end.o ${postdep_objects_CXX}" 
+ fi
+ 
+ 
diff --git a/srcpkgs/gcc/template b/srcpkgs/gcc/template
index ead6f05a498..f4e2f949933 100644
--- a/srcpkgs/gcc/template
+++ b/srcpkgs/gcc/template
@@ -8,7 +8,7 @@ _isl_version=0.21
 
 pkgname=gcc
 version=${_minorver}.0
-revision=6
+revision=7
 short_desc="GNU Compiler Collection"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 homepage="http://gcc.gnu.org"

             reply	other threads:[~2020-10-14 18:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 18:31 jnbr [this message]
2020-10-15  1:58 ` fosslinux
2020-10-15  5:20 ` jnbr
2020-10-15  5:20 ` jnbr
2020-10-16 15:09 ` sgn
2020-10-16 18:20 ` jnbr
2020-10-16 18:29 ` [PR PATCH] [Merged]: " jnbr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25605@inbox.vuxu.org \
    --to=jnbr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).