Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] common/build-style/meson.sh: set auto-features to auto.
@ 2020-10-14 22:09 ericonr
  2020-10-18  2:57 ` ahesford
  2020-10-18  3:00 ` [PR PATCH] [Merged]: " ericonr
  0 siblings, 2 replies; 3+ messages in thread
From: ericonr @ 2020-10-14 22:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages meson
https://github.com/void-linux/void-packages/pull/25611

common/build-style/meson.sh: set auto-features to auto.
This allows the build system to detect itself whether it should use
certain features, instead of defaulting to (potentially bad) enabled
status.

Features that aren't detected properly, be it because false positives or
negatives, should be explicitly called out in the templates.

A patch file from https://github.com/void-linux/void-packages/pull/25611.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-meson-25611.patch --]
[-- Type: text/x-diff, Size: 1045 bytes --]

From ec3321739d71129af620cea8b5d592165ab98202 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 14 Oct 2020 19:03:31 -0300
Subject: [PATCH] common/build-style/meson.sh: set auto-features to auto.

This allows the build system to detect itself whether it should use
certain features, instead of defaulting to (potentially bad) enabled
status.

Features that aren't detected properly, be it because false positives or
negatives, should be explicitly called out in the templates.
---
 common/build-style/meson.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/build-style/meson.sh b/common/build-style/meson.sh
index 1a68b9473a7..9b92279148c 100644
--- a/common/build-style/meson.sh
+++ b/common/build-style/meson.sh
@@ -107,7 +107,7 @@ do_configure() {
 		--localstatedir=/var \
 		--sharedstatedir=/var/lib \
 		--buildtype=plain \
-		--auto-features=enabled \
+		--auto-features=auto \
 		--wrap-mode=nodownload \
 		-Db_lto=true -Db_ndebug=true \
 		-Db_staticpic=true \

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: common/build-style/meson.sh: set auto-features to auto.
  2020-10-14 22:09 [PR PATCH] common/build-style/meson.sh: set auto-features to auto ericonr
@ 2020-10-18  2:57 ` ahesford
  2020-10-18  3:00 ` [PR PATCH] [Merged]: " ericonr
  1 sibling, 0 replies; 3+ messages in thread
From: ahesford @ 2020-10-18  2:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/25611#issuecomment-711109082

Comment:
I like this change. We should be able to disable non-essential features by depriving the build of dependencies, not requiring templates to manually exclude every option.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: common/build-style/meson.sh: set auto-features to auto.
  2020-10-14 22:09 [PR PATCH] common/build-style/meson.sh: set auto-features to auto ericonr
  2020-10-18  2:57 ` ahesford
@ 2020-10-18  3:00 ` ericonr
  1 sibling, 0 replies; 3+ messages in thread
From: ericonr @ 2020-10-18  3:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

There's a merged pull request on the void-packages repository

common/build-style/meson.sh: set auto-features to auto.
https://github.com/void-linux/void-packages/pull/25611

Description:
This allows the build system to detect itself whether it should use
certain features, instead of defaulting to (potentially bad) enabled
status.

Features that aren't detected properly, be it because false positives or
negatives, should be explicitly called out in the templates.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-18  3:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 22:09 [PR PATCH] common/build-style/meson.sh: set auto-features to auto ericonr
2020-10-18  2:57 ` ahesford
2020-10-18  3:00 ` [PR PATCH] [Merged]: " ericonr

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git