Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] aspell: split tools into a subpkg
@ 2020-10-16  4:43 CameronNemo
  2020-10-17  2:46 ` ericonr
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: CameronNemo @ 2020-10-16  4:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

There is a new pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages aspell
https://github.com/void-linux/void-packages/pull/25648

aspell: split tools into a subpkg
None

A patch file from https://github.com/void-linux/void-packages/pull/25648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aspell-25648.patch --]
[-- Type: text/x-diff, Size: 1596 bytes --]

From bb46acb7f8f61dc2a045c1d217f5f88b14829e86 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Thu, 15 Oct 2020 21:42:39 -0700
Subject: [PATCH] aspell: split tools into a subpkg

---
 srcpkgs/aspell-tools    |  1 +
 srcpkgs/aspell/template | 14 ++++++++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)
 create mode 120000 srcpkgs/aspell-tools

diff --git a/srcpkgs/aspell-tools b/srcpkgs/aspell-tools
new file mode 120000
index 00000000000..2954cad5043
--- /dev/null
+++ b/srcpkgs/aspell-tools
@@ -0,0 +1 @@
+aspell
\ No newline at end of file
diff --git a/srcpkgs/aspell/template b/srcpkgs/aspell/template
index b3ccbeeaef8..6bda56ac340 100644
--- a/srcpkgs/aspell/template
+++ b/srcpkgs/aspell/template
@@ -1,12 +1,11 @@
 # Template file for 'aspell'
 pkgname=aspell
 version=0.60.8
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--enable-compile-in-filters"
 hostmakedepends="automake libtool gettext-devel perl"
 makedepends="ncurses-devel"
-depends="perl"
 short_desc="Spell checker with good multi-language support"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-only"
@@ -22,6 +21,17 @@ pre_configure() {
 	autoreconf -fi
 }
 
+aspell-tools_package() {
+	depends="${sourcepkg}>=${version}_${revision} perl"
+	short_desc+=" - tools"
+	pkg_install() {
+		vmove usr/bin/aspell-import
+		vmove "usr/bin/pre*"
+		vmove usr/bin/run-with-aspell
+		vmove usr/bin/word-list-compress
+	}
+}
+
 aspell-devel_package() {
 	depends="ncurses-devel libstdc++-devel aspell>=${version}_${revision}"
 	short_desc+=" - development files"

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: aspell: split tools into a subpkg
  2020-10-16  4:43 [PR PATCH] aspell: split tools into a subpkg CameronNemo
@ 2020-10-17  2:46 ` ericonr
  2020-10-18  2:35 ` CameronNemo
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2020-10-17  2:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25648#issuecomment-710732639

Comment:
Isn't it bad if people have this installed and lose the tools?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: aspell: split tools into a subpkg
  2020-10-16  4:43 [PR PATCH] aspell: split tools into a subpkg CameronNemo
  2020-10-17  2:46 ` ericonr
@ 2020-10-18  2:35 ` CameronNemo
  2020-10-18  2:35 ` CameronNemo
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: CameronNemo @ 2020-10-18  2:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/25648#issuecomment-711107831

Comment:
Maybe, but how often do people manually install aspell and use these tools? I think it is likely pulled in by other packages in most cases, or used for the main program (aspell) and no others. This is one of the few packages that pulls in Perl on my inst

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: aspell: split tools into a subpkg
  2020-10-16  4:43 [PR PATCH] aspell: split tools into a subpkg CameronNemo
  2020-10-17  2:46 ` ericonr
  2020-10-18  2:35 ` CameronNemo
@ 2020-10-18  2:35 ` CameronNemo
  2020-10-18 14:41 ` sgn
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: CameronNemo @ 2020-10-18  2:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/25648#issuecomment-711107831

Comment:
Maybe, but how often do people manually install aspell and use these tools? I think it is likely pulled in by other packages in most cases, or used for the main program (aspell) and no others. This is one of the few packages that pulls in Perl on my installations.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: aspell: split tools into a subpkg
  2020-10-16  4:43 [PR PATCH] aspell: split tools into a subpkg CameronNemo
                   ` (2 preceding siblings ...)
  2020-10-18  2:35 ` CameronNemo
@ 2020-10-18 14:41 ` sgn
  2020-10-18 22:33 ` Duncaen
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: sgn @ 2020-10-18 14:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/25648#issuecomment-711186359

Comment:
I take cnemo's side.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: aspell: split tools into a subpkg
  2020-10-16  4:43 [PR PATCH] aspell: split tools into a subpkg CameronNemo
                   ` (3 preceding siblings ...)
  2020-10-18 14:41 ` sgn
@ 2020-10-18 22:33 ` Duncaen
  2020-10-25  6:57 ` sgn
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Duncaen @ 2020-10-18 22:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/25648#issuecomment-711433881

Comment:
Wouldn't it make more sense to split it into a libaspell package?
So users who manually installed it can keep it, others will have both until everything is rebuild against the new dependency name and then the aspell package gets orphaned.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: aspell: split tools into a subpkg
  2020-10-16  4:43 [PR PATCH] aspell: split tools into a subpkg CameronNemo
                   ` (4 preceding siblings ...)
  2020-10-18 22:33 ` Duncaen
@ 2020-10-25  6:57 ` sgn
  2020-10-26  3:14 ` [PR PATCH] [Updated] " CameronNemo
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: sgn @ 2020-10-25  6:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/25648#issuecomment-711186359

Comment:
I take cnemo's side.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] aspell: split tools into a subpkg
  2020-10-16  4:43 [PR PATCH] aspell: split tools into a subpkg CameronNemo
                   ` (5 preceding siblings ...)
  2020-10-25  6:57 ` sgn
@ 2020-10-26  3:14 ` CameronNemo
  2020-10-26  3:49 ` CameronNemo
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: CameronNemo @ 2020-10-26  3:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

There is an updated pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages aspell
https://github.com/void-linux/void-packages/pull/25648

aspell: split tools into a subpkg
None

A patch file from https://github.com/void-linux/void-packages/pull/25648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aspell-25648.patch --]
[-- Type: text/x-diff, Size: 1277 bytes --]

From 7fe22d287b6812311fffbf75bc7eb9048defcb64 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Thu, 15 Oct 2020 21:42:39 -0700
Subject: [PATCH] aspell: split library into a subpkg

---
 srcpkgs/aspell/template | 10 +++++++++-
 srcpkgs/libaspell       |  1 +
 2 files changed, 10 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/libaspell

diff --git a/srcpkgs/aspell/template b/srcpkgs/aspell/template
index b3ccbeeaef8..dfb23e9423d 100644
--- a/srcpkgs/aspell/template
+++ b/srcpkgs/aspell/template
@@ -1,7 +1,7 @@
 # Template file for 'aspell'
 pkgname=aspell
 version=0.60.8
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--enable-compile-in-filters"
 hostmakedepends="automake libtool gettext-devel perl"
@@ -22,6 +22,14 @@ pre_configure() {
 	autoreconf -fi
 }
 
+libaspell_package() {
+	short_desc+=" - library"
+	pkg_install() {
+		vmoce "usr/lib/*.so.*"
+		vmove "usr/lib/aspell-*"
+	}
+}
+
 aspell-devel_package() {
 	depends="ncurses-devel libstdc++-devel aspell>=${version}_${revision}"
 	short_desc+=" - development files"
diff --git a/srcpkgs/libaspell b/srcpkgs/libaspell
new file mode 120000
index 00000000000..2954cad5043
--- /dev/null
+++ b/srcpkgs/libaspell
@@ -0,0 +1 @@
+aspell
\ No newline at end of file

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] aspell: split tools into a subpkg
  2020-10-16  4:43 [PR PATCH] aspell: split tools into a subpkg CameronNemo
                   ` (6 preceding siblings ...)
  2020-10-26  3:14 ` [PR PATCH] [Updated] " CameronNemo
@ 2020-10-26  3:49 ` CameronNemo
  2020-10-26  4:09 ` CameronNemo
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: CameronNemo @ 2020-10-26  3:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

There is an updated pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages aspell
https://github.com/void-linux/void-packages/pull/25648

aspell: split tools into a subpkg
None

A patch file from https://github.com/void-linux/void-packages/pull/25648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aspell-25648.patch --]
[-- Type: text/x-diff, Size: 1820 bytes --]

From 6a7a3c58e845855f6aa3098918bfc0638992a30d Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Thu, 15 Oct 2020 21:42:39 -0700
Subject: [PATCH] aspell: split library into a subpkg

---
 common/shlibs           |  4 ++--
 srcpkgs/aspell/template | 10 +++++++++-
 srcpkgs/libaspell       |  1 +
 3 files changed, 12 insertions(+), 3 deletions(-)
 create mode 120000 srcpkgs/libaspell

diff --git a/common/shlibs b/common/shlibs
index 856f9de9a6e..aae34d15456 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -554,8 +554,8 @@ libicudata.so.67 icu-libs-67.1_1
 libicutu.so.67 icu-libs-67.1_1
 libicuuc.so.67 icu-libs-67.1_1
 libicutest.so.67 icu-libs-67.1_1
-libaspell.so.15 aspell-0.60_1
-libpspell.so.15 aspell-0.60_1
+libaspell.so.15 libaspell-0.60.8_2
+libpspell.so.15 libaspell-0.60.8_2
 libenchant.so.1 enchant-1.4.2_1
 libenchant-2.so.2 enchant2-2.2.3_1
 libgconf-2.so.4 GConf-2.32.0_1
diff --git a/srcpkgs/aspell/template b/srcpkgs/aspell/template
index b3ccbeeaef8..414e0adedfd 100644
--- a/srcpkgs/aspell/template
+++ b/srcpkgs/aspell/template
@@ -1,7 +1,7 @@
 # Template file for 'aspell'
 pkgname=aspell
 version=0.60.8
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--enable-compile-in-filters"
 hostmakedepends="automake libtool gettext-devel perl"
@@ -22,6 +22,14 @@ pre_configure() {
 	autoreconf -fi
 }
 
+libaspell_package() {
+	short_desc+=" - library"
+	pkg_install() {
+		vmove "usr/lib/*.so.*"
+		vmove "usr/lib/aspell-*"
+	}
+}
+
 aspell-devel_package() {
 	depends="ncurses-devel libstdc++-devel aspell>=${version}_${revision}"
 	short_desc+=" - development files"
diff --git a/srcpkgs/libaspell b/srcpkgs/libaspell
new file mode 120000
index 00000000000..2954cad5043
--- /dev/null
+++ b/srcpkgs/libaspell
@@ -0,0 +1 @@
+aspell
\ No newline at end of file

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: aspell: split tools into a subpkg
  2020-10-16  4:43 [PR PATCH] aspell: split tools into a subpkg CameronNemo
                   ` (7 preceding siblings ...)
  2020-10-26  3:49 ` CameronNemo
@ 2020-10-26  4:09 ` CameronNemo
  2020-10-26 11:43 ` [PR REVIEW] aspell: split library " Duncaen
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: CameronNemo @ 2020-10-26  4:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/25648#issuecomment-716291547

Comment:
Changed this to split libaspell out.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] aspell: split library into a subpkg
  2020-10-16  4:43 [PR PATCH] aspell: split tools into a subpkg CameronNemo
                   ` (8 preceding siblings ...)
  2020-10-26  4:09 ` CameronNemo
@ 2020-10-26 11:43 ` Duncaen
  2020-10-26 17:04 ` CameronNemo
  2020-10-26 17:16 ` Duncaen
  11 siblings, 0 replies; 13+ messages in thread
From: Duncaen @ 2020-10-26 11:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/25648#discussion_r511898852

Comment:
I guess you could remove the duplicated line, I don't think there is a reason for that.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] aspell: split library into a subpkg
  2020-10-16  4:43 [PR PATCH] aspell: split tools into a subpkg CameronNemo
                   ` (9 preceding siblings ...)
  2020-10-26 11:43 ` [PR REVIEW] aspell: split library " Duncaen
@ 2020-10-26 17:04 ` CameronNemo
  2020-10-26 17:16 ` Duncaen
  11 siblings, 0 replies; 13+ messages in thread
From: CameronNemo @ 2020-10-26 17:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/25648#discussion_r512125321

Comment:
libaspell vs libpspell

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] aspell: split library into a subpkg
  2020-10-16  4:43 [PR PATCH] aspell: split tools into a subpkg CameronNemo
                   ` (10 preceding siblings ...)
  2020-10-26 17:04 ` CameronNemo
@ 2020-10-26 17:16 ` Duncaen
  11 siblings, 0 replies; 13+ messages in thread
From: Duncaen @ 2020-10-26 17:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/25648#discussion_r512133635

Comment:
oh sorry, looks good.

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2020-10-26 17:16 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16  4:43 [PR PATCH] aspell: split tools into a subpkg CameronNemo
2020-10-17  2:46 ` ericonr
2020-10-18  2:35 ` CameronNemo
2020-10-18  2:35 ` CameronNemo
2020-10-18 14:41 ` sgn
2020-10-18 22:33 ` Duncaen
2020-10-25  6:57 ` sgn
2020-10-26  3:14 ` [PR PATCH] [Updated] " CameronNemo
2020-10-26  3:49 ` CameronNemo
2020-10-26  4:09 ` CameronNemo
2020-10-26 11:43 ` [PR REVIEW] aspell: split library " Duncaen
2020-10-26 17:04 ` CameronNemo
2020-10-26 17:16 ` Duncaen

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git