Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] doxygen: build with python3, stop breaking masterdir
@ 2020-10-25 16:23 sgn
  2020-10-26  0:54 ` [PR REVIEW] " ericonr
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: sgn @ 2020-10-25 16:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

There is a new pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages doxygen-python-3
https://github.com/void-linux/void-packages/pull/25881

doxygen: build with python3, stop breaking masterdir
@ericonr 

A patch file from https://github.com/void-linux/void-packages/pull/25881.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-doxygen-python-3-25881.patch --]
[-- Type: text/x-diff, Size: 922 bytes --]

From 63f38431d8dc62b433c7fb75015937f6801775c5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Sun, 25 Oct 2020 23:22:01 +0700
Subject: [PATCH] doxygen: build with python3, stop breaking masterdir

---
 srcpkgs/doxygen/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/doxygen/template b/srcpkgs/doxygen/template
index b6fb8b7b567..9fe4729644b 100644
--- a/srcpkgs/doxygen/template
+++ b/srcpkgs/doxygen/template
@@ -1,9 +1,10 @@
 # Template file for 'doxygen'
 pkgname=doxygen
 version=1.8.20
-revision=1
+revision=2
 build_style=cmake
-hostmakedepends="chroot-git perl python flex"
+configure_args="-DCMAKE_BUILD_TYPE=None"
+hostmakedepends="perl python3 flex"
 checkdepends="libxml2 texlive-BibTeX"
 short_desc="Source code documentation generator tool"
 maintainer="Érico Nogueira <ericonr@disroot.org>"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] doxygen: build with python3, stop breaking masterdir
  2020-10-25 16:23 [PR PATCH] doxygen: build with python3, stop breaking masterdir sgn
@ 2020-10-26  0:54 ` ericonr
  2020-10-26 12:08 ` sgn
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2020-10-26  0:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25881#discussion_r511674646

Comment:
Perhaps it would be good to leave a comment for why this is needed?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] doxygen: build with python3, stop breaking masterdir
  2020-10-25 16:23 [PR PATCH] doxygen: build with python3, stop breaking masterdir sgn
  2020-10-26  0:54 ` [PR REVIEW] " ericonr
@ 2020-10-26 12:08 ` sgn
  2020-10-26 12:09 ` sgn
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2020-10-26 12:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/25881#discussion_r511911799

Comment:
I think it's well-known that our cmake use `-DCMAKE_BUILD_TYPE=Release` which add `-O3` and some other `C{,XX}FLAGS`, I tried to change it once but some packages that try to be clever and do some weird things when `CMAKE_BUILD_TYPE` is not `Release`. Hence, I added them manually to those packages known to not broken.

Regarding "breaking masterdir", with `chroot-git` in `hostmakedepends`, `xbps-src` will try to remove it up-on cleanup. And it's a dependency of `base-chroot` then it'll be broken.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] doxygen: build with python3, stop breaking masterdir
  2020-10-25 16:23 [PR PATCH] doxygen: build with python3, stop breaking masterdir sgn
  2020-10-26  0:54 ` [PR REVIEW] " ericonr
  2020-10-26 12:08 ` sgn
@ 2020-10-26 12:09 ` sgn
  2020-10-26 12:33 ` ericonr
  2020-10-26 12:33 ` [PR PATCH] [Merged]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2020-10-26 12:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/25881#discussion_r511911799

Comment:
I think it's well-known that our cmake use `-DCMAKE_BUILD_TYPE=Release` which adds `-O3` and some other `C{,XX}FLAGS`, I tried to change it once but some packages try to be clever and do some weird things when `CMAKE_BUILD_TYPE` is not `Release`. Hence, I added them manually to those packages known to not broken.

Regarding "breaking masterdir", with `chroot-git` in `hostmakedepends`, `xbps-src` will try to remove it up-on cleanup. And it's a dependency of `base-chroot` then it'll be broken.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] doxygen: build with python3, stop breaking masterdir
  2020-10-25 16:23 [PR PATCH] doxygen: build with python3, stop breaking masterdir sgn
                   ` (2 preceding siblings ...)
  2020-10-26 12:09 ` sgn
@ 2020-10-26 12:33 ` ericonr
  2020-10-26 12:33 ` [PR PATCH] [Merged]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2020-10-26 12:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25881#discussion_r511925023

Comment:
Ok, got it. Thanks!

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Merged]: doxygen: build with python3, stop breaking masterdir
  2020-10-25 16:23 [PR PATCH] doxygen: build with python3, stop breaking masterdir sgn
                   ` (3 preceding siblings ...)
  2020-10-26 12:33 ` ericonr
@ 2020-10-26 12:33 ` ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2020-10-26 12:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

There's a merged pull request on the void-packages repository

doxygen: build with python3, stop breaking masterdir
https://github.com/void-linux/void-packages/pull/25881

Description:
@ericonr 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-10-26 12:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-25 16:23 [PR PATCH] doxygen: build with python3, stop breaking masterdir sgn
2020-10-26  0:54 ` [PR REVIEW] " ericonr
2020-10-26 12:08 ` sgn
2020-10-26 12:09 ` sgn
2020-10-26 12:33 ` ericonr
2020-10-26 12:33 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).