[PR PATCH] go-bindata: update to 3.1.3 and switch to the latest upstream url

[PR PATCH] go-bindata: update to 3.1.3 and switch to the latest upstream url

[smorimoto]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

There is a new pull request by smorimoto against master on the void-packages repository

https://github.com/smorimoto/void-packages go-bindata
https://github.com/void-linux/void-packages/pull/25913

go-bindata: update to 3.1.3 and switch to the latest upstream url


A patch file from https://github.com/void-linux/void-packages/pull/25913.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-bindata-25913.patch --]
[-- Type: text/x-diff, Size: 1507 bytes --]

From 7306ea7739f80925502d0afedcd294bb8470f7f2 Mon Sep 17 00:00:00 2001
From: Sora Morimoto <sora@morimoto.io>
Date: Tue, 27 Oct 2020 18:18:17 +0900
Subject: [PATCH] go-bindata: update to 3.1.3 and switch to the latest upstream
 url

Signed-off-by: Sora Morimoto <sora@morimoto.io>
---
 srcpkgs/go-bindata/template | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/srcpkgs/go-bindata/template b/srcpkgs/go-bindata/template
index fefc747838b..98327f63e85 100644
--- a/srcpkgs/go-bindata/template
+++ b/srcpkgs/go-bindata/template
@@ -1,15 +1,16 @@
 # Template file for 'go-bindata'
 pkgname=go-bindata
-version=3.0.7.20151023
-revision=12
-_commit=a0ff2567cfb70903282db057e799fd826784d41d
-wrksrc="$pkgname-$_commit"
+version=3.1.3
+revision=1
 build_style=go
-short_desc="A small utility which generates Go code from any file"
+go_import_path="github.com/go-bindata/go-bindata"
+short_desc="Turn data file into go code"
 maintainer="Andrea Brancaleoni <abc@pompel.me>"
 license="Public Domain"
-go_import_path="github.com/jteeuwen/go-bindata"
-go_package="${go_import_path}/go-bindata"
-homepage="https://$go_import_path"
-distfiles="$homepage/archive/$_commit.tar.gz"
-checksum=65cf65ac422fb8072abfaabec86c20a74e448a93b489e896a36642e7049f5d32
+homepage="https://github.com/go-bindata/go-bindata"
+distfiles="${homepage}/archive/v${version}.tar.gz"
+checksum=c9115e60995ecba15568c9f8052e77764f2b87b7b362cafd900cfc9829cba7e8
+
+post_install() {
+	vlicense LICENSE
+}

Re: go-bindata: update to 3.1.3 and switch to the latest upstream url

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/25913#issuecomment-717477773

Comment:
Can you check if all the packages that depend on go-bindata for building do still compile AND run after this? I think browsh might also get the bindata patch removed with this.

Re: go-bindata: update to 3.1.3 and switch to the latest upstream url

[smorimoto]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New comment by smorimoto on void-packages repository

https://github.com/void-linux/void-packages/pull/25913#issuecomment-717489615

Comment:
@Johnnynator Sure. It seems the Travis backlog build growth is preventing the build from being triggered, so I will test them locally and then push the commits.

Re: go-bindata: update to 3.1.3 and switch to the latest upstream url

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25913#issuecomment-717491126

Comment:
>Can you check if all the packages that depend on go-bindata for building do still compile AND run after this? I think browsh might also get the bindata patch removed with this.

I hope not, I upstreamed that one D:

Re: go-bindata: update to 3.1.3 and switch to the latest upstream url

[smorimoto]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by smorimoto on void-packages repository

https://github.com/void-linux/void-packages/pull/25913#issuecomment-718201252

Comment:
Did you mean that we shouldn't remove the patch in the browsh package?

Re: go-bindata: update to 3.1.3 and switch to the latest upstream url

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25913#issuecomment-718208646

Comment:
Yes, unless the package stops working. If it stops working, we might need another patch for the next release.

Re: go-bindata: update to 3.1.3 and switch to the latest upstream url

[smorimoto]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

New comment by smorimoto on void-packages repository

https://github.com/void-linux/void-packages/pull/25913#issuecomment-718212229

Comment:
Okay. But, is it better not to bump the revision of the browsh package? or is it better to bump the revision if the build is successful and works correctly?

Re: go-bindata: update to 3.1.3 and switch to the latest upstream url

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25913#issuecomment-718215367

Comment:
Don't think you need to revbump either way, since browsh is working.

Just remove the patch if having it there breaks the package (ideally, we'd like to keep packages in the repo buildable).

Re: go-bindata: update to 3.1.3 and switch to the latest upstream url

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25913#issuecomment-718215367

Comment:
Don't think you need to revbump either way, since browsh is working.

Just remove the patch if having it there breaks the package (ideally, we'd like to keep packages in the repo buildable). Note that you need to install and run the newly built package, a failure won't manifest itself at build time.

Re: go-bindata: update to 3.1.3 and switch to the latest upstream url

[smorimoto]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New comment by smorimoto on void-packages repository

https://github.com/void-linux/void-packages/pull/25913#issuecomment-718415854

Comment:
How do I build browsh using my local edited go-bindata? The build system tells me that it can't find the go-bindata command.

Re: go-bindata: update to 3.1.3 and switch to the latest upstream url

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25913#issuecomment-718689686

Comment:
Is `./xbps-src pkg browsh` failing? It should be all set up to build it.

Re: go-bindata: update to 3.1.3 and switch to the latest upstream url

[smorimoto]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New comment by smorimoto on void-packages repository

https://github.com/void-linux/void-packages/pull/25913#issuecomment-719968832

Comment:
I tried it, but somehow it says it can't find the go-bindata command.

Re: go-bindata: update to 3.1.3 and switch to the latest upstream url

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 748 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25913#issuecomment-719970249

Comment:
The package is empty:

```
~/v/void-packages on testprs ➜ xls go-bindata
/usr/share/licenses/go-bindata/LICENSE
~/v/void-packages on testprs ➜ xq go-bindata
pkgver: go-bindata-3.1.3_1
short_desc: Turn data file into go code
architecture: x86_64-musl
filename-sha256: 8f75195cfb2a639d248e3a454395851992d9908511f74108f6c1cea40b27d8dc
filename-size: 794B
homepage: https://github.com/go-bindata/go-bindata
installed_size: 169B
license: Public Domain
maintainer: Andrea Brancaleoni <abc@pompel.me>
pkgname: go-bindata
repository: /home/ericonr/void/void-packages/hostdir/binpkgs/testprs
```

Re: go-bindata: update to 3.1.3 and switch to the latest upstream url

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/25913#issuecomment-752353041

Comment:
Bump?

Re: go-bindata: update to 3.1.3 and switch to the latest upstream url

[smorimoto]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New comment by smorimoto on void-packages repository

https://github.com/void-linux/void-packages/pull/25913#issuecomment-752678655

Comment:
I will investigate.

Re: go-bindata: update to 3.1.3 and switch to the latest upstream url

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25913#issuecomment-778925593

Comment:
Ping

Re: go-bindata: update to 3.1.3 and switch to the latest upstream url

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25913#issuecomment-806082515

Comment:
Closing due to inactivity, feel free to reopen :)

Re: [PR PATCH] [Closed]: go-bindata: update to 3.1.3 and switch to the latest upstream url

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

There's a closed pull request on the void-packages repository

go-bindata: update to 3.1.3 and switch to the latest upstream url
https://github.com/void-linux/void-packages/pull/25913

Description: