Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: herbe-1.0.0
@ 2020-12-16 10:14 tuxliban
  2020-12-16 10:44 ` [PR PATCH] [Updated] " tuxliban
                   ` (15 more replies)
  0 siblings, 16 replies; 18+ messages in thread
From: tuxliban @ 2020-12-16 10:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

There is a new pull request by tuxliban against master on the void-packages repository

https://github.com/tuxliban/void-packages herbe
https://github.com/void-linux/void-packages/pull/27195

New package: herbe-1.0.0
Daemon-less notifications without D-Bus. Minimal and lightweight


A patch file from https://github.com/void-linux/void-packages/pull/27195.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-herbe-27195.patch --]
[-- Type: text/x-diff, Size: 4150 bytes --]

From 19b83b04173aafc9342c41520d4d8122efe9c975 Mon Sep 17 00:00:00 2001
From: tuxliban <tenshalito@gmail.com>
Date: Wed, 16 Dec 2020 03:56:49 -0600
Subject: [PATCH] New package: herbe-1.0.0

---
 srcpkgs/herbe/patches/Xresources.diff | 95 +++++++++++++++++++++++++++
 srcpkgs/herbe/template                | 17 +++++
 2 files changed, 112 insertions(+)
 create mode 100644 srcpkgs/herbe/patches/Xresources.diff
 create mode 100644 srcpkgs/herbe/template

diff --git a/srcpkgs/herbe/patches/Xresources.diff b/srcpkgs/herbe/patches/Xresources.diff
new file mode 100644
index 00000000000..2c9e9b1c5da
--- /dev/null
+++ b/srcpkgs/herbe/patches/Xresources.diff
@@ -0,0 +1,95 @@
+diff --git a/config.def.h b/config.def.h
+index 86b7e76..d545925 100644
+--- a/config.def.h
++++ b/config.def.h
+@@ -2,18 +2,18 @@ static const char *background_color = "#3e3e3e";
+ static const char *border_color = "#ececec";
+ static const char *font_color = "#ececec";
+ static const char *font_pattern = "monospace:size=10";
+-static const unsigned line_spacing = 5;
+-static const unsigned int padding = 15;
++static unsigned line_spacing = 5;
++static unsigned int padding = 15;
+ 
+-static const unsigned int width = 450;
+-static const unsigned int border_size = 2;
+-static const unsigned int pos_x = 30;
+-static const unsigned int pos_y = 60;
++static unsigned int width = 450;
++static unsigned int border_size = 2;
++static unsigned int pos_x = 30;
++static unsigned int pos_y = 60;
+ 
+ enum corners { TOP_LEFT, TOP_RIGHT, BOTTOM_LEFT, BOTTOM_RIGHT };
+ enum corners corner = TOP_RIGHT;
+ 
+-static const unsigned int duration = 5; /* in seconds */
++static unsigned int duration = 5; /* in seconds */
+ 
+ #define DISMISS_BUTTON Button1
+ #define ACTION_BUTTON Button3
+diff --git a/herbe.c b/herbe.c
+index 51d3990..574e967 100644
+--- a/herbe.c
++++ b/herbe.c
+@@ -1,5 +1,6 @@
+ #include <X11/Xlib.h>
+ #include <X11/Xft/Xft.h>
++#include <X11/Xresource.h>
+ #include <stdio.h>
+ #include <stdlib.h>
+ #include <signal.h>
+@@ -15,6 +16,13 @@
+ #define EXIT_FAIL 1
+ #define EXIT_DISMISS 2
+ 
++#define XRES_STR(name)                                        \
++	if (XrmGetResource(db, "herbe." #name, "*", &type, &val)) \
++	name = val.addr
++#define XRES_INT(name)                                        \
++	if (XrmGetResource(db, "herbe." #name, "*", &type, &val)) \
++	name = strtoul(val.addr, 0, 10)
++
+ Display *display;
+ Window window;
+ int exit_code = EXIT_DISMISS;
+@@ -107,6 +115,28 @@ int main(int argc, char *argv[])
+ 	if (!(display = XOpenDisplay(0)))
+ 		die("Cannot open display");
+ 
++	XrmInitialize();
++
++	char *res_man = XResourceManagerString(display);
++	XrmDatabase db = XrmGetStringDatabase(res_man);
++
++	char *type;
++	XrmValue val;
++
++	XRES_STR(background_color);
++	XRES_STR(border_color);
++	XRES_STR(font_color);
++	XRES_STR(font_pattern);
++
++	XRES_INT(line_spacing);
++	XRES_INT(padding);
++	XRES_INT(width);
++	XRES_INT(border_size);
++	XRES_INT(pos_x);
++	XRES_INT(pos_y);
++	XRES_INT(corner);
++	XRES_INT(duration);
++
+ 	int screen = DefaultScreen(display);
+ 	Visual *visual = DefaultVisual(display, screen);
+ 	Colormap colormap = DefaultColormap(display, screen);
+@@ -214,7 +244,8 @@ int main(int argc, char *argv[])
+ 	XftDrawDestroy(draw);
+ 	XftColorFree(display, visual, colormap, &color);
+ 	XftFontClose(display, font);
++	XrmDestroyDatabase(db);
+ 	XCloseDisplay(display);
+ 
+ 	return exit_code;
+-}
+\ No newline at end of file
++}
diff --git a/srcpkgs/herbe/template b/srcpkgs/herbe/template
new file mode 100644
index 00000000000..de2bf34a198
--- /dev/null
+++ b/srcpkgs/herbe/template
@@ -0,0 +1,17 @@
+# Template file for 'herbe'
+pkgname=herbe
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+makedepends="libXft-devel"
+short_desc="Daemon-less notifications without D-Bus. Minimal and lightweight"
+maintainer="tuxliban <tenshalito@gmail.com>"
+license="MIT"
+homepage="https://github.com/dudik/herbe"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=78e454159050c86e030fb5a6cf997ac914345210cdf5a4ca4d7600c5296b7f76
+patch_args="-Np1"
+
+do_build() {
+	export CFLAGS=${CFLAGS}
+}

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Updated] New package: herbe-1.0.0
  2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
@ 2020-12-16 10:44 ` tuxliban
  2020-12-17 14:08 ` [PR REVIEW] " Piraty
                   ` (14 subsequent siblings)
  15 siblings, 0 replies; 18+ messages in thread
From: tuxliban @ 2020-12-16 10:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

There is an updated pull request by tuxliban against master on the void-packages repository

https://github.com/tuxliban/void-packages herbe
https://github.com/void-linux/void-packages/pull/27195

New package: herbe-1.0.0
Daemon-less notifications without D-Bus. Minimal and lightweight


A patch file from https://github.com/void-linux/void-packages/pull/27195.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-herbe-27195.patch --]
[-- Type: text/x-diff, Size: 5006 bytes --]

From 19b83b04173aafc9342c41520d4d8122efe9c975 Mon Sep 17 00:00:00 2001
From: tuxliban <tenshalito@gmail.com>
Date: Wed, 16 Dec 2020 03:56:49 -0600
Subject: [PATCH 1/2] New package: herbe-1.0.0

---
 srcpkgs/herbe/patches/Xresources.diff | 95 +++++++++++++++++++++++++++
 srcpkgs/herbe/template                | 17 +++++
 2 files changed, 112 insertions(+)
 create mode 100644 srcpkgs/herbe/patches/Xresources.diff
 create mode 100644 srcpkgs/herbe/template

diff --git a/srcpkgs/herbe/patches/Xresources.diff b/srcpkgs/herbe/patches/Xresources.diff
new file mode 100644
index 00000000000..2c9e9b1c5da
--- /dev/null
+++ b/srcpkgs/herbe/patches/Xresources.diff
@@ -0,0 +1,95 @@
+diff --git a/config.def.h b/config.def.h
+index 86b7e76..d545925 100644
+--- a/config.def.h
++++ b/config.def.h
+@@ -2,18 +2,18 @@ static const char *background_color = "#3e3e3e";
+ static const char *border_color = "#ececec";
+ static const char *font_color = "#ececec";
+ static const char *font_pattern = "monospace:size=10";
+-static const unsigned line_spacing = 5;
+-static const unsigned int padding = 15;
++static unsigned line_spacing = 5;
++static unsigned int padding = 15;
+ 
+-static const unsigned int width = 450;
+-static const unsigned int border_size = 2;
+-static const unsigned int pos_x = 30;
+-static const unsigned int pos_y = 60;
++static unsigned int width = 450;
++static unsigned int border_size = 2;
++static unsigned int pos_x = 30;
++static unsigned int pos_y = 60;
+ 
+ enum corners { TOP_LEFT, TOP_RIGHT, BOTTOM_LEFT, BOTTOM_RIGHT };
+ enum corners corner = TOP_RIGHT;
+ 
+-static const unsigned int duration = 5; /* in seconds */
++static unsigned int duration = 5; /* in seconds */
+ 
+ #define DISMISS_BUTTON Button1
+ #define ACTION_BUTTON Button3
+diff --git a/herbe.c b/herbe.c
+index 51d3990..574e967 100644
+--- a/herbe.c
++++ b/herbe.c
+@@ -1,5 +1,6 @@
+ #include <X11/Xlib.h>
+ #include <X11/Xft/Xft.h>
++#include <X11/Xresource.h>
+ #include <stdio.h>
+ #include <stdlib.h>
+ #include <signal.h>
+@@ -15,6 +16,13 @@
+ #define EXIT_FAIL 1
+ #define EXIT_DISMISS 2
+ 
++#define XRES_STR(name)                                        \
++	if (XrmGetResource(db, "herbe." #name, "*", &type, &val)) \
++	name = val.addr
++#define XRES_INT(name)                                        \
++	if (XrmGetResource(db, "herbe." #name, "*", &type, &val)) \
++	name = strtoul(val.addr, 0, 10)
++
+ Display *display;
+ Window window;
+ int exit_code = EXIT_DISMISS;
+@@ -107,6 +115,28 @@ int main(int argc, char *argv[])
+ 	if (!(display = XOpenDisplay(0)))
+ 		die("Cannot open display");
+ 
++	XrmInitialize();
++
++	char *res_man = XResourceManagerString(display);
++	XrmDatabase db = XrmGetStringDatabase(res_man);
++
++	char *type;
++	XrmValue val;
++
++	XRES_STR(background_color);
++	XRES_STR(border_color);
++	XRES_STR(font_color);
++	XRES_STR(font_pattern);
++
++	XRES_INT(line_spacing);
++	XRES_INT(padding);
++	XRES_INT(width);
++	XRES_INT(border_size);
++	XRES_INT(pos_x);
++	XRES_INT(pos_y);
++	XRES_INT(corner);
++	XRES_INT(duration);
++
+ 	int screen = DefaultScreen(display);
+ 	Visual *visual = DefaultVisual(display, screen);
+ 	Colormap colormap = DefaultColormap(display, screen);
+@@ -214,7 +244,8 @@ int main(int argc, char *argv[])
+ 	XftDrawDestroy(draw);
+ 	XftColorFree(display, visual, colormap, &color);
+ 	XftFontClose(display, font);
++	XrmDestroyDatabase(db);
+ 	XCloseDisplay(display);
+ 
+ 	return exit_code;
+-}
+\ No newline at end of file
++}
diff --git a/srcpkgs/herbe/template b/srcpkgs/herbe/template
new file mode 100644
index 00000000000..de2bf34a198
--- /dev/null
+++ b/srcpkgs/herbe/template
@@ -0,0 +1,17 @@
+# Template file for 'herbe'
+pkgname=herbe
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+makedepends="libXft-devel"
+short_desc="Daemon-less notifications without D-Bus. Minimal and lightweight"
+maintainer="tuxliban <tenshalito@gmail.com>"
+license="MIT"
+homepage="https://github.com/dudik/herbe"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=78e454159050c86e030fb5a6cf997ac914345210cdf5a4ca4d7600c5296b7f76
+patch_args="-Np1"
+
+do_build() {
+	export CFLAGS=${CFLAGS}
+}

From e8e4e6310c5715f5420da1fce243424e18858cb8 Mon Sep 17 00:00:00 2001
From: tuxliban <tenshalito@gmail.com>
Date: Wed, 16 Dec 2020 04:43:12 -0600
Subject: [PATCH 2/2] herbe: update to 1.0.0.

---
 srcpkgs/herbe/template | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/herbe/template b/srcpkgs/herbe/template
index de2bf34a198..e5b9319f6a1 100644
--- a/srcpkgs/herbe/template
+++ b/srcpkgs/herbe/template
@@ -3,7 +3,7 @@ pkgname=herbe
 version=1.0.0
 revision=1
 build_style=gnu-makefile
-makedepends="libXft-devel"
+makedepends="libXft-devel freetype-devel"
 short_desc="Daemon-less notifications without D-Bus. Minimal and lightweight"
 maintainer="tuxliban <tenshalito@gmail.com>"
 license="MIT"
@@ -15,3 +15,7 @@ patch_args="-Np1"
 do_build() {
 	export CFLAGS=${CFLAGS}
 }
+
+do_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: herbe-1.0.0
  2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
  2020-12-16 10:44 ` [PR PATCH] [Updated] " tuxliban
@ 2020-12-17 14:08 ` Piraty
  2020-12-17 14:08 ` Piraty
                   ` (13 subsequent siblings)
  15 siblings, 0 replies; 18+ messages in thread
From: Piraty @ 2020-12-17 14:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/27195#discussion_r545115723

Comment:
this 
1. doesn't build anything and renders the [package empty (except license)](https://github.com/void-linux/void-packages/pull/27195/checks?check_run_id=1563142458#step:13:9)
2. should not be necessary as CFLAGS is already in env

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: herbe-1.0.0
  2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
  2020-12-16 10:44 ` [PR PATCH] [Updated] " tuxliban
  2020-12-17 14:08 ` [PR REVIEW] " Piraty
@ 2020-12-17 14:08 ` Piraty
  2020-12-17 22:07 ` tuxliban
                   ` (12 subsequent siblings)
  15 siblings, 0 replies; 18+ messages in thread
From: Piraty @ 2020-12-17 14:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/27195#discussion_r545114943

Comment:
elaborate on reasoning about this patch or mention the source if any

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: herbe-1.0.0
  2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
                   ` (2 preceding siblings ...)
  2020-12-17 14:08 ` Piraty
@ 2020-12-17 22:07 ` tuxliban
  2020-12-17 22:08 ` tuxliban
                   ` (11 subsequent siblings)
  15 siblings, 0 replies; 18+ messages in thread
From: tuxliban @ 2020-12-17 22:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

New review comment by tuxliban on void-packages repository

https://github.com/void-linux/void-packages/pull/27195#discussion_r545434652

Comment:
I got the patch [from here](https://github.com/dudik/herbe/pull/11) and it was convenient for me to add it so that users can modify the settings from the Xresources file and not compile it from source.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: herbe-1.0.0
  2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
                   ` (3 preceding siblings ...)
  2020-12-17 22:07 ` tuxliban
@ 2020-12-17 22:08 ` tuxliban
  2020-12-17 22:35 ` tuxliban
                   ` (10 subsequent siblings)
  15 siblings, 0 replies; 18+ messages in thread
From: tuxliban @ 2020-12-17 22:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2558 bytes --]

New review comment by tuxliban on void-packages repository

https://github.com/void-linux/void-packages/pull/27195#discussion_r545434875

Comment:
Previously I tried to build the binary directly with the help of the gnu-makefile build script, but despite having specified the makedepends in the middle of the process it gives me an error for missing a header.
The only way I was able to build the binary was as the template currently is.

```
-> $ ./xbps-src -f pkg herbe
=> xbps-src: updating repositories for host (x86_64-musl)...
[*] Updating repository `https://alpha.us.repo.voidlinux.org/current/musl/x86_64-musl-repodata' ...
x86_64-musl-repodata: 1688KB [avg rate: 86KB/s]
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/x86_64-musl-repodata' ...
x86_64-musl-repodata: 1688KB [avg rate: 187KB/s]
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/nonfree/x86_64-musl-repodata' ..
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> herbe-1.0.0_1: removing autodeps, please wait...
=> herbe-1.0.0_1: building [gnu-makefile] for x86_64-musl...
   [target] libXft-devel-2.3.3_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
   [target] freetype-devel-2.10.4_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
=> herbe-1.0.0_1: installing target dependencies: libXft-devel-2.3.3_1 freetype-devel-2.10.4_1 ...
=> herbe-1.0.0_1: running do-fetch hook: 00-distfiles ...
=> herbe-1.0.0_1: running do-extract hook: 00-distfiles ...
=> herbe-1.0.0_1: extracting distfile(s), please wait...
=> herbe-1.0.0_1: running do-patch hook: 00-patches ...
=> herbe-1.0.0_1: patching: 11.diff.
=> herbe-1.0.0_1: patching: Xresources.diff.
Reversed (or previously applied) patch detected!  Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file config.def.h.rej
Reversed (or previously applied) patch detected!  Skipping patch.
4 out of 4 hunks ignored -- saving rejects to file herbe.c.rej
=> ERROR: herbe-1.0.0_1: do-patch_00-patches: 'patch -sl ${_args} -i ${_patch} 2> /dev/null' exited with 1
=> ERROR:   in _process_patch() at common/hooks/do-patch/00-patches.sh:34
=> ERROR:   in hook() at common/hooks/do-patch/00-patches.sh:51
=> ERROR:   in run_func() at common/xbps-src/shutils/common.sh:21
=> ERROR:   in run_pkg_hooks() at common/xbps-src/shutils/common.sh:245
=> ERROR:   in run_step() at common/xbps-src/shutils/common.sh:71
=> ERROR:   in main() at common/xbps-src/libexec/xbps-src-dopatch.sh:33
```

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: herbe-1.0.0
  2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
                   ` (4 preceding siblings ...)
  2020-12-17 22:08 ` tuxliban
@ 2020-12-17 22:35 ` tuxliban
  2020-12-17 22:38 ` tuxliban
                   ` (9 subsequent siblings)
  15 siblings, 0 replies; 18+ messages in thread
From: tuxliban @ 2020-12-17 22:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2667 bytes --]

New review comment by tuxliban on void-packages repository

https://github.com/void-linux/void-packages/pull/27195#discussion_r545434875

Comment:
Previously I tried to build the binary directly with the help of the gnu-makefile build script, but despite having specified the makedepends in the middle of the process it gives me an error for missing a header.
The only way I was able to build the binary was as the template currently is.

```
-> $ ./xbps-src -f pkg herbe
=> xbps-src: updating repositories for host (x86_64-musl)...
[*] Updating repository `https://alpha.us.repo.voidlinux.org/current/musl/x86_64-musl-repodata' ...
x86_64-musl-repodata: 1688KB [avg rate: 86KB/s]
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/x86_64-musl-repodata' ...
x86_64-musl-repodata: 1688KB [avg rate: 187KB/s]
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/nonfree/x86_64-musl-repodata' ..
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> herbe-1.0.0_1: removing autodeps, please wait...
=> herbe-1.0.0_1: building [gnu-makefile] for x86_64-musl...
   [target] libXft-devel-2.3.3_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
   [target] freetype-devel-2.10.4_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
=> herbe-1.0.0_1: installing target dependencies: libXft-devel-2.3.3_1 freetype-devel-2.10.4_1 ...
=> herbe-1.0.0_1: running do-fetch hook: 00-distfiles ...
=> herbe-1.0.0_1: running do-extract hook: 00-distfiles ...
=> herbe-1.0.0_1: extracting distfile(s), please wait...
=> herbe-1.0.0_1: running do-patch hook: 00-patches ...
=> herbe-1.0.0_1: patching: 11.diff.
=> herbe-1.0.0_1: patching: Xresources.diff.
Reversed (or previously applied) patch detected!  Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file config.def.h.rej
Reversed (or previously applied) patch detected!  Skipping patch.
4 out of 4 hunks ignored -- saving rejects to file herbe.c.rej
=> ERROR: herbe-1.0.0_1: do-patch_00-patches: 'patch -sl ${_args} -i ${_patch} 2> /dev/null' exited with 1
=> ERROR:   in _process_patch() at common/hooks/do-patch/00-patches.sh:34
=> ERROR:   in hook() at common/hooks/do-patch/00-patches.sh:51
=> ERROR:   in run_func() at common/xbps-src/shutils/common.sh:21
=> ERROR:   in run_pkg_hooks() at common/xbps-src/shutils/common.sh:245
=> ERROR:   in run_step() at common/xbps-src/shutils/common.sh:71
=> ERROR:   in main() at common/xbps-src/libexec/xbps-src-dopatch.sh:33
```
It should also be said that the program does not have a user manual since its use is relatively very simple

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: herbe-1.0.0
  2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
                   ` (5 preceding siblings ...)
  2020-12-17 22:35 ` tuxliban
@ 2020-12-17 22:38 ` tuxliban
  2020-12-17 22:44 ` tuxliban
                   ` (8 subsequent siblings)
  15 siblings, 0 replies; 18+ messages in thread
From: tuxliban @ 2020-12-17 22:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2629 bytes --]

New review comment by tuxliban on void-packages repository

https://github.com/void-linux/void-packages/pull/27195#discussion_r545434875

Comment:
Previously I tried to build the binary directly with the help of the gnu-makefile build script, but despite having specified the makedepends in the middle of the process it gives me an error for missing a header.
The only way I was able to build the binary was as the template currently is.

```
-> $ ./xbps-src -f pkg herbe
=> xbps-src: updating repositories for host (x86_64-musl)...
[*] Updating repository `https://alpha.us.repo.voidlinux.org/current/musl/x86_64-musl-repodata' ...
x86_64-musl-repodata: 1688KB [avg rate: 86KB/s]
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/x86_64-musl-repodata' ...
x86_64-musl-repodata: 1688KB [avg rate: 187KB/s]
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/nonfree/x86_64-musl-repodata' ..
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> herbe-1.0.0_1: removing autodeps, please wait...
=> herbe-1.0.0_1: building [gnu-makefile] for x86_64-musl...
   [target] libXft-devel-2.3.3_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
   [target] freetype-devel-2.10.4_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
=> herbe-1.0.0_1: installing target dependencies: libXft-devel-2.3.3_1 freetype-devel-2.10.4_1 ...
=> herbe-1.0.0_1: running do-fetch hook: 00-distfiles ...
=> herbe-1.0.0_1: running do-extract hook: 00-distfiles ...
=> herbe-1.0.0_1: extracting distfile(s), please wait...
=> herbe-1.0.0_1: running do-patch hook: 00-patches ...
=> herbe-1.0.0_1: patching: Xresources.diff.
Reversed (or previously applied) patch detected!  Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file config.def.h.rej
Reversed (or previously applied) patch detected!  Skipping patch.
4 out of 4 hunks ignored -- saving rejects to file herbe.c.rej
=> ERROR: herbe-1.0.0_1: do-patch_00-patches: 'patch -sl ${_args} -i ${_patch} 2> /dev/null' exited with 1
=> ERROR:   in _process_patch() at common/hooks/do-patch/00-patches.sh:34
=> ERROR:   in hook() at common/hooks/do-patch/00-patches.sh:51
=> ERROR:   in run_func() at common/xbps-src/shutils/common.sh:21
=> ERROR:   in run_pkg_hooks() at common/xbps-src/shutils/common.sh:245
=> ERROR:   in run_step() at common/xbps-src/shutils/common.sh:71
=> ERROR:   in main() at common/xbps-src/libexec/xbps-src-dopatch.sh:33
```
It should also be said that the program does not have a user manual since its use is relatively very simple

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: herbe-1.0.0
  2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
                   ` (6 preceding siblings ...)
  2020-12-17 22:38 ` tuxliban
@ 2020-12-17 22:44 ` tuxliban
  2020-12-21 11:46 ` Piraty
                   ` (7 subsequent siblings)
  15 siblings, 0 replies; 18+ messages in thread
From: tuxliban @ 2020-12-17 22:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2792 bytes --]

New review comment by tuxliban on void-packages repository

https://github.com/void-linux/void-packages/pull/27195#discussion_r545434875

Comment:
Previously I tried to build the binary directly with the help of the gnu-makefile build script, but despite having specified the makedepends in the middle of the process it gives me an error for missing a header.
The only way I was able to build the binary was as the template currently is.

```
-> $ ./xbps-src -f pkg herbe
=> xbps-src: updating repositories for host (x86_64-musl)...
[*] Updating repository `https://alpha.us.repo.voidlinux.org/current/musl/x86_64-musl-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/x86_64-musl-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/nonfree/x86_64-musl-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> herbe-1.0.0_1: removing autodeps, please wait...
=> herbe-1.0.0_1: building [gnu-makefile] for x86_64-musl...
   [target] libXft-devel-2.3.3_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
   [target] freetype-devel-2.10.4_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
=> herbe-1.0.0_1: installing target dependencies: libXft-devel-2.3.3_1 freetype-devel-2.10.4_1 ...
=> herbe-1.0.0_1: running do-fetch hook: 00-distfiles ...
=> herbe-1.0.0_1: running do-extract hook: 00-distfiles ...
=> herbe-1.0.0_1: extracting distfile(s), please wait...
=> herbe-1.0.0_1: running do-patch hook: 00-patches ...
=> herbe-1.0.0_1: patching: Xresources.diff.
=> herbe-1.0.0_1: running pre-configure hook: 00-gnu-configure-asneeded ...
=> herbe-1.0.0_1: running pre-configure hook: 01-override-config ...
=> herbe-1.0.0_1: running pre-configure hook: 02-script-wrapper ...
=> herbe-1.0.0_1: running pre-build hook: 02-script-wrapper ...
=> herbe-1.0.0_1: running do_build ...
cp config.def.h config.h
cc herbe.c -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -march=native -O2 -pipe    -o herbe
In file included from herbe.c:2:
/usr/include/X11/Xft/Xft.h:39:10: fatal error: ft2build.h: No such file or directory
   39 | #include <ft2build.h>
      |          ^~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:12: herbe] Error 1
=> ERROR: herbe-1.0.0_1: do_build: '${make_cmd} CC="$CC" CXX="$CXX" LD="$LD" AR="$AR" RANLIB="$RANLIB" CPP="$CPP" AS="$AS" OBJCOPY="$OBJCOPY" OBJDUMP="$OBJDUMP" CFLAGS="$CFLAGS" CXXFLAGS="$CXXFLAGS" LDFLAGS="$LDFLAGS" ${makejobs} ${make_build_args} ${make_build_target}' exited with 2
=> ERROR:   in do_build() at common/build-style/gnu-makefile.sh:9
```
It should also be said that the program does not have a user manual since its use is relatively very simple

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: herbe-1.0.0
  2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
                   ` (7 preceding siblings ...)
  2020-12-17 22:44 ` tuxliban
@ 2020-12-21 11:46 ` Piraty
  2020-12-21 11:47 ` Piraty
                   ` (6 subsequent siblings)
  15 siblings, 0 replies; 18+ messages in thread
From: Piraty @ 2020-12-21 11:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/27195#discussion_r546662362

Comment:
reference the origin of that patch in the patch header. nobody reads github

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: herbe-1.0.0
  2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
                   ` (8 preceding siblings ...)
  2020-12-21 11:46 ` Piraty
@ 2020-12-21 11:47 ` Piraty
  2020-12-21 11:48 ` Piraty
                   ` (5 subsequent siblings)
  15 siblings, 0 replies; 18+ messages in thread
From: Piraty @ 2020-12-21 11:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/27195#discussion_r546662362

Comment:
reference the origin of that patch in the patch header. nobody reads github. side-note: Void won't patch in random features that upstream doesn't want/reviewed

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: herbe-1.0.0
  2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
                   ` (9 preceding siblings ...)
  2020-12-21 11:47 ` Piraty
@ 2020-12-21 11:48 ` Piraty
  2020-12-21 11:50 ` Piraty
                   ` (4 subsequent siblings)
  15 siblings, 0 replies; 18+ messages in thread
From: Piraty @ 2020-12-21 11:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/27195#discussion_r546663064

Comment:
as the template is now, the package just ships one file (the license)

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: herbe-1.0.0
  2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
                   ` (10 preceding siblings ...)
  2020-12-21 11:48 ` Piraty
@ 2020-12-21 11:50 ` Piraty
  2020-12-21 11:50 ` Piraty
                   ` (3 subsequent siblings)
  15 siblings, 0 replies; 18+ messages in thread
From: Piraty @ 2020-12-21 11:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/27195#discussion_r546663064

Comment:
as the template is now, the package just ships one file (the license).
the error indicated you're missing a package in `makedepends` (hint: it's freetype-devel. you can use xlocate from xtools to find files)

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: herbe-1.0.0
  2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
                   ` (11 preceding siblings ...)
  2020-12-21 11:50 ` Piraty
@ 2020-12-21 11:50 ` Piraty
  2021-02-07 11:33 ` [PR PATCH] [Updated] " tuxliban
                   ` (2 subsequent siblings)
  15 siblings, 0 replies; 18+ messages in thread
From: Piraty @ 2020-12-21 11:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/27195#discussion_r546663064

Comment:
as the template is now, the package just ships one file (the license).
the error indicates you're missing a package in `makedepends` (hint: it's freetype-devel. you can use xlocate from xtools to find files)

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Updated] New package: herbe-1.0.0
  2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
                   ` (12 preceding siblings ...)
  2020-12-21 11:50 ` Piraty
@ 2021-02-07 11:33 ` tuxliban
  2021-04-28 11:51 ` ericonr
  2021-04-28 11:51 ` [PR PATCH] [Closed]: " ericonr
  15 siblings, 0 replies; 18+ messages in thread
From: tuxliban @ 2021-02-07 11:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

There is an updated pull request by tuxliban against master on the void-packages repository

https://github.com/tuxliban/void-packages herbe
https://github.com/void-linux/void-packages/pull/27195

New package: herbe-1.0.0
Daemon-less notifications without D-Bus. Minimal and lightweight


A patch file from https://github.com/void-linux/void-packages/pull/27195.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-herbe-27195.patch --]
[-- Type: text/x-diff, Size: 9217 bytes --]

From 19b83b04173aafc9342c41520d4d8122efe9c975 Mon Sep 17 00:00:00 2001
From: tuxliban <tenshalito@gmail.com>
Date: Wed, 16 Dec 2020 03:56:49 -0600
Subject: [PATCH 1/3] New package: herbe-1.0.0

---
 srcpkgs/herbe/patches/Xresources.diff | 95 +++++++++++++++++++++++++++
 srcpkgs/herbe/template                | 17 +++++
 2 files changed, 112 insertions(+)
 create mode 100644 srcpkgs/herbe/patches/Xresources.diff
 create mode 100644 srcpkgs/herbe/template

diff --git a/srcpkgs/herbe/patches/Xresources.diff b/srcpkgs/herbe/patches/Xresources.diff
new file mode 100644
index 00000000000..2c9e9b1c5da
--- /dev/null
+++ b/srcpkgs/herbe/patches/Xresources.diff
@@ -0,0 +1,95 @@
+diff --git a/config.def.h b/config.def.h
+index 86b7e76..d545925 100644
+--- a/config.def.h
++++ b/config.def.h
+@@ -2,18 +2,18 @@ static const char *background_color = "#3e3e3e";
+ static const char *border_color = "#ececec";
+ static const char *font_color = "#ececec";
+ static const char *font_pattern = "monospace:size=10";
+-static const unsigned line_spacing = 5;
+-static const unsigned int padding = 15;
++static unsigned line_spacing = 5;
++static unsigned int padding = 15;
+ 
+-static const unsigned int width = 450;
+-static const unsigned int border_size = 2;
+-static const unsigned int pos_x = 30;
+-static const unsigned int pos_y = 60;
++static unsigned int width = 450;
++static unsigned int border_size = 2;
++static unsigned int pos_x = 30;
++static unsigned int pos_y = 60;
+ 
+ enum corners { TOP_LEFT, TOP_RIGHT, BOTTOM_LEFT, BOTTOM_RIGHT };
+ enum corners corner = TOP_RIGHT;
+ 
+-static const unsigned int duration = 5; /* in seconds */
++static unsigned int duration = 5; /* in seconds */
+ 
+ #define DISMISS_BUTTON Button1
+ #define ACTION_BUTTON Button3
+diff --git a/herbe.c b/herbe.c
+index 51d3990..574e967 100644
+--- a/herbe.c
++++ b/herbe.c
+@@ -1,5 +1,6 @@
+ #include <X11/Xlib.h>
+ #include <X11/Xft/Xft.h>
++#include <X11/Xresource.h>
+ #include <stdio.h>
+ #include <stdlib.h>
+ #include <signal.h>
+@@ -15,6 +16,13 @@
+ #define EXIT_FAIL 1
+ #define EXIT_DISMISS 2
+ 
++#define XRES_STR(name)                                        \
++	if (XrmGetResource(db, "herbe." #name, "*", &type, &val)) \
++	name = val.addr
++#define XRES_INT(name)                                        \
++	if (XrmGetResource(db, "herbe." #name, "*", &type, &val)) \
++	name = strtoul(val.addr, 0, 10)
++
+ Display *display;
+ Window window;
+ int exit_code = EXIT_DISMISS;
+@@ -107,6 +115,28 @@ int main(int argc, char *argv[])
+ 	if (!(display = XOpenDisplay(0)))
+ 		die("Cannot open display");
+ 
++	XrmInitialize();
++
++	char *res_man = XResourceManagerString(display);
++	XrmDatabase db = XrmGetStringDatabase(res_man);
++
++	char *type;
++	XrmValue val;
++
++	XRES_STR(background_color);
++	XRES_STR(border_color);
++	XRES_STR(font_color);
++	XRES_STR(font_pattern);
++
++	XRES_INT(line_spacing);
++	XRES_INT(padding);
++	XRES_INT(width);
++	XRES_INT(border_size);
++	XRES_INT(pos_x);
++	XRES_INT(pos_y);
++	XRES_INT(corner);
++	XRES_INT(duration);
++
+ 	int screen = DefaultScreen(display);
+ 	Visual *visual = DefaultVisual(display, screen);
+ 	Colormap colormap = DefaultColormap(display, screen);
+@@ -214,7 +244,8 @@ int main(int argc, char *argv[])
+ 	XftDrawDestroy(draw);
+ 	XftColorFree(display, visual, colormap, &color);
+ 	XftFontClose(display, font);
++	XrmDestroyDatabase(db);
+ 	XCloseDisplay(display);
+ 
+ 	return exit_code;
+-}
+\ No newline at end of file
++}
diff --git a/srcpkgs/herbe/template b/srcpkgs/herbe/template
new file mode 100644
index 00000000000..de2bf34a198
--- /dev/null
+++ b/srcpkgs/herbe/template
@@ -0,0 +1,17 @@
+# Template file for 'herbe'
+pkgname=herbe
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+makedepends="libXft-devel"
+short_desc="Daemon-less notifications without D-Bus. Minimal and lightweight"
+maintainer="tuxliban <tenshalito@gmail.com>"
+license="MIT"
+homepage="https://github.com/dudik/herbe"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=78e454159050c86e030fb5a6cf997ac914345210cdf5a4ca4d7600c5296b7f76
+patch_args="-Np1"
+
+do_build() {
+	export CFLAGS=${CFLAGS}
+}

From e8e4e6310c5715f5420da1fce243424e18858cb8 Mon Sep 17 00:00:00 2001
From: tuxliban <tenshalito@gmail.com>
Date: Wed, 16 Dec 2020 04:43:12 -0600
Subject: [PATCH 2/3] herbe: update to 1.0.0.

---
 srcpkgs/herbe/template | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/herbe/template b/srcpkgs/herbe/template
index de2bf34a198..e5b9319f6a1 100644
--- a/srcpkgs/herbe/template
+++ b/srcpkgs/herbe/template
@@ -3,7 +3,7 @@ pkgname=herbe
 version=1.0.0
 revision=1
 build_style=gnu-makefile
-makedepends="libXft-devel"
+makedepends="libXft-devel freetype-devel"
 short_desc="Daemon-less notifications without D-Bus. Minimal and lightweight"
 maintainer="tuxliban <tenshalito@gmail.com>"
 license="MIT"
@@ -15,3 +15,7 @@ patch_args="-Np1"
 do_build() {
 	export CFLAGS=${CFLAGS}
 }
+
+do_install() {
+	vlicense LICENSE
+}

From 75ed0b6d2cc18fc5ff59dd701bbced5602257678 Mon Sep 17 00:00:00 2001
From: tuxliban <tenshalito@gmail.com>
Date: Wed, 16 Dec 2020 03:56:49 -0600
Subject: [PATCH 3/3] New package: herbe-1.0.0

---
 srcpkgs/herbe/patches/Xresources.diff | 95 +++++++++++++++++++++++++++
 srcpkgs/herbe/template                | 21 ++++++
 2 files changed, 116 insertions(+)
 create mode 100644 srcpkgs/herbe/patches/Xresources.diff
 create mode 100644 srcpkgs/herbe/template

diff --git a/srcpkgs/herbe/patches/Xresources.diff b/srcpkgs/herbe/patches/Xresources.diff
new file mode 100644
index 00000000000..2c9e9b1c5da
--- /dev/null
+++ b/srcpkgs/herbe/patches/Xresources.diff
@@ -0,0 +1,95 @@
+diff --git a/config.def.h b/config.def.h
+index 86b7e76..d545925 100644
+--- a/config.def.h
++++ b/config.def.h
+@@ -2,18 +2,18 @@ static const char *background_color = "#3e3e3e";
+ static const char *border_color = "#ececec";
+ static const char *font_color = "#ececec";
+ static const char *font_pattern = "monospace:size=10";
+-static const unsigned line_spacing = 5;
+-static const unsigned int padding = 15;
++static unsigned line_spacing = 5;
++static unsigned int padding = 15;
+ 
+-static const unsigned int width = 450;
+-static const unsigned int border_size = 2;
+-static const unsigned int pos_x = 30;
+-static const unsigned int pos_y = 60;
++static unsigned int width = 450;
++static unsigned int border_size = 2;
++static unsigned int pos_x = 30;
++static unsigned int pos_y = 60;
+ 
+ enum corners { TOP_LEFT, TOP_RIGHT, BOTTOM_LEFT, BOTTOM_RIGHT };
+ enum corners corner = TOP_RIGHT;
+ 
+-static const unsigned int duration = 5; /* in seconds */
++static unsigned int duration = 5; /* in seconds */
+ 
+ #define DISMISS_BUTTON Button1
+ #define ACTION_BUTTON Button3
+diff --git a/herbe.c b/herbe.c
+index 51d3990..574e967 100644
+--- a/herbe.c
++++ b/herbe.c
+@@ -1,5 +1,6 @@
+ #include <X11/Xlib.h>
+ #include <X11/Xft/Xft.h>
++#include <X11/Xresource.h>
+ #include <stdio.h>
+ #include <stdlib.h>
+ #include <signal.h>
+@@ -15,6 +16,13 @@
+ #define EXIT_FAIL 1
+ #define EXIT_DISMISS 2
+ 
++#define XRES_STR(name)                                        \
++	if (XrmGetResource(db, "herbe." #name, "*", &type, &val)) \
++	name = val.addr
++#define XRES_INT(name)                                        \
++	if (XrmGetResource(db, "herbe." #name, "*", &type, &val)) \
++	name = strtoul(val.addr, 0, 10)
++
+ Display *display;
+ Window window;
+ int exit_code = EXIT_DISMISS;
+@@ -107,6 +115,28 @@ int main(int argc, char *argv[])
+ 	if (!(display = XOpenDisplay(0)))
+ 		die("Cannot open display");
+ 
++	XrmInitialize();
++
++	char *res_man = XResourceManagerString(display);
++	XrmDatabase db = XrmGetStringDatabase(res_man);
++
++	char *type;
++	XrmValue val;
++
++	XRES_STR(background_color);
++	XRES_STR(border_color);
++	XRES_STR(font_color);
++	XRES_STR(font_pattern);
++
++	XRES_INT(line_spacing);
++	XRES_INT(padding);
++	XRES_INT(width);
++	XRES_INT(border_size);
++	XRES_INT(pos_x);
++	XRES_INT(pos_y);
++	XRES_INT(corner);
++	XRES_INT(duration);
++
+ 	int screen = DefaultScreen(display);
+ 	Visual *visual = DefaultVisual(display, screen);
+ 	Colormap colormap = DefaultColormap(display, screen);
+@@ -214,7 +244,8 @@ int main(int argc, char *argv[])
+ 	XftDrawDestroy(draw);
+ 	XftColorFree(display, visual, colormap, &color);
+ 	XftFontClose(display, font);
++	XrmDestroyDatabase(db);
+ 	XCloseDisplay(display);
+ 
+ 	return exit_code;
+-}
+\ No newline at end of file
++}
diff --git a/srcpkgs/herbe/template b/srcpkgs/herbe/template
new file mode 100644
index 00000000000..e5b9319f6a1
--- /dev/null
+++ b/srcpkgs/herbe/template
@@ -0,0 +1,21 @@
+# Template file for 'herbe'
+pkgname=herbe
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+makedepends="libXft-devel freetype-devel"
+short_desc="Daemon-less notifications without D-Bus. Minimal and lightweight"
+maintainer="tuxliban <tenshalito@gmail.com>"
+license="MIT"
+homepage="https://github.com/dudik/herbe"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=78e454159050c86e030fb5a6cf997ac914345210cdf5a4ca4d7600c5296b7f76
+patch_args="-Np1"
+
+do_build() {
+	export CFLAGS=${CFLAGS}
+}
+
+do_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: New package: herbe-1.0.0
  2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
                   ` (13 preceding siblings ...)
  2021-02-07 11:33 ` [PR PATCH] [Updated] " tuxliban
@ 2021-04-28 11:51 ` ericonr
  2021-04-28 11:51 ` [PR PATCH] [Closed]: " ericonr
  15 siblings, 0 replies; 18+ messages in thread
From: ericonr @ 2021-04-28 11:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27195#issuecomment-828391445

Comment:
Closed with #30558

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Closed]: New package: herbe-1.0.0
  2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
                   ` (14 preceding siblings ...)
  2021-04-28 11:51 ` ericonr
@ 2021-04-28 11:51 ` ericonr
  15 siblings, 0 replies; 18+ messages in thread
From: ericonr @ 2021-04-28 11:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

There's a closed pull request on the void-packages repository

New package: herbe-1.0.0
https://github.com/void-linux/void-packages/pull/27195

Description:
Daemon-less notifications without D-Bus. Minimal and lightweight


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PR PATCH] New package: herbe-1.0.0
@ 2021-04-28 10:53 biopsin
  0 siblings, 0 replies; 18+ messages in thread
From: biopsin @ 2021-04-28 10:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1723 bytes --]

There is a new pull request by biopsin against master on the void-packages repository

https://github.com/biopsin/void-packages patch-1
https://github.com/void-linux/void-packages/pull/30558

New package: herbe-1.0.0
Tested local build for
[x] armv7l-musl
[x] i686
[x] x86_64/-musl

Closes PR https://github.com/void-linux/void-packages/pull/27195
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [x] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30558.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-30558.patch --]
[-- Type: text/x-diff, Size: 1110 bytes --]

From 0ae4fa93a577caf8fc9a4454af01a9858a381a61 Mon Sep 17 00:00:00 2001
From: biopsin <biopsin@teknik.io>
Date: Wed, 28 Apr 2021 10:31:57 +0000
Subject: [PATCH] New package: herbe-1.0.0

---
 srcpkgs/herbe/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/herbe/template

diff --git a/srcpkgs/herbe/template b/srcpkgs/herbe/template
new file mode 100644
index 000000000000..000e2b1f444d
--- /dev/null
+++ b/srcpkgs/herbe/template
@@ -0,0 +1,22 @@
+# Template file for 'herbe'
+pkgname=herbe
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+makedepends="libXft-devel"
+short_desc="Daemon-less notifications without D-Bus"
+maintainer="biopsin <biopsin@teknik.io>"
+license="MIT"
+homepage="https://github.com/dudik/herbe"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=78e454159050c86e030fb5a6cf997ac914345210cdf5a4ca4d7600c5296b7f76
+
+do_build() {
+	# Patch Makefile to locate <ft2build.h>
+	vsed 's|-I/usr/include/freetype2|-I${XBPS_CROSS_BASE}/usr/include/freetype2|' \
+		-i ${wrksrc}/Makefile
+}
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2021-04-28 11:51 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-16 10:14 [PR PATCH] New package: herbe-1.0.0 tuxliban
2020-12-16 10:44 ` [PR PATCH] [Updated] " tuxliban
2020-12-17 14:08 ` [PR REVIEW] " Piraty
2020-12-17 14:08 ` Piraty
2020-12-17 22:07 ` tuxliban
2020-12-17 22:08 ` tuxliban
2020-12-17 22:35 ` tuxliban
2020-12-17 22:38 ` tuxliban
2020-12-17 22:44 ` tuxliban
2020-12-21 11:46 ` Piraty
2020-12-21 11:47 ` Piraty
2020-12-21 11:48 ` Piraty
2020-12-21 11:50 ` Piraty
2020-12-21 11:50 ` Piraty
2021-02-07 11:33 ` [PR PATCH] [Updated] " tuxliban
2021-04-28 11:51 ` ericonr
2021-04-28 11:51 ` [PR PATCH] [Closed]: " ericonr
2021-04-28 10:53 [PR PATCH] " biopsin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).