[ISSUE] Localization files in /usr/lib/locale

[ISSUE] Localization files in /usr/lib/locale

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 3023 bytes --]

New issue by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/27491

Description:
The correct `localedir` is `/usr/share/locale`, which is respected on all glibc packages. Unfortunately, on musl some packages perform their own detection of what `localedir` to use, due to some really weird mechanisms, and end up putting those files into `/usr/lib/locale`. Since locale data isn't arch specific, it should be stored in `/usr/share`. For multilib systems, this also makes it so locale data only has to be installed once, in `/usr/share`, by the native package.

@q66 scraped his repo for packages with files in `/usr/lib/locale`, which should be fixed, unless there are specific circumstances (`pcsx2` is one such example, since it can't be installed at all on 64-bit systems).

- [ ] appdata-tools
- [ ] ario
- [ ] brasero
- [ ] desmume
- [ ] dia
- [ ] exo
- [ ] garcon
- [ ] GConf
- [ ] gconf-editor
- [ ] gdmap
- [ ] geeqie
- [ ] gimp
- [ ] gimp-lqr-plugin
- [ ] gmpc
- [ ] gnome-doc-utils
- [ ] gnome-mime-data
- [ ] gnome-mplayer
- [ ] gnome-nettool
- [ ] gnome-screensaver
- [ ] gnome-system-log
- [ ] gnumeric
- [ ] goocanvas1 (will be removed in #27438 )
- [ ] gpicview
- [ ] gtk+
- [ ] gtk2-engines
- [ ] gtkpod
- [ ] gtksourceview2
- [ ] gtkspell
- [ ] gxmessage
- [ ] homebank
- [ ] leafpad
- [ ] libcryptui
- [ ] libglib-static
- [ ] libgnomecanvas
- [ ] libgnome-keyring
- [ ] libgpod
- [ ] libwnck2
- [ ] libxfce4ui
- [ ] libxfce4util
- [ ] lightdm-gtk-greeter
- [ ] lxappearance-obconf
- [ ] lxinput
- [ ] lxlauncher
- [ ] mousepad
- [ ] orage
- [ ] parcellite
- [ ] parole
- [ ] pcmanx-gtk2
- [ ] pidgin-libnotify
- [ ] pidgin-otr
- [ ] pidgin-privacy-please
- [ ] pmount
- [ ] polkit-gnome
- [ ] pragha
- [ ] ristretto
- [ ] seahorse-nautilus
- [ ] seahorse-sharing
- [ ] spacefm
- [ ] Thunar
- [ ] thunar-archive-plugin
- [ ] thunar-media-tags-plugin
- [ ] thunar-volman
- [ ] tilp2
- [ ] tumbler
- [ ] udevil
- [ ] ufraw
- [ ] uget
- [ ] viking
- [ ] volumeicon
- [ ] vte
- [ ] vte290
- [ ] xdg-user-dirs-gtk
- [ ] xfburn
- [ ] xfce4-appfinder
- [ ] xfce4-battery-plugin
- [ ] xfce4-clipman-plugin
- [ ] xfce4-cpufreq-plugin
- [ ] xfce4-cpugraph-plugin
- [ ] xfce4-dict
- [ ] xfce4-diskperf-plugin
- [ ] xfce4-fsguard-plugin
- [ ] xfce4-genmon-plugin
- [ ] xfce4-mailwatch-plugin
- [ ] xfce4-mpc-plugin
- [ ] xfce4-netload-plugin
- [ ] xfce4-notifyd
- [ ] xfce4-panel
- [ ] xfce4-places-plugin
- [ ] xfce4-power-manager
- [ ] xfce4-pulseaudio-plugin
- [ ] xfce4-screenshooter
- [ ] xfce4-sensors-plugin
- [ ] xfce4-session
- [ ] xfce4-settings
- [ ] xfce4-systemload-plugin
- [ ] xfce4-taskmanager
- [ ] xfce4-terminal
- [ ] xfce4-time-out-plugin
- [ ] xfce4-timer-plugin
- [ ] xfce4-verve-plugin
- [ ] xfce4-wavelan-plugin
- [ ] xfce4-weather-plugin
- [ ] xfce4-xkb-plugin
- [ ] xfconf
- [ ] xfdesktop
- [ ] xfwm4
- [ ] xnoise
- [ ] xournal
- [ ] xsane

Re: Localization files in /usr/lib/locale

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 1710 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-751640784

Comment:
I did have a look at geeqie and assume most of the listed packages above share the same issue.
It seems the problems lies in `/usr/share/aclocal/glib-gettext.m4`, line 275:
```
	  AC_TRY_LINK(, [extern int _nl_msg_cat_cntr;
			 return _nl_msg_cat_cntr],
	    [CATOBJEXT=.gmo 
             DATADIRNAME=share],
	    [case $host in
	    *-*-solaris*)
	    dnl On Solaris, if bind_textdomain_codeset is in libc,
	    dnl GNU format message catalog is always supported,
            dnl since both are added to the libc all together.
	    dnl Hence, we'd like to go with DATADIRNAME=share and
	    dnl and CATOBJEXT=.gmo in this case.
            AC_CHECK_FUNC(bind_textdomain_codeset,
	      [CATOBJEXT=.gmo 
               DATADIRNAME=share],
	      [CATOBJEXT=.mo
               DATADIRNAME=lib])
	    ;;
	    *-*-openbsd*)
	    CATOBJEXT=.mo
            DATADIRNAME=share
	    ;;
	    *)
	    CATOBJEXT=.mo
            DATADIRNAME=lib
	    ;;
	    esac])
```

Musl doesn’t have `_nl_msg_cat_cntr`, the test fails, and so `CATOBJEXT` is set to `.mo`.

Then in line 451:
```
if test "x$CATOBJEXT" = "x.mo" ; then
  localedir=`eval echo "${libdir}/locale"`
else
  localedir=`eval echo "${datadir}/locale"`
fi
```

So the translations are put into `libdir`.
Even adding `--localedir=/usr/share/locale` to `configure_args` didn’t change this.

The easiest way to solve this might be to patch `glib-gettext.m4` and just change `${libdir}/locale` to `${datadir}/locale`.
However, no idea if there might me side effects. ;)

Re: Localization files in /usr/lib/locale

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 1722 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-751640784

Comment:
I did have a look at geeqie and assume most of the listed packages above share the same issue.
It seems the problems lies in `/usr/share/aclocal/glib-gettext.m4`, line 275:
```
	  AC_TRY_LINK(, [extern int _nl_msg_cat_cntr;
			 return _nl_msg_cat_cntr],
	    [CATOBJEXT=.gmo 
             DATADIRNAME=share],
	    [case $host in
	    *-*-solaris*)
	    dnl On Solaris, if bind_textdomain_codeset is in libc,
	    dnl GNU format message catalog is always supported,
            dnl since both are added to the libc all together.
	    dnl Hence, we'd like to go with DATADIRNAME=share and
	    dnl and CATOBJEXT=.gmo in this case.
            AC_CHECK_FUNC(bind_textdomain_codeset,
	      [CATOBJEXT=.gmo 
               DATADIRNAME=share],
	      [CATOBJEXT=.mo
               DATADIRNAME=lib])
	    ;;
	    *-*-openbsd*)
	    CATOBJEXT=.mo
            DATADIRNAME=share
	    ;;
	    *)
	    CATOBJEXT=.mo
            DATADIRNAME=lib
	    ;;
	    esac])
```

Musl doesn’t have `_nl_msg_cat_cntr`, the test fails, and so `CATOBJEXT` is set to `.mo`.

Then in line 451:
```
if test "x$CATOBJEXT" = "x.mo" ; then
  localedir=`eval echo "${libdir}/locale"`
else
  localedir=`eval echo "${datadir}/locale"`
fi
```

So the translations are put into `libdir`.
Even adding `--localedir=/usr/share/locale` to `configure_args` didn’t change this.

The easiest way to solve this might be to patch `glib-gettext.m4` and just change `${libdir}/locale` to `${datadir}/locale` in line 452.
However, no idea if there might me side effects. ;)

Re: Localization files in /usr/lib/locale

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-751647131

Comment:
Patching `glib-gettext.m4` (alone) might not be that good an idea because it would require the package to regenerate the `configure` script which needs all the automake stuff added to `hostmakedepends` etc. It works for geeqie because it has to run an `autogen.sh` in `pre_configure()` and does it anyway.

Would a configure hook scanning for `localdir` in `configure` scripts be any good?

Re: Localization files in /usr/lib/locale

[sgn]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-751720491

Comment:
Maybe link to `libintl` unconditionally on musl?

Re: Localization files in /usr/lib/locale

[sgn]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-751720491

Comment:
Maybe link to `libintl` unconditionally on musl? (I don't like this idea, though)

Re: Localization files in /usr/lib/locale

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-751769292

Comment:
I'm very much against forcing `libintl` when it isn't necessary...

@newbluemoon I believe `--with-localedir` was reported to work...

Re: Localization files in /usr/lib/locale

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-751786779

Comment:
At least for geeqie `--with-localedir` doesn’t work either. If it would it could just be added to `common/environment/configure/gnu-configure-args.sh`...

Re: Localization files in /usr/lib/locale

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-751819962

Comment:
`--with-locale-dir`, actually. Sorry for the confusion.

Re: Localization files in /usr/lib/locale

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-751828722

Comment:
No, doesn’t work with geeqie; `AM_GLIB_DEFINE_LOCALEDIR` doesn’t check if `$localedir` is already set – it just overwrites it regardless. But that might not be the case with the other packages; they might have added some more checks. I’ll do some testing.

Re: Localization files in /usr/lib/locale

[q66]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-751878462

Comment:
`--with-locale-dir` is specific to xfce stuff

Re: Localization files in /usr/lib/locale

[sgn]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-752667753

Comment:
`--with-locale-dir` doesn't work for Thunar 4.16.1

Re: Localization files in /usr/lib/locale

[sgn]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-752667753

Comment:
`--with-locale-dir` doesn't work for Thunar 4.16.1.

---

It's `--with-locales-dir` with an `s` after `locale`

Re: Localization files in /usr/lib/locale

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-752669929

Comment:
I tried geeqie, dia, and leafpad. There `$localedir` is always hardcoded in the end. I have some fixes on a per package basis ready for those, but maybe a general approach is desired (maybe thats only feasible for the Xfce stuff)?

Re: Localization files in /usr/lib/locale

[q66]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-752677658

Comment:
the m4 files causing this should be fixed either way since they may be used for user built stuff and we don't want that in there either

and then for packages we need to fix it on per-package basis (I see no other way) and introduce a pkglint check to add /usr/lib/locale into forbidden directories (except for glibc-locales)

Re: Localization files in /usr/lib/locale

[sgn]

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-752679569

Comment:
For xfce4 stuff, it's defined by `XDT_I18N` from `xfce4-dev-tools`, it can be fixed by `--with-locales-dir=/usr/share/locale`.
For other stuffs, I don't think we can fix in general, except patching `/usr/share/aclocal/glib-gettext.m4` from `glib-devel` and run `autoreconf -fi` for all problematic packages.

Re: Localization files in /usr/lib/locale

[q66]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-752695820

Comment:
so we should ix `xfce4-dev-tools` as well as `glib-devel`, then for xfce4 packages apply `--with-locales-dir`, for the others we can probably patch the right pattern in their configure scripts, don't have to necessarily re-generate everything

Re: Localization files in /usr/lib/locale

[q66]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-752695820

Comment:
so we should fix `xfce4-dev-tools` as well as `glib-devel`, then for xfce4 packages apply `--with-locales-dir`, for the others we can probably patch the right pattern in their configure scripts, don't have to necessarily re-generate everything

Re: Localization files in /usr/lib/locale

[sgn]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-752804031

Comment:
Doing this and now I realized that we should just
```sh
vsed -i '/localedir =/s,=.*,= /usr/share/locale,' po/Makefile.in.in
```

Re: Localization files in /usr/lib/locale

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-752852821

Comment:
@sgn that only fixes install location, not where the programs will search for locale data.

If anything, my fix from #27511 might work better.

Re: Localization files in /usr/lib/locale

[sgn]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-752925689

Comment:
We need to run `autoreconf -fi` for:
```
-DPACKAGE_LOCALE_DIR=\"$(localedir)\"           \
```

Re: Localization files in /usr/lib/locale

[sgn]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-752925689

Comment:
We need to run `autoreconf -fi` for:
```
-DPACKAGE_LOCALE_DIR=\"$(localedir)\"           \
```

---
Actually, we need both. Run `autoreconf -fi` to have the macro defined correctly, and `sed` to correct installation directory.
I'll eject non-XFCE change for now.

Re: Localization files in /usr/lib/locale

[sgn]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-752936880

Comment:
I ended up patching more into `glib` https://github.com/void-linux/void-packages/pull/27558/commits/b5a894c02b2d3c5db86d8e5b4d804545bdd7c83c

Re: Localization files in /usr/lib/locale

[q66]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-752937245

Comment:
we just need to patch configure scripts...

Re: Localization files in /usr/lib/locale

[q66]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-752937245

Comment:
we just need to patch configure scripts... (instead of full autoreconf)

Re: Localization files in /usr/lib/locale

[Justinizer]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New comment by Justinizer on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-812832065

Comment:
Gimp patch by ericonr worked for me in #29970

Re: Localization files in /usr/lib/locale

[sgn]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-861573756

Comment:
I think everything has been done?

Re: Localization files in /usr/lib/locale

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-861586712

Comment:
It seems `gtk+` has no locale files at all? Why was it in that list? (or did we accidentally remove its locales?)

I guess the plan is to make `usr/locale` an error now?

Re: Localization files in /usr/lib/locale

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-861588361

Comment:
Or not, pcsx2 requires those files (we could add an override tho)

Re: Localization files in /usr/lib/locale

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/issues/27491#issuecomment-1114104830

Comment:
Issues become stale 90 days after last activity and are closed 14 days after that.  If this issue is still relevant bump it or assign it.

Re: [ISSUE] [CLOSED] Localization files in /usr/lib/locale

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 3218 bytes --]

Closed issue by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/27491

Description:
The correct `localedir` is `/usr/share/locale`, which is respected on all glibc packages. Unfortunately, on musl some packages perform their own detection of what `localedir` to use, due to some really weird mechanisms, and end up putting those files into `/usr/lib/locale`. Since locale data isn't arch specific, it should be stored in `/usr/share`. For multilib systems, this also makes it so locale data only has to be installed once, in `/usr/share`, by the native package.

@q66 scraped his repo for packages with files in `/usr/lib/locale`, which should be fixed, unless there are specific circumstances (`pcsx2` is one such example, since it can't be installed at all on 64-bit systems).

- [x] appdata-tools (removed in 1b2e92128ec7ba97e41bf7f41d91273253bea052)
- [x] ario
- [x] brasero
- [x] desmume #27782 
- [x] dia
- [x] exo
- [x] garcon
- [x] GConf
- [x] gconf-editor
- [x] gdmap
- [x] geeqie
- [x] gimp (can be fixed with 3.0 when it releases, since that supports meson)
- [x] gimp-lqr-plugin
- [x] gmpc
- [x] gnome-doc-utils
- [x] gnome-mime-data
- [x] gnome-mplayer
- [x] gnome-nettool
- [x] gnome-screensaver
- [x] gnome-system-log
- [x] gnumeric
- [x] goocanvas1 (will be removed in #27438 )
- [x] gpicview
- [ ] gtk+
- [x] gtk2-engines
- [x] gtkpod
- [x] gtksourceview2
- [x] gtkspell
- [x] gxmessage
- [x] homebank
- [x] leafpad
- [x] libcryptui
- [x] libglib-static (removed in 2c6bde11ad4fb27a752b8f9d73f928e28fe4934e)
- [x] libgnomecanvas
- [x] libgnome-keyring
- [x] libgpod
- [x] libwnck2
- [x] libxfce4ui
- [x] libxfce4util
- [x] lightdm-gtk-greeter
- [x] lxappearance-obconf
- [x] lxinput
- [x] lxlauncher
- [x] mousepad
- [x] orage
- [x] parcellite
- [x] parole
- [x] pcmanx-gtk2
- [x] pidgin-libnotify
- [x] pidgin-otr
- [x] pidgin-privacy-please
- [x] pmount
- [x] polkit-gnome
- [x] pragha
- [x] ristretto
- [x] seahorse-nautilus
- [x] seahorse-sharing
- [x] spacefm
- [x] Thunar
- [x] thunar-archive-plugin
- [x] thunar-media-tags-plugin
- [x] thunar-volman
- [x] tilp2
- [x] tumbler
- [x] udevil
- [x] ufraw
- [x] uget
- [x] viking
- [x] volumeicon
- [x] vte #27556 
- [x] vte290
- [x] xdg-user-dirs-gtk
- [x] xfburn
- [x] xfce4-appfinder
- [x] xfce4-battery-plugin
- [x] xfce4-clipman-plugin
- [x] xfce4-cpufreq-plugin
- [x] xfce4-cpugraph-plugin
- [x] xfce4-dict
- [x] xfce4-diskperf-plugin
- [x] xfce4-fsguard-plugin
- [x] xfce4-genmon-plugin
- [x] xfce4-mailwatch-plugin
- [x] xfce4-mpc-plugin
- [x] xfce4-netload-plugin
- [x] xfce4-notifyd
- [x] xfce4-panel
- [x] xfce4-places-plugin
- [x] xfce4-power-manager
- [x] xfce4-pulseaudio-plugin
- [x] xfce4-screenshooter
- [x] xfce4-sensors-plugin
- [x] xfce4-session
- [x] xfce4-settings
- [x] xfce4-systemload-plugin
- [x] xfce4-taskmanager
- [x] xfce4-terminal
- [x] xfce4-time-out-plugin
- [x] xfce4-timer-plugin
- [x] xfce4-verve-plugin
- [x] xfce4-wavelan-plugin
- [x] xfce4-weather-plugin
- [x] xfce4-xkb-plugin
- [x] xfconf
- [x] xfdesktop
- [x] xfwm4
- [x] xnoise
- [x] xournal
- [x] xsane