[ISSUE] lm_sensors service missing

[ISSUE] lm_sensors service missing

[Mek101]

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

New issue by Mek101 on void-packages repository

https://github.com/void-linux/void-packages/issues/27525

Description:
<!-- Don't request update of package. We have a script for that. https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt . However, a quality pull request may help. -->
### System

* xuname:  
  Void 5.9.16_1 x86_64-musl AuthenticAMD uptodate rFFFF
* package:  
  lm_sensors-3.6.0_1

### Expected behavior
At the end of the `sensors` setup via `sensors-detect`, the latter prints to enable the `lm_sensors` service to load the appropriate modules at boot time.

### Actual behavior
The output is:
```
Copy prog/init/lm_sensors.init to /etc/init.d/lm_sensors for initialization at boot time.
You should now start the lm_sensors service to load the required kernel modules.
```
Not only the paths are wrong, but there also no sensors service under `/etc/sv/` to start

### Steps to reproduce the behavior
Run the `sensors-detect` command.

Re: lm_sensors service missing

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/27525#issuecomment-753409324

Comment:
The systemd unit is

```
[Unit]
Description=Initialize hardware monitoring sensors

[Service]
EnvironmentFile=/etc/sysconfig/lm_sensors
Type=oneshot
RemainAfterExit=yes
ExecStart=-/sbin/modprobe -qab $BUS_MODULES $HWMON_MODULES
ExecStart=/usr/bin/sensors -s
ExecStop=-/sbin/modprobe -qabr $BUS_MODULES $HWMON_MODULES

[Install]
WantedBy=multi-user.target
```

Looks quite feasible to port to a run script, if you want to try it!

It also has `fancontrol.service` and `sensord.service`, but I think we don't build `sensord`.

Re: lm_sensors service missing

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/27525#issuecomment-753409509

Comment:
Argh, no :/

It's a oneshot... So it would be best to install the `lm_sensors.init` script and tell people to call it in `/etc/rc.local`, assuming that works. Afaik we don't any new oneshot services, since they require using `exec pause` at the end, which is quite the ugly workaround.

Re: lm_sensors service missing

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/27525#issuecomment-753409509

Comment:
Argh, no :/

It's a oneshot... So it would be best to install the `lm_sensors.init` script and tell people to call it in `/etc/rc.local`, assuming that works. Afaik we don't want any new oneshot services, since they require using `exec pause` at the end, which is quite the ugly workaround.

Re: lm_sensors should include a service

[Mek101]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by Mek101 on void-packages repository

https://github.com/void-linux/void-packages/issues/27525#issuecomment-783312244

Comment:
What if we put them in [`/etc/modules-load.d/`](https://man.voidlinux.org/modules-load.8)?

Re: lm_sensors should include a service

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/27525#issuecomment-783476970

Comment:
Can their utility write a file that works in `/etc/modules-load.d`?

Re: lm_sensors should include a service

[Mek101]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by Mek101 on void-packages repository

https://github.com/void-linux/void-packages/issues/27525#issuecomment-783512259

Comment:
We could either patch it or provide the file with the package

Re: lm_sensors should include a service

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/27525#issuecomment-783515495

Comment:
How about try to get it upstream? It should solve the issue for any distro, because a service is really not necessary here.

Re: lm_sensors should include a service

[Mek101]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by Mek101 on void-packages repository

https://github.com/void-linux/void-packages/issues/27525#issuecomment-783529136

Comment:
That would be ideal.
Upstream here: https://github.com/lm-sensors/lm-sensors