[PR PATCH] intellij-idea-community-edition: add .desktop.

[PR PATCH] intellij-idea-community-edition: add .desktop.

[AlexDltg]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

There is a new pull request by AlexDltg against master on the void-packages repository

https://github.com/AlexDltg/void-packages master
https://github.com/void-linux/void-packages/pull/27686

intellij-idea-community-edition: add .desktop.


A patch file from https://github.com/void-linux/void-packages/pull/27686.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-27686.patch --]
[-- Type: text/x-diff, Size: 1753 bytes --]

From e3b1d8b975988c3b4c9049b454810cb96c0fe237 Mon Sep 17 00:00:00 2001
From: AlexDltg <adelatorregarcia.cf@iesesteveterradas.cat>
Date: Tue, 5 Jan 2021 13:11:49 +0100
Subject: [PATCH] intellij-idea-community-edition: add .desktop.

---
 .../intellij-idea-community-edition/files/idea.desktop    | 8 ++++++++
 srcpkgs/intellij-idea-community-edition/template          | 3 ++-
 2 files changed, 10 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/intellij-idea-community-edition/files/idea.desktop

diff --git a/srcpkgs/intellij-idea-community-edition/files/idea.desktop b/srcpkgs/intellij-idea-community-edition/files/idea.desktop
new file mode 100644
index 00000000000..5d32e21b019
--- /dev/null
+++ b/srcpkgs/intellij-idea-community-edition/files/idea.desktop
@@ -0,0 +1,8 @@
+[Desktop Entry]
+Name=IntelliJ IDEA Community Edition
+Comment=Java integrated development environment by JetBrains
+Exec=/usr/bin/idea %f
+Icon=idea
+Terminal=false
+Type=Application
+Categories=Development;
\ No newline at end of file
diff --git a/srcpkgs/intellij-idea-community-edition/template b/srcpkgs/intellij-idea-community-edition/template
index 8b41709db36..cb424260fc9 100644
--- a/srcpkgs/intellij-idea-community-edition/template
+++ b/srcpkgs/intellij-idea-community-edition/template
@@ -1,7 +1,7 @@
 # Template file for 'intellij-idea-community-edition'
 pkgname=intellij-idea-community-edition
 version=2020.3.1
-revision=1
+revision=2
 archs="i686 x86_64"
 depends="virtual?java-environment giflib libXtst"
 short_desc="Java integrated development environment by JetBrains"
@@ -58,4 +58,5 @@ do_install() {
 	esac
 
 	ln -sf /usr/lib/intellij-idea/bin/idea.sh ${DESTDIR}/usr/bin/idea
+	vinstall ${FILESDIR}/idea.desktop 644 usr/share/applications
 }

Re: [PR PATCH] [Updated] intellij-idea-community-edition: add .desktop.

[AlexDltg]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

There is an updated pull request by AlexDltg against master on the void-packages repository

https://github.com/AlexDltg/void-packages master
https://github.com/void-linux/void-packages/pull/27686

intellij-idea-community-edition: add .desktop.


A patch file from https://github.com/void-linux/void-packages/pull/27686.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-27686.patch --]
[-- Type: text/x-diff, Size: 1925 bytes --]

From 3be333af9b03f46d71e224ff1ecdc59f7269e8de Mon Sep 17 00:00:00 2001
From: AlexDltg <adelatorregarcia.cf@iesesteveterradas.cat>
Date: Tue, 5 Jan 2021 13:11:49 +0100
Subject: [PATCH] intellij-idea-community-edition: add .desktop.

---
 .../intellij-idea-community-edition/files/idea.desktop    | 8 ++++++++
 srcpkgs/intellij-idea-community-edition/template          | 5 ++++-
 2 files changed, 12 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/intellij-idea-community-edition/files/idea.desktop

diff --git a/srcpkgs/intellij-idea-community-edition/files/idea.desktop b/srcpkgs/intellij-idea-community-edition/files/idea.desktop
new file mode 100644
index 00000000000..5d32e21b019
--- /dev/null
+++ b/srcpkgs/intellij-idea-community-edition/files/idea.desktop
@@ -0,0 +1,8 @@
+[Desktop Entry]
+Name=IntelliJ IDEA Community Edition
+Comment=Java integrated development environment by JetBrains
+Exec=/usr/bin/idea %f
+Icon=idea
+Terminal=false
+Type=Application
+Categories=Development;
\ No newline at end of file
diff --git a/srcpkgs/intellij-idea-community-edition/template b/srcpkgs/intellij-idea-community-edition/template
index 8b41709db36..023174f155c 100644
--- a/srcpkgs/intellij-idea-community-edition/template
+++ b/srcpkgs/intellij-idea-community-edition/template
@@ -1,7 +1,7 @@
 # Template file for 'intellij-idea-community-edition'
 pkgname=intellij-idea-community-edition
 version=2020.3.1
-revision=1
+revision=2
 archs="i686 x86_64"
 depends="virtual?java-environment giflib libXtst"
 short_desc="Java integrated development environment by JetBrains"
@@ -58,4 +58,7 @@ do_install() {
 	esac
 
 	ln -sf /usr/lib/intellij-idea/bin/idea.sh ${DESTDIR}/usr/bin/idea
+	ln -sf /usr/lib/intellij-idea/bin/idea.png ${DESTDIR}/usr/share/pixmaps/
+	ln -sf /usr/lib/intellij-idea/bin/idea.svg ${DESTDIR}/usr/share/icons/hicolor/scalable/apps/
+	vinstall ${FILESDIR}/idea.desktop 644 usr/share/applications
 }

Re: [PR PATCH] [Updated] intellij-idea-community-edition: add .desktop.

[AlexDltg]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

There is an updated pull request by AlexDltg against master on the void-packages repository

https://github.com/AlexDltg/void-packages master
https://github.com/void-linux/void-packages/pull/27686

intellij-idea-community-edition: add .desktop.


A patch file from https://github.com/void-linux/void-packages/pull/27686.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-27686.patch --]
[-- Type: text/x-diff, Size: 2284 bytes --]

From 5ff9416edbcc49f64ae7d399d13f653846f83974 Mon Sep 17 00:00:00 2001
From: AlexDltg <adelatorregarcia.cf@iesesteveterradas.cat>
Date: Tue, 5 Jan 2021 13:11:49 +0100
Subject: [PATCH] intellij-idea-community-edition: add .desktop.

---
 .../intellij-idea-community-edition/files/idea.desktop    | 8 ++++++++
 srcpkgs/intellij-idea-community-edition/template          | 7 ++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/intellij-idea-community-edition/files/idea.desktop

diff --git a/srcpkgs/intellij-idea-community-edition/files/idea.desktop b/srcpkgs/intellij-idea-community-edition/files/idea.desktop
new file mode 100644
index 00000000000..5d32e21b019
--- /dev/null
+++ b/srcpkgs/intellij-idea-community-edition/files/idea.desktop
@@ -0,0 +1,8 @@
+[Desktop Entry]
+Name=IntelliJ IDEA Community Edition
+Comment=Java integrated development environment by JetBrains
+Exec=/usr/bin/idea %f
+Icon=idea
+Terminal=false
+Type=Application
+Categories=Development;
\ No newline at end of file
diff --git a/srcpkgs/intellij-idea-community-edition/template b/srcpkgs/intellij-idea-community-edition/template
index 8b41709db36..28048e2fa6c 100644
--- a/srcpkgs/intellij-idea-community-edition/template
+++ b/srcpkgs/intellij-idea-community-edition/template
@@ -1,7 +1,7 @@
 # Template file for 'intellij-idea-community-edition'
 pkgname=intellij-idea-community-edition
 version=2020.3.1
-revision=1
+revision=2
 archs="i686 x86_64"
 depends="virtual?java-environment giflib libXtst"
 short_desc="Java integrated development environment by JetBrains"
@@ -23,6 +23,8 @@ do_install() {
 	vmkdir usr/bin
 	vmkdir usr/share/doc/intellij-idea
 	vmkdir usr/lib/intellij-idea
+	vmkdir usr/share/pixmaps
+	vmkdir usr/share/icons/hicolor/scalable/apps
 
 	mv bin lib plugins redist product-info.json build.txt  ${DESTDIR}/usr/lib/intellij-idea
 	mv LICENSE.txt NOTICE.txt license ${DESTDIR}/usr/share/doc/intellij-idea
@@ -58,4 +60,7 @@ do_install() {
 	esac
 
 	ln -sf /usr/lib/intellij-idea/bin/idea.sh ${DESTDIR}/usr/bin/idea
+	ln -sf /usr/lib/intellij-idea/bin/idea.png ${DESTDIR}/usr/share/pixmaps
+	ln -sf /usr/lib/intellij-idea/bin/idea.svg ${DESTDIR}/usr/share/icons/hicolor/scalable/apps
+	vinstall ${FILESDIR}/idea.desktop 644 usr/share/applications
 }

Re: intellij-idea-community-edition: add .desktop.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27686#issuecomment-754684396

Comment:
I really don't like vendoring in desktop files... They are upstream responsibility, not for each distribution to provide.

Re: intellij-idea-community-edition: add .desktop.

[AlexDltg]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

New comment by AlexDltg on void-packages repository

https://github.com/void-linux/void-packages/pull/27686#issuecomment-754696163

Comment:
> I really don't like vendoring in desktop files... They are upstream responsibility, not for each distribution to provide.
Sorry, I don't know if I have understood correctly
What do you mean to change the "comment" section or do you think it is wrong to provide .desktop files.

Re: intellij-idea-community-edition: add .desktop.

[AlexDltg]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

New comment by AlexDltg on void-packages repository

https://github.com/void-linux/void-packages/pull/27686#issuecomment-754696163

Comment:
> I really don't like vendoring in desktop files... They are upstream responsibility, not for each distribution to provide.
Sorry, I don't know if I have understood correctly

What do you mean to change the "comment" section or do you think it is wrong to provide .desktop files.

Re: intellij-idea-community-edition: add .desktop.

[AlexDltg]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

New comment by AlexDltg on void-packages repository

https://github.com/void-linux/void-packages/pull/27686#issuecomment-754696163

Comment:
> I really don't like vendoring in desktop files... They are upstream responsibility, not for each distribution to provide.

Sorry, I don't know if I have understood correctly
What do you mean to change the "comment" section or do you think it is wrong to provide .desktop files.

Re: intellij-idea-community-edition: add .desktop.

[AlexDltg]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

New comment by AlexDltg on void-packages repository

https://github.com/void-linux/void-packages/pull/27686#issuecomment-754696163

Comment:
> I really don't like vendoring in desktop files... They are upstream responsibility, not for each distribution to provide.

Sorry, I don't know if I have understood correctly
What do you mean, change the "comment" section or do you think it is wrong to provide .desktop files.

Re: intellij-idea-community-edition: add .desktop.

[AlexDltg]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

New comment by AlexDltg on void-packages repository

https://github.com/void-linux/void-packages/pull/27686#issuecomment-754696163

Comment:
> I really don't like vendoring in desktop files... They are upstream responsibility, not for each distribution to provide.

Sorry, I don't know if I have understood correctly
What do you mean, change the "comment" section or do you think it is wrong to provide .desktop files?

Re: intellij-idea-community-edition: add .desktop.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27686#issuecomment-754701163

Comment:
I think IDEA should provide a desktop file of their own that we simply install.

That said, given that this is a proprietary application, the chances of actually changing this on their side is kind of low, so I can understand the reasoning for accepting it.

I leave it for someone else to merge.

Re: intellij-idea-community-edition: add .desktop.

[AlexDltg]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

New comment by AlexDltg on void-packages repository

https://github.com/void-linux/void-packages/pull/27686#issuecomment-754696163

Comment:
> I really don't like vendoring in desktop files... They are upstream responsibility, not for each distribution to provide.

Sorry, I don't know if I have understood correctly
What do you mean? change something in the .desktop or that is wrong to provide .desktop files?

Re: [PR PATCH] [Updated] intellij-idea-community-edition: add .desktop.

[AlexDltg]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

There is an updated pull request by AlexDltg against master on the void-packages repository

https://github.com/AlexDltg/void-packages master
https://github.com/void-linux/void-packages/pull/27686

intellij-idea-community-edition: add .desktop.


A patch file from https://github.com/void-linux/void-packages/pull/27686.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-27686.patch --]
[-- Type: text/x-diff, Size: 2417 bytes --]

From 7a28cda6221930585b318f2fee2cd143ccad9ad4 Mon Sep 17 00:00:00 2001
From: AlexDltg <adelatorregarcia.cf@iesesteveterradas.cat>
Date: Tue, 5 Jan 2021 13:11:49 +0100
Subject: [PATCH] intellij-idea-community-edition: add .desktop.

---
 .../intellij-idea-community-edition/files/idea.desktop   | 8 ++++++++
 srcpkgs/intellij-idea-community-edition/template         | 9 +++++++--
 2 files changed, 15 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/intellij-idea-community-edition/files/idea.desktop

diff --git a/srcpkgs/intellij-idea-community-edition/files/idea.desktop b/srcpkgs/intellij-idea-community-edition/files/idea.desktop
new file mode 100644
index 00000000000..5d32e21b019
--- /dev/null
+++ b/srcpkgs/intellij-idea-community-edition/files/idea.desktop
@@ -0,0 +1,8 @@
+[Desktop Entry]
+Name=IntelliJ IDEA Community Edition
+Comment=Java integrated development environment by JetBrains
+Exec=/usr/bin/idea %f
+Icon=idea
+Terminal=false
+Type=Application
+Categories=Development;
\ No newline at end of file
diff --git a/srcpkgs/intellij-idea-community-edition/template b/srcpkgs/intellij-idea-community-edition/template
index 8b41709db36..418d4518235 100644
--- a/srcpkgs/intellij-idea-community-edition/template
+++ b/srcpkgs/intellij-idea-community-edition/template
@@ -1,9 +1,9 @@
 # Template file for 'intellij-idea-community-edition'
 pkgname=intellij-idea-community-edition
 version=2020.3.1
-revision=1
+revision=2
 archs="i686 x86_64"
-depends="virtual?java-environment giflib libXtst"
+depends="virtual?java-environment giflib libXtst hicolor-icon-theme"
 short_desc="Java integrated development environment by JetBrains"
 maintainer="John <me@johnnynator.dev>"
 license="Apache-2.0"
@@ -23,6 +23,8 @@ do_install() {
 	vmkdir usr/bin
 	vmkdir usr/share/doc/intellij-idea
 	vmkdir usr/lib/intellij-idea
+	vmkdir usr/share/pixmaps
+	vmkdir usr/share/icons/hicolor/scalable/apps
 
 	mv bin lib plugins redist product-info.json build.txt  ${DESTDIR}/usr/lib/intellij-idea
 	mv LICENSE.txt NOTICE.txt license ${DESTDIR}/usr/share/doc/intellij-idea
@@ -58,4 +60,7 @@ do_install() {
 	esac
 
 	ln -sf /usr/lib/intellij-idea/bin/idea.sh ${DESTDIR}/usr/bin/idea
+	ln -sf /usr/lib/intellij-idea/bin/idea.png ${DESTDIR}/usr/share/pixmaps
+	ln -sf /usr/lib/intellij-idea/bin/idea.svg ${DESTDIR}/usr/share/icons/hicolor/scalable/apps
+	vinstall ${FILESDIR}/idea.desktop 644 usr/share/applications
 }

Re: intellij-idea-community-edition: add .desktop.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27686#issuecomment-778925381

Comment:
@Johnnynator 

Re: [PR PATCH] [Merged]: intellij-idea-community-edition: add .desktop.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

There's a merged pull request on the void-packages repository

intellij-idea-community-edition: add .desktop.
https://github.com/void-linux/void-packages/pull/27686

Description: