[ISSUE] go packages may have mismatched package names

[ISSUE] go packages may have mismatched package names

[vixus0]

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

New issue by vixus0 on void-packages repository

https://github.com/void-linux/void-packages/issues/27690

Description:
### Problem

When using the `build_style=go`, package templates may be using a `go_import_path=` that does not match the name of the go package. This could be because the package name changed in the upstream source. The result is a seemingly correct package that was actually built from very old sources thanks to the way go works. I suspect this is mainly likely to happen with go sources that make use of go modules but as that becomes more standard it might become more likely.

For an example, see #27688.

### Mitigations

- Linting: when `go.mod` is present, check that `go_import_path=` is set to the name defined there.
- `build-style/go.sh`: (better, imo) set the value of `go_import_path=` to the module name defined in `go.mod`.

Re: go packages may have mismatched package names

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/27690#issuecomment-781584289

Comment:
Once more #28847

I believe this can be detected when `git` is added to `hostmakedepends`, since it's what Go uses to download the old version of the module. Will try to go through templates for this.

Re: go packages may have mismatched package names

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/issues/27690#issuecomment-1114433123

Comment:
Issues become stale 90 days after last activity and are closed 14 days after that.  If this issue is still relevant bump it or assign it.

Re: go packages may have mismatched package names

[vixus0]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New comment by vixus0 on void-packages repository

https://github.com/void-linux/void-packages/issues/27690#issuecomment-1116061700

Comment:
Bumping while we wait for #28895.

Re: [ISSUE] [CLOSED] go packages may have mismatched package names

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

Closed issue by vixus0 on void-packages repository

https://github.com/void-linux/void-packages/issues/27690

Description:
### Problem

When using the `build_style=go`, package templates may be using a `go_import_path=` that does not match the name of the go package. This could be because the package name changed in the upstream source. The result is a seemingly correct package that was actually built from very old sources thanks to the way go works. I suspect this is mainly likely to happen with go sources that make use of go modules but as that becomes more standard it might become more likely.

For an example, see #27688.

### Mitigations

- Linting: when `go.mod` is present, check that `go_import_path=` is set to the name defined there.
- `build-style/go.sh`: (better, imo) set the value of `go_import_path=` to the module name defined in `go.mod`.