Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] qjackctl: Add build option for jack-session support
@ 2021-01-11 15:17 Clyybber
  2021-01-11 18:48 ` [PR REVIEW] " newbluemoon
                   ` (18 more replies)
  0 siblings, 19 replies; 20+ messages in thread
From: Clyybber @ 2021-01-11 15:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

There is a new pull request by Clyybber against master on the void-packages repository

https://github.com/Clyybber/void-packages qjackctlsessionoption
https://github.com/void-linux/void-packages/pull/27828

qjackctl: Add build option for jack-session support


A patch file from https://github.com/void-linux/void-packages/pull/27828.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qjackctlsessionoption-27828.patch --]
[-- Type: text/x-diff, Size: 1374 bytes --]

From e63aaf37ccb9527cb5bb6fb5714f6bcfeca5aaf8 Mon Sep 17 00:00:00 2001
From: Clyybber <darkmine956@gmail.com>
Date: Mon, 11 Jan 2021 16:15:59 +0100
Subject: [PATCH] qjackctl: Add build option for jack-session support

---
 srcpkgs/qjackctl/template | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/qjackctl/template b/srcpkgs/qjackctl/template
index 83743edd237..cce1a52f0be 100644
--- a/srcpkgs/qjackctl/template
+++ b/srcpkgs/qjackctl/template
@@ -1,7 +1,7 @@
 # Template file for 'qjackctl'
 pkgname=qjackctl
 version=0.9.0
-revision=1
+revision=2
 build_style=gnu-configure
 build_helper=qmake
 hostmakedepends="pkg-config"
@@ -14,6 +14,16 @@ homepage="http://qjackctl.sourceforge.net"
 distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.gz"
 checksum=5196c5c01b7948c1a8ca37cd3198a7f0fe095a99a34a67086abd3466855b4abd
 
+build_options="jack_session"
+build_options_default="jack_session"
+desc_option_jack_session="Enable support for the deprecated Jack Session API (which pipewire does not implement)"
+
+if [ "$build_option_jack_session" ]; then
+	configure_args+=" --enable-jack-session"
+else
+	configure_args+=" --disable-jack-session"
+fi
+
 if [ "${CROSS_BUILD}" ]; then
 	hostmakedepends+=" qt5-host-tools qt5-devel qt5-x11extras-devel"
 	configure_args+=" ac_cv_path_ac_cv_qmake=${XBPS_WRAPPERDIR}/qmake"

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
@ 2021-01-11 18:48 ` newbluemoon
  2021-01-11 18:48 ` newbluemoon
                   ` (17 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: newbluemoon @ 2021-01-11 18:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

New review comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/27828#discussion_r555264355

Comment:
Instead of the if-else-block you should use `configure_args=(vopt_enable jack-session)`.
See [https://github.com/void-linux/void-packages/blob/master/Manual.md#build-options](https://github.com/void-linux/void-packages/blob/master/Manual.md#build-options).

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
  2021-01-11 18:48 ` [PR REVIEW] " newbluemoon
@ 2021-01-11 18:48 ` newbluemoon
  2021-01-11 18:48 ` newbluemoon
                   ` (16 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: newbluemoon @ 2021-01-11 18:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

New review comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/27828#discussion_r555264355

Comment:
Instead of the if-else-block you should use `configure_args=$(vopt_enable jack-session)`.
See [https://github.com/void-linux/void-packages/blob/master/Manual.md#build-options](https://github.com/void-linux/void-packages/blob/master/Manual.md#build-options).

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
  2021-01-11 18:48 ` [PR REVIEW] " newbluemoon
  2021-01-11 18:48 ` newbluemoon
@ 2021-01-11 18:48 ` newbluemoon
  2021-01-11 19:06 ` [PR PATCH] [Updated] " Clyybber
                   ` (15 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: newbluemoon @ 2021-01-11 18:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

New review comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/27828#discussion_r555264355

Comment:
Instead of the if-else-block you should use `configure_args="$(vopt_enable jack-session)"`.
See [https://github.com/void-linux/void-packages/blob/master/Manual.md#build-options](https://github.com/void-linux/void-packages/blob/master/Manual.md#build-options).

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
                   ` (2 preceding siblings ...)
  2021-01-11 18:48 ` newbluemoon
@ 2021-01-11 19:06 ` Clyybber
  2021-01-11 19:06 ` [PR REVIEW] " Clyybber
                   ` (14 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: Clyybber @ 2021-01-11 19:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

There is an updated pull request by Clyybber against master on the void-packages repository

https://github.com/Clyybber/void-packages qjackctlsessionoption
https://github.com/void-linux/void-packages/pull/27828

qjackctl: Add build option for jack-session support


A patch file from https://github.com/void-linux/void-packages/pull/27828.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qjackctlsessionoption-27828.patch --]
[-- Type: text/x-diff, Size: 1274 bytes --]

From e79a68d11bc54cec7cc6e8d54a31e270c838b483 Mon Sep 17 00:00:00 2001
From: Clyybber <darkmine956@gmail.com>
Date: Mon, 11 Jan 2021 16:15:59 +0100
Subject: [PATCH] qjackctl: Add build option for jack-session support

---
 srcpkgs/qjackctl/template | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/qjackctl/template b/srcpkgs/qjackctl/template
index 83743edd237..a7b19841687 100644
--- a/srcpkgs/qjackctl/template
+++ b/srcpkgs/qjackctl/template
@@ -1,7 +1,7 @@
 # Template file for 'qjackctl'
 pkgname=qjackctl
 version=0.9.0
-revision=1
+revision=2
 build_style=gnu-configure
 build_helper=qmake
 hostmakedepends="pkg-config"
@@ -14,6 +14,12 @@ homepage="http://qjackctl.sourceforge.net"
 distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.gz"
 checksum=5196c5c01b7948c1a8ca37cd3198a7f0fe095a99a34a67086abd3466855b4abd
 
+build_options="jack_session"
+build_options_default="jack_session"
+desc_option_jack_session="Enable support for the deprecated Jack Session API (which pipewire does not implement)"
+
+configure_args="$(vopt_enable jack_session)"
+
 if [ "${CROSS_BUILD}" ]; then
 	hostmakedepends+=" qt5-host-tools qt5-devel qt5-x11extras-devel"
 	configure_args+=" ac_cv_path_ac_cv_qmake=${XBPS_WRAPPERDIR}/qmake"

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
                   ` (3 preceding siblings ...)
  2021-01-11 19:06 ` [PR PATCH] [Updated] " Clyybber
@ 2021-01-11 19:06 ` Clyybber
  2021-01-11 19:13 ` [PR PATCH] [Updated] " Clyybber
                   ` (13 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: Clyybber @ 2021-01-11 19:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New review comment by Clyybber on void-packages repository

https://github.com/void-linux/void-packages/pull/27828#discussion_r555274874

Comment:
Thanks!

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
                   ` (4 preceding siblings ...)
  2021-01-11 19:06 ` [PR REVIEW] " Clyybber
@ 2021-01-11 19:13 ` Clyybber
  2021-01-11 19:16 ` [PR REVIEW] " ericonr
                   ` (12 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: Clyybber @ 2021-01-11 19:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

There is an updated pull request by Clyybber against master on the void-packages repository

https://github.com/Clyybber/void-packages qjackctlsessionoption
https://github.com/void-linux/void-packages/pull/27828

qjackctl: Add build option for jack-session support


A patch file from https://github.com/void-linux/void-packages/pull/27828.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qjackctlsessionoption-27828.patch --]
[-- Type: text/x-diff, Size: 1238 bytes --]

From 1acef374ccd0051765f8c23e5f43837d394fbb23 Mon Sep 17 00:00:00 2001
From: Clyybber <darkmine956@gmail.com>
Date: Mon, 11 Jan 2021 16:15:59 +0100
Subject: [PATCH] qjackctl: Add build option for jack-session support

---
 srcpkgs/qjackctl/template | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/qjackctl/template b/srcpkgs/qjackctl/template
index 83743edd237..cd041f2429b 100644
--- a/srcpkgs/qjackctl/template
+++ b/srcpkgs/qjackctl/template
@@ -1,7 +1,7 @@
 # Template file for 'qjackctl'
 pkgname=qjackctl
 version=0.9.0
-revision=1
+revision=2
 build_style=gnu-configure
 build_helper=qmake
 hostmakedepends="pkg-config"
@@ -14,6 +14,12 @@ homepage="http://qjackctl.sourceforge.net"
 distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.gz"
 checksum=5196c5c01b7948c1a8ca37cd3198a7f0fe095a99a34a67086abd3466855b4abd
 
+build_options="jack_session"
+build_options_default="jack_session"
+desc_option_jack_session="Enable support for the deprecated Jack Session API"
+
+configure_args="$(vopt_enable jack_session)"
+
 if [ "${CROSS_BUILD}" ]; then
 	hostmakedepends+=" qt5-host-tools qt5-devel qt5-x11extras-devel"
 	configure_args+=" ac_cv_path_ac_cv_qmake=${XBPS_WRAPPERDIR}/qmake"

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
                   ` (5 preceding siblings ...)
  2021-01-11 19:13 ` [PR PATCH] [Updated] " Clyybber
@ 2021-01-11 19:16 ` ericonr
  2021-01-11 19:19 ` pullmoll
                   ` (11 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-01-11 19:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27828#discussion_r555279973

Comment:
`configure_args` go between these two

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
                   ` (6 preceding siblings ...)
  2021-01-11 19:16 ` [PR REVIEW] " ericonr
@ 2021-01-11 19:19 ` pullmoll
  2021-01-11 19:19 ` [PR PATCH] [Updated] " Clyybber
                   ` (10 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: pullmoll @ 2021-01-11 19:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/27828#discussion_r555281393

Comment:
I think you need to use a dash instead of an underscore for the build option.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
                   ` (7 preceding siblings ...)
  2021-01-11 19:19 ` pullmoll
@ 2021-01-11 19:19 ` Clyybber
  2021-01-11 19:19 ` [PR REVIEW] " Clyybber
                   ` (9 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: Clyybber @ 2021-01-11 19:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

There is an updated pull request by Clyybber against master on the void-packages repository

https://github.com/Clyybber/void-packages qjackctlsessionoption
https://github.com/void-linux/void-packages/pull/27828

qjackctl: Add build option for jack-session support


A patch file from https://github.com/void-linux/void-packages/pull/27828.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qjackctlsessionoption-27828.patch --]
[-- Type: text/x-diff, Size: 1361 bytes --]

From 7a3006b8e0b2d584ade65507287c89e7d5735caa Mon Sep 17 00:00:00 2001
From: Clyybber <darkmine956@gmail.com>
Date: Mon, 11 Jan 2021 16:15:59 +0100
Subject: [PATCH] qjackctl: Add build option for jack-session support

---
 srcpkgs/qjackctl/template | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/qjackctl/template b/srcpkgs/qjackctl/template
index 83743edd237..62ba381a799 100644
--- a/srcpkgs/qjackctl/template
+++ b/srcpkgs/qjackctl/template
@@ -1,9 +1,10 @@
 # Template file for 'qjackctl'
 pkgname=qjackctl
 version=0.9.0
-revision=1
+revision=2
 build_style=gnu-configure
 build_helper=qmake
+configure_args="$(vopt_enable jack_session)"
 hostmakedepends="pkg-config"
 makedepends="alsa-lib-devel qt5-devel jack-devel qt5-x11extras-devel"
 depends="desktop-file-utils hicolor-icon-theme jack"
@@ -14,6 +15,10 @@ homepage="http://qjackctl.sourceforge.net"
 distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.gz"
 checksum=5196c5c01b7948c1a8ca37cd3198a7f0fe095a99a34a67086abd3466855b4abd
 
+build_options="jack_session"
+build_options_default="jack_session"
+desc_option_jack_session="Enable support for the deprecated Jack Session API"
+
 if [ "${CROSS_BUILD}" ]; then
 	hostmakedepends+=" qt5-host-tools qt5-devel qt5-x11extras-devel"
 	configure_args+=" ac_cv_path_ac_cv_qmake=${XBPS_WRAPPERDIR}/qmake"

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
                   ` (8 preceding siblings ...)
  2021-01-11 19:19 ` [PR PATCH] [Updated] " Clyybber
@ 2021-01-11 19:19 ` Clyybber
  2021-01-11 19:19 ` pullmoll
                   ` (8 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: Clyybber @ 2021-01-11 19:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New review comment by Clyybber on void-packages repository

https://github.com/void-linux/void-packages/pull/27828#discussion_r555281547

Comment:
Thanks, done.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
                   ` (9 preceding siblings ...)
  2021-01-11 19:19 ` [PR REVIEW] " Clyybber
@ 2021-01-11 19:19 ` pullmoll
  2021-01-11 19:22 ` Clyybber
                   ` (7 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: pullmoll @ 2021-01-11 19:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/27828#discussion_r555281393

Comment:
I think you need to use a dash instead of an underscore for the build option, i.e. `$(vopt_enable jack-session)`

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
                   ` (10 preceding siblings ...)
  2021-01-11 19:19 ` pullmoll
@ 2021-01-11 19:22 ` Clyybber
  2021-01-11 19:22 ` Clyybber
                   ` (6 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: Clyybber @ 2021-01-11 19:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

New review comment by Clyybber on void-packages repository

https://github.com/void-linux/void-packages/pull/27828#discussion_r555282956

Comment:
Using a dash doesn't work since `build_option_jack-session` is an invalid variable name.
This is why I initially used an if statement checking the option, but I tested and verified that using `jack_session` works properly.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
                   ` (11 preceding siblings ...)
  2021-01-11 19:22 ` Clyybber
@ 2021-01-11 19:22 ` Clyybber
  2021-01-11 19:22 ` Clyybber
                   ` (5 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: Clyybber @ 2021-01-11 19:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

New review comment by Clyybber on void-packages repository

https://github.com/void-linux/void-packages/pull/27828#discussion_r555282956

Comment:
Using a dash doesn't work since `build_option_jack-session` is an invalid variable name.
This is why I initially used an if statement checking the option (because I think it wouldn't work using an underscore), but I tested and verified that using `jack_session` works properly.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
                   ` (12 preceding siblings ...)
  2021-01-11 19:22 ` Clyybber
@ 2021-01-11 19:22 ` Clyybber
  2021-01-11 19:25 ` Clyybber
                   ` (4 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: Clyybber @ 2021-01-11 19:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

New review comment by Clyybber on void-packages repository

https://github.com/void-linux/void-packages/pull/27828#discussion_r555282956

Comment:
Using a dash doesn't work since `build_option_jack-session` is an invalid variable name.
This is why I initially used an if statement checking the option (because I thought it wouldn't work using an underscore), but I tested and verified that using `jack_session` works properly.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
                   ` (13 preceding siblings ...)
  2021-01-11 19:22 ` Clyybber
@ 2021-01-11 19:25 ` Clyybber
  2021-01-11 19:34 ` [PR PATCH] [Updated] " Clyybber
                   ` (3 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: Clyybber @ 2021-01-11 19:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

New review comment by Clyybber on void-packages repository

https://github.com/void-linux/void-packages/pull/27828#discussion_r555282956

Comment:
Using a dash doesn't work since `build_option_jack-session` is an invalid variable name.
This is why I initially used an if statement checking the option (because I thought it wouldn't work using an underscore).

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
                   ` (14 preceding siblings ...)
  2021-01-11 19:25 ` Clyybber
@ 2021-01-11 19:34 ` Clyybber
  2021-01-11 19:35 ` [PR REVIEW] " Clyybber
                   ` (2 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: Clyybber @ 2021-01-11 19:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

There is an updated pull request by Clyybber against master on the void-packages repository

https://github.com/Clyybber/void-packages qjackctlsessionoption
https://github.com/void-linux/void-packages/pull/27828

qjackctl: Add build option for jack-session support


A patch file from https://github.com/void-linux/void-packages/pull/27828.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qjackctlsessionoption-27828.patch --]
[-- Type: text/x-diff, Size: 1374 bytes --]

From 37ceb2078c214c2a67ef7a314789b6d8d032dbb0 Mon Sep 17 00:00:00 2001
From: Clyybber <darkmine956@gmail.com>
Date: Mon, 11 Jan 2021 16:15:59 +0100
Subject: [PATCH] qjackctl: Add build option for jack-session support

---
 srcpkgs/qjackctl/template | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/qjackctl/template b/srcpkgs/qjackctl/template
index 83743edd237..adc7190ce31 100644
--- a/srcpkgs/qjackctl/template
+++ b/srcpkgs/qjackctl/template
@@ -1,9 +1,10 @@
 # Template file for 'qjackctl'
 pkgname=qjackctl
 version=0.9.0
-revision=1
+revision=2
 build_style=gnu-configure
 build_helper=qmake
+configure_args="$(vopt_enable jack_session jack-session)"
 hostmakedepends="pkg-config"
 makedepends="alsa-lib-devel qt5-devel jack-devel qt5-x11extras-devel"
 depends="desktop-file-utils hicolor-icon-theme jack"
@@ -14,6 +15,10 @@ homepage="http://qjackctl.sourceforge.net"
 distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.gz"
 checksum=5196c5c01b7948c1a8ca37cd3198a7f0fe095a99a34a67086abd3466855b4abd
 
+build_options="jack_session"
+build_options_default="jack_session"
+desc_option_jack_session="Enable support for the deprecated Jack Session API"
+
 if [ "${CROSS_BUILD}" ]; then
 	hostmakedepends+=" qt5-host-tools qt5-devel qt5-x11extras-devel"
 	configure_args+=" ac_cv_path_ac_cv_qmake=${XBPS_WRAPPERDIR}/qmake"

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
                   ` (15 preceding siblings ...)
  2021-01-11 19:34 ` [PR PATCH] [Updated] " Clyybber
@ 2021-01-11 19:35 ` Clyybber
  2021-01-12  3:08 ` [PR PATCH] [Closed]: " ericonr
  2021-01-12  3:09 ` ericonr
  18 siblings, 0 replies; 20+ messages in thread
From: Clyybber @ 2021-01-11 19:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New review comment by Clyybber on void-packages repository

https://github.com/void-linux/void-packages/pull/27828#discussion_r555290279

Comment:
Changed to `$(vopt_enable jack_session jack-session)`, thanks!

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Closed]: qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
                   ` (16 preceding siblings ...)
  2021-01-11 19:35 ` [PR REVIEW] " Clyybber
@ 2021-01-12  3:08 ` ericonr
  2021-01-12  3:09 ` ericonr
  18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-01-12  3:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

There's a closed pull request on the void-packages repository

qjackctl: Add build option for jack-session support
https://github.com/void-linux/void-packages/pull/27828

Description:


^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: qjackctl: Add build option for jack-session support
  2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
                   ` (17 preceding siblings ...)
  2021-01-12  3:08 ` [PR PATCH] [Closed]: " ericonr
@ 2021-01-12  3:09 ` ericonr
  18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-01-12  3:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27828#issuecomment-758365033

Comment:
Just as a tip, if someone has to ask why the change is necessary, it's likely important to include it in the commit message as well :) 

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2021-01-12  3:09 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 15:17 [PR PATCH] qjackctl: Add build option for jack-session support Clyybber
2021-01-11 18:48 ` [PR REVIEW] " newbluemoon
2021-01-11 18:48 ` newbluemoon
2021-01-11 18:48 ` newbluemoon
2021-01-11 19:06 ` [PR PATCH] [Updated] " Clyybber
2021-01-11 19:06 ` [PR REVIEW] " Clyybber
2021-01-11 19:13 ` [PR PATCH] [Updated] " Clyybber
2021-01-11 19:16 ` [PR REVIEW] " ericonr
2021-01-11 19:19 ` pullmoll
2021-01-11 19:19 ` [PR PATCH] [Updated] " Clyybber
2021-01-11 19:19 ` [PR REVIEW] " Clyybber
2021-01-11 19:19 ` pullmoll
2021-01-11 19:22 ` Clyybber
2021-01-11 19:22 ` Clyybber
2021-01-11 19:22 ` Clyybber
2021-01-11 19:25 ` Clyybber
2021-01-11 19:34 ` [PR PATCH] [Updated] " Clyybber
2021-01-11 19:35 ` [PR REVIEW] " Clyybber
2021-01-12  3:08 ` [PR PATCH] [Closed]: " ericonr
2021-01-12  3:09 ` ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).