[PR PATCH] volctl: fix dependencies

[PR PATCH] volctl: fix dependencies

[endigma-4426]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

There is a new pull request by endigma-4426 against master on the void-packages repository

https://github.com/endigma-4426/void-packages patch-4
https://github.com/void-linux/void-packages/pull/27872

volctl: fix dependencies
volctl package requires pulseaudio currently, also totally functional with new audio server pipewire's built in pulse server, so the dependency on pulseaudio should be removed.

A patch file from https://github.com/void-linux/void-packages/pull/27872.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-4-27872.patch --]
[-- Type: text/x-diff, Size: 1107 bytes --]

From 8b20324e5f8dd0b2734dd725a287a3dbaebb7834 Mon Sep 17 00:00:00 2001
From: endigma <34945114+endigma-4426@users.noreply.github.com>
Date: Tue, 12 Jan 2021 18:53:55 -0400
Subject: [PATCH] volctl: fix dependencies

volctl package requires pulseaudio currently, also totally functional with new audio server pipewire's built in pulse server, so the dependency on pulseaudio should be removed.
---
 srcpkgs/volctl/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/volctl/template b/srcpkgs/volctl/template
index 305e7e9ba1f..0b4dc7d4409 100644
--- a/srcpkgs/volctl/template
+++ b/srcpkgs/volctl/template
@@ -4,8 +4,8 @@ version=0.8.0
 revision=2
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-gobject pulseaudio desktop-file-utils"
-short_desc="Lightweight volume control that sits in your systray"
+depends="python3-gobject desktop-file-utils"
+short_desc="Lightweight volume control for pulseaudio that sits in your systray"
 maintainer="teldra <teldra@rotce.de>"
 license="GPL-2.0-only"
 homepage="https://buzz.github.io/volctl/"

Re: volctl: fix dependencies

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27872#issuecomment-759153790

Comment:
Can you try to fix the tests? Might be a matter of adding `python3-yaml` to `depends` (also anything missing from `install_requires` line in https://github.com/buzz/volctl/blob/master/setup.py) + adding `checkdepends="$depends"`

Re: volctl: fix dependencies

[endigma-4426]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

New comment by endigma-4426 on void-packages repository

https://github.com/void-linux/void-packages/pull/27872#issuecomment-759193941

Comment:
I'll look into fixing these tomorrow, currently installing with pulseaudio on an xbps ignore list works.

Re: volctl: fix dependencies

[teldra]

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

New comment by teldra on void-packages repository

https://github.com/void-linux/void-packages/pull/27872#issuecomment-761795633

Comment:
RIght now, I have this https://github.com/teldra/void-packages/pull/new/update-volctl

Test stops with
```
Unable to init server: Could not connect: Connection refused
Unable to init server: Could not connect: Connection refused
error: libpulse.so.0: cannot open shared object file: No such file or directory
```

So which libpulse.so.0 should be put into checkdepends?
And I wonder, if gtk+3 is really needed in depends. In checkdepends, it is needed.

Re: volctl: fix dependencies

[endigma-4426]

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]

New comment by endigma-4426 on void-packages repository

https://github.com/void-linux/void-packages/pull/27872#issuecomment-762233457

Comment:
> RIght now, I have this https://github.com/teldra/void-packages/pull/new/update-volctl
> 
> Test stops with
> 
> ```
> Unable to init server: Could not connect: Connection refused
> Unable to init server: Could not connect: Connection refused
> error: libpulse.so.0: cannot open shared object file: No such file or directory
> ```
> 
> So which libpulse.so.0 should be put into checkdepends?
> And I wonder, if gtk+3 is really needed in depends. In checkdepends, it is needed.

I suppose pipewire's pulse backend provides this, is there a way for an either-or dependency to be implemented?

Re: volctl: fix dependencies

[endigma-4426]

[-- Attachment #1: Type: text/plain, Size: 831 bytes --]

New comment by endigma-4426 on void-packages repository

https://github.com/void-linux/void-packages/pull/27872#issuecomment-762233457

Comment:
> RIght now, I have this https://github.com/teldra/void-packages/pull/new/update-volctl
> 
> Test stops with
> 
> ```
> Unable to init server: Could not connect: Connection refused
> Unable to init server: Could not connect: Connection refused
> error: libpulse.so.0: cannot open shared object file: No such file or directory
> ```
> 
> So which libpulse.so.0 should be put into checkdepends?
> And I wonder, if gtk+3 is really needed in depends. In checkdepends, it is needed.

I suppose pipewire's pulse backend provides this, is there a way for an either-or dependency to be implemented? I have volctl working as intended right now running under pipewire's pulse server

Re: volctl: fix dependencies

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27872#issuecomment-762261102

Comment:
Since the main usage is with pulseaudio, I'd also test with it. You might need to add `dbus` to `checkdepends` and run `dbus-run-session python setup.py test` in `do_check`.