From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] Add patch fixing caribou crash + remove caribou from gnome-shell / gnome-core
Date: Wed, 13 Jan 2021 16:02:22 +0100 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27892@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
There is a new pull request by ericonr against master on the void-packages repository
https://github.com/ericonr/void-packages caribou
https://github.com/void-linux/void-packages/pull/27892
Add patch fixing caribou crash + remove caribou from gnome-shell / gnome-core
A patch file from https://github.com/void-linux/void-packages/pull/27892.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-caribou-27892.patch --]
[-- Type: text/x-diff, Size: 5646 bytes --]
From bf27357e5dc98e59071073f48fe15a33e0417370 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 13 Jan 2021 11:45:12 -0300
Subject: [PATCH 1/3] caribou: add fix for crash observed in
cinammon-screensaver.
https://github.com/linuxmint/cinnamon-screensaver/issues/354
---
srcpkgs/caribou/patches/fix-crash.patch | 46 +++++++++++++++++++++++++
srcpkgs/caribou/template | 2 +-
2 files changed, 47 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/caribou/patches/fix-crash.patch
diff --git a/srcpkgs/caribou/patches/fix-crash.patch b/srcpkgs/caribou/patches/fix-crash.patch
new file mode 100644
index 00000000000..a6fa3d7cd37
--- /dev/null
+++ b/srcpkgs/caribou/patches/fix-crash.patch
@@ -0,0 +1,46 @@
+From d41c8e44b12222a290eaca16703406b113a630c6 Mon Sep 17 00:00:00 2001
+From: Michael Webster <miketwebster@gmail.com>
+Date: Tue, 12 Jan 2021 18:01:47 +0000
+Subject: [PATCH] xadapter.vala: Remove XkbKeyTypesMask and fields from
+ XKbChangeMap call.
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+This was originally a workaround for xFree86 4.3 - see:
+https://bugzilla.gnome.org/show_bug.cgi?id=673547
+
+As of https://gitlab.freedesktop.org/xorg/xserver/-/commit/87c64fc5b0 this
+causes a BadLength error when attempting to use shifted characters.
+
+Ref:
+https://www.x.org/releases/X11R7.7/doc/libX11/XKB/xkblib.html#Changing_Map_Components_in_the_Server
+---
+ libcaribou/xadapter.vala | 9 ++-------
+ 1 file changed, 2 insertions(+), 7 deletions(-)
+
+diff --git a/libcaribou/xadapter.vala b/libcaribou/xadapter.vala
+index 22858b7..1da5a78 100644
+--- a/libcaribou/xadapter.vala
++++ b/libcaribou/xadapter.vala
+@@ -195,15 +195,10 @@ namespace Caribou {
+
+ Xkb.MapChanges changes = Xkb.MapChanges ();
+
+- // We don't touch key types here but include the
+- // information in XkbSetMap request to the server, because
+- // some X servers need the information to check the sanity
+- // of the keysyms change.
+- changes.changed = (ushort) (Xkb.KeySymsMask | Xkb.KeyTypesMask);
++ changes.changed = (ushort) Xkb.KeySymsMask;
+ changes.first_key_sym = (char) this.reserved_keycode;
+ changes.num_key_syms = this.xkbdesc.map.key_sym_map[this.reserved_keycode].width;
+- changes.first_type = 0;
+- changes.num_types = this.xkbdesc.map.num_types;
++
+ Xkb.change_map (this.xdisplay, this.xkbdesc, changes);
+
+ this.xdisplay.flush ();
+--
+GitLab
+
diff --git a/srcpkgs/caribou/template b/srcpkgs/caribou/template
index 6ac08ee5e22..0fac4244c03 100644
--- a/srcpkgs/caribou/template
+++ b/srcpkgs/caribou/template
@@ -1,7 +1,7 @@
# Template file for 'caribou'
pkgname=caribou
version=0.4.21
-revision=4
+revision=5
build_style=gnu-configure
build_helper="gir"
configure_args="--disable-schemas-compile --disable-static --disable-gtk2-module
From 85131612d15f97dc4df4f1508a9b7c0f446d8a6e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 13 Jan 2021 11:56:11 -0300
Subject: [PATCH 2/3] gnome-shell: remove caribou dependency.
---
srcpkgs/gnome-shell/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/gnome-shell/template b/srcpkgs/gnome-shell/template
index 6753b6ac54e..65ac693a585 100644
--- a/srcpkgs/gnome-shell/template
+++ b/srcpkgs/gnome-shell/template
@@ -1,20 +1,20 @@
# Template file for 'gnome-shell'
pkgname=gnome-shell
version=3.38.1
-revision=1
+revision=2
build_style=meson
build_helper=gir
configure_args="-Dsystemd=false"
hostmakedepends="gobject-introspection gtk-doc libxslt pkg-config python3 sassc
asciidoc perl glib-devel mutter-devel gettext gjs-devel"
-makedepends="at-spi2-atk caribou-devel evolution-data-server-devel folks-devel
+makedepends="at-spi2-atk evolution-data-server-devel folks-devel
gcr-devel gjs-devel gnome-bluetooth-devel gnome-control-center-devel gnome-desktop-devel
gnome-menus-devel gsettings-desktop-schemas-devel gstreamer1-devel gtk+3-devel
ibus-devel json-glib-devel libcanberra-devel libcroco-devel libglib-devel
libsecret-devel libsoup-devel libX11-devel libxml2-devel mutter-devel
libnma-devel polkit-devel pulseaudio-devel
startup-notification-devel telepathy-logger-devel gnome-autoar-devel"
-depends="caribou elogind glxinfo gnome-control-center gsettings-desktop-schemas upower"
+depends="elogind glxinfo gnome-control-center gsettings-desktop-schemas upower"
short_desc="GNOME core user interface"
maintainer="Enno Boland <gottox@voidlinux.org>"
license="GPL-2.0-or-later"
From f16bf380721b47e5d4ffd467b756f280682470ba Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 13 Jan 2021 11:56:47 -0300
Subject: [PATCH 3/3] gnome-core: remove caribou dependency.
---
srcpkgs/gnome-core/template | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/srcpkgs/gnome-core/template b/srcpkgs/gnome-core/template
index 4aab60c6b74..075bd15cdd3 100644
--- a/srcpkgs/gnome-core/template
+++ b/srcpkgs/gnome-core/template
@@ -1,7 +1,7 @@
# Template file for 'gnome-core'
pkgname=gnome-core
version=3.38.0
-revision=2
+revision=3
build_style=meta
short_desc="GNOME meta-package for Void Linux - core components"
maintainer="q66 <daniel@octaforge.org>"
@@ -13,7 +13,6 @@ depends="
at-spi2-core>=2.38.0
at-spi2-atk>=2.38.0
cantarell-fonts>=0.201
- caribou>=0.4.21
dconf>=0.36.0
evolution-data-server>=3.38.0
folks>=0.14.0
next reply other threads:[~2021-01-13 15:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 15:02 ericonr [this message]
2021-01-13 15:51 ` ericonr
2021-01-13 20:57 ` [PR PATCH] [Updated] " ericonr
2021-01-14 4:21 ` ericonr
2021-01-17 18:55 ` ericonr
2021-01-27 1:23 ` [PR PATCH] [Closed]: " q66
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27892@inbox.vuxu.org \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).