[-- Attachment #1: Type: text/plain, Size: 315 bytes --] There is a new pull request by subsonik against master on the void-packages repository https://github.com/subsonik/void-packages newsboat https://github.com/void-linux/void-packages/pull/27902 newsboat: update to 2.22.1. A patch file from https://github.com/void-linux/void-packages/pull/27902.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-newsboat-27902.patch --] [-- Type: text/x-diff, Size: 1014 bytes --] From 61a9e33e0f4269cd9e95e6f15efb03bbc06d80b1 Mon Sep 17 00:00:00 2001 From: John Rowley <hey@johnrowley.me> Date: Wed, 13 Jan 2021 21:55:35 +0100 Subject: [PATCH] newsboat: update to 2.22.1. --- srcpkgs/newsboat/template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template index e0ebdeeea50..d9fc235194c 100644 --- a/srcpkgs/newsboat/template +++ b/srcpkgs/newsboat/template @@ -1,6 +1,6 @@ # Template file for 'newsboat' pkgname=newsboat -version=2.21 +version=2.22.1 revision=1 build_style=configure build_helper="rust" @@ -16,7 +16,7 @@ license="MIT" homepage="https://newsboat.org/" changelog="https://raw.githubusercontent.com/newsboat/newsboat/master/CHANGELOG.md" distfiles="https://newsboat.org/releases/${version}/newsboat-${version}.tar.xz" -checksum=0c46b3dd46bb578dd6dd4915db4cfdffb4352ab258f251080ad14655c75a9c31 +checksum=8920f41cc53776b67c0e85ad1696b0967f6ac248f3b8913d977942c15d75e690 do_check() { make test
[-- Attachment #1: Type: text/plain, Size: 436 bytes --] New comment by Minoru on void-packages repository https://github.com/void-linux/void-packages/pull/27902#issuecomment-759750365 Comment: Hi, Newsboat maintainer again :wave: Please see https://github.com/tibequadorian/void-packages/pull/5#issuecomment-758023098 and https://github.com/tibequadorian/void-packages/pull/5#issuecomment-758023098 (someone else was preparing a PR with an update, and I ended up commenting in their fork).
[-- Attachment #1: Type: text/plain, Size: 800 bytes --] New comment by subsonik on void-packages repository https://github.com/void-linux/void-packages/pull/27902#issuecomment-759765730 Comment: Thanks for the input @Minoru :) I've ran the test suite on my machine using an x86_64 chroot and everything passed as an unprivileged user. The x86_64-musl tests fail, as previously noted, but I can confirm that the app itself is working fine on my machine (x86_64-musl). I'm inexperienced with Void packaging/Travis, unfortunately, so I'm not sure if I can get the tests to run on Travis as an unprivileged user. I think someone more knowledgeable will need to weigh in here, but in my opinion, besides the musl test failures and Travis running the test suite as a privileged user, this update is good to go. Maybe the test phase should be skipped?
[-- Attachment #1: Type: text/plain, Size: 276 bytes --] New comment by ericonr on void-packages repository https://github.com/void-linux/void-packages/pull/27902#issuecomment-763236473 Comment: @tibequadorian do you think the changes from `post_patch` in https://github.com/tibequadorian/void-packages/pull/5/files are necessary?
[-- Attachment #1: Type: text/plain, Size: 735 bytes --] New comment by tibequadorian on void-packages repository https://github.com/void-linux/void-packages/pull/27902#issuecomment-763276139 Comment: > @tibequadorian do you think the changes from `post_patch` in https://github.com/tibequadorian/void-packages/pull/5/files are necessary? On @Minoru suggestion in https://github.com/tibequadorian/void-packages/pull/5#discussion_r555127025 I set `make_check_target=ci-check` and removed current `do_check` from the template. This fails with "Error opening terminal: unknown." However the `ci-check` target in the Makefile looks quite similar to what was in the `do_check` function, so I kinda merged the idea in `post_patch()` and checks were indeed successful, but the CI still fails.
[-- Attachment #1: Type: text/plain, Size: 733 bytes --] New comment by tibequadorian on void-packages repository https://github.com/void-linux/void-packages/pull/27902#issuecomment-763276139 Comment: > @tibequadorian do you think the changes from `post_patch` in https://github.com/tibequadorian/void-packages/pull/5/files are necessary? On @Minoru suggestion in https://github.com/tibequadorian/void-packages/pull/5#discussion_r555127025 I set `make_check_target=ci-check` and removed current `do_check` from the template. This fails with "Error opening terminal: unknown." However the `ci-check` target in the Makefile looks quite similar to what was in the `do_check` function, so I kinda merged the idea in `post_patch` and checks were indeed successful, but the CI still fails.
[-- Attachment #1: Type: text/plain, Size: 747 bytes --] New comment by tibequadorian on void-packages repository https://github.com/void-linux/void-packages/pull/27902#issuecomment-763276139 Comment: > @tibequadorian do you think the changes from `post_patch` in https://github.com/tibequadorian/void-packages/pull/5/files are necessary? On @Minoru suggestion in https://github.com/tibequadorian/void-packages/pull/5#discussion_r555127025 I set `make_check_target=ci-check` and removed current `do_check` from the template. This fails with "Error opening terminal: unknown." However the `ci-check` target in the Makefile looks quite similar to what was in the `do_check` function, so I kinda merged the idea in `post_patch` and checks were indeed successful on my machine, but the CI still fails.
[-- Attachment #1: Type: text/plain, Size: 755 bytes --] New comment by tibequadorian on void-packages repository https://github.com/void-linux/void-packages/pull/27902#issuecomment-763276139 Comment: > @tibequadorian do you think the changes from `post_patch` in https://github.com/tibequadorian/void-packages/pull/5/files are necessary? On @Minoru suggestion in https://github.com/tibequadorian/void-packages/pull/5#discussion_r555127025 I set `make_check_target=ci-check` and removed current `do_check` from the template. This fails with "Error opening terminal: unknown." However parts of the `ci-check` target in the Makefile look quite similar to what was in the `do_check` function, so I kinda merged the idea in `post_patch` and checks were indeed successful on my machine, but the CI still fails.
[-- Attachment #1: Type: text/plain, Size: 1789 bytes --] There is a new pull request by tibequadorian against master on the void-packages repository https://github.com/tibequadorian/void-packages newsboat https://github.com/void-linux/void-packages/pull/28801 newsboat: update to 2.22.1. <!-- Mark items with [x] where applicable --> #### General - [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements) #### Have the results of the proposed changes been tested? - [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me - [ ] I generally don't use the affected packages but briefly tested this PR Tests fail on CI because they're run as superuser. I ran them locally and it worked fine. Changed check target to `ci-check` which was introduced in 2.22 to run C++ *and* Rust tests. <!-- If GitHub CI cannot be used to validate the build result (for example, if the build is likely to take several hours), make sure to [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration). When skipping CI, uncomment and fill out the following section. Note: for builds that are likely to complete in less than 2 hours, it is not acceptable to skip CI. --> <!-- #### Does it build and run successfully? (Please choose at least one native build and, if supported, at least one cross build. More are better.) - [ ] I built this PR locally for my native architecture, (ARCH-LIBC) - [ ] I built this PR locally for these architectures (if supported. mark crossbuilds): - [ ] aarch64-musl - [ ] armv7l - [ ] armv6l-musl --> A patch file from https://github.com/void-linux/void-packages/pull/28801.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-newsboat-28801.patch --] [-- Type: text/x-diff, Size: 1505 bytes --] From bfaf78e1667ea4f5446b7905edaf40ec086636d4 Mon Sep 17 00:00:00 2001 From: tibequadorian <tibequadorian@posteo.de> Date: Mon, 11 Jan 2021 12:08:45 +0100 Subject: [PATCH] newsboat: update to 2.22.1. --- srcpkgs/newsboat/template | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template index e0ebdeeea50..930285d6e28 100644 --- a/srcpkgs/newsboat/template +++ b/srcpkgs/newsboat/template @@ -1,11 +1,12 @@ # Template file for 'newsboat' pkgname=newsboat -version=2.21 +version=2.22.1 revision=1 build_style=configure build_helper="rust" configure_script="./config.sh" make_install_args="prefix=/usr" +make_check_target="ci-check" hostmakedepends="ruby-asciidoctor pkg-config cargo git gettext" makedepends="json-c-devel libcurl-devel libxml2-devel sqlite-devel stfl-devel rust-std" @@ -16,11 +17,13 @@ license="MIT" homepage="https://newsboat.org/" changelog="https://raw.githubusercontent.com/newsboat/newsboat/master/CHANGELOG.md" distfiles="https://newsboat.org/releases/${version}/newsboat-${version}.tar.xz" -checksum=0c46b3dd46bb578dd6dd4915db4cfdffb4352ab258f251080ad14655c75a9c31 +checksum=8920f41cc53776b67c0e85ad1696b0967f6ac248f3b8913d977942c15d75e690 -do_check() { - make test - (cd test && TERM=$TERM TMPDIR=/dev/shm ./test) +# tests fail when run by superuser +make_check=extended + +post_patch() { + vsed -i Makefile -e "s|\./test|TERM=$TERM TMPDIR=/dev/shm \./test|g" } post_install() {
[-- Attachment #1: Type: text/plain, Size: 161 bytes --] There's a closed pull request on the void-packages repository newsboat: update to 2.22.1. https://github.com/void-linux/void-packages/pull/27902 Description: