From: vixus0 <vixus0@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] github-cli: fix setting build version and date
Date: Mon, 18 Jan 2021 14:26:46 +0100 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28011@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1563 bytes --]
There is a new pull request by vixus0 against master on the void-packages repository
https://github.com/vixus0/void-packages fix-github-cli-version
https://github.com/void-linux/void-packages/pull/28011
github-cli: fix setting build version and date
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to include "[ci skip]' in
either the PR title or this description. When skipping CI, uncomment and complete
the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
[ci skip]
-->
A patch file from https://github.com/void-linux/void-packages/pull/28011.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-github-cli-version-28011.patch --]
[-- Type: text/x-diff, Size: 1139 bytes --]
From 26ba8a6e13cb04a2c0ecd1ff5625a7908554badc Mon Sep 17 00:00:00 2001
From: Anshul Sirur <anshul@vixus0.dev>
Date: Mon, 18 Jan 2021 14:24:52 +0100
Subject: [PATCH] github-cli: fix setting build version and date
---
srcpkgs/github-cli/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/github-cli/template b/srcpkgs/github-cli/template
index e65f708957e..1f2bf7af608 100644
--- a/srcpkgs/github-cli/template
+++ b/srcpkgs/github-cli/template
@@ -6,7 +6,7 @@ wrksrc="cli-${version}"
build_style=go
build_helper=qemu
go_import_path="github.com/cli/cli/cmd/gh"
-go_ldflags="-X github.com/cli/cli/command.Version=v${version}"
+go_ldflags="-X github.com/cli/cli/internal/build.Version=v${version}"
short_desc="GitHub CLI tool"
maintainer="shizonic <realtiaz@gmail.com>"
license="MIT"
@@ -19,7 +19,7 @@ pre_build() {
local _date
if [ "$SOURCE_DATE_EPOCH" ]; then
_date="$(date --utc --date "@$SOURCE_DATE_EPOCH" "+%Y-%m-%d")"
- go_ldflags="$go_ldflags -X github.com/cli/cli/command.BuildDate=${_date}"
+ go_ldflags="$go_ldflags -X github.com/cli/cli/internal/build.Date=${_date}"
fi
}
next reply other threads:[~2021-01-18 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 13:26 vixus0 [this message]
2021-01-18 13:52 ` ericonr
2021-01-19 12:43 ` vixus0
2021-01-19 12:46 ` [PR PATCH] [Updated] " vixus0
2021-01-19 13:31 ` ericonr
2021-01-19 13:31 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28011@inbox.vuxu.org \
--to=vixus0@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).