Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Add new package walk
@ 2021-01-27 21:10 anddam
  2021-01-27 21:14 ` [PR PATCH] [Updated] " anddam
                   ` (24 more replies)
  0 siblings, 25 replies; 26+ messages in thread
From: anddam @ 2021-01-27 21:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

There is a new pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature-new-package-walk
https://github.com/void-linux/void-packages/pull/28273

Add new package walk
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28273.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature-new-package-walk-28273.patch --]
[-- Type: text/x-diff, Size: 1154 bytes --]

From 31ef100bd88f85d7ae39a4ef68df4a4b1071cc8c Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH] Add new package walk

---
 srcpkgs/walk/template | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 00000000000..0426104c230
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,26 @@
+# Template file for 'walk'
+pkgname=walk
+version=20190920
+revision=1
+_commit=70f7a8c104acf109ae810a9b34eb8e8b92b4d27d
+build_style="gnu-makefile"
+wrksrc="${pkgname}-${_commit}"
+short_desc="walk and sor utility, collectively replacing find"
+maintainer="orphaned"
+license="Apache-2.0"
+homepage="https://github.com/google/walk"
+distfiles="https://github.com/google/walk/archive/${_commit}.tar.gz"
+checksum=fce16683d757605a11284586794627a4352ec62718c59093a02f56b39896a1cd
+
+do_build() {
+    make
+}
+
+do_install() {
+    vinstall sor 0755 usr/bin/
+    vinstall walk 0755 usr/bin/
+    vman sor.1
+    vman walk.1
+    vdoc README.md
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
@ 2021-01-27 21:14 ` anddam
  2021-01-27 21:15 ` [PR REVIEW] " abenson
                   ` (23 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: anddam @ 2021-01-27 21:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]

There is an updated pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature-new-package-walk
https://github.com/void-linux/void-packages/pull/28273

Add new package walk
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28273.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature-new-package-walk-28273.patch --]
[-- Type: text/x-diff, Size: 1705 bytes --]

From 31ef100bd88f85d7ae39a4ef68df4a4b1071cc8c Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH 1/2] Add new package walk

---
 srcpkgs/walk/template | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 00000000000..0426104c230
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,26 @@
+# Template file for 'walk'
+pkgname=walk
+version=20190920
+revision=1
+_commit=70f7a8c104acf109ae810a9b34eb8e8b92b4d27d
+build_style="gnu-makefile"
+wrksrc="${pkgname}-${_commit}"
+short_desc="walk and sor utility, collectively replacing find"
+maintainer="orphaned"
+license="Apache-2.0"
+homepage="https://github.com/google/walk"
+distfiles="https://github.com/google/walk/archive/${_commit}.tar.gz"
+checksum=fce16683d757605a11284586794627a4352ec62718c59093a02f56b39896a1cd
+
+do_build() {
+    make
+}
+
+do_install() {
+    vinstall sor 0755 usr/bin/
+    vinstall walk 0755 usr/bin/
+    vman sor.1
+    vman walk.1
+    vdoc README.md
+	vlicense LICENSE
+}

From 75301a791352a014669d84e207b6f1646585f595 Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Wed, 27 Jan 2021 22:13:07 +0100
Subject: [PATCH 2/2] Avoid installing license file per travis linting in CI

---
 srcpkgs/walk/template | 1 -
 1 file changed, 1 deletion(-)

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
index 0426104c230..a005372d047 100644
--- a/srcpkgs/walk/template
+++ b/srcpkgs/walk/template
@@ -22,5 +22,4 @@ do_install() {
     vman sor.1
     vman walk.1
     vdoc README.md
-	vlicense LICENSE
 }

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
  2021-01-27 21:14 ` [PR PATCH] [Updated] " anddam
@ 2021-01-27 21:15 ` abenson
  2021-01-27 21:15 ` abenson
                   ` (22 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: abenson @ 2021-01-27 21:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#discussion_r565637964

Comment:
Why is this already orphaned?

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
  2021-01-27 21:14 ` [PR PATCH] [Updated] " anddam
  2021-01-27 21:15 ` [PR REVIEW] " abenson
@ 2021-01-27 21:15 ` abenson
  2021-01-27 21:15 ` abenson
                   ` (21 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: abenson @ 2021-01-27 21:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#discussion_r565638083

Comment:
Capitalize the beginning.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (2 preceding siblings ...)
  2021-01-27 21:15 ` abenson
@ 2021-01-27 21:15 ` abenson
  2021-01-27 21:16 ` abenson
                   ` (20 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: abenson @ 2021-01-27 21:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#discussion_r565638328

Comment:
`vbin`?

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (3 preceding siblings ...)
  2021-01-27 21:15 ` abenson
@ 2021-01-27 21:16 ` abenson
  2021-01-27 21:17 ` abenson
                   ` (19 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: abenson @ 2021-01-27 21:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#discussion_r565638911

Comment:
Is there an issue with the `do_build` provided by `build_style=gnu-makefile` 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (4 preceding siblings ...)
  2021-01-27 21:16 ` abenson
@ 2021-01-27 21:17 ` abenson
  2021-01-27 21:27 ` [PR PATCH] [Updated] " anddam
                   ` (18 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: abenson @ 2021-01-27 21:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#discussion_r565640000

Comment:
Consider opening an issue upstream to periodically tag actual releases?

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (5 preceding siblings ...)
  2021-01-27 21:17 ` abenson
@ 2021-01-27 21:27 ` anddam
  2021-01-27 21:27 ` [PR REVIEW] " anddam
                   ` (17 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: anddam @ 2021-01-27 21:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]

There is an updated pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature-new-package-walk
https://github.com/void-linux/void-packages/pull/28273

Add new package walk
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28273.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature-new-package-walk-28273.patch --]
[-- Type: text/x-diff, Size: 1187 bytes --]

From 0ee693d196374966b51d110e913d902e83c28427 Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH] Add new package walk

Avoid installing license file per travis linting in CI

walk: lint template
---
 srcpkgs/walk/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 00000000000..f30a404d91f
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,25 @@
+# Template file for 'walk'
+pkgname=walk
+version=20190920
+revision=1
+_commit=70f7a8c104acf109ae810a9b34eb8e8b92b4d27d
+wrksrc="${pkgname}-${_commit}"
+build_style="gnu-makefile"
+short_desc="Two utilities collectively replacing find: walk and sor"
+maintainer="Orphaned <orphaned@voidlinux.org>"
+license="Apache-2.0"
+homepage="https://github.com/google/walk"
+distfiles="https://github.com/google/walk/archive/${_commit}.tar.gz"
+checksum=fce16683d757605a11284586794627a4352ec62718c59093a02f56b39896a1cd
+
+do_build() {
+	make
+}
+
+do_install() {
+	vbin sor
+	vbin walk
+	vman sor.1
+	vman walk.1
+	vdoc README.md
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (6 preceding siblings ...)
  2021-01-27 21:27 ` [PR PATCH] [Updated] " anddam
@ 2021-01-27 21:27 ` anddam
  2021-01-27 21:28 ` anddam
                   ` (16 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: anddam @ 2021-01-27 21:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by anddam on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#discussion_r565646154

Comment:
Do you want maintainership?

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (7 preceding siblings ...)
  2021-01-27 21:27 ` [PR REVIEW] " anddam
@ 2021-01-27 21:28 ` anddam
  2021-01-27 21:29 ` anddam
                   ` (15 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: anddam @ 2021-01-27 21:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by anddam on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#discussion_r565646538

Comment:
 Rephrased since the tool name is lower case

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (8 preceding siblings ...)
  2021-01-27 21:28 ` anddam
@ 2021-01-27 21:29 ` anddam
  2021-01-27 21:34 ` abenson
                   ` (14 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: anddam @ 2021-01-27 21:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New review comment by anddam on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#discussion_r565646758

Comment:
Done, I had not run xlint at all before.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (9 preceding siblings ...)
  2021-01-27 21:29 ` anddam
@ 2021-01-27 21:34 ` abenson
  2021-01-27 21:38 ` abenson
                   ` (13 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: abenson @ 2021-01-27 21:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#discussion_r565649827

Comment:
Generally if you make the PR to add it, you be willing to maintain it.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (10 preceding siblings ...)
  2021-01-27 21:34 ` abenson
@ 2021-01-27 21:38 ` abenson
  2021-01-27 21:40 ` [PR REVIEW] " anddam
                   ` (12 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: abenson @ 2021-01-27 21:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#issuecomment-768593820

Comment:
The commit message should also follow the convention of "New package: walk-20190920"

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (11 preceding siblings ...)
  2021-01-27 21:38 ` abenson
@ 2021-01-27 21:40 ` anddam
  2021-01-27 21:40 ` anddam
                   ` (11 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: anddam @ 2021-01-27 21:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New review comment by anddam on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#discussion_r565653122

Comment:
Only that I did not know about it.


^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (12 preceding siblings ...)
  2021-01-27 21:40 ` [PR REVIEW] " anddam
@ 2021-01-27 21:40 ` anddam
  2021-01-27 21:42 ` [PR PATCH] [Updated] " anddam
                   ` (10 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: anddam @ 2021-01-27 21:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New comment by anddam on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#issuecomment-768595092

Comment:
> The commit message should also follow the convention of "New package: walk-20190920"

Duly noted, just found the relevant part in `CONTRIBUTING.md`.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (13 preceding siblings ...)
  2021-01-27 21:40 ` anddam
@ 2021-01-27 21:42 ` anddam
  2021-01-27 21:45 ` anddam
                   ` (9 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: anddam @ 2021-01-27 21:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]

There is an updated pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature-new-package-walk
https://github.com/void-linux/void-packages/pull/28273

Add new package walk
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28273.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature-new-package-walk-28273.patch --]
[-- Type: text/x-diff, Size: 1119 bytes --]

From 83e11313af31da138837d2ce400d8aa75766db6a Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH] New package: walk-20190920

---
 srcpkgs/walk/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 000000000000..f30a404d91f7
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,25 @@
+# Template file for 'walk'
+pkgname=walk
+version=20190920
+revision=1
+_commit=70f7a8c104acf109ae810a9b34eb8e8b92b4d27d
+wrksrc="${pkgname}-${_commit}"
+build_style="gnu-makefile"
+short_desc="Two utilities collectively replacing find: walk and sor"
+maintainer="Orphaned <orphaned@voidlinux.org>"
+license="Apache-2.0"
+homepage="https://github.com/google/walk"
+distfiles="https://github.com/google/walk/archive/${_commit}.tar.gz"
+checksum=fce16683d757605a11284586794627a4352ec62718c59093a02f56b39896a1cd
+
+do_build() {
+	make
+}
+
+do_install() {
+	vbin sor
+	vbin walk
+	vman sor.1
+	vman walk.1
+	vdoc README.md
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (14 preceding siblings ...)
  2021-01-27 21:42 ` [PR PATCH] [Updated] " anddam
@ 2021-01-27 21:45 ` anddam
  2021-01-27 21:46 ` [PR REVIEW] " anddam
                   ` (8 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: anddam @ 2021-01-27 21:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]

There is an updated pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature-new-package-walk
https://github.com/void-linux/void-packages/pull/28273

Add new package walk
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28273.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature-new-package-walk-28273.patch --]
[-- Type: text/x-diff, Size: 1087 bytes --]

From ffdd27ff8433e8215f24bb2a4ee22f307aca48ab Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH] New package: walk-20190920

---
 srcpkgs/walk/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 00000000000..d5017d68535
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,21 @@
+# Template file for 'walk'
+pkgname=walk
+version=20190920
+revision=1
+_commit=70f7a8c104acf109ae810a9b34eb8e8b92b4d27d
+wrksrc="${pkgname}-${_commit}"
+build_style="gnu-makefile"
+short_desc="Two utilities collectively replacing find: walk and sor"
+maintainer="Orphaned <orphaned@voidlinux.org>"
+license="Apache-2.0"
+homepage="https://github.com/google/walk"
+distfiles="https://github.com/google/walk/archive/${_commit}.tar.gz"
+checksum=fce16683d757605a11284586794627a4352ec62718c59093a02f56b39896a1cd
+
+do_install() {
+	vbin sor
+	vbin walk
+	vman sor.1
+	vman walk.1
+	vdoc README.md
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (15 preceding siblings ...)
  2021-01-27 21:45 ` anddam
@ 2021-01-27 21:46 ` anddam
  2021-01-27 22:06 ` ericonr
                   ` (7 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: anddam @ 2021-01-27 21:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

New review comment by anddam on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#discussion_r565653122

Comment:
~~Only that I did not know about it.~~

I misunderstood what you said, I tested with default `do_build` from `gnu-makefile` and removed the override.


^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (16 preceding siblings ...)
  2021-01-27 21:46 ` [PR REVIEW] " anddam
@ 2021-01-27 22:06 ` ericonr
  2021-01-27 22:07 ` ericonr
                   ` (6 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ericonr @ 2021-01-27 22:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#discussion_r565670015

Comment:
This is not the correct mail.

And given that this is a rather niche package, it should have a maintainer in order to be accepted.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (17 preceding siblings ...)
  2021-01-27 22:06 ` ericonr
@ 2021-01-27 22:07 ` ericonr
  2021-01-27 22:13 ` [PR PATCH] [Updated] " anddam
                   ` (5 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ericonr @ 2021-01-27 22:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#discussion_r565670795

Comment:
Upstream seemst to not have moved since 2019... Unless this is widely requested or similar, I don't fancy accepting something that doesn't have any official releases.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (18 preceding siblings ...)
  2021-01-27 22:07 ` ericonr
@ 2021-01-27 22:13 ` anddam
  2021-02-15 23:56 ` anddam
                   ` (4 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: anddam @ 2021-01-27 22:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]

There is an updated pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature-new-package-walk
https://github.com/void-linux/void-packages/pull/28273

Add new package walk
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28273.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature-new-package-walk-28273.patch --]
[-- Type: text/x-diff, Size: 1085 bytes --]

From f9290b5fbcdd15fc2d42f74d9dd58bdd41761ec4 Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH] New package: walk-20190920

---
 srcpkgs/walk/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 00000000000..649c8de3577
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,21 @@
+# Template file for 'walk'
+pkgname=walk
+version=20190920
+revision=1
+_commit=70f7a8c104acf109ae810a9b34eb8e8b92b4d27d
+wrksrc="${pkgname}-${_commit}"
+build_style="gnu-makefile"
+short_desc="Two utilities collectively replacing find: walk and sor"
+maintainer="Orphaned <orphan@voidlinux.org>"
+license="Apache-2.0"
+homepage="https://github.com/google/walk"
+distfiles="https://github.com/google/walk/archive/${_commit}.tar.gz"
+checksum=fce16683d757605a11284586794627a4352ec62718c59093a02f56b39896a1cd
+
+do_install() {
+	vbin sor
+	vbin walk
+	vman sor.1
+	vman walk.1
+	vdoc README.md
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (19 preceding siblings ...)
  2021-01-27 22:13 ` [PR PATCH] [Updated] " anddam
@ 2021-02-15 23:56 ` anddam
  2021-02-15 23:58 ` [PR REVIEW] " anddam
                   ` (3 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: anddam @ 2021-02-15 23:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]

There is an updated pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature-new-package-walk
https://github.com/void-linux/void-packages/pull/28273

Add new package walk
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28273.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature-new-package-walk-28273.patch --]
[-- Type: text/x-diff, Size: 1081 bytes --]

From a5744f92423051310b80a4011a5ba43c8ffd7044 Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH] New package: walk-20190920

---
 srcpkgs/walk/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 00000000000..3451672f2b5
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,21 @@
+# Template file for 'walk'
+pkgname=walk
+version=20190920
+revision=1
+_commit=70f7a8c104acf109ae810a9b34eb8e8b92b4d27d
+wrksrc="${pkgname}-${_commit}"
+build_style="gnu-makefile"
+short_desc="Two utilities collectively replacing find: walk and sor"
+maintainer="Andrea D'Amore <a@d-amo.re>"
+license="Apache-2.0"
+homepage="https://github.com/google/walk"
+distfiles="https://github.com/google/walk/archive/${_commit}.tar.gz"
+checksum=fce16683d757605a11284586794627a4352ec62718c59093a02f56b39896a1cd
+
+do_install() {
+	vbin sor
+	vbin walk
+	vman sor.1
+	vman walk.1
+	vdoc README.md
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (20 preceding siblings ...)
  2021-02-15 23:56 ` anddam
@ 2021-02-15 23:58 ` anddam
  2021-02-15 23:58 ` anddam
                   ` (2 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: anddam @ 2021-02-15 23:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by anddam on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#discussion_r576475499

Comment:
I asked for that in https://github.com/google/walk/issues/3

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (21 preceding siblings ...)
  2021-02-15 23:58 ` [PR REVIEW] " anddam
@ 2021-02-15 23:58 ` anddam
  2022-05-02  2:16 ` github-actions
  2022-05-17  2:14 ` [PR PATCH] [Closed]: " github-actions
  24 siblings, 0 replies; 26+ messages in thread
From: anddam @ 2021-02-15 23:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New review comment by anddam on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#discussion_r576475511

Comment:
I took maintainership.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (22 preceding siblings ...)
  2021-02-15 23:58 ` anddam
@ 2022-05-02  2:16 ` github-actions
  2022-05-17  2:14 ` [PR PATCH] [Closed]: " github-actions
  24 siblings, 0 replies; 26+ messages in thread
From: github-actions @ 2022-05-02  2:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/28273#issuecomment-1114433427

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Closed]: Add new package walk
  2021-01-27 21:10 [PR PATCH] Add new package walk anddam
                   ` (23 preceding siblings ...)
  2022-05-02  2:16 ` github-actions
@ 2022-05-17  2:14 ` github-actions
  24 siblings, 0 replies; 26+ messages in thread
From: github-actions @ 2022-05-17  2:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]

There's a closed pull request on the void-packages repository

Add new package walk
https://github.com/void-linux/void-packages/pull/28273

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 26+ messages in thread

end of thread, other threads:[~2022-05-17  2:14 UTC | newest]

Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-27 21:10 [PR PATCH] Add new package walk anddam
2021-01-27 21:14 ` [PR PATCH] [Updated] " anddam
2021-01-27 21:15 ` [PR REVIEW] " abenson
2021-01-27 21:15 ` abenson
2021-01-27 21:15 ` abenson
2021-01-27 21:16 ` abenson
2021-01-27 21:17 ` abenson
2021-01-27 21:27 ` [PR PATCH] [Updated] " anddam
2021-01-27 21:27 ` [PR REVIEW] " anddam
2021-01-27 21:28 ` anddam
2021-01-27 21:29 ` anddam
2021-01-27 21:34 ` abenson
2021-01-27 21:38 ` abenson
2021-01-27 21:40 ` [PR REVIEW] " anddam
2021-01-27 21:40 ` anddam
2021-01-27 21:42 ` [PR PATCH] [Updated] " anddam
2021-01-27 21:45 ` anddam
2021-01-27 21:46 ` [PR REVIEW] " anddam
2021-01-27 22:06 ` ericonr
2021-01-27 22:07 ` ericonr
2021-01-27 22:13 ` [PR PATCH] [Updated] " anddam
2021-02-15 23:56 ` anddam
2021-02-15 23:58 ` [PR REVIEW] " anddam
2021-02-15 23:58 ` anddam
2022-05-02  2:16 ` github-actions
2022-05-17  2:14 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).