From 46a16e0a8fe4fe4f321fa18eeb7f241645527b5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89rico=20Rolim?= Date: Fri, 29 Jan 2021 21:47:18 -0300 Subject: [PATCH 1/2] xbps-src: add -K option to getopt string. Was forgotten when the actual option was added. --- xbps-src | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xbps-src b/xbps-src index 77969af84a1..c9219386916 100755 --- a/xbps-src +++ b/xbps-src @@ -354,7 +354,7 @@ readonly XBPS_SRC_VERSION="113" export XBPS_MACHINE=$(xbps-uhelper -C /dev/null arch) XBPS_OPTIONS= -XBPS_OPTSTRING="1a:c:CEfgGhH:iIj:Lm:No:p:qQr:tV" +XBPS_OPTSTRING="1a:c:CEfgGhH:iIj:Lm:No:p:qQKr:tV" # Preprocess arguments in order to allow options before and after XBPS_TARGET. eval set -- $(getopt "$XBPS_OPTSTRING" "$@"); From ff30aea9a6d2d421739febe053a79e95b523fab3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89rico=20Rolim?= Date: Fri, 29 Jan 2021 21:47:59 -0300 Subject: [PATCH 2/2] xbps-src/libexec: add more make_check option. Allows a template to define in which circumstances its do_check phase should run, without requiring custom do_check definitions in each template (also makes it easier to change things in how build styles do things without checking as many templates). Add to Manual as well. --- Manual.md | 5 +++++ common/xbps-src/libexec/xbps-src-docheck.sh | 11 +++++++++++ 2 files changed, 16 insertions(+) diff --git a/Manual.md b/Manual.md index ed73ec338fa..e7c1f28db67 100644 --- a/Manual.md +++ b/Manual.md @@ -589,6 +589,11 @@ patches to the package sources during `do_patch()`. Patches are stored in - `disable_parallel_build` If set the package won't be built in parallel and `XBPS_MAKEJOBS` has no effect. +- `make_check` Sets the cases in which the `check` phase is run. Can be `yes` (the default) to run if +`XBPS_CHECK_PKGS` is set, `extended` to run if `XBPS_CHECK_PKGS` is `full` and `no` to never run. +This option should usually be accompanied by a comment explaining why it was set, especially when +set to `no`. + - `keep_libtool_archives` If enabled the `GNU Libtool` archives won't be removed. By default those files are always removed automatically. diff --git a/common/xbps-src/libexec/xbps-src-docheck.sh b/common/xbps-src/libexec/xbps-src-docheck.sh index 6be6c9d6ead..1cb9f6ab13a 100755 --- a/common/xbps-src/libexec/xbps-src-docheck.sh +++ b/common/xbps-src/libexec/xbps-src-docheck.sh @@ -32,6 +32,17 @@ if [ -z "$XBPS_CHECK_PKGS" ]; then exit 0 fi +if [ "$make_check" = no ]; then + msg_normal "${pkgname}-${version}_${revision}: skipping check (make_check=no) ...\n" + exit 0 +fi + +if [ "$make_check" = extended -a "$XBPS_CHECK_PKGS" != full ]; then + msg_normal \ + "${pkgname}-${version}_${revision}: skipping check (make_check=extended and XBPS_CHECK_PKGS is not 'full') ...\n" + exit 0 +fi + for f in $XBPS_COMMONDIR/environment/check/*.sh; do source_file "$f" done